On Fri, 18 Aug 2006 17:41:26 +0200 Thomas Klein <[EMAIL PROTECTED]> wrote:
> Hi Alexey, > > first of all thanks a lot for the extensive review. > > > Alexey Dobriyan wrote: > >> + u64 hret = H_HARDWARE; > > > > Useless assignment here and everywhere. > > > > Initializing returncodes to errorstate is a cheap way to prevent > accidentally returning (uninitalized) success returncodes which > can lead to catastrophic misbehaviour. That is old thinking. Current compilers do live/dead analysis and tell you about this at compile time which is better than relying on default behavior at runtime. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html