From: Andi Kleen <[EMAIL PROTECTED]>
Date: Fri, 18 Aug 2006 20:17:18 +0200

> 
> > @@ -1136,7 +1137,8 @@ int tcp_recvmsg(struct kiocb *iocb, stru
> >     skb = skb_peek_tail(&sk->sk_receive_queue);
> >     if (skb)
> >             available = TCP_SKB_CB(skb)->seq + skb->len - (*seq);
> > -   if ((available < target) &&
> > +   dst = __sk_dst_get(sk);
> > +   if ((available < target) && (!dst || (dst->dev != &loopback_dev)) &&
> 
> You just added another potential cache miss to a critical
> path. A bit flag in the socket would be better.
> 
> But is it really worth this ugly special case?

I think it isn't.  It is really gross.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to