Re: [PATCH] pcmcia: hostap_cs.c - 0xc00f,0x0000 conflicts with pcnet_cs

2006-06-30 Thread John W. Linville
On Fri, Jun 30, 2006 at 08:34:04PM -0400, Jeff Garzik wrote: > Linux Kernel Mailing List wrote: > >commit fd99ddd0701385344eadaf2daa6abbc5fb086750 > >tree 013d75048f086edfa7a89ac3f3301dde13017817 > >parent 0db6095d4ff8918350797dfe299d572980e82fa0 > >author Komuro <[EMAIL PROTECTED]> Mon, 17 Apr 200

RE: [PATCH 2.6.17] support for TSO over IPv6

2006-06-30 Thread Leonid Grossman
Thanks Herbert! We'll fix this. Leonid > -Original Message- > From: Herbert Xu [mailto:[EMAIL PROTECTED] > Sent: Friday, June 30, 2006 8:38 PM > To: Leonid Grossman > Cc: Ananda Raju; netdev@vger.kernel.org; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; Ravinandan Arakali; > [EMAIL PROTECTE

Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats

2006-06-30 Thread Andrew Morton
On Fri, 30 Jun 2006 23:37:10 -0400 Shailabh Nagar <[EMAIL PROTECTED]> wrote: > >Set aside the implementation details and ask "what is a good design"? > > > >A kernel-wide constant, whether determined at build-time or by a /proc poke > >isn't a nice design. > > > >Can we permit userspace to send in

Re: [PATCH 2.6.17] support for TSO over IPv6

2006-06-30 Thread Herbert Xu
Hi Leonid: On Fri, Jun 30, 2006 at 04:46:56PM -0400, Leonid Grossman wrote: > > If ECE == 1, then set it to one for all datagrams. > If CWR == 1, then set it to one for the first datagram, and set it to > zero for the rest? Exactly. Cheers, -- Visit Openswan at http://www.openswan.org/ Email:

Re: [PATCH] NET: Fix ipv6 GSO payload length

2006-06-30 Thread Herbert Xu
On Fri, Jun 30, 2006 at 03:56:47PM -0700, Michael Chan wrote: > Fix ipv6 GSO payload length calculation. > > The ipv6 payload length excludes the ipv6 base header length and so > must be subtracted. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Looks good to me. Thanks for cathcing this!

Re: [1/4] [IPV6]: Remove redundant length check on input

2006-06-30 Thread Herbert Xu
On Fri, Jun 30, 2006 at 07:44:49PM -0400, Ananda Raju wrote: > > I tested the patch, and TSO over ipv6 is working fine. But TSO disable > not working for IPv6. > > I tried the from tree /pub/scm/linux/kernel/git/davem/net-2.6 I think we need some new ethtool helper functions that sets/clears bo

Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats

2006-06-30 Thread Shailabh Nagar
Andrew Morton wrote: On Fri, 30 Jun 2006 22:20:23 -0400 Shailabh Nagar <[EMAIL PROTECTED]> wrote: If we're going to abuse nl_pid then how about we design things so that nl_pid is treated as two 16-bit words - one word is the start CPU and the other word is the end cpu? Or, if a 65536-CPU l

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread jamal
On Sat, 2006-01-07 at 01:45 +0200, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2006-06-30 17:31 > > Better to explain the reason for ifb first: > > ifb exists initially as a replacement for IMQ. > > 1) qdiscs/policies that are per device as opposed to system wide. > > This now allows for shar

Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats

2006-06-30 Thread Andrew Morton
On Fri, 30 Jun 2006 22:20:23 -0400 Shailabh Nagar <[EMAIL PROTECTED]> wrote: > >If we're going to abuse nl_pid then how about we design things so that > >nl_pid is treated as two 16-bit words - one word is the start CPU and the > >other word is the end cpu? > > > >Or, if a 65536-CPU limit is too s

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Patrick McHardy
jamal wrote: > On Fri, 2006-30-06 at 19:33 +0200, Patrick McHardy wrote: > >>Well, I thought I stay out of this, but since you mention me .. >> > I think you will add value to the discussion ;-> > Regardless, we need to settle these kind of issues so we can work better > together. A while back i s

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread jamal
On Sat, 2006-01-07 at 01:22 +0200, Thomas Graf wrote: > This is boring, I reversed everything to not change any semantics and > you still complain. > You reversed a bug that you had introduced. Do you want me to review this patch or not now? Be a little reasonable please. > * jamal <[EMAIL PROTE

Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats

2006-06-30 Thread Shailabh Nagar
Andrew Morton wrote: Shailabh Nagar <[EMAIL PROTECTED]> wrote: +/* + * Per-task exit data sent from the kernel to user space + * is tagged by an id based on grouping of cpus. + * + * If userspace specifies a non-zero P as the nl_pid field of + * the sockaddr_nl structure while binding to a n

Re: [patch 2/6] [Network namespace] Network device sharing by view

2006-06-30 Thread Eric W. Biederman
jamal <[EMAIL PROTECTED]> writes: > On Fri, 2006-30-06 at 12:22 -0600, Eric W. Biederman wrote: > >> >> Anyway Jamal can you see the problem the aliases present to the > implementation? >> > > I think more than anything i may have a different view of things and no > code ;-> And you are trying t

Re: [PATCH] pcmcia: hostap_cs.c - 0xc00f,0x0000 conflicts with pcnet_cs

2006-06-30 Thread Jeff Garzik
Linux Kernel Mailing List wrote: commit fd99ddd0701385344eadaf2daa6abbc5fb086750 tree 013d75048f086edfa7a89ac3f3301dde13017817 parent 0db6095d4ff8918350797dfe299d572980e82fa0 author Komuro <[EMAIL PROTECTED]> Mon, 17 Apr 2006 21:41:21 +0900 committer Dominik Brodowski <[EMAIL PROTECTED]> Fri, 30

Re: [PATCH] com20020_cs: more device support

2006-06-30 Thread Jeff Garzik
For the nth time, drivers/net patches should at least be CC'd to netdev and me. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [1/4] [IPV6]: Remove redundant length check on input

2006-06-30 Thread Ananda Raju
Sure, we will do that. -Original Message- From: Michael Chan [mailto:[EMAIL PROTECTED] Sent: Friday, June 30, 2006 5:08 PM To: Ananda Raju Cc: David Miller; [EMAIL PROTECTED]; netdev@vger.kernel.org Subject: RE: [1/4] [IPV6]: Remove redundant length check on input On Fri, 2006-06-30 at

RE: [1/4] [IPV6]: Remove redundant length check on input

2006-06-30 Thread Michael Chan
On Fri, 2006-06-30 at 19:55 -0400, Ananda Raju wrote: > True, I am referring to "ethtool -K ethX tso off" > ethtool_op_set_tso() won't clear NETIF_F_TSO6 for ethtool -K ethX tso > off > Instead of using ethtool_op_set_tso() in your ethtool_ops structure, you can use a private function to set or cl

Re: jumbo frames and memory fragmentation

2006-06-30 Thread Jesse Brandeburg
On 6/30/06, Chris Friesen <[EMAIL PROTECTED]> wrote: Evgeniy Polyakov wrote: > It definitely will. > Packet split in hardware means separating data and headers into > different pages in different reads, while software page split means that > skb has a list of fragments where part of the packet w

[PATCH] IOAT: fix kernel-doc in source files

2006-06-30 Thread Randy.Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix kernel-doc warnings in drivers/dma/: - use correct function & parameter names - add descriptions where omitted Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/dma/dmaengine.c | 20 drivers/dma/ioatdma.c |8 +-

RE: [1/4] [IPV6]: Remove redundant length check on input

2006-06-30 Thread Ananda Raju
True, I am referring to "ethtool -K ethX tso off" ethtool_op_set_tso() won't clear NETIF_F_TSO6 for ethtool -K ethX tso off Ananda -Original Message- From: Michael Chan [mailto:[EMAIL PROTECTED] Sent: Friday, June 30, 2006 4:53 PM To: Ananda Raju Cc: David Miller; [EMAIL PROTECTED]; netd

RE: [1/4] [IPV6]: Remove redundant length check on input

2006-06-30 Thread Michael Chan
On Fri, 2006-06-30 at 19:44 -0400, Ananda Raju wrote: > Hi, > > I tested the patch, and TSO over ipv6 is working fine. But TSO disable > not working for IPv6. > You need to clear NETIF_F_TSO6 in dev->features to disable ipv6 TSO. - To unsubscribe from this list: send the line "unsubscribe netd

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2006-06-30 17:31 > Better to explain the reason for ifb first: > ifb exists initially as a replacement for IMQ. > 1) qdiscs/policies that are per device as opposed to system wide. > This now allows for sharing. > > 2) Allows for queueing incoming traffic for shaping in

RE: [1/4] [IPV6]: Remove redundant length check on input

2006-06-30 Thread Ananda Raju
Hi, I tested the patch, and TSO over ipv6 is working fine. But TSO disable not working for IPv6. I tried the from tree /pub/scm/linux/kernel/git/davem/net-2.6 Ananda -Original Message- From: David Miller [mailto:[EMAIL PROTECTED] Sent: Friday, June 30, 2006 2:20 PM To: [EMAIL PROTEC

Re: jumbo frames and memory fragmentation

2006-06-30 Thread Chris Friesen
Evgeniy Polyakov wrote: It definitely will. Packet split in hardware means separating data and headers into different pages in different reads, while software page split means that skb has a list of fragments where part of the packet will be DMAed, so jumbo frame will be converted into several

[PATCH] tg3: Add ipv6 TSO feature

2006-06-30 Thread Michael Chan
Enable ipv6 TSO feature on chips that support it. Update version to 3.61. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 47c96fc..b992c0a 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -69,8 +69,8 @@ #define DRV_MODULE_NAME

[PATCH] IOAT: fix header file kernel-doc

2006-06-30 Thread Randy.Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix kernel-doc problems in include/linux/dmaengine.h: - add some fields/parameters - expand some descriptions - fix typos Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- include/linux/dmaengine.h | 43 +-- 1 fil

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Thomas Graf
This is boring, I reversed everything to not change any semantics and you still complain. * jamal <[EMAIL PROTECTED]> 2006-06-30 17:35 > On Fri, 2006-30-06 at 23:20 +0200, Thomas Graf wrote: > > * jamal <[EMAIL PROTECTED]> 2006-06-30 17:09 > > > the ref inside the else below after changing input_d

Re: RDMA will be reverted

2006-06-30 Thread Tom Tucker
On Fri, 2006-06-30 at 14:16 -0700, David Miller wrote: > The TOE folks have tried to submit their hooks and drivers > on several occaisions, and we've rejected it every time. iWARP != TOE > - > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [EMAIL

[PATCH] NET: Fix ipv6 GSO payload length

2006-06-30 Thread Michael Chan
Fix ipv6 GSO payload length calculation. The ipv6 payload length excludes the ipv6 base header length and so must be subtracted. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c index 25f8bf8..2d622d1 100644 --- a/net/ipv6/ipv6_soc

Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats

2006-06-30 Thread Andrew Morton
Shailabh Nagar <[EMAIL PROTECTED]> wrote: > > Based on previous discussions, the above solutions can be expanded/modified > to: > > a) allow userspace to listen to a group of cpus instead of all. Multiple > collection daemons can distribute the load as you pointed out. Doing > collection > by cp

Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats

2006-06-30 Thread Andrew Morton
Shailabh Nagar <[EMAIL PROTECTED]> wrote: > > +/* > + * Per-task exit data sent from the kernel to user space > + * is tagged by an id based on grouping of cpus. > + * > + * If userspace specifies a non-zero P as the nl_pid field of > + * the sockaddr_nl structure while binding to a netlink socket,

Re: [patch 2/6] [Network namespace] Network device sharing by view

2006-06-30 Thread jamal
On Fri, 2006-30-06 at 12:22 -0600, Eric W. Biederman wrote: > > Anyway Jamal can you see the problem the aliases present to the > implementation? > I think more than anything i may have a different view of things and no code ;-> And you are trying to restore order in the discussion - so my wil

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread jamal
On Fri, 2006-30-06 at 23:20 +0200, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2006-06-30 17:09 > > the ref inside the else below after changing input_dev > > A non-existant iif is already equivalent to !iif since it jumps > into the same branch. I thought 0 was a valid iif as Ben G was po

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread jamal
On Fri, 2006-30-06 at 23:10 +0200, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2006-06-30 16:54 > > I agree - and i try hard to document but at times there's too much > > and a line needs to be drawn. > > As an example: > > the eth->ifb->ifb case though is a very corner case. All the IMQ types

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2006-06-30 17:09 > On Fri, 2006-30-06 at 19:13 +0200, Thomas Graf wrote: > > Index: net-2.6.git/drivers/net/ifb.c > > === > > --- net-2.6.git.orig/drivers/net/ifb.c > > +++ net-2.6.git/drivers/net/ifb.c > >

Re: IPVS Sysctl Variables

2006-06-30 Thread David Miller
From: Horms <[EMAIL PROTECTED]> Date: Fri, 30 Jun 2006 15:19:41 +0900 > there are quite a number of entries under /proc/sys/net/ipv4/vs, > I swear that they were documented in Documentation/networking/ > at some stage, but perhaps I am dreaming. > > In any case, if I clean up the information at t

Re: RDMA will be reverted

2006-06-30 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Fri, 30 Jun 2006 13:51:19 -0700 > And I can't think of a single other example of a case where we > refused to merge a driver, not because of any issues with the driver > code, but because we don't like the hardware it drives and think > that people sho

Re: [1/4] [IPV6]: Remove redundant length check on input

2006-06-30 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 30 Jun 2006 15:42:09 +1000 > I've added GSO for TCPv6 and updated Ananda's patch. Please note that > the following patches have only been compile-tested. I applied this and pushed it to Linus, let's cross our fingers :) - To unsubscribe from this l

Re: [PATCH 9/15] pcmcia: hostap_cs.c - 0xc00f, 0x0000 conflicts with pcnet_cs

2006-06-30 Thread Pavel Roskin
Hi Dominik, On Fri, 2006-06-30 at 21:59 +0200, Dominik Brodowski wrote: > - PCMCIA_DEVICE_MANF_CARD(0xc00f, 0x), > +/* PCMCIA_DEVICE_MANF_CARD(0xc00f, 0x),conflict with pcnet_cs */ That's fine if we also add symbolic names. I could identify two hostap_cs compatible cards using

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2006-06-30 16:54 > I agree - and i try hard to document but at times there's too much > and a line needs to be drawn. > As an example: > the eth->ifb->ifb case though is a very corner case. All the IMQ types > need to only redirect to one ifb; while i test it ive always

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread jamal
Ok, I think found the last patch you posted, comments below (I have to run off soon): On Fri, 2006-30-06 at 19:13 +0200, Thomas Graf wrote: > There you go, leaves ifb broken as-is, at least prevents it > from crashing randomly when the input_dev disappears. > I hope the above comment does show

Re: [PATCH 28 of 39] IB/ipath - Fixes a bug where our delay for EEPROM no longer works due to compiler reordering

2006-06-30 Thread Roland Dreier
> > static void i2c_wait_for_writes(struct ipath_devdata *dd) > > { > > + mb(); > >(void)ipath_read_kreg32(dd, dd->ipath_kregs->kr_scratch); > > } > That's a bit weird. I wouldn't have expected the compiler to muck around > with a readl(). I never liked this patch. The last time

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread jamal
On Fri, 2006-30-06 at 13:33 -0700, David Miller wrote: > From: Thomas Graf <[EMAIL PROTECTED]> > Date: Fri, 30 Jun 2006 22:30:34 +0200 > > > Lack of stylistic commas is less of a concern, rather the lack of > > comments and notes where absolutely essential. > > Yes, intent is very important to do

Re: RDMA will be reverted

2006-06-30 Thread Roland Dreier
You snipped my question about what specifically you wanted reverted, so I'm going to assume that after cooling down and understanding the situation, you're OK with everything that's in Linus's tree... > The integration of iWARP with the Linux networking, while much better > than TOE, is still he

RE: [PATCH 2.6.17] support for TSO over IPv6

2006-06-30 Thread Leonid Grossman
> -Original Message- > From: Herbert Xu [mailto:[EMAIL PROTECTED] > Sent: Thursday, June 29, 2006 5:39 PM > To: Ananda Raju > Cc: netdev@vger.kernel.org; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; Leonid Grossman; Ravinandan Arakali; > [EMAIL PROTECTED]; Sriram Rapuru; Michael Chan > Sub

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread jamal
On Fri, 2006-30-06 at 22:08 +0200, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2006-06-30 15:34 > > So assuming it is taken in mirred (i havent thought of where it is > > decremented), why would using the ifindex be better? > > The issue exists regardless of mirred/ifb. As soon as the packet

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Fri, 30 Jun 2006 22:30:34 +0200 > Lack of stylistic commas is less of a concern, rather the lack of > comments and notes where absolutely essential. Yes, intent is very important to document when it is not obvious. Everyone is guilty of not doing this

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2006-06-30 15:59 > One thing is clear in my mind at least (and i have said it several > times): I am not as good at the semantics as either yourself or Thomas > or Dave or Acme etc but i have tons of other things that compensate for. > Probably "not as good" is not the b

Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats

2006-06-30 Thread jamal
On Fri, 2006-30-06 at 15:10 -0400, Shailabh Nagar wrote: > > Also to get feedback on this kind of usage of the nl_pid field, the > approach etc. > It does not look unreasonable. I think you may have issues when you have multiple such sockets opened within a single process. But do some testing

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Fri, 30 Jun 2006 15:40:26 -0400 > My arguement was: > dev get by index per device will involve a a) lookup + b) incrementing > the refcount. > if i use the dev pointer in that path then it becomes only #b > > in both cases, you need to increment the counter

[PATCH 14/15] com20020_cs: more device support

2006-06-30 Thread Dominik Brodowski
From: Marc Sowen <[EMAIL PROTECTED]> Date: Sun, 25 Jun 2006 01:56:24 -0700 Subject: [PATCH] com20020_cs: more device support Enable the com20020_cs arcnet driver to see the SoHard (now Mercury Computer Systems Inc.) SH ARC-PCMCIA card. Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Signed-off-

[PATCH 9/15] pcmcia: hostap_cs.c - 0xc00f,0x0000 conflicts with pcnet_cs

2006-06-30 Thread Dominik Brodowski
From: Komuro <[EMAIL PROTECTED]> Date: Mon, 17 Apr 2006 21:41:21 +0900 Subject: [PATCH] pcmcia: hostap_cs.c - 0xc00f,0x conflicts with pcnet_cs Comment out the ID 0xc00f,0x in hostap_cs.c, as it conflicts with the pcnet_cs driver. Signed-off-by: [EMAIL PROTECTED] Signed-off-by: Dominik B

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2006-06-30 15:34 > I thought we went past that point already - and i made it clear that > the reference is _not_ taken in netif_receive_skb(). > > So assuming it is taken in mirred (i havent thought of where it is > decremented), why would using the ifindex be better?

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread jamal
On Fri, 2006-30-06 at 19:33 +0200, Patrick McHardy wrote: > jamal wrote: > > You are attempting to change architecture (which works just fine) in the > > way you > > think it should work - and then point to something as a bug because it > > doesnt work the way you think it should work. > > This

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread jamal
On Fri, 2006-30-06 at 19:42 +0200, Patrick McHardy wrote: > jamal wrote: > > Thomas makes the claim, this can be achieved only by using an ifindex. > > And i havent been able to see how. I have a small performance problem if > > i just use ifindex. Using ifindex will eventually save 32 bits on the

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread jamal
On Fri, 2006-30-06 at 19:42 +0200, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2006-06-30 13:32 > > Thomas makes the claim, this can be achieved only by using an ifindex. > > And i havent been able to see how. I have a small performance problem if > > i just use ifindex. Using ifindex will ev

Re: Please pull 'upstream' branch of wireless-2.6 (revised)

2006-06-30 Thread John W. Linville
On Fri, Jun 30, 2006 at 12:31:00PM -0400, Jeff Garzik wrote: > >The following changes since commit > >fcc18e83e1f6fd9fa6b333735bf0fcd530655511: > > Malcolm Parsons: > >uclinux: use PER_LINUX_32BIT in binfmt_flat > > > >are found in the git repository at: > > > > git://git.kernel.org/pub

Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats

2006-06-30 Thread Shailabh Nagar
Shailabh Nagar wrote: > Shailabh Nagar wrote: > > > Index: linux-2.6.17-mm3equiv/kernel/taskstats.c > === > --- linux-2.6.17-mm3equiv.orig/kernel/taskstats.c 2006-06-30 > 11:57:14.0 -0400 > +++ linux-2.6.17-mm3equiv/ke

Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats

2006-06-30 Thread Shailabh Nagar
Shailabh Nagar wrote: > Andrew, > > Based on previous discussions, the above solutions can be expanded/modified > to: > > a) allow userspace to listen to a group of cpus instead of all. Multiple > collection daemons can distribute the load as you pointed out. Doing > collection > by cpu groups r

Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats

2006-06-30 Thread Shailabh Nagar
Andrew Morton wrote: > On Thu, 29 Jun 2006 09:44:08 -0700 > Paul Jackson <[EMAIL PROTECTED]> wrote: > > >>>You're probably correct on that model. However, it all depends on the actual >>>workload. Are people who actually have large-CPU (>256) systems actually >>>running fork()-heavy things like web

Re: jumbo frames and memory fragmentation

2006-06-30 Thread Evgeniy Polyakov
On Fri, Jun 30, 2006 at 11:53:36AM -0600, Chris Friesen ([EMAIL PROTECTED]) wrote: > >Either upgrade your kernel or backport the page-splitting code in the > >current tree. That's really the only sane solution for jumbo packets. > > Looking at the page-splitting code, it says "82571 and greater

Re: [patch 2/6] [Network namespace] Network device sharing by view

2006-06-30 Thread Eric W. Biederman
jamal <[EMAIL PROTECTED]> writes: >> > > Then the pragmatic question becomes how to correlate what you see from >> > > `ip addr list' to guests. >> > >> > on the host ip addr and the one seen on the guest side are the same. >> > Except one is seen (on the host) on guest0-eth0 and another is seen

Re: strict isolation of net interfaces

2006-06-30 Thread Eric W. Biederman
Daniel Lezcano <[EMAIL PROTECTED]> writes: > Serge E. Hallyn wrote: >> Quoting Cedric Le Goater ([EMAIL PROTECTED]): >> >>>we could work on virtualizing the net interfaces in the host, map them to >>>eth0 or something in the guest and let the guest handle upper network layers >>>? >>> >>>lo0 woul

Re: strict isolation of net interfaces

2006-06-30 Thread Eric W. Biederman
Daniel Lezcano <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> Daniel Lezcano <[EMAIL PROTECTED]> writes: >> >>>Serge E. Hallyn wrote: >>> Quoting Cedric Le Goater ([EMAIL PROTECTED]): >we could work on virtualizing the net interfaces in the host, map them to >eth0

Re: jumbo frames and memory fragmentation

2006-06-30 Thread Chris Friesen
Herbert Xu wrote: Either upgrade your kernel or backport the page-splitting code in the current tree. That's really the only sane solution for jumbo packets. Looking at the page-splitting code, it says "82571 and greater support packet-split...". We're running the 82546GB device. Looks lik

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Thomas Graf
* Patrick McHardy <[EMAIL PROTECTED]> 2006-06-30 19:42 > I think Thomas was more complaining about the values it is set to > and the fact that only a single redirection is possible for each > packet, no? I have no interest in resolving this anymore, it seems to be a "feature" to avoid tx lock dead

Re: strict isolation of net interfaces

2006-06-30 Thread Eric W. Biederman
"Serge E. Hallyn" <[EMAIL PROTECTED]> writes: > Quoting Eric W. Biederman ([EMAIL PROTECTED]): >> This whole debate on network devices show up in multiple network namespaces >> is just silly. The only reason for wanting that appears to be better > management. > > A damned good reason. Better m

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Patrick McHardy
jamal wrote: > On Fri, 2006-30-06 at 19:18 +0200, Patrick McHardy wrote: > >>Thomas Graf wrote: >> >>>* Thomas Graf <[EMAIL PROTECTED]> 2006-06-30 18:32 >>> >>> Anyways, I give up. Last time I've been running after you trying to fix the many bugs you leave behind. Ever noticed that wheneve

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2006-06-30 13:32 > I will summarize what the outstanding issues are, the rest of the "bugs" > just ignore otherwise the discussion is a waste of time and may > get out of control. > > 1) ifb references skb->input_dev > 2) mirred sets the skb->input_dev which is used in

Please re-apply the pwork macsuspend patch

2006-06-30 Thread Michael Buesch
Hi John, Please re-apply the "Suspend MAC in periodic work" now. I neither remember the exact name, nor do I still have the patch. Well, I deleted it since it was applied... hrm... But I assume you know which patch I mean. Please re-apply it because: * It does _NO_ harm. * It _fixes_ a bug. * I a

Re: 2.6.17-mm4

2006-06-30 Thread Alan Cox
Ar Gwe, 2006-06-30 am 13:27 -0400, ysgrifennodd Dave Jones: > surely no-one made an acpi aware vlb machine :) > > There are probably other creative ways. And the not-so-creative simple one which is how old IDE addresses much of this: Date: Fri Jun 30 16:39:20 2006 +0100 Subject: [PATCH 13/20]

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2006-06-30 13:19 > On Fri, 2006-30-06 at 18:32 +0200, Thomas Graf wrote: > > * jamal <[EMAIL PROTECTED]> 2006-06-30 10:35 > > > > Did you actually try to run this before you reached this conclusion? > > > > I did, fortunately some other bug prevents this from happenin

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Patrick McHardy
jamal wrote: > You are attempting to change architecture (which works just fine) in the way > you > think it should work - and then point to something as a bug because it > doesnt work the way you think it should work. > This is a problem not just with you BTW, but with Patrick as well (althoug

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread jamal
On Fri, 2006-30-06 at 19:18 +0200, Patrick McHardy wrote: > Thomas Graf wrote: > > * Thomas Graf <[EMAIL PROTECTED]> 2006-06-30 18:32 > > > >>Anyways, I give up. Last time I've been running after you trying > >>to fix the many bugs you leave behind. Ever noticed that whenever > >>you add some new

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Ben Greear
Thomas Graf wrote: * Thomas Graf <[EMAIL PROTECTED]> 2006-06-30 18:32 Anyways, I give up. Last time I've been running after you trying to fix the many bugs you leave behind. Ever noticed that whenever you add some new code it's someone else following up with tons of small bugfix patches having

Re: 2.6.17-mm4

2006-06-30 Thread Dave Jones
On Fri, Jun 30, 2006 at 01:14:30PM +0100, Alan Cox wrote: > Ar Gwe, 2006-06-30 am 11:54 +0200, ysgrifennodd Arjan van de Ven: > > another quick hack is to check for vesa lb... eg if pci is present, skip > > this thing entirely :) > > Not really, many people made VLB/PCI combo boards. - check

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread jamal
On Fri, 2006-30-06 at 18:32 +0200, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2006-06-30 10:35 > > Did you actually try to run this before you reached this conclusion? > > I did, fortunately some other bug prevents this from happening, > packets are simply dropped somewhere. > It is not

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Patrick McHardy
Thomas Graf wrote: > * Thomas Graf <[EMAIL PROTECTED]> 2006-06-30 18:32 > >>Anyways, I give up. Last time I've been running after you trying >>to fix the many bugs you leave behind. Ever noticed that whenever >>you add some new code it's someone else following up with tons of >>small bugfix patche

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Thomas Graf
* Thomas Graf <[EMAIL PROTECTED]> 2006-06-30 18:32 > Anyways, I give up. Last time I've been running after you trying > to fix the many bugs you leave behind. Ever noticed that whenever > you add some new code it's someone else following up with tons of > small bugfix patches having a hard time try

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Patrick McHardy
Patrick McHardy wrote: > Nicolas Dichtel wrote: > >>Bit 8 of skb->tc_verd is set by IFB, so packet isn't reclassify. >>This bit avoid the loop. > > > It would, if something would actually set it. > > ~/src/kernel/linux-2.6$ grep NCLS -r net/ > net/core/dev.c: if (skb->tc_verd & TC_NCLS) { > net

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Patrick McHardy
Nicolas Dichtel wrote: > Bit 8 of skb->tc_verd is set by IFB, so packet isn't reclassify. > This bit avoid the loop. It would, if something would actually set it. ~/src/kernel/linux-2.6$ grep NCLS -r net/ net/core/dev.c: if (skb->tc_verd & TC_NCLS) { net/core/dev.c: skb->tc_verd = CLR_TC_

Re: [PATCH 0 of 39] ipath - bug fixes, performance enhancements,and portability improvements

2006-06-30 Thread Bryan O'Sullivan
On Fri, 2006-06-30 at 19:31 +0300, Michael S. Tsirkin wrote: > OK, next week I'll put these into my tree, too. Thanks. The first 37 are in -mm; the last two you can drop until I sort them out. http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0 of 39] ipath - bug fixes, performance enhancements,and portability improvements

2006-06-30 Thread Michael S. Tsirkin
Quoting r. Bryan O'Sullivan <[EMAIL PROTECTED]>: > Subject: [PATCH 0 of 39] ipath - bug fixes, performance enhancements,and > portability improvements > > Hi, Andrew - > > These patches bring the ipath driver up to date with a number of bug fixes, > performance improvements, and better PowerPC s

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2006-06-30 10:35 > On Fri, 2006-30-06 at 16:15 +0200, Thomas Graf wrote: > > eth0::tcf_mirred() skb->dev = ifb0, input_dev = eth0 > > ifb0::tcf_mirred() skb->dev = ifb1, input_dev = ifb0 > > ifb1::ifb_xmit() skb->dev = ifb0, input_dev = ifb1, set ncls bit >

Re: Please pull 'upstream' branch of wireless-2.6 (revised)

2006-06-30 Thread Jeff Garzik
John W. Linville wrote: On Mon, Jun 26, 2006 at 05:25:52PM -0400, John W. Linville wrote: Michael Buesch: bcm43xx: suspend MAC while executing long pwork The above patch ruffled some feathers on netdev. In the interest of moving things along, I have pulled that patch out of wireless-2.

Re: Please pull 'zd1211rw' branch of wireless-2.6 (new driver)

2006-06-30 Thread Jeff Garzik
John W. Linville wrote: For easier review, a tarball of drivers/net/wireless/zd1211rw is available here: http://www.kernel.org/pub/linux/kernel/people/linville/zd1211rw.tar.gz From Daniel's initial zd1211rw changelog: [PATCH] ZyDAS ZD1211 USB-WLAN driver There are 60+ USB wi

Re: [PATCH 1/3] mv643xx fixes - Disable interrupts on all ports during initialization

2006-06-30 Thread Jeff Garzik
Brent Cook wrote: This patch disable interrupts on all ports during initialization. The current assumes that the firmware has already disabled all interrupts on all ports. We have encountered some boards that do not always disable interrupts (XES XPedite 6200 for instance) on a soft reset. This

Re: strict isolation of net interfaces

2006-06-30 Thread Serge E. Hallyn
Quoting Eric W. Biederman ([EMAIL PROTECTED]): > This whole debate on network devices show up in multiple network namespaces > is just silly. The only reason for wanting that appears to be better > management. A damned good reason. Clearly we want the parent namespace to be able to control what

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Ben Greear
jamal wrote: On Fri, 2006-30-06 at 16:15 +0200, Thomas Graf wrote: You agreed in your last posting that the 3rd option, being that not caring about whether a device might disappear but having a way to check for it, is what we agreed on and what makes most sense, yes, i recalled that as the

Re: strict isolation of net interfaces

2006-06-30 Thread Daniel Lezcano
Eric W. Biederman wrote: Daniel Lezcano <[EMAIL PROTECTED]> writes: Serge E. Hallyn wrote: Quoting Cedric Le Goater ([EMAIL PROTECTED]): we could work on virtualizing the net interfaces in the host, map them to eth0 or something in the guest and let the guest handle upper network layers ?

[PATCH 2.6 1/3] net/ipv4|v6: RFC 3828-compliant UDP-Lite support

2006-06-30 Thread Gerrit Renker
This is an extension which adds RFC3828 - compliant UDP-Lite functionality to the IPv4 / IPv6 networking stack. I have uploaded three IPv6-ready UDP-Lite applications, with install instructions, so please give it a test drive if you can spare a few minutes. The link and further information is

Re: [patch 2/6] [Network namespace] Network device sharing by view

2006-06-30 Thread Andrey Savochkin
Jamal, On Fri, Jun 30, 2006 at 09:50:52AM -0400, jamal wrote: > > BTW - I was just looking at openvz, very impressive. To the other folks, Thanks! > I am not putting down any of your approaches - just havent > had time to study them. Andrey, this is the same thing you guys have > been working o

[PATCH 2.6 2/3] net/ipv4|v6: RFC 3828-compliant UDP-Lite support

2006-06-30 Thread Gerrit Renker
The IPv4 part of the UDP-Lite extension. Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]> Signed-off-by: William Stanislaus <[EMAIL PROTECTED]> --- core/sock.c|7 ipv4/Makefile |1 ipv4/af_inet.c | 95 +++ ipv4/proc.c| 37 + ipv4/udplite.c | 1651 +++

[PATCH 2.6 3/3] net/ipv4|v6: RFC 3828-compliant UDP-Lite support

2006-06-30 Thread Gerrit Renker
The IPv6 part of the UDP-Lite extension. Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]> Signed-off-by: William Stanislaus <[EMAIL PROTECTED]> --- include/net/ipv6.h | 11 include/net/transp_v6.h |4 net/ipv6/Makefile |1 net/ipv6/af_inet6.c | 36 + net/ipv6/proc.c

Re: [patch] work around/fix deadlock in the bcm43xx driver by making netlink irq safe

2006-06-30 Thread Arjan van de Ven
Joseph Jezak wrote: Can you provide the details to the list? I'll look into getting SoftMAC fixed if you do. sure the basic issue is that bcm43xx does it's rx processing in a softirq, and holds the bcm->irq_lock during that time. The rx processing calls into the softmac layer, which in turn

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread jamal
On Fri, 2006-30-06 at 16:15 +0200, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2006-06-30 09:57 > > On Fri, 2006-30-06 at 15:08 +0200, Thomas Graf wrote: > > > That creates a nice loop on ingress. Upon reentering the > > > stack with skb->dev set to eth0 again we'll go through the > > > same i

Off by one buglets

2006-06-30 Thread Ralf Baechle
Ages ago, changeset http://www.kernel.org/git/?p=linux/kernel/git/tglx/history.git;a=commit;h=22d864d542a0b92116751186f1794c7d0f1ca1b9 which converted several protocols from using open coded comparisons to use the helper function sk_acceptq_is_full() did introduce a bunch of off by one errors - s

[patch] work around/fix deadlock in the bcm43xx driver by making netlink irq safe

2006-06-30 Thread Arjan van de Ven
Hi, there is a complex deadlock in the bcm43xx driver, that apparently can only be solved by rewriting the softmac layer or by the patch below that makes the netlink lock irq safe. (details about the deadlock available but sort of not relevant for the discussion). Please consider this patch fo

Re: strict isolation of net interfaces

2006-06-30 Thread Eric W. Biederman
Daniel Lezcano <[EMAIL PROTECTED]> writes: > Serge E. Hallyn wrote: >> Quoting Cedric Le Goater ([EMAIL PROTECTED]): >> >>>we could work on virtualizing the net interfaces in the host, map them to >>>eth0 or something in the guest and let the guest handle upper network layers >>>? >>> >>>lo0 woul

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-06-30 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2006-06-30 09:57 > On Fri, 2006-30-06 at 15:08 +0200, Thomas Graf wrote: > > That creates a nice loop on ingress. Upon reentering the > > stack with skb->dev set to eth0 again we'll go through the > > same ingress filters as the first time and we'll hit ifb0 > > again ov

  1   2   >