* jamal <[EMAIL PROTECTED]> 2006-06-30 13:32 > I will summarize what the outstanding issues are, the rest of the "bugs" > just ignore otherwise the discussion is a waste of time and may > get out of control. > > 1) ifb references skb->input_dev > 2) mirred sets the skb->input_dev which is used in #1 > > It is possible that when #1 happens infact input_dev is gone because no > ref count is incremented. Ok, Thomas is that sufficient to discuss the > crux of the matter?
Sure, that's the most obvious bug. > At one point many months ago, the logic was for now the likelihood this > will happen is low but we need to cover for by at least figuring the > existence of input_dev when referencing it. > > Thomas makes the claim, this can be achieved only by using an ifindex. > And i havent been able to see how. I have a small performance problem if > i just use ifindex. Using ifindex will eventually save 32 bits on the > 64 bit machines. I posed the question as to which was more beneficial > as a solution that hasnt been addressed. I'd appreciate if you'd stop sperading lies. I claimed it to be the best solution, not the only one. Everyone agrees that it's possible to use a pointer and take a reference in netif_receive_skb() while it also seems obvious to most that it's not a good idea to take two additional atomic operations in the fast path for this purpose. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
