Re: [PATCH] [NET] : get rid of 'struct sec_path *' in skbuff if ! CONFIG_XFRM

2006-03-13 Thread Eric Dumazet
Herbert Xu a écrit : Eric Dumazet <[EMAIL PROTECTED]> wrote: - C(sp); -#ifdef CONFIG_INET - secpath_get(skb->sp); +#ifdef CONFIG_XFRM + n->sp = secpath_get(skb->sp); #endif Please move the ifdef into xfrm.h while you're at it. That is, make secpath_get a no-op if CONFIG_XFRM

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread Russell Stuart
On Mon, 2006-03-13 at 22:39 -0500, jamal wrote: > Trust me - I understand this stuff;-> (I have described these two to > many people). And i will take a look at your doc at some point. > > What i mean is: that you could achieve the result of stitching > hashtables together to direct a packet to e

[Fwd: Re: [PATCH 15/16] ipw2200: switch to the new ipw2200-fw-3.0 image format]

2006-03-13 Thread Sam Leffler
--- Begin Message --- I don't see how to verify the image being loaded is appropriate for the operating mode. The old fw header had a mode field (0 bss, 1 ibss, 2 monitor) but the new one does not--unless it's encoded in the version field? Sam --- End Message ---

Re: [Patch 9/9] Generic netlink interface for delay accounting

2006-03-13 Thread Shailabh Nagar
Matt Helsley wrote: On Mon, 2006-03-13 at 19:56 -0500, Shailabh Nagar wrote: Comments addressed (all in response to Jamal) - Eliminated TASKSTATS_CMD_LISTEN and TASKSTATS_CMD_IGNORE The enums for these are still in the patch. See below. +/* + * Commands sent from userspace +

Re: [Patch 9/9] Generic netlink interface for delay accounting

2006-03-13 Thread Shailabh Nagar
jamal wrote: On Mon, 2006-13-03 at 18:33 -0800, Matt Helsley wrote: On Mon, 2006-03-13 at 19:56 -0500, Shailabh Nagar wrote: Jamal, was your Mon, 13 Mar 2006 21:29:09 -0500 reply: Note, you are still not following the standard scheme of doing things. Example: using command =

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread Russell Stuart
On Mon, 2006-03-13 at 22:10 -0500, jamal wrote: > I will try to find the scripts. Just the data sets will do. I can then pump it through my python script. But before launching into this, I don't see the choice of algorithm as very important. Yes, I believe the 2.4 one was better. But not by s

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread jamal
On Tue, 2006-14-03 at 13:27 +1000, Russell Stuart wrote: > On Mon, 2006-03-13 at 21:39 -0500, jamal wrote: > > Looks like it is doing the right thing - Although sometimes the only way > > to really see things is to send some traffic. > > Take my word for it that I have sent mega bytes of traffic

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread jamal
On Tue, 2006-14-03 at 13:16 +1000, Russell Stuart wrote: > On Mon, 2006-03-13 at 21:24 -0500, jamal wrote: [..] > > And besides if you really insist, look at using hashkey - it will work a > > lot better since the dependency is only at the kernel and none at user > > space. > > Hashkey and sample

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread Russell Stuart
On Mon, 2006-03-13 at 21:39 -0500, jamal wrote: > On Tue, 2006-14-03 at 12:29 +1000, Russell Stuart wrote: > > On Sat, 2006-03-11 at 08:11 -0500, jamal wrote: > > > On Fri, 2006-10-02 at 12:33 +1000, Russell Stuart wrote: > > > > This patch adds a "divisor" option to tc's "sample" > > > > clause:

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread Russell Stuart
On Mon, 2006-03-13 at 21:24 -0500, jamal wrote: > If you dont mind please stop ccing lartc - they keep bouncing my mail. OK. Somebody should fix that. A kernel net developer not being able to post to lartc is just plain wrong. > On Tue, 2006-14-03 at 10:31 +1000, Russell Stuart wrote: > > > An

Re: [2.6 patch] drivers/net/wireless/ipw2200.c: fix an array overun

2006-03-13 Thread Zhu Yi
On Sat, 2006-03-11 at 04:42 +0100, Adrian Bunk wrote: > This patch fixes a big array overun found by the Coverity checker. > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- linux-2.6.16-rc5-mm3-full/drivers/net/wireless/ipw2200.c.old > 2006-03-11 02:41:23.0 +0100 > +++ l

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread jamal
On Tue, 2006-14-03 at 12:45 +1000, Russell Stuart wrote: > On Sat, 2006-03-11 at 10:56 -0500, jamal wrote: > > [1] Essentially, if you teach u32 in 2.4 to spread rules over different > > buckets it will not do so evenly. Off top of my head i remember that the > > best you could ever do is have buc

Re: [Patch 9/9] Generic netlink interface for delay accounting

2006-03-13 Thread jamal
On Mon, 2006-13-03 at 18:33 -0800, Matt Helsley wrote: > On Mon, 2006-03-13 at 19:56 -0500, Shailabh Nagar wrote: > Jamal, was your Mon, 13 Mar 2006 21:29:09 -0500 reply: > > Note, you are still not following the standard scheme of doing things. > > Example: using command = GET and the message car

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread Russell Stuart
On Sat, 2006-03-11 at 10:56 -0500, jamal wrote: > Right - take a look at the use of hashkey with varying divisors to see > where the 2.4 folding breaks[1]. Note you should be able to use hashkey > instead of sample and it would work fine. > [1] Essentially, if you teach u32 in 2.4 to spread rule

Re: [Patch 9/9] Generic netlink interface for delay accounting

2006-03-13 Thread Matt Helsley
On Mon, 2006-03-13 at 19:56 -0500, Shailabh Nagar wrote: > Comments addressed (all in response to Jamal) > > - Eliminated TASKSTATS_CMD_LISTEN and TASKSTATS_CMD_IGNORE The enums for these are still in the patch. See below. > +/* > + * Commands sent from userspace > + * Not versioned. New com

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread jamal
On Tue, 2006-14-03 at 12:29 +1000, Russell Stuart wrote: > On Sat, 2006-03-11 at 08:11 -0500, jamal wrote: > > On Fri, 2006-10-02 at 12:33 +1000, Russell Stuart wrote: > > > This patch adds a "divisor" option to tc's "sample" > > > clause: > > > > While this looks right - can we have more test da

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread Russell Stuart
On Sat, 2006-03-11 at 08:11 -0500, jamal wrote: > On Fri, 2006-10-02 at 12:33 +1000, Russell Stuart wrote: > > This patch adds a "divisor" option to tc's "sample" > > clause: > > While this looks right - can we have more test data with tc filter ls > both before and after your fix? Specify diviso

Re: [Patch 9/9] Generic netlink interface for delay accounting

2006-03-13 Thread jamal
On Mon, 2006-13-03 at 19:56 -0500, Shailabh Nagar wrote: > delayacct-genetlink.patch > > Create a generic netlink interface (NETLINK_GENERIC family), > called "taskstats", for getting delay and cpu statistics of > tasks and thread groups during their lifetime and when they exit. > > Comments a

Re: [2.6 patch] hostap_{pci,plx}.c: fix memory leaks

2006-03-13 Thread Herbert Xu
Adrian Bunk <[EMAIL PROTECTED]> wrote: > > + if (pci_enable_device(pdev)) > + return -EIO; > + >hw_priv = kmalloc(sizeof(*hw_priv), GFP_KERNEL); >if (hw_priv == NULL) >return -ENOMEM; >memset(hw_priv, 0, sizeof(*hw_priv)); > > - if

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread jamal
If you dont mind please stop ccing lartc - they keep bouncing my mail. On Tue, 2006-14-03 at 10:31 +1000, Russell Stuart wrote: > Anyway, jokes aside, the situation we have now is the > current "tc" doesn't work with the current kernel. Slow down: The two perceived problematic combos are: a)

Re: [PATCH] [NET] : get rid of 'struct sec_path *' in skbuff if ! CONFIG_XFRM

2006-03-13 Thread Herbert Xu
Eric Dumazet <[EMAIL PROTECTED]> wrote: > > - C(sp); > -#ifdef CONFIG_INET > - secpath_get(skb->sp); > +#ifdef CONFIG_XFRM > + n->sp = secpath_get(skb->sp); > #endif Please move the ifdef into xfrm.h while you're at it. That is, make secpath_get a no-op if CONFIG_XFRM is not def

Re: [Announce] Intel PRO/Wireless 3945ABG Network Connection

2006-03-13 Thread David Rosky
John W. Linville wrote: On Sun, Mar 12, 2006 at 04:01:57PM -0800, David Rosky wrote: (Telecommunications Certification Body).The FCC also maintains a mechanism whereby certification-related questions can be asked directly of them and whereby answers to previous questions can be Can you

Re: [PATCH] scm: fold __scm_send() into scm_send()

2006-03-13 Thread Andrew Morton
Ingo Oeser <[EMAIL PROTECTED]> wrote: > > -int scm_send(struct socket *sock, struct msghdr *msg, struct scm_cookie > *scm) > -{ > -struct task_struct *p = current; > -scm->creds = (struct ucred) { > -.uid = p->uid, > -.gid = p->gid, > -.pid = p->t

[Patch 9/9] Generic netlink interface for delay accounting

2006-03-13 Thread Shailabh Nagar
delayacct-genetlink.patch Create a generic netlink interface (NETLINK_GENERIC family), called "taskstats", for getting delay and cpu statistics of tasks and thread groups during their lifetime and when they exit. Comments addressed (all in response to Jamal) - Eliminated TASKSTATS_CMD_LISTEN

[Patch 8/9] generic netlink utility functions

2006-03-13 Thread Shailabh Nagar
genetlink-utils.patch Two utilities for simplifying usage of NETLINK_GENERIC interface. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> Signed-off-by: Shailabh Nagar <[EMAIL PROTECTED]> include/net/genetlink.h | 20 1 files changed, 20 insertions(+) Index: linux-2.6.16-r

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread Russell Stuart
On Mon, 2006-03-13 at 13:50 -0800, Stephen Hemminger wrote: > On Tue, 14 Mar 2006 07:43:57 +1000 > Russell Stuart <[EMAIL PROTECTED]> wrote: > > > On Mon, 2006-03-13 at 10:04 -0800, Stephen Hemminger wrote: > > > The memset fix is in current CVS. I just wasn't going to take the > > > patch that lo

Writing a Rate based transport protocol

2006-03-13 Thread Saurabh Jain
Hi All, I am trying to write a new rate based transport protocol in linux kernel (either as a module or directly within the kernel). Basically it would be similar to UDP but with features like dynamic rate control, connection and state management, error control like TCP. Is there any established f

Re: ES-API?

2006-03-13 Thread Zach Brown
> Also, the following scares me: > > This specification has not been verified for avoidance of possible > third-party proprietary rights. In implementing this specification, > usual procedures to ensure the respect of possible third-party > intellectual property rights should be followed. Scary,

Re: ES-API?

2006-03-13 Thread Stephen Hemminger
On Mon, 13 Mar 2006 14:25:08 -0800 Zach Brown <[EMAIL PROTECTED]> wrote: > Hi guys, > > I'm hearing noise about the 'Extended Sockets' API in Oracle. It's an > extension to the socket API put together by an industry group that calls > itself the Interconnect Software Consortium and is working in

Re: ES-API?

2006-03-13 Thread Zach Brown
> Yes, this is how these standard groups try to force a particular > approach to high speed networking down everyone's throats. Yeah, from what I understand there's a lot of RDMA/IB people involved in that ``ICSC'' thing. > I think we'll pass on this stuff. OK, so noted. Thanks. - z - To unsu

Re: [TCP]: Fix zero port problem in IPv6

2006-03-13 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 13 Mar 2006 22:50:31 +1100 > I was looking into the bug report titled > > [IPv6 since 2.6.12] connect() without bind() can't time out. > > There are actually a couple of different issues here. Here is a fix to > the most obvious one. Thanks

RE: Router stops routing after changing MAC Address

2006-03-13 Thread linux-os \(Dick Johnson\)
On Mon, 13 Mar 2006, Greg Scott wrote: > Yup. > > I had a situation 2 weeks ago where a customer connected a system to the > Internet with an IP Address he should not have used. And the little > Cisco router on the frontend dutifully recorded it in its ARP cache - > forever, with no TTL! This t

Re: ES-API?

2006-03-13 Thread David S. Miller
From: Zach Brown <[EMAIL PROTECTED]> Date: Mon, 13 Mar 2006 14:25:08 -0800 > The API adds support for things like memory registration, async > operations completed through event queues, "standard" sendfile() and > async poll(), etc. Yes, this is how these standard groups try to force a particular

ES-API?

2006-03-13 Thread Zach Brown
Hi guys, I'm hearing noise about the 'Extended Sockets' API in Oracle. It's an extension to the socket API put together by an industry group that calls itself the Interconnect Software Consortium and is working in partnership with the open group. The API adds support for things like memory regis

[2.6 patch] hostap_{pci,plx}.c: fix memory leaks

2006-03-13 Thread Adrian Bunk
This patch fixes two memotry leaks spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/wireless/hostap/hostap_pci.c |6 +++--- drivers/net/wireless/hostap/hostap_plx.c |6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) --- linux-2.6

[PATCH 08/15] bridge: netfilter VLAN macro cleanup

2006-03-13 Thread shemminger
Fix the VLAN macros in bridge netfilter code. Macros should not depend on magic variables. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: net-2.6.17/net/bridge/br_netfilter.c === --- net-2.6.17.orig/net/bridge/br_netfilt

Re: [PATCH 14/15] llc: llc_mac_hdr_init const arguments

2006-03-13 Thread Arnaldo Carvalho de Melo
On 3/13/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Cleanup of LLC. llc_mac_hdr_init can take constant arguments, > and it is defined twice once in llc_output.h that is otherwise unused. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Acked-by: Arnaldo Carvalho de Melo <[EMAIL PRO

RE: Router stops routing after changing MAC Address

2006-03-13 Thread Greg Scott
Yup. I had a situation 2 weeks ago where a customer connected a system to the Internet with an IP Address he should not have used. And the little Cisco router on the frontend dutifully recorded it in its ARP cache - forever, with no TTL! This took down their webmail for most of a day until we fi

[PATCH 12/15] bridge: use llc for receiving STP packets

2006-03-13 Thread shemminger
Use LLC for the receive path of Spanning Tree Protocol packets. This allows link local multicast packets to be received by other protocols (if they care), and uses the existing LLC code to get STP packets back into bridge code. The bridge multicast address is also checked, so bridges using other l

[PATCH 00/15] Bridge update for 2.6.17

2006-03-13 Thread shemminger
This patches includes previous bridge changes for 2.6.17 and new patches to enable using LLC to handle bridge STP packets. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-inf

[PATCH 14/15] llc: llc_mac_hdr_init const arguments

2006-03-13 Thread shemminger
Cleanup of LLC. llc_mac_hdr_init can take constant arguments, and it is defined twice once in llc_output.h that is otherwise unused. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.17.orig/include/net/llc.h +++ net-2.6.17/include/net/llc.h @@ -71,7 +71,7 @@ extern int llc_rcv(st

[PATCH 05/15] bridge: optimize frame pass up

2006-03-13 Thread shemminger
The netfilter hook that is used to receive frames doesn't need to be a stub. It is only called in two ways, both of which ignore the return value. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.17.orig/net/bridge/br_input.c +++ net-2.6.17/net/bridge/br_input.c @@ -21,12 +21,6 @@

[PATCH 15/15] bridge: use LLC to send STP

2006-03-13 Thread shemminger
The bridge code can use existing LLC output code when building spanning tree protocol packets. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: net-2.6.17/net/bridge/br_stp_bpdu.c === --- net-2.6.17.orig/net/bridge/br_st

[PATCH 13/15] bridge: allow show/store of group multicast address

2006-03-13 Thread shemminger
Bridge's communicate with each other using Spanning Tree Protocol over a standard multicast address. There are times when testing or layering bridges over existing topologies or tunnels, when it is useful to use alternative multicast addresses for STP packets. The 802.1d standard has some unused a

Re: [PATCH] scm: fold __scm_send() into scm_send()

2006-03-13 Thread Andrew Morton
Benjamin LaHaise <[EMAIL PROTECTED]> wrote: > > On Mon, Mar 13, 2006 at 09:05:31PM +0100, Ingo Oeser wrote: > > From: Ingo Oeser <[EMAIL PROTECTED]> > > > > Fold __scm_send() into scm_send() and remove that interface completly > > from the kernel. > > Whoa, what are you doing here? > scm_send()

RE: [PATCH 3/8] [I/OAT] Setup the networking subsystem as a DMA client

2006-03-13 Thread Leech, Christopher
> > +#ifdef CONFIG_NET_DMA > > +#include > > +#endif > > There are still a number of instances of this in the patch > series. Did you > decide to keep the ifdefs in there for some reason? No, I just missed them in header files. Thanks. - To unsubscribe from this list: send the line "unsub

[PATCH 04/15] bridge: use kzalloc

2006-03-13 Thread shemminger
Use kzalloc versus kmalloc+memset. Also don't need to do memset() of bridge address since it is in netdev private data that is already zero'd in alloc_netdev. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.17.orig/net/bridge/br_if.c +++ net-2.6.17/net/bridge/br_if.c @@ -210,7 +2

[PATCH 10/15] bridge: forwarding remove unneeded preempt and bh diasables

2006-03-13 Thread shemminger
Optimize the forwarding and transmit paths. Both places are called with bottom half/no preempt so there is no need to use spin_lock_bh or rcu_read_lock. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- br-2.6.orig/net/bridge/br_fdb.c +++ br-2.6/net/bridge/br_fdb.c @@ -341,7 +341,6 @@ voi

[PATCH 09/15] bridge: netfilter inline cleanup

2006-03-13 Thread shemminger
Move nf_bridge_alloc from header file to the one place it is used and optimize it. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.17.orig/include/linux/netfilter_bridge.h +++ net-2.6.17/include/linux/netfilter_bridge.h @@ -47,22 +47,6 @@ enum nf_br_hook_priorities { #define BR

[PATCH 03/15] bridge: use kcalloc

2006-03-13 Thread shemminger
Use kcalloc rather than kmalloc + memset. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: br-2.6/net/bridge/br_if.c === --- br-2.6.orig/net/bridge/br_if.c +++ br-2.6/net/bridge/br_if.c @@ -237,12 +237,11 @@ static int fin

[PATCH 01/15] bridge: remove unneeded bh disables

2006-03-13 Thread shemminger
The STP timers run off softirq (kernel timers), so there is no need to disable bottom half in the spin locks. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: br-2.6/net/bridge/br_stp_timer.c === --- br-2.6.orig/net/bridg

[PATCH 11/15] bridge: stp timer to jiffies cleanup

2006-03-13 Thread shemminger
Cleanup the get/set of bridge timer value in the packets. It is clearer not to bury the conversion in macro. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- br-2.6.orig/net/bridge/br_stp_bpdu.c +++ br-2.6/net/bridge/br_stp_bpdu.c @@ -19,8 +19,7 @@ #include "br_private.h" #include "br_

[PATCH 02/15] bridge: use setup_timer

2006-03-13 Thread shemminger
Use the now standard setup_timer function. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: br-2.6/net/bridge/br_stp_timer.c === --- br-2.6.orig/net/bridge/br_stp_timer.c +++ br-2.6/net/bridge/br_stp_timer.c @@ -144,39 +1

[PATCH 06/15] bridge: netfilter whitespace

2006-03-13 Thread shemminger
Run br_netfilter through Lindent to fix whitespace. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.17.orig/net/bridge/br_netfilter.c +++ net-2.6.17/net/bridge/br_netfilter.c @@ -136,7 +136,7 @@ static void __br_dnat_complain(void) if (jiffies - last_complaint >= 5 * H

[PATCH 07/15] bridge: netfilter dont use __constant_htons

2006-03-13 Thread shemminger
Only use__constant_htons() for initializers and switch cases. For other uses, it is just as efficient and clearer to use htons Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.17.orig/net/bridge/br_netfilter.c +++ net-2.6.17/net/bridge/br_netfilter.c @@ -61,14 +61,14 @@ static int

Re: Router stops routing after changing MAC Address

2006-03-13 Thread Randy.Dunlap
On Mon, 13 Mar 2006 15:27:26 -0500 linux-os \(Dick Johnson\) wrote: > > On Mon, 13 Mar 2006, Stephen Hemminger wrote: > > > There still is a bug in the 3c59x driver. It doesn't include any code > > to handle changing the mac address. It will work if you take the device > > down, change address

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread Stephen Hemminger
On Tue, 14 Mar 2006 07:43:57 +1000 Russell Stuart <[EMAIL PROTECTED]> wrote: > On Mon, 2006-03-13 at 10:04 -0800, Stephen Hemminger wrote: > > The memset fix is in current CVS. I just wasn't going to take the > > patch that looked at utsname to decide what hash to use. > > Stephen, could you desc

Re: Router stops routing after changing MAC Address

2006-03-13 Thread Rick Jones
> Anyway, if the device fails, you have routers and hosts ARPing the interface, trying to establish a route anyway. But only after what may be a much longer time than the customer is willing to accept or able to configure. I know of a number of HA situations where the "new" device is given t

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread Russell Stuart
On Mon, 2006-03-13 at 10:04 -0800, Stephen Hemminger wrote: > The memset fix is in current CVS. I just wasn't going to take the > patch that looked at utsname to decide what hash to use. Stephen, could you describe your objections to it please? - To unsubscribe from this list: send the line "uns

RE: Router stops routing after changing MAC Address

2006-03-13 Thread linux-os \(Dick Johnson\)
On Mon, 13 Mar 2006, Greg Scott wrote: > But in a failover scenario you want two devices to have the same IEEE > (station) Address (or MAC Address or hardware address). So many names > for the same thing! > > When the primary unit fails, you want the backup unit to completely > assume the failed

[-mm patch] make drivers/net/tg3.c:tg3_request_irq()

2006-03-13 Thread Adrian Bunk
On Sun, Mar 12, 2006 at 03:10:36AM -0800, Andrew Morton wrote: >... > Changes since 2.6.16-rc5-mm3: >... > git-net.patch >... > git trees >... This patch makes the needlessly global function tg3_request_irq() static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.16-rc6-mm1-fu

RE: Router stops routing after changing MAC Address

2006-03-13 Thread Greg Scott
But in a failover scenario you want two devices to have the same IEEE (station) Address (or MAC Address or hardware address). So many names for the same thing! When the primary unit fails, you want the backup unit to completely assume the failed unit's identity - right down to the MAC Address.

[PATCH] scm: fold __scm_send() into scm_send()

2006-03-13 Thread Ingo Oeser
From: Ingo Oeser <[EMAIL PROTECTED]> Fold __scm_send() into scm_send() and remove that interface completly from the kernel. Signed-off-by: Ingo Oeser <[EMAIL PROTECTED]> --- Inspired by the patch to inline scm_send() I did the next logical step :-) Regards Ingo Oeser diff --git a/include/net/s

Re: Router stops routing after changing MAC Address

2006-03-13 Thread linux-os \(Dick Johnson\)
On Mon, 13 Mar 2006, Stephen Hemminger wrote: > There still is a bug in the 3c59x driver. It doesn't include any code > to handle changing the mac address. It will work if you take the device > down, change address, then bring it up. But you shouldn't have to do that. > > Also, if the driver ha

Re: [PATCH] scm: fold __scm_send() into scm_send()

2006-03-13 Thread Benjamin LaHaise
On Mon, Mar 13, 2006 at 09:05:31PM +0100, Ingo Oeser wrote: > From: Ingo Oeser <[EMAIL PROTECTED]> > > Fold __scm_send() into scm_send() and remove that interface completly > from the kernel. Whoa, what are you doing here? Uninlining scm_send() is a Bad Thing to do given that scm_send() is in t

Re: drivers/net/chelsio/sge.c: two array overflows

2006-03-13 Thread Scott Bardone
Adrian, This is a bug. The array should contain 2 elements. Attached is a patch which fixes it. Thanks. Signed-off-by: Scott Bardone <[EMAIL PROTECTED]> Adrian Bunk wrote: The Coverity checker spotted the following two array overflows in drivers/net/chelsio/sge.c (in both cases, the arrays c

Re: [patch 1/4] natsemi: Add support for using MII port with no PHY

2006-03-13 Thread thockin
On Mon, Mar 13, 2006 at 06:23:31PM +, Mark Brown wrote: > On Sun, Mar 12, 2006 at 01:41:13PM -0800, [EMAIL PROTECTED] wrote: > > > Not that my opinion should hold much weight, having been absent from the > > driver for some time, but yuck. Is there no better way to do this thatn > > sprinklin

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread Patrick McHardy
Stephen Hemminger wrote: > The memset fix is in current CVS. I just wasn't going to take the > patch that looked at utsname to decide what hash to use. Yes, that sucks. We have another incompatibility, old iproute versions (like the one shipped by Debian) show garbage statistics for HFSC. I think

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread jamal
On Mon, 2006-13-03 at 18:55 +0100, Patrick McHardy wrote: > jamal wrote: > > Lets put it this way: > > The only you will _ever_ get that message is if you had made a syntax > > error (which you did not). Please look at the code on where that message > > appears and: > > > > a) tell me how you wou

Re: [Bugme-new] [Bug 6177] New: Java remote debugging is slow due to apparent networking bug

2006-03-13 Thread Rick Jones
S, since they know the length it means they know the data to send, which means there is no valid excuse for not sending all the data at one time - ie in one call to the transport. Their use of TCP_NODELAY was simply a kludge, and a massive one at that. I still think there are issues tryin

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread Patrick McHardy
Stephen Hemminger wrote: >>BTW, running valgrind on tc shows lots of uses of uninitialized values, >>it seems like a good idea if someone would go over these and fix them >>up. > > > If we had a test script of commands (code coverage), that would help. Actually the Coverity scanner is quite good

Re: [patch 1/4] natsemi: Add support for using MII port with no PHY

2006-03-13 Thread Mark Brown
On Sun, Mar 12, 2006 at 01:41:13PM -0800, [EMAIL PROTECTED] wrote: > Not that my opinion should hold much weight, having been absent from the > driver for some time, but yuck. Is there no better way to do this thatn > sprinkling poo all over it? The changes are mostly isolated into check_link(),

Re: [Bugme-new] [Bug 6177] New: Java remote debugging is slow due to apparent networking bug

2006-03-13 Thread Stephen Hemminger
On Mon, 13 Mar 2006 09:25:44 -0800 Rick Jones <[EMAIL PROTECTED]> wrote: > Eric Molitor wrote: > > You are correct, the format is as follows. > > > > Command Packet > > * Header > > o length (4 bytes) > > o id (4 bytes) > > o flags (1 byte) > >

Re: Router stops routing after changing MAC Address

2006-03-13 Thread Stephen Hemminger
There still is a bug in the 3c59x driver. It doesn't include any code to handle changing the mac address. It will work if you take the device down, change address, then bring it up. But you shouldn't have to do that. Also, if the driver handles setting mac address, it could have prevented you fr

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread Stephen Hemminger
On Mon, 13 Mar 2006 18:55:35 +0100 Patrick McHardy <[EMAIL PROTECTED]> wrote: > jamal wrote: > > On Mon, 2006-13-03 at 14:44 +1000, Russell Stuart wrote: > > > >>You are wrong on both counts. > > > > > > I am wrong on why it is being rejected - but what you are seeing is > > worse than i thoug

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread Patrick McHardy
jamal wrote: > On Mon, 2006-13-03 at 14:44 +1000, Russell Stuart wrote: > >>You are wrong on both counts. > > > I am wrong on why it is being rejected - but what you are seeing is > worse than i thought initially. > > Lets put it this way: > The only you will _ever_ get that message is if you

Re: [PATCH 5/6 v2] IB: IP address based RDMA connection manager

2006-03-13 Thread Roland Dreier
Sean> It's dropping the reference on cma_dev, as opposed to Sean> id_priv. Duh, sorry. - R. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Bugme-new] [Bug 6177] New: Java remote debugging is slow due to apparent networking bug

2006-03-13 Thread Rick Jones
Eric Molitor wrote: You are correct, the format is as follows. Command Packet * Header o length (4 bytes) o id (4 bytes) o flags (1 byte) o command set (1 byte) o command (1 byte) * data (Variable) Reply Packe

RE: Router stops routing after changing MAC Address

2006-03-13 Thread Greg Scott
HOT DOGGIES!! I think Chuck found the problem. It turns out that the OUI portion of the MAC Address - those leftmost 6 hex digits that identify the vendor - do also have some other special meaning built in. Chuck, I am indebted to you and the list. If the second hex digit is odd, this m

RE: [PATCH 5/6 v2] IB: IP address based RDMA connection manager

2006-03-13 Thread Sean Hefty
> > +static void cma_detach_from_dev(struct rdma_id_private *id_priv) > > +{ > > + list_del(&id_priv->list); > > + if (atomic_dec_and_test(&id_priv->cma_dev->refcount)) > > + wake_up(&id_priv->cma_dev->wait); > > + id_priv->cma_dev = NULL; > > +} > >doesn't need to do atomic_dec_and

[PATCH] [NET] : get rid of 'struct sec_path *' in skbuff if ! CONFIG_XFRM

2006-03-13 Thread Eric Dumazet
There is a strange glitch about secpath_put() and secpath_get() calls. secpath_put() is called from __kfree_skb() only if CONFIG_XFRM is defined. secpath_get() is called from skb_clone() and copy_skb_header() if CONFIG_INET is defined (!!!) I think the intention was to use CONFIG_XFRM everyw

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-13 Thread jamal
On Mon, 2006-13-03 at 14:44 +1000, Russell Stuart wrote: > On Sat, 2006-03-11 at 08:11 -0500, jamal wrote: > > > On my machine tc does not parse filter "sample" for the u32 > > > filter. Eg: > > > > > > tc filter add dev eth2 parent 1:0 protocol ip prio 1 u32 ht 801: \ > > > classid 1:3 \

Re: PKTGEN: Adds thread limit parameter.

2006-03-13 Thread akepner
On Mon, 13 Mar 2006, Luiz Fernando Capitulino wrote: BTW Robert, my TODO list for pktgen so far is: * A new command called 'rem_device' to remove one device at a time (currently, we can only remove all devices in one shoot with 'rem_devices_all') This should be very simple to i

Re: [UPDATED PATCH] Re: [Lse-tech] Re: [Patch 7/7] Generic netlink interface (delay accounting)

2006-03-13 Thread Balbir Singh
On Sat, Mar 11, 2006 at 08:30:49AM -0500, jamal wrote: > On Fri, 2006-10-03 at 22:09 +0530, Balbir Singh wrote: > > On Fri, Mar 10, 2006 at 09:53:53AM -0500, jamal wrote: > > > > On kernel->user (in the case of response to #a or async notifiation as > > > in #b) you really dont need to specify th

Re: [PATCH 5/6 v2] IB: IP address based RDMA connection manager

2006-03-13 Thread Roland Dreier
It seems that cma_detach_from_dev(): > +static void cma_detach_from_dev(struct rdma_id_private *id_priv) > +{ > +list_del(&id_priv->list); > +if (atomic_dec_and_test(&id_priv->cma_dev->refcount)) > +wake_up(&id_priv->cma_dev->wait); > +id_priv->cma_dev = NULL; > +}

Re: kmalloc_node returns unaligned memory

2006-03-13 Thread Jes Sorensen
> "Olaf" == Olaf Hering <[EMAIL PROTECTED]> writes: Olaf> kmalloc_node returns unaligned pointers on powerpc, when Olaf> CONFIG_DEBUG_SLAB is enabled. This makes iptables very Olaf> unhappy. It checks the alignment in Olaf> net/ipv6/netfilter/ip6_tables.c:check_entry_size_and_hooks(). Olaf> __

Re: GigE on PowerMac G5

2006-03-13 Thread Andreas Schwab
Andreas Schwab <[EMAIL PROTECTED]> writes: > Benjamin Herrenschmidt <[EMAIL PROTECTED]> writes: > >> At this point, all I can say is... does it work in OS X ? > > Strange, OS X can't do it either. Looks like I have a hardware problem. It turned out that one of the contacts in the RJ-45 jack was

Re: PKTGEN: Adds thread limit parameter.

2006-03-13 Thread Luiz Fernando Capitulino
On Mon, 13 Mar 2006 14:29:17 +0100 Robert Olsson <[EMAIL PROTECTED]> wrote: | | Luiz Fernando Capitulino writes: | | > Well, I wouldn't say it's _really_ needed. But it really avoids having | > too many thread entries in the pktgen's /proc directory, and as a good | > result, you will not ha

kmalloc_node returns unaligned memory

2006-03-13 Thread Olaf Hering
kmalloc_node returns unaligned pointers on powerpc, when CONFIG_DEBUG_SLAB is enabled. This makes iptables very unhappy. It checks the alignment in net/ipv6/netfilter/ip6_tables.c:check_entry_size_and_hooks(). __alignof__(struct ip6t_entry) returns 8. But returned pointers from xt_alloc_table_inf

Re: [Announce] Intel PRO/Wireless 3945ABG Network Connection

2006-03-13 Thread John W. Linville
On Sun, Mar 12, 2006 at 04:01:57PM -0800, David Rosky wrote: > (Telecommunications Certification Body).The FCC also maintains > a mechanism whereby certification-related questions can be asked > directly of them and whereby answers to previous questions can be Can you point me at this? What

Re: PKTGEN: Adds thread limit parameter.

2006-03-13 Thread Robert Olsson
Luiz Fernando Capitulino writes: > Well, I wouldn't say it's _really_ needed. But it really avoids having > too many thread entries in the pktgen's /proc directory, and as a good > result, you will not have pending threads which will never run as well. > > Also note that the patch is triv

Re: PKTGEN: Adds thread limit parameter.

2006-03-13 Thread Luiz Fernando Capitulino
Hi Robert, On Mon, 13 Mar 2006 10:44:49 +0100 Robert Olsson <[EMAIL PROTECTED]> wrote: | | Hello! | | Really needed? Well, I wouldn't say it's _really_ needed. But it really avoids having too many thread entries in the pktgen's /proc directory, and as a good result, you will not have pendi

RE: Router stops routing after changing MAC Address

2006-03-13 Thread Greg Scott
On eth0 - no. My "fudged" MAC Address is based on the IP Address. So 1.2.3.50 becomes 001.002.003.050, which turns into 00:10:02:00:30:50. But 1.2.3 is fake - it isn't the one I really use. The other one, 172.16.16.3 - that is a real IP Address that turns into 17:20:16:01:60:03. And here I thoug

Re: Possible bug in PFKEY implementation...

2006-03-13 Thread KOVACS Krisztian
Hi, On Sunday 12 March 2006 23.29, Stjepan Gros wrote: > setkey command behaves strangely when SPD is large. Either because I'm > doing something wrong or because there is a bug. I believe it's a bug, > but who knows... Anyway, after 529 items it simply stops displaying > items from SPD with a

[TCP]: Fix zero port problem in IPv6

2006-03-13 Thread Herbert Xu
Hi Dave: I was looking into the bug report titled [IPv6 since 2.6.12] connect() without bind() can't time out. There are actually a couple of different issues here. Here is a fix to the most obvious one. [TCP]: Fix zero port problem in IPv6 When we link a socket into the hash table, w

PKTGEN: Adds thread limit parameter.

2006-03-13 Thread Robert Olsson
Hello! Really needed? If so -- Wouldn't a concept of a bitmask to control also which CPU's that runs the threads be more general? Cheers. --ro Luiz Fernando Capitulino writes: > > Currently, pktgen will create one thread for each online CPU in the