[2.6 patch] schedule eepro100.c for removal

2006-01-17 Thread Adrian Bunk
On Tue, Jan 17, 2006 at 07:36:02PM -0500, Jeff Garzik wrote: > John W. Linville wrote: > >On Tue, Jan 17, 2006 at 02:27:16PM -0800, John Ronciak wrote: > > > > > >>Another thing is that removal of the driver (or disabling the config) > >>will hopefully force the issue in that people with these ARCH

Re: e1000 breakage in Jeff's tree

2006-01-17 Thread Jeff Garzik
Andrew Morton wrote: It'd be easier for me to just pull the bare patches out of git. But I haven't yet worked out how to persuade git to do that in a sane fashion (help) I use 'git-diff-tree -p $hash' Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

Re: e1000 breakage in Jeff's tree

2006-01-17 Thread Andrew Morton
Jeff Garzik <[EMAIL PROTECTED]> wrote: > > Andrew Morton wrote: > > The e1000 changes which popped up in Jeff's netdev tree today break the > > driver on my emt64 box. There's no real sign of damage apart from the fact > > that it simply won't send stuff. > > > > e1000: :01:02.0: e1000_probe:

Re: [PATCH 2/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Arjan van de Ven
> > > Also should infiniband exports be EXPORT_SYMBOL_GPL, to make > it clear that binary drivers for this are not allowed?? > the dual license text needs a bit of clarification I suspect to make explicit that the "or BSD" part only applies when used entirely outside the linux kernel. (that al

Re: e1000 breakage in Jeff's tree

2006-01-17 Thread Jeff Garzik
Andrew Morton wrote: The e1000 changes which popped up in Jeff's netdev tree today break the driver on my emt64 box. There's no real sign of damage apart from the fact that it simply won't send stuff. e1000: :01:02.0: e1000_probe: (PCI:33MHz:32-bit) 00:0e:0c:2f:2c:c1 e1000: eth0: e1000_prob

e1000 breakage in Jeff's tree

2006-01-17 Thread Andrew Morton
The e1000 changes which popped up in Jeff's netdev tree today break the driver on my emt64 box. There's no real sign of damage apart from the fact that it simply won't send stuff. e1000: :01:02.0: e1000_probe: (PCI:33MHz:32-bit) 00:0e:0c:2f:2c:c1 e1000: eth0: e1000_probe: Intel(R) PRO/1000 N

Re: net 2.6.16-rc1: multiple ipv6 failures

2006-01-17 Thread David S. Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 17 Jan 2006 21:39:20 -0500 > 2) bind fails (which everyone on my network immediately noticed, and > complained about). > > > Jan 17 21:29:04 pretzel named[5110]: loading configuration from > > '/etc/named.conf' > > Jan 17 21:29:04 pretzel named[51

Re: [PATCH 1/1] double xfrm_state_put bug fix

2006-01-17 Thread James Morris
On Tue, 17 Jan 2006, David S. Miller wrote: > From: James Morris <[EMAIL PROTECTED]> > Date: Tue, 17 Jan 2006 21:27:05 -0500 (EST) > > > This is confusing code, how about a comment? > > There is a big comment in __xfrm_state_delete(), would you like > something more? :-) No, my fault. - James

Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context

2006-01-17 Thread Patrick McHardy
John W. Linville wrote: On Wed, Jan 18, 2006 at 02:46:36AM +0100, Patrick McHardy wrote: According to Patrick McHardy, the other dev_kfree_skb change is no longer required. Perhaps Patrick will comment? The second dev_kfree_skb is outside the interrupt-disabled section, so using dev_kfree_sk

Re: [PATCH 1/1] double xfrm_state_put bug fix

2006-01-17 Thread Catherine Zhang
This is much better. Sorry for the confusion. With a clear comment like this, I don't think it'll happen again. thanks, Catherine On 1/17/06, Herbert Xu <[EMAIL PROTECTED]> wrote: > On Tue, Jan 17, 2006 at 06:29:26PM -0800, David S. Miller wrote: > > > > There is a big comment in __xfrm_state_d

Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context

2006-01-17 Thread John W. Linville
On Wed, Jan 18, 2006 at 02:46:36AM +0100, Patrick McHardy wrote: > John W. Linville wrote: > >On Tue, Jan 17, 2006 at 07:17:55PM +0100, Roger While wrote: > > > >>I am going to NACK this. > >>Two reasons : > >>1) Unless we are patching different trees, it appears > >>the dev_kfree_skb at label drop

Re: [PATCH 1/1] double xfrm_state_put bug fix

2006-01-17 Thread Herbert Xu
On Tue, Jan 17, 2006 at 06:29:26PM -0800, David S. Miller wrote: > > There is a big comment in __xfrm_state_delete(), would you like > something more? :-) How about something like this? This should make someone think twice before treating it as a duplicate. [IPSEC]: Turn first xfrm_state_put int

Re: net 2.6.16-rc1: multiple ipv6 failures

2006-01-17 Thread Patrick McHardy
Jeff Garzik wrote: Just moved my firewall/gateway from 2.6.15 to 2.6.16-rc1, and had a couple IPv6-related problems really bite me. The fix just went in Linus' tree ([IPV6]: Preserve procfs IPV6 address output format). - To unsubscribe from this list: send the line "unsubscribe netdev" in the

net 2.6.16-rc1: multiple ipv6 failures

2006-01-17 Thread Jeff Garzik
Just moved my firewall/gateway from 2.6.15 to 2.6.16-rc1, and had a couple IPv6-related problems really bite me. 1) radvd runs at 100% CPU (CentOS 4 userland, 2.6.15 worked fine). I had to kill it. Jan 17 21:24:43 pretzel ifup: done. Jan 17 21:24:44 pretzel ifup: radvd control enabled, but c

Re: [PATCH] Remove MANY unneeded header files in net/core/filter.c

2006-01-17 Thread Kris Katterjohn
From: David S. Miller Sent: 1/17/2006 3:18:08 PM > From: "Kris Katterjohn" <[EMAIL PROTECTED]> > Date: Tue, 17 Jan 2006 09:03:22 -0800 > > > Are there any headers I'm deleting that _should_ be there, but not > > necessarily required for a clean compilation? If so, let me know and > > I'll redo the

[PATCH RESEND 0/6] e1000: driver udpate

2006-01-17 Thread Jeff Kirsher
Made the suggested changes to the disable packet split patch. These were diff'd with Garzik's latest upstream branch. The following series implements... 1. Added disable packet split capability (as a CONFIG option) 2. Added RX buffer enhancements 3. Added functions to save and restore config 4.

[PATCH RESEND 6/6] e1000: Added driver comments

2006-01-17 Thread Jeff Kirsher
Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 72 +--- 1 files changed, 67 insertions(+), 5 deletions(-) diff --git a

[PATCH RESEND 2/6] e1000: Added RX buffer enhancements

2006-01-17 Thread Jeff Kirsher
Align the prefetches to a dword to help speed them up. Recycle skb's and early replenish. Force memory writes to complete before fetching more descriptors. Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTEC

Re: [PATCH 1/1] double xfrm_state_put bug fix

2006-01-17 Thread David S. Miller
From: James Morris <[EMAIL PROTECTED]> Date: Tue, 17 Jan 2006 21:27:05 -0500 (EST) > This is confusing code, how about a comment? There is a big comment in __xfrm_state_delete(), would you like something more? :-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

[PATCH RESEND 3/6] e1000: Added functions to save and restore config

2006-01-17 Thread Jeff Kirsher
These functions help restore the driver to active configuration when coming out of resume for power management. Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c

[PATCH RESEND 1/6] e1000: Added disable packet split capability

2006-01-17 Thread Jeff Kirsher
Adds the ability to disability packet split at compile time and use the legacy receive path on PCI express hardware. Made this a CONFIG option and modified the Kconfig, to reflect the new option. Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]>

[PATCH RESEND 4/6] e1000: Added functions declarations

2006-01-17 Thread Jeff Kirsher
Added e1000_mc_addr_list_update Added e1000_read_reg_io Added e1000_enable_pciex_master These are not static functions, that is why we have them declared in the header. Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: John Ronciak

Re: [PATCH 1/1] double xfrm_state_put bug fix

2006-01-17 Thread James Morris
On Wed, 18 Jan 2006, Herbert Xu wrote: > cxzhang <[EMAIL PROTECTED]> wrote: > > > > Fix for a minor double xfrm_state_put() bug. > > This is bogus. It takes two puts to really kill the state. The > same thing happens in xfrm_user of course. This is confusing code, how about a comment? - Jam

Re: [openib-general] RE: [PATCH 2/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Grant Grundler
On Tue, Jan 17, 2006 at 03:24:37PM -0800, Sean Hefty wrote: > +static void cm_mask_compare_data(u8 *dst, u8 *src, u8 *mask) > +{ > + int i; > + > + for (i = 0; i < IB_CM_PRIVATE_DATA_COMPARE_SIZE; i++) > + dst[i] = src[i] & mask[i]; > +} Is this code going to get invoked very o

Re: IPSEC Offload

2006-01-17 Thread Dave Dillow
On Tue, 2006-01-17 at 15:01 -0800, David S. Miller wrote: > From: Dave Dillow <[EMAIL PROTECTED]> > Date: Tue, 17 Jan 2006 16:25:57 -0500 > > > In that case, I'll blow the dust off and try to make it sooner > > rather than later. > > Please take your time with it. 2.6.16 feature window has close

Re: [PATCH 1/1] double xfrm_state_put bug fix

2006-01-17 Thread Herbert Xu
cxzhang <[EMAIL PROTECTED]> wrote: > > Fix for a minor double xfrm_state_put() bug. This is bogus. It takes two puts to really kill the state. The same thing happens in xfrm_user of course. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>

Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context

2006-01-17 Thread Patrick McHardy
John W. Linville wrote: On Tue, Jan 17, 2006 at 07:17:55PM +0100, Roger While wrote: I am going to NACK this. Two reasons : 1) Unless we are patching different trees, it appears the dev_kfree_skb at label drop_free got missed. http://marc.theaimsgroup.com/?l=linux-netdev&m=113629395408219&w=

Re: [PATCH 1/1] double xfrm_state_put bug fix

2006-01-17 Thread Patrick McHardy
cxzhang wrote: Fix for a minor double xfrm_state_put() bug. Both xfrm_state_put's are needed, explanation copied from http://oss.sgi.com/projects/netdev/archive/2005-05/msg00361.html: We hold two references (one from xfrm_state_alloc(), one from xfrm_state_hold()), but only drop one. We need

Re: [PATCH 1/1] double xfrm_state_put bug fix

2006-01-17 Thread James Morris
On Tue, 17 Jan 2006, cxzhang wrote: > > Fix for a minor double xfrm_state_put() bug. > > --- > > net/key/af_key.c |1 - > 1 files changed, 1 deletion(-) > > diff -puN net/key/af_key.c~bugfix net/key/af_key.c > --- linux-2.6.15/net/key/af_key.c~bugfix2006-01-17 19:47:20.280890504 > -

Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context

2006-01-17 Thread John W. Linville
On Tue, Jan 17, 2006 at 07:17:55PM +0100, Roger While wrote: > I am going to NACK this. > Two reasons : > 1) Unless we are patching different trees, it appears > the dev_kfree_skb at label drop_free got missed. http://marc.theaimsgroup.com/?l=linux-netdev&m=113629395408219&w=2 According to Patric

[GIT PATCHES] TIPC fixes

2006-01-17 Thread Per Liden
Dave, Here is a set of patches in response to the initial criticism/comments that TIPC received. The reason why these patches touch so many files is the fix to avoid namespace pullution. Please see diffstat and commit log below. Please pull from: git://tipc.cslab.ericsson.net/pub/git/

Re: [PATCH] skge: fix dma mask setup.

2006-01-17 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/12] sky2: receive buffer alignment

2006-01-17 Thread Jeff Garzik
Stephen Hemminger wrote: Need to make sure that sky2 receive buffers are 64 bit aligned. Also, don't need to start off with GFP_ATOMIC on initial setup. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied 1-12 - To unsubscribe from this list: send the line "unsubscribe netdev" in th

Re: [RFC: 2.6 patch] remove drivers/net/eepro100.c

2006-01-17 Thread Jeff Garzik
John W. Linville wrote: On Tue, Jan 17, 2006 at 02:27:16PM -0800, John Ronciak wrote: Another thing is that removal of the driver (or disabling the config) will hopefully force the issue in that people with these ARCHs will use the e100 and if they have problems we can get them fixed in the e1

[PATCH 1/1] double xfrm_state_put bug fix

2006-01-17 Thread cxzhang
Fix for a minor double xfrm_state_put() bug. --- net/key/af_key.c |1 - 1 files changed, 1 deletion(-) diff -puN net/key/af_key.c~bugfix net/key/af_key.c --- linux-2.6.15/net/key/af_key.c~bugfix2006-01-17 19:47:20.280890504 -0500 +++ linux-2.6.15-cxzhang/net/key/af_key.c 2006

Re: [RFC: 2.6 patch] remove drivers/net/eepro100.c

2006-01-17 Thread John W. Linville
On Tue, Jan 17, 2006 at 02:27:16PM -0800, John Ronciak wrote: > Another thing is that removal of the driver (or disabling the config) > will hopefully force the issue in that people with these ARCHs will > use the e100 and if they have problems we can get them fixed in the > e100 driver. At this

Re: [PATCH RESEND netdev-2.6 1/3] e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue)

2006-01-17 Thread Jeff Garzik
Jesse Brandeburg wrote: e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue) Set the end of list bit to cause the hardware's transmit state machine to work correctly and not prevent management (BMC) traffic. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by:

Re: [PATCH ] ethtool: Remove duplex info from CTRL register dump

2006-01-17 Thread Jeff Garzik
cramerj wrote: applied, after replacing "ethtool:" with "e1000:" in the subject line. Even if it's modifying the ethtool app? As long as it doesn't confuse your scripts, I suppose. ethtool is a separate project. Since the email contents are copied into the ethtool project changelog, havin

Re: wireless: recap of current issues (stack)

2006-01-17 Thread Chase Venters
On Tuesday 17 January 2006 12:37, Jirka Bohac wrote: > At the present time, the ieee80211 stack is used by ipw2x00 > (heavily) and hostap (a little bit). Other mainline drivers only use > headers (mainly constants). > > If it shows that the DeviceScape stack is more mature and > appropriate (which

Re: R8169 driver & Netgear GA511 NIC - soft lockup/hang in rtl8169_phy_timer

2006-01-17 Thread Francois Romieu
Russell Steinthal <[EMAIL PROTECTED]> : [...] > Thanks again for the help --- if you have any other ideas or things > you'd like me to test, let me know. I am probably not searching in the right direction. :o/ CONFIG_LOG_BUF_SHIFT=14 -> Please make it 17, your dmesg are trimmed. # CONFIG_PRINTK

RE: [PATCH 2/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Sean Hefty
>> +static void cm_mask_compare_data(u8 *dst, u8 *src, u8 *mask) > >static void cm_mask_compare_data(u8 *dst, const u8 *src, u8 *mask) > >but I would rename it to cm_mask_copy since it doesn't really do a compare. I'll change this. The function is masking the "data to use in the comparison", but

[PATCH 5/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Sean Hefty
This patch adds the kernel component to support the userspace Infiniband/RDMA connection agent library. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> --- diff -uprN -X linux-2.6.git/Documentation/dontdiff linux-2.6.git/drivers/infiniband/core/Makefile linux-2.6.ib/drivers/infiniband/core/Makef

Re: [PATCH 2/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Stephen Hemminger
Minor nits. On Tue, 17 Jan 2006 15:24:37 -0800 "Sean Hefty" <[EMAIL PROTECTED]> wrote: > The following patch extends matching connection requests to listens in the > Infiniband CM to include private data. > > Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> > > --- > +static void cm_mask_compare_

Re: [GIT PATCHES] SCTP bugfixes for 2.6.16

2006-01-17 Thread David S. Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Tue, 17 Jan 2006 15:20:50 -0800 > Please pull the following SCTP bugfixes from >master.kernel.org:/pub/scm/linux/kernel/git/sridhar/lksctp-2.6.git Looks good. Pulled, thanks Sridhar. - To unsubscribe from this list: send the line "unsubscribe

[PATCH 4/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Sean Hefty
The following patch implements a kernel mode connection management agent over Infiniband that connects based on IP addresses. The agent defines a generic RDMA connection abstraction to support clients wanting to connect over different RDMA devices. It also handles RDMA device hotplug events on be

Re: wireless: recap of current issues (other issues / fake ethernet)

2006-01-17 Thread Stefan Rompf
Am Sonntag 15 Januar 2006 16:39 schrieb Stuffed Crust: > Internally, we're pure 802.11. One thing to keep in mind that we're not > going to be bridging/translating non-data traffic to other networks, and > with that in mind, 802.3<->802.11 translation is trivial, and won't lose > anything except

[PATCH 3/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Sean Hefty
The following provides an address translation service that maps IP addresses to Infiniband addresses (GIDs) using IPoIB. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> --- diff -uprN -X linux-2.6.git/Documentation/dontdiff linux-2.6.git/drivers/infiniband/core/addr.c linux-2.6.ib/drivers/infini

RE: [PATCH 2/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Sean Hefty
The following patch extends matching connection requests to listens in the Infiniband CM to include private data. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> --- diff -uprN -X linux-2.6.git/Documentation/dontdiff linux-2.6.git/drivers/infiniband/core/cm.c linux-2.6.ib/drivers/infiniband/core

[PATCH 1/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Sean Hefty
The following patch provides common handling for marshalling data between userspace clients and kernel mode Infiniband drivers. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> --- diff -uprN -X linux-2.6.git/Documentation/dontdiff linux-2.6.git/drivers/infiniband/core/Makefile linux-2.6.ib/drive

[GIT PATCHES] SCTP bugfixes for 2.6.16

2006-01-17 Thread Sridhar Samudrala
Dave, Please pull the following SCTP bugfixes from master.kernel.org:/pub/scm/linux/kernel/git/sridhar/lksctp-2.6.git Thanks Sridhar include/net/sctp/sctp.h|2 + include/net/sctp/structs.h | 89 +--- net/sctp/input.c | 73

Re: [PATCH] Remove MANY unneeded header files in net/core/filter.c

2006-01-17 Thread David S. Miller
From: "Kris Katterjohn" <[EMAIL PROTECTED]> Date: Tue, 17 Jan 2006 09:03:22 -0800 > Are there any headers I'm deleting that _should_ be there, but not > necessarily required for a clean compilation? If so, let me know and > I'll redo the patch. If the build still works, that doesn't mean much :-)

Re: [PATCH] Use is_zero_ether_addr() in net/core/netpoll.c

2006-01-17 Thread David S. Miller
From: "Kris Katterjohn" <[EMAIL PROTECTED]> Date: Tue, 17 Jan 2006 13:51:11 -0800 > This replaces a memcmp() with is_zero_ether_addr(). > > Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Applied, thanks Kris. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: NIP6_FMT "breaks" ifconfig

2006-01-17 Thread Kumar Gala
On Jan 17, 2006, at 5:05 PM, David S. Miller wrote: From: Kumar Gala <[EMAIL PROTECTED]> Date: Tue, 17 Jan 2006 16:35:01 -0600 The use of NIP6_FMT from kernel.h in net/ipv6/addrconf.c changes how / proc/net/if_inet6 format's IPv6 addresses and thus breaks ifconfig's ability to display IPv6

[PATCH 0/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Sean Hefty
The following set of patches defines a connection abstraction for Infiniband and other RDMA devices, and serves several purposes: * It implements a connection protocol over Infiniband based on IP addressing. This greatly simplifies clients wishing to establish connections over Infiniband. * It de

Re: TIPC needs some cleanup

2006-01-17 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 17 Jan 2006 15:04:34 -0800 > Also, let's work with the current code. It is a lot easier to let > others clean it up, if the changes are against the mainline (or -mm) > rather than having to send it off to get put into yet another git > repo.

Re: TIPC needs some cleanup

2006-01-17 Thread Stephen Hemminger
On Tue, 17 Jan 2006 14:55:10 -0800 (PST) "David S. Miller" <[EMAIL PROTECTED]> wrote: > From: Andi Kleen <[EMAIL PROTECTED]> > Date: Tue, 17 Jan 2006 21:42:38 +0100 > > > On Tuesday 17 January 2006 21:31, jamal wrote: > > > > > the TIPC tree has been open for months now for review. > > > > Tha

Re: NIP6_FMT "breaks" ifconfig

2006-01-17 Thread David S. Miller
From: Kumar Gala <[EMAIL PROTECTED]> Date: Tue, 17 Jan 2006 16:35:01 -0600 > The use of NIP6_FMT from kernel.h in net/ipv6/addrconf.c changes how / > proc/net/if_inet6 format's IPv6 addresses and thus breaks ifconfig's > ability to display IPv6 addresses. I'm not sure if this is > acceptable

[PATCH RESEND netdev-2.6 0/3] e100: driver updates

2006-01-17 Thread Jesse Brandeburg
I'm actually getting better at this, really, no, really... This patch set is against linus-2.6 repository updated today e100 driver update 1. Fix TX hang and RMCP Ping issue (due to a microcode loading issue) 2. Handle the return values from pci_* functions 3. e100 whitespace fixes - To unsubscr

[PATCH RESEND netdev-2.6 2/3] e100: Handle the return values from pci_* functions

2006-01-17 Thread Jesse Brandeburg
e100: Handle the return values from pci_* functions This is to resolve warnings during compile time. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/e100.c | 30 +++

[PATCH RESEND netdev-2.6 1/3] e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue)

2006-01-17 Thread Jesse Brandeburg
e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue) Set the end of list bit to cause the hardware's transmit state machine to work correctly and not prevent management (BMC) traffic. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Jeff Kirsher <[EMAIL PROT

[PATCH RESEND netdev-2.6 3/3] e100: e100 whitespace fixes

2006-01-17 Thread Jesse Brandeburg
e100: e100 whitespace fixes These are whitespace only fixes. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> --- drivers/net/e100.c | 74 ++-- 1

Re: IPSEC Offload

2006-01-17 Thread David S. Miller
From: Dave Dillow <[EMAIL PROTECTED]> Date: Tue, 17 Jan 2006 16:25:57 -0500 > In that case, I'll blow the dust off and try to make it sooner > rather than later. Please take your time with it. 2.6.16 feature window has closed and 2.6.17 is at least a month or two away. - To unsubscribe from this

Re: TIPC needs some cleanup

2006-01-17 Thread David S. Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Tue, 17 Jan 2006 21:42:38 +0100 > On Tuesday 17 January 2006 21:31, jamal wrote: > > > the TIPC tree has been open for months now for review. > > That is not how Linux code review works - the code is supposed to get posted > to the appropiate mailing l

RE: [PATCH ] ethtool: Remove duplex info from CTRL register dump

2006-01-17 Thread cramerj
> > applied, after replacing "ethtool:" with "e1000:" in the subject line. Even if it's modifying the ethtool app? As long as it doesn't confuse your scripts, I suppose. -Jeb - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More m

Re: wireless: recap of current issues (stack)

2006-01-17 Thread Stefan Rompf
Am Dienstag 17 Januar 2006 19:37 schrieb Jirka Bohac: > - DeviceScape can be there so it can be polished and new drivers can > start using it. > - ieee80211 could be there with a big fat warning that it will go > away soon, just to allow ipw2x00 to work while DeviceScape and > the ipw2x00 po

NIP6_FMT "breaks" ifconfig

2006-01-17 Thread Kumar Gala
The use of NIP6_FMT from kernel.h in net/ipv6/addrconf.c changes how / proc/net/if_inet6 format's IPv6 addresses and thus breaks ifconfig's ability to display IPv6 addresses. I'm not sure if this is acceptable breakage of a userspace app or not. - kumar - To unsubscribe from this list: send

Re: [RFC: 2.6 patch] remove drivers/net/eepro100.c

2006-01-17 Thread John Ronciak
We don't of any problems reported against e100 that have not been talked about in this thread (in old ARCH types). I think the eepro100 driver should be removed from the config "just in case" but we are in full support of the e100 driver and if somebody says that it's not working on one of the dif

Re: State of the Union: Wireless / 802.11 master device

2006-01-17 Thread Stephen Hemminger
On Tue, 17 Jan 2006 23:16:43 +0100 Stefan Rompf <[EMAIL PROTECTED]> wrote: > Am Dienstag 17 Januar 2006 20:42 schrieb Jouni Malinen: > > > Sure, you can do it that way, too. However, this is not the only use. I > > just remembered another one: QoS. Devicescape 802.11 code uses a qdisc > > on the

Re: wireless: recap of current issues (configuration)

2006-01-17 Thread Stefan Rompf
Am Sonntag 15 Januar 2006 21:11 schrieb Johannes Berg: > [iwconfig mode ...] > > Yeah, I agree with this, it is much cleaner to handle in the kernel. > Think about the issues if you have a struct net_device that has 250 > bytes of "payload" for the struct virtual_sta_device in it and you want > to

Re: State of the Union: Wireless / 802.11 master device

2006-01-17 Thread Stefan Rompf
Am Dienstag 17 Januar 2006 20:42 schrieb Jouni Malinen: > Sure, you can do it that way, too. However, this is not the only use. I > just remembered another one: QoS. Devicescape 802.11 code uses a qdisc > on the master interface to take care of determining which hardware TX > queue to use with WMM

[PATCH 05/12] sky2: write barrier's

2006-01-17 Thread Stephen Hemminger
Be more careful about memory barriers. The only place we really need them is before and after updating the chip's ring interface. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-2.6.orig/drivers/net/sky2.c +++ sky2-2.6/drivers/net/sky2.c @@ -707,6 +707,7 @@ static inline struct sky

[PATCH 07/12] sky2: optimize for 32 bit dma

2006-01-17 Thread Stephen Hemminger
Small optimization, if dma addresses are 32 bits, then high bits are always zero. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-2.6.orig/drivers/net/sky2.c +++ sky2-2.6/drivers/net/sky2.c @@ -745,7 +745,7 @@ static inline struct sky2_rx_le *sky2_ne /* Return high part of DMA add

[PATCH 10/12] sky2: don't inline so much

2006-01-17 Thread Stephen Hemminger
Don't need to inline quite so many routines, let the compiler decide Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-2.6.orig/drivers/net/sky2.c +++ sky2-2.6/drivers/net/sky2.c @@ -704,7 +704,7 @@ static inline struct sky2_tx_le *get_tx_ * This is a workaround code taken from SysK

[PATCH 02/12] sky2: call pci_set_consistent_dma_mask

2006-01-17 Thread Stephen Hemminger
Need to call pci_set_consistent_dma_mask in the case of 64 bit DMA. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- netdev-2.6.orig/drivers/net/sky2.c +++ netdev-2.6/drivers/net/sky2.c @@ -3054,13 +3054,17 @@ static int __devinit sky2_probe(struct p goto err_out_free_reg

[PATCH 12/12] sky2: 0.13 version

2006-01-17 Thread Stephen Hemminger
--- sky2-git.orig/drivers/net/sky2.c +++ sky2-git/drivers/net/sky2.c @@ -57,7 +57,7 @@ #include "sky2.h" #define DRV_NAME "sky2" -#define DRV_VERSION"0.12" +#define DRV_VERSION"0.13" #define PFXDRV_NAME " " /* -- Stephen Hemminger <

[PATCH 03/12] sky2: version 0.12

2006-01-17 Thread Stephen Hemminger
Version update. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- netdev-2.6.orig/drivers/net/sky2.c +++ netdev-2.6/drivers/net/sky2.c @@ -57,7 +57,7 @@ #include "sky2.h" #define DRV_NAME "sky2" -#define DRV_VERSION"0.11" +#define DRV_VERSION"0.12"

[PATCH 06/12] sky2: don't bother clearing status ring elements

2006-01-17 Thread Stephen Hemminger
Don't need to zero out the status ring entries after processing. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-2.6.orig/drivers/net/sky2.c +++ sky2-2.6/drivers/net/sky2.c @@ -1825,7 +1825,6 @@ static int sky2_poll(struct net_device * struct sk_buff *skb;

[PATCH 01/12] sky2: receive buffer alignment

2006-01-17 Thread Stephen Hemminger
Need to make sure that sky2 receive buffers are 64 bit aligned. Also, don't need to start off with GFP_ATOMIC on initial setup. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- netdev-2.6.orig/drivers/net/sky2.c +++ netdev-2.6/drivers/net/sky2.c @@ -75,6 +75,7 @@ #define RX_LE_BYTES

[PATCH 08/12] sky2: ratelimit error messages

2006-01-17 Thread Stephen Hemminger
Make sure and rate limit all the error messages that might occur. If a problem occurs then a few messages are enough. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-2.6.orig/drivers/net/sky2.c +++ sky2-2.6/drivers/net/sky2.c @@ -92,7 +92,7 @@ static const u32 default_msg = N

[PATCH 09/12] sky2: use kzalloc

2006-01-17 Thread Stephen Hemminger
Can use kzalloc here. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-2.6.orig/drivers/net/sky2.c +++ sky2-2.6/drivers/net/sky2.c @@ -3099,14 +3099,13 @@ static int __devinit sky2_probe(struct p #endif err = -ENOMEM; - hw = kmalloc(sizeof(*hw), GFP_KERNEL); +

[PATCH 04/12] sky2: fix ram buffer for Yukon FE rev 2

2006-01-17 Thread Stephen Hemminger
Fix problems with Yukon FE rev 2 chipset. Don't cut and paste bugs in from sk98lin driver. Change how the ram buffer is divided up, and make the math clearer. Also, set the thresholds where rx takes precedence. The threshold values are just guesses at this point, it might be worth tuning them later

[PATCH 11/12] sky2: more conservative transmit locking

2006-01-17 Thread Stephen Hemminger
Be more careful about transmit locking, this solves a possible race between tx_complete and transmit, that would cause a tx timeout. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-git.orig/drivers/net/sky2.c +++ sky2-git/drivers/net/sky2.c @@ -889,13 +889,13 @@ static void sky2_vla

[PATCH 00/12] sky2:

2006-01-17 Thread Stephen Hemminger
Updates to sky2 driver (based on 2.6.16-rc1). Includes previously posted 0.12 patches, which Jeff hasn't merged yet... The most important fixes are: * ram buffer initialization for Yukon FE revision A3 (88E8053) * race in transmit locking -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://

[Patch 2.6.15] starfire: Implement suspend/resume

2006-01-17 Thread Stefan Rompf
This patch implements suspend and resume methods for the starfire driver. It allows me to put my desktop PC with a starfire dual board into S4. Signed-Off-By: Stefan Rompf <[EMAIL PROTECTED]> --- linux-2.6.15/drivers/net/starfire.c.orig2006-01-04 01:01:18.0 +0100 +++ linux-2.6.15/dri

[PATCH] Use is_zero_ether_addr() in net/core/netpoll.c

2006-01-17 Thread Kris Katterjohn
This replaces a memcmp() with is_zero_ether_addr(). Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Thanks! --- x/net/core/netpoll.c2006-01-17 08:25:32.0 -0600 +++ y/net/core/netpoll.c2006-01-17 15:45:01.0 -0600 @@ -703,7 +703,7 @@ int netpoll_setup(struct netp

Re: IPSEC Offload

2006-01-17 Thread Dave Dillow
On Tue, 2006-01-17 at 13:16 -0800, David S. Miller wrote: > From: Dave Dillow <[EMAIL PROTECTED]> > Date: Tue, 17 Jan 2006 11:45:04 -0500 > > > Would this still be interesting to anyone? If I can get a good > > framework in place, maybe we can get Intel to open up their cards to > > work with it a

Re: IPSEC Offload

2006-01-17 Thread David S. Miller
From: Dave Dillow <[EMAIL PROTECTED]> Date: Tue, 17 Jan 2006 11:45:04 -0500 > Would this still be interesting to anyone? If I can get a good > framework in place, maybe we can get Intel to open up their cards to > work with it as well. I feel like support for this is inevitable, personally. It's

Re: [PATCH] Replacing with (compare|is_zero)_ether_addr() and ETH_ALEN in pktgen.c

2006-01-17 Thread David S. Miller
From: "Kris Katterjohn" <[EMAIL PROTECTED]> Date: Sun, 15 Jan 2006 19:50:47 -0800 > This replaces some tests with is_zero_ether_addr(), memcmp(one, two, 6) with > compare_ether_addr(one, two), and 6 with ETH_ALEN where appropriate. > > Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Applied,

Re: [EBTABLES]: Handle SCTP/DCCP in ebt_{ip,log}

2006-01-17 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 12 Jan 2006 06:53:57 +0100 > This patch adds SCTP/DCCP support to ebt_ip.c and ebt_log.c. The > ebt_ipt.c change needs a userspace change as well, this is the > second attached patch. Kernel side applied, thanks Patrick. - To unsubscribe from t

Re: [PKT_SCHED]: Handle SCTP/DCCP in sfq_hash

2006-01-17 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 12 Jan 2006 06:53:01 +0100 > Handle SCTP/DCCP in sfq_hash to make it recognize seperate connections. Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordo

Re: State of the Union: Wireless / 802.11 master device

2006-01-17 Thread Jouni Malinen
On Tue, Jan 17, 2006 at 02:55:31PM -0500, jamal wrote: > On Tue, 2006-17-01 at 11:42 -0800, Jouni Malinen wrote: > so if i understood correctly: > You have a master netdevice which underneath it has child netdevices? I'm not sure what exactly "child netdev" means, but it sounds like something tha

Re: TIPC needs some cleanup

2006-01-17 Thread Andi Kleen
On Tuesday 17 January 2006 21:31, jamal wrote: > The decision was made at netconf and announcements were made in the > kernel summit That's the famous "smoke filled backrooms" where Linux development shouldn't happen. > the TIPC tree has been open for months now for review. That is not how Lin

Re: TIPC needs some cleanup

2006-01-17 Thread jamal
On Tue, 2006-17-01 at 21:18 +0100, Andi Kleen wrote: > That is what we have code reviews for - to tell you > about such things - but somehow you seem to have sneaked your code > around that. > That sounds a little harsh Andi and i know you are a much bigger boy than you sound above. The decisio

[PATCH 1/1] LSM-IPsec SELinux Authorize (with fixes)

2006-01-17 Thread cxzhang
Minor fixes, per James' comment. thanks, Catherine This patch contains a fix for the previous patch that adds security contexts to IPsec policies and security associations. In the previous patch, no authorization (besides the check for write permissions to SAD and SPD) is required to delete

Re: TIPC needs some cleanup

2006-01-17 Thread Andi Kleen
On Tuesday 17 January 2006 16:04, Jon Maloy wrote: > There are two good reasons (exuses?) for this: First, the dbg.c code was > written well before relayfs, so for natural reasons we could not > consider it back then. Second, at least I wasn't aware of relayfs until > recently, and I am still no

RE: State of the Union: Wireless

2006-01-17 Thread Simon Barber
To do qos properly there needs to be a single net_device that a single qdisc can be installed on - this alone is a good reason for a master net_device. (there must be a single 802.11 qdisc for a single physical piece of hardware). Here is another reason (for hardware devices that do not include a M

Re: TIPC needs some cleanup

2006-01-17 Thread Jon Maloy
There are two good reasons (exuses?) for this: First, the dbg.c code was written well before relayfs, so for natural reasons we could not consider it back then. Second, at least I wasn't aware of relayfs until recently, and I am still not sure if and how much the functionalities overlap. Now t

Re: wireless: recap of current issues (stack)

2006-01-17 Thread Olivier Blin
Jean Tourrilhes <[EMAIL PROTECTED]> writes: >> Please consider this page about drakroam and net_applet as well: >> http://qa.mandriva.com/twiki/bin/view/Main/EasyWifi > > NetApplet was already on my page, but thanks to you I've > checked it and it's now 404. Well, assuming your netapplet is

Re: State of the Union: Wireless / 802.11 master device

2006-01-17 Thread jamal
On Tue, 2006-17-01 at 11:42 -0800, Jouni Malinen wrote: > > Sure, you can do it that way, too. However, this is not the only use. I > just remembered another one: QoS. Devicescape 802.11 code uses a qdisc > on the master interface to take care of determining which hardware TX > queue to use with

Re: wireless: recap of current issues (stack)

2006-01-17 Thread Jean Tourrilhes
On Tue, Jan 17, 2006 at 08:23:50PM +0100, Olivier Blin wrote: > > And most of the time, userland has to poll for scan results or > association status, netlink notifications would help. > For example, it would be a lot easier for ifplugd to listen on a > netlink, instead of polling for current AP a

  1   2   >