Re: [IPv4] Fix issue reported by Coverity in net/ipv4/udp.c

2005-12-01 Thread Eric Dumazet
Herbert Xu a écrit : Jayachandran C. <[EMAIL PROTECTED]> wrote: diff -ur linux-2.6.15-rc3-git1.clean/net/ipv4/udp.c linux-2.6.15-rc3-git1/net/ipv4/udp.c --- linux-2.6.15-rc3-git1.clean/net/ipv4/udp.c Wed Nov 30 21:55:27 2005 +++ linux-2.6.15-rc3-git1/net/ipv4/udp.cThu Dec 1 05:23:40

Re: [patch 1/3] atmel: save on array initialization

2005-12-01 Thread Dmitry Torokhov
On Thursday 01 December 2005 11:36, Dmitry Torokhov wrote: > On 12/1/05, Jeff Garzik <[EMAIL PROTECTED]> wrote: > > Dmitry Torokhov wrote: > > > NET: atmel - do not initialize array over and over again > > > > > > Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> > > > > can you resend this series

Re: [PATCH 6/6][DCCP]: Introduce dccp_ipv4_af_ops

2005-12-01 Thread David S. Miller
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Thu, 1 Dec 2005 23:13:12 -0200 > Please consider pulling from: > > master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.16.git Looks good. All pulled, thanks Arnaldo. - To unsubscribe from this list: send the line "unsubscribe ne

Re: [IPv4] Fix issue reported by Coverity in net/ipv4/af_inet.c

2005-12-01 Thread Herbert Xu
On Thu, Dec 01, 2005 at 06:34:39PM -0800, David S. Miller wrote: > > The error makes a lot of sense, because it allows you to actually > distinguish between the two cases. It's not possible to do so > with only the EPROTONOSUPPORT indication. Fair enough. How about something like this then? [IP

Re: [Bug 5672] New: cannot get socket once accept(2) has failed due to EMFILE/ENFILE

2005-12-01 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 1 Dec 2005 10:51:55 -0800 > Detail of issue is old: > > http://oss.sgi.com/archives/netdev/2004-11/msg00573.html > > Once accept fails on EMFILE/ENFILE you cannot get the socket even if you free > up > fd's and retry... I want to apply som

Re: [GIT PATCHES] Couple of SCTP bugfixes

2005-12-01 Thread David S. Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Thu, 01 Dec 2005 17:22:44 -0800 > Could you try pulling the following SCTP updates from >master.kernel.org:/pub/scm/linux/kernel/git/sridhar/lksctp-2.6.git Pulled, thanks Sridhar. - To unsubscribe from this list: send the line "unsubscribe net

Re: [PATCH] [IPV6]: Load protocol module dynamically (is Re: [IPv4] Fix issue reported by Coverity in net/ipv4/af_inet.c)

2005-12-01 Thread David S. Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Fri, 02 Dec 2005 11:21:50 +0900 (JST) > Here it is: > > [IPV6]: Load protocol module dynamically. > > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Applied, thanks a lot Yoshifuji-san. - To unsubscribe from this list: send the line "unsub

Re: [IPv4] Fix issue reported by Coverity in net/ipv4/af_inet.c

2005-12-01 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 02 Dec 2005 12:42:48 +1100 > However, ESOCKTNOSUPPORT is not defined by POSIX, so perhaps we > should always return EPROTONOSUPPORT. > > What do you think Dave? We've traditionally returned ESOCKTNOSUPPORT for this case. I don't see any convincing

Re: Resend [PATCH netdev-2.6 2/8] e1000: Performance Enhancements

2005-12-01 Thread jamal
On Thu, 2005-01-12 at 16:16 -0800, David S. Miller wrote: > From: "Ronciak, John" <[EMAIL PROTECTED]> > Date: Thu, 1 Dec 2005 15:10:19 -0800 > > > Do you have a specific example? We have tried this on Intel (x86 and > > IA-64), AMD (x86 and x86_64) and PPC processors. Most show gains with > > no

Re: [IPv4] Fix issue reported by Coverity in net/ipv4/af_inet.c

2005-12-01 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 01 Dec 2005 18:04:30 -0800 (PST)), "David S. Miller" <[EMAIL PROTECTED]> says: > net/ipv6/af_inet.c:inet6_create() has a similar problem and > it also is missing the module load logic the ipv4 counterpart > has. > > Anyone up for cooking up a fix for those

Re: [IPv4] Fix issue reported by Coverity in net/ipv4/af_inet.c

2005-12-01 Thread David S. Miller
From: "Jayachandran C." <[EMAIL PROTECTED]> Date: Thu, 1 Dec 2005 08:11:40 -0800 > This patch > - removes the "if(!protocol)" check > - adds a check when answer == NULL, to see if the list is empty > to return -ESOCKTNOSUPPORT or -EPROTONOSUPPORT > > Signed-off-by: Jayachandran C. Patc

Re: [IPv4] Fix issue reported by Coverity in net/ipv4/af_inet.c

2005-12-01 Thread Herbert Xu
Jayachandran C. <[EMAIL PROTECTED]> wrote: > > Problem Description: > In the existing code, if the protocol is not supported, "answer" > will be NULL and an error code of -ESOCKTNOSUPPORT will be returned. > The condition "if(!protocol)" which returns -EPROTONOSUPPORT will > never be reached becau

Re: [IPv4] Fix issue reported by Coverity in net/ipv4/udp.c

2005-12-01 Thread Herbert Xu
Jayachandran C. <[EMAIL PROTECTED]> wrote: > > diff -ur linux-2.6.15-rc3-git1.clean/net/ipv4/udp.c > linux-2.6.15-rc3-git1/net/ipv4/udp.c > --- linux-2.6.15-rc3-git1.clean/net/ipv4/udp.c Wed Nov 30 21:55:27 2005 > +++ linux-2.6.15-rc3-git1/net/ipv4/udp.cThu Dec 1 05:23:40 2005 > @@ -848,

[GIT PATCHES] Couple of SCTP bugfixes

2005-12-01 Thread Sridhar Samudrala
Dave, Could you try pulling the following SCTP updates from master.kernel.org:/pub/scm/linux/kernel/git/sridhar/lksctp-2.6.git I am also including the patches inline in case the pull doesn't work for you. Thanks Sridhar

[PATCH 5/6][ICSK]: Move v4_addr2sockaddr from TCP to icsk

2005-12-01 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.16.git Best Regards, - Arnaldo tree 3f70eeccfa29ead14246583618a038d29c579a60 parent f52bb940239fc4078639e598da06c42f0c9add16 author Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> 1133483850 -0200

[PATCH 6/6][DCCP]: Introduce dccp_ipv4_af_ops

2005-12-01 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.16.git Best Regards, - Arnaldo tree 123eb3b4b48c74759e83249eebf9d5e0897ade9c parent c31a8d1bb087e6f7b231f00dc611bd505d96d9c6 author Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> 1133484923 -0200

[PATCH 4/6][ICSK]: Rename struct tcp_func to struct inet_connection_sock_af_ops

2005-12-01 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.16.git Best Regards, - Arnaldo tree 83b7d1dcd67d7ca63c7b56ecd80fb29806feae60 parent 1ba3079af91baf4cc7b219f8b08009d20894d748 author Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> 1133482904 -0200

[PATCH 2/6][IPV6]: Generalise tcp_v6_search_req & tcp_v6_synq_add

2005-12-01 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.16.git Best Regards, - Arnaldo tree a2ad2e96371e91a977875fbda686a242ce41072e parent a94cc4a7611fe08452945b4c74258ef2c3c8bee9 author Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> 1133468875 -0200

[PATCH 3/6][IPV6]: Introduce inet6_rsk()

2005-12-01 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.16.git Best Regards, - Arnaldo tree da67c6e526a4d1fdead5180a8ca72a7af6d51f7b parent 3a6760c6c44e315ab238dc9e468e49a8c4d5a1a9 author Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> 1133479444 -0200

[PATCH 1/6][ICSK]: make inet_csk_reqsk_queue_hash_add timeout arg unsigned long

2005-12-01 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.16.git Best Regards, - Arnaldo tree e941c1c8b26eebb49f94cafc292e2e28fea4d008 parent e82e7da9b2bb8ee35d6c8b3e7484a1e0c5421c46 author Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> 1133395069 -0200

Re: Resend [PATCH netdev-2.6 2/8] e1000: Performance Enhancements

2005-12-01 Thread David S. Miller
From: "Ronciak, John" <[EMAIL PROTECTED]> Date: Thu, 1 Dec 2005 15:10:19 -0800 > Do you have a specific example? We have tried this on Intel (x86 and > IA-64), AMD (x86 and x86_64) and PPC processors. Most show gains with > none showing any detriment to performance with the test cases. The > ga

RE: Resend [PATCH netdev-2.6 2/8] e1000: Performance Enhancements

2005-12-01 Thread Ronciak, John
Hi Jamal, Do you have a specific example? We have tried this on Intel (x86 and IA-64), AMD (x86 and x86_64) and PPC processors. Most show gains with none showing any detriment to performance with the test cases. The gains seen on the ones that show gains are significant in almost all cases.

Re: [stable] [PATCH] [NETLINK]: Fix processing of fib_lookup netlink messages

2005-12-01 Thread Thomas Graf
* Greg KH <[EMAIL PROTECTED]> 2005-12-01 14:21 > On Thu, Dec 01, 2005 at 11:05:12PM +0100, Thomas Graf wrote: > > The receive path for fib_lookup netlink messages is lacking sanity > > checks for header and payload and is thus vulnerable to malformed > > netlink messages causing illegal memory refe

Re: [stable] [PATCH] [NETLINK]: Fix processing of fib_lookup netlink messages

2005-12-01 Thread David S. Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Thu, 1 Dec 2005 14:21:10 -0800 > On Thu, Dec 01, 2005 at 11:05:12PM +0100, Thomas Graf wrote: > > The receive path for fib_lookup netlink messages is lacking sanity > > checks for header and payload and is thus vulnerable to malformed > > netlink messages ca

Re: [stable] [PATCH] [NETLINK]: Fix processing of fib_lookup netlink messages

2005-12-01 Thread Greg KH
On Thu, Dec 01, 2005 at 11:05:12PM +0100, Thomas Graf wrote: > The receive path for fib_lookup netlink messages is lacking sanity > checks for header and payload and is thus vulnerable to malformed > netlink messages causing illegal memory references. > > Signed-off-by: Thomas Graf <[EMAIL PROTECT

[PATCH] [NETLINK]: Fix processing of fib_lookup netlink messages

2005-12-01 Thread Thomas Graf
The receive path for fib_lookup netlink messages is lacking sanity checks for header and payload and is thus vulnerable to malformed netlink messages causing illegal memory references. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: linux-2.6/net/ipv4/fib_frontend.c

Re: more on PMTU issues

2005-12-01 Thread David S. Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Thu, 01 Dec 2005 21:45:59 +0100 > I wonder if it's possible for an application receiving / sending UDP > frames to many different peers to ask to not add entries to > hostcache ? (ie routecache isnt it ?) Currently, UDP doesn't explicitly update the PM

Re: more on PMTU issues

2005-12-01 Thread David S. Miller
From: John Heffner <[EMAIL PROTECTED]> Date: Thu, 01 Dec 2005 11:53:44 -0500 > . > > When implementing additional validity checks at a protocol above IP, > these checks are useless if it just uses a cached value from another > pr

Re: more on PMTU issues

2005-12-01 Thread Stephen Hemminger
On Thu, 01 Dec 2005 12:35:30 -0800 (PST) "David S. Miller" <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Thu, 1 Dec 2005 09:46:22 -0800 > > > Also, there a related IETF draft about ICMP that discusses an number of PMTU > > related issues. > > > > http://www

Re: more on PMTU issues

2005-12-01 Thread Eric Dumazet
David S. Miller a écrit : This gives further credence to BSD's hostcache which makes it use PMTU metrics only learned by TCP. I still dislike the reduced granularity of such a scheme, since as we all know ipsec routes can have wildly different metrics and can be keyed by things like port number

Re: more on PMTU issues

2005-12-01 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 1 Dec 2005 09:46:22 -0800 > Also, there a related IETF draft about ICMP that discusses an number of PMTU > related issues. > > http://www.ietf.org/internet-drafts/draft-gont-tcpm-icmp-attacks-05.txt > which has generated lots of discuss

Re: more on PMTU issues

2005-12-01 Thread David S. Miller
From: John Heffner <[EMAIL PROTECTED]> Date: Thu, 01 Dec 2005 11:53:44 -0500 > Yes it does, and arguably correctly so. As I see it this really comes > down to a question of cached metrics scope. I had a discussion recently > about this with Fernando Gont. See the thread "Improvement for the

[PATCH] ieee80211_crypt_tkip depends on NET_RADIO

2005-12-01 Thread Olaf Hering
*** Warning: ".wireless_send_event" [net/ieee80211/ieee80211_crypt_tkip.ko] undefined! Signed-off-by: Olaf Hering <[EMAIL PROTECTED]> net/ieee80211/Kconfig |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.14/net/ieee80211/Kconfig =

Re: more on PMTU issues

2005-12-01 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 01 Dec 2005 23:21:26 +1100 > You could then say > > dst = dst->ops->cow(dst, flow); > dst->update_pmtu(dst, mtu); > > You can also store the returned dst in the socket. I think this is > worthwhile since receiving an PMTU message is usually follow

Re: [PATCH] ixp2000: change netif_schedule_test to __netif_schedule_prep

2005-12-01 Thread Lennert Buytenhek
On Thu, Dec 01, 2005 at 11:12:47AM -0800, Stephen Hemminger wrote: > Sky2 update changed name of netif_schedule_test to __netif_schedule_prep > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> --L - To unsubscribe from this list: send

[PATCH] ixp2000: change netif_schedule_test to __netif_schedule_prep

2005-12-01 Thread Stephen Hemminger
Sky2 update changed name of netif_schedule_test to __netif_schedule_prep Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- netdev-2.6.orig/drivers/net/ixp2000/ixpdev.c +++ netdev-2.6/drivers/net/ixp2000/ixpdev.c @@ -202,7 +202,7 @@ static irqreturn_t ixpdev_interrupt(int */

Fw: [Bug 5672] New: cannot get socket once accept(2) has failed due to EMFILE/ENFILE

2005-12-01 Thread Stephen Hemminger
Begin forwarded message: Date: Mon, 28 Nov 2005 08:16:52 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bug 5672] New: cannot get socket once accept(2) has failed due to EMFILE/ENFILE http://bugzilla.kernel.org/show_bug.cgi?id=5672 Summary: cannot get socket once ac

Re: more on PMTU issues

2005-12-01 Thread Stephen Hemminger
On Thu, 01 Dec 2005 11:53:44 -0500 John Heffner <[EMAIL PROTECTED]> wrote: > David S. Miller wrote: > > After talking the IPV6 PMTU situation over with Herbert > > this afternoon, we discovered that IPV4 has the same > > problem :-) > > Yes it does, and arguably correctly so. As I see it this re

Re: [PATCH 01/13] sky2: eliminate special case for EC-A1

2005-12-01 Thread Stephen Hemminger
On Thu, 1 Dec 2005 11:16:53 + Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Wed, Nov 30, 2005 at 11:45:11AM -0800, [EMAIL PROTECTED] wrote: > > Eliminate special case for EC-A1. The overhead isn't so > > great that having config option is worth it. > > > > Signed-off-by: Stephen Hemminger

Re: more on PMTU issues

2005-12-01 Thread John Heffner
David S. Miller wrote: After talking the IPV6 PMTU situation over with Herbert this afternoon, we discovered that IPV4 has the same problem :-) Yes it does, and arguably correctly so. As I see it this really comes down to a question of cached metrics scope. I had a discussion recently about

[PATCH] sky2: interrupt not cleared.

2005-12-01 Thread Stephen Hemminger
One of the rearrangements dropped this and it means sky2 spins in napi/interrupt. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: sky2-2.6/drivers/net/sky2.c === --- sky2-2.6.orig/drivers/net/sky2.c +++ sky2-2.6/drivers/n

Re: [patch 1/3] atmel: save on array initialization

2005-12-01 Thread Dmitry Torokhov
On 12/1/05, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Dmitry Torokhov wrote: > > NET: atmel - do not initialize array over and over again > > > > Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> > > can you resend this series without MIME attachments? > Jeff, I would love to but there was no tra

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-12-01 Thread Krzysztof Halasa
jamal <[EMAIL PROTECTED]> writes: >> Sure. But the changes are said to "fix" it, without success (of course, >> they can't succeed without doing what I outlined, that's just >> theoretically impossible, and OTOH not needed at all). > > And i fail to see how. I think I can only agree with you on t

[IPv4] Fix issue reported by Coverity in net/ipv4/af_inet.c

2005-12-01 Thread Jayachandran C.
This patch tries to fix an issue reported in net/ipv4/af_inet.c by Coverity, please review and apply if correct. Error reported: CID: 1728 Checker: DEADCODE File: net/ipv4/af_inet.c Function: inet_create Description: After this line (or expression), the value of "protocol" cannot be

[IPv4] Fix issue reported by Coverity in net/ipv4/udp.c

2005-12-01 Thread Jayachandran C.
This patch tries to fix an issue reported in net/ipv4/udp.c by Coverity, please review and apply if correct. Error reported: CID: 2623 Checker: USE_AFTER_FREE File: net/ipv4/udp.c Function: udp_recvmsg Description: Dereferencing freed pointer "skb" in call to function "skb_free_datagram" Patch

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-12-01 Thread jamal
On Thu, 2005-01-12 at 16:39 +0100, Krzysztof Halasa wrote: > jamal <[EMAIL PROTECTED]> writes: > > >> This bit alone doesn't tell if it's dormant or, for example, simply down > >> (either admin or carrier). > > > dormant is an operational state and _not_ an admin state. > > And, in your opinion

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-12-01 Thread Krzysztof Halasa
jamal <[EMAIL PROTECTED]> writes: >> This bit alone doesn't tell if it's dormant or, for example, simply down >> (either admin or carrier). > dormant is an operational state and _not_ an admin state. And, in your opinion, changing admin state has not effect on operational state? > How is this

Re: Resend [PATCH netdev-2.6 2/8] e1000: Performance Enhancements

2005-12-01 Thread jamal
On Thu, 2005-01-12 at 02:36 -0800, Jeff Kirsher wrote: > e1000 driver update > > Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> > Signed-off-by: John Ronciak <[EMAIL PROTECTED]> > Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> > > 2. Performance Enhancements > - aggressive prefetch of rx_de

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-12-01 Thread jamal
On Thu, 2005-01-12 at 13:48 +0100, Krzysztof Halasa wrote: > Hi, > > Stefan Rompf <[EMAIL PROTECTED]> writes: > > +} > > This is of course much much more correct than those strange operations > on dev->char_type, though netif_dormant* is still misnamed - dormant > isn't one bit but rather a comb

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-12-01 Thread jamal
Hi Stefan, Looking good. On Wed, 2005-30-11 at 23:29 +0100, Stefan Rompf wrote: > Changes since last version: > > -remove NETIF_F_STACKED, use dev->iflink instead. Change VLAN to set > dev->iflink properly There is only one gotcha i noticed with vlan - as you keep stacking you set the iflink;

Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)

2005-12-01 Thread Krzysztof Halasa
Hi, Stefan Rompf <[EMAIL PROTECTED]> writes: > ok, seems we are getting near submission for kernel inclusion. If no new > comments arise, the only thing missing from my side is documentation. I understand it's supposed to be race and "race" free? > + unsigned char operstate; /* R

Re: more on PMTU issues

2005-12-01 Thread Herbert Xu
David S. Miller <[EMAIL PROTECTED]> wrote: > > One idea is to pass in a "const struct flowi *flp" into the > dst->ops->update_pmtu() handler which has the src/dest address fields > filled in. I did code something like that up, then threw it away, but > such a simple change is easily rematerializa

Re: [PATCH 01/13] sky2: eliminate special case for EC-A1

2005-12-01 Thread Christoph Hellwig
On Wed, Nov 30, 2005 at 11:45:11AM -0800, [EMAIL PROTECTED] wrote: > Eliminate special case for EC-A1. The overhead isn't so > great that having config option is worth it. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > > --- sky2-netdev.orig/drivers/net/Kconfig > +++ sky2-netdev/drive

Resend [PATCH netdev-2.6 8/8] e1000: Multique Fixes

2005-12-01 Thread Jeff Kirsher
e1000 driver update Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> 8. Multique Fixes - Added ethtool stats for multiple queues - Added printout for an indication that mutliqueue is enabled/disabl

Resend [PATCH netdev-2.6 6/8] e1000: Comments/Doc/Driver Version

2005-12-01 Thread Jeff Kirsher
e1000 driver update Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> 6. Comments/Doc/Driver Version diff -up linux-2.6/drivers/net/e1000/e1000_hw.c linux-2.6.new/drivers/net/e1000/e1000_hw.c ---

Resend [PATCH netdev-2.6 5/8] e1000: Fix compilation warnings

2005-12-01 Thread Jeff Kirsher
e1000 driver update Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> 5. Fix compilation warnings - Handle return values from functions diff -up linux-2.6/drivers/net/e1000/e1000_main.c linux-2.6.

Resend [PATCH netdev-2.6 4/8] e1000: Multiple fixes (RX fifo errors, SoL/IDER, flow control watermarks)

2005-12-01 Thread Jeff Kirsher
e1000 driver update Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> 4. Multiple Fixes - Fix RX fifo errors and statistics counting - Fix for SoL/IDER sessions - Fix flow control watermarks - Fix D

Resend [PATCH netdev-2.6 3/8] e1000: New Features and devices

2005-12-01 Thread Jeff Kirsher
e1000 driver update Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> 3. New features and devices - Print bus speed, width, and MAC when loading - Added device support for fiber adapter diff -up li

Resend [PATCH netdev-2.6 2/8] e1000: Performance Enhancements

2005-12-01 Thread Jeff Kirsher
e1000 driver update Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> 2. Performance Enhancements - aggressive prefetch of rx_desc and skb->data just like we do for 10gig - align the prefetches to a

Resend [PATCH netdev-2.6 1/8] e1000: Fixes for 8357x

2005-12-01 Thread Jeff Kirsher
e1000 driver update Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: John Ronciak <[EMAIL PROTECTED]> Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> 1. Fixes for 8257x - TSO workaround - Fixes eeprom version reporting - Fix loopback test - Fix for WOL diff -up linux-2.6/driv

netdev queue updated

2005-12-01 Thread Jeff Garzik
Here is the current contents of netdev-2.6.git#ALL, which is auto-propagated to Andrew Morton's -mm tree. http://www.kernel.org/pub/linux/kernel/people/jgarzik/patchkits/2.6/2.6.15-rc4-netdev1.patch.bz2 Adrian Bunk: drivers/net/sk98lin/skge.c: make SkPciWriteCfgDWord() a static inline

Re: [PATCH netdev-2.6 1/8] e1000: Fixes for 8357x

2005-12-01 Thread Jeff Garzik
Kirsher, Jeffrey T wrote: -Original Message- Jeff Garzik wrote: Patches 1-8 approved, but failed to apply to 'upstream' branch: [EMAIL PROTECTED] netdev-2.6]$ git-applymbox /g/tmp/mbox ~/info/signoff.txt 8 patch(es) to process. Applying 'e1000: Fixes for 8357x' fatal: corrupt pat

Re: [PATCH netdev-2.6 1/8] e1000: Fixes for 8357x

2005-12-01 Thread Jeff Kirsher
On 11/30/05, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Jeff Kirsher wrote: > > Fixes for 8257x > > - TSO workaround > > - Fixes eeprom version reporting > > - Fix loopback test > > - Fix for WOL > > > > Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> > > Signed-off-by: John Ronciak <[EMAIL PROTECTED

Re: [PATCH] Add MIPS dependency for dm9000 driver

2005-12-01 Thread Franck
Hi Andrew 2005/11/30, Andrew Morton <[EMAIL PROTECTED]>: > Franck <[EMAIL PROTECTED]> wrote: > > > > The attached patch adds MIPS dependency for dm9000 ethernet > > controller. Indeed this controller is used by some embedded platforms > > based on MIPS CPUs. > > > > Is there any reason why we cann