Hi Stefan, Looking good.
On Wed, 2005-30-11 at 23:29 +0100, Stefan Rompf wrote: > Changes since last version: > > -remove NETIF_F_STACKED, use dev->iflink instead. Change VLAN to set > dev->iflink properly There is only one gotcha i noticed with vlan - as you keep stacking you set the iflink; shouldnt you do the opposite when the last of stacked on netdevices disappear, wouldnt the iflink end up pointing to -1 or maybe even ifindex of the vlan? My only other comment was on array operstates; is there any harm in really adding the strings to name those states nulled right now? > I've successfully tested stacking and userspace interaction, also with > drivers > that do not call netif_carrier_*() > nice. > Should we reset link_mode on dev_open() to allow the user to reset the state > to a usable state with a down/up transition if supplicant crashes for some > reason or should we depend on maintainers/distributors to update userspace > for this? Why would this be any different than say a user app crashed and left the device in admin down state? I think we should stay out of the policy decision altogether; I think some devices will start up in dormant mode on dev_open() but you could pass such parameters perhaps as module init values etc cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
