Re: [Mingw-w64-public] [PATCH][CRT] Split wassert and assert into different units

2017-10-25 Thread Martin Storsjö
On Wed, 25 Oct 2017, Tamar Christina wrote: On Sun, 22 Oct 2017 21:29:32 + Martin Storsjö wrote > On Sun, 22 Oct 2017, Tamar Christina wrote: > > > say I have an object file requiring both _assert and _wassert. > > > > if my link order is -lmsvcrt -lmingwex, it'll pick assert fro

Re: [Mingw-w64-public] [PATCH][CRT] Split wassert and assert into different units

2017-10-25 Thread Tamar Christina
On Sun, 22 Oct 2017 21:29:32 + Martin Storsjö wrote > On Sun, 22 Oct 2017, Tamar Christina wrote: > > > On Sun, 22 Oct 2017 19:28:04 + Martin Storsjö > > wrote > > > On Sun, 22 Oct 2017, Tamar Christina wrote: > > > > > > > Actually.. > > > > >

Re: [Mingw-w64-public] [PATCH][CRT] Split wassert and assert into different units

2017-10-22 Thread Martin Storsjö
On Sun, 22 Oct 2017, Tamar Christina wrote: On Sun, 22 Oct 2017 19:28:04 + Martin Storsjö wrote > On Sun, 22 Oct 2017, Tamar Christina wrote: > > > Actually.. > > > > This may not be the right fix. The regression I am trying to fix is a duplicate symbols error on _wassert when >

Re: [Mingw-w64-public] [PATCH][CRT] Split wassert and assert into different units

2017-10-22 Thread Tamar Christina
Hi Martin, On Sun, 22 Oct 2017 19:28:04 + Martin Storsjö wrote > On Sun, 22 Oct 2017, Tamar Christina wrote: > > > Actually.. > > > > This may not be the right fix. The regression I am trying to fix is a > > duplicate symbols error on _wassert when > > linking both

Re: [Mingw-w64-public] [PATCH][CRT] Split wassert and assert into different units

2017-10-22 Thread Tamar Christina
sers.sourceforge.net>; > mingw-w64-public<mailto:mingw-w64-public@lists.sourceforge.net> > 件名: Re: [Mingw-w64-public] [PATCH][CRT] Split wassert and assert into > different units > > Actually.. > > This may not be the right fix. The regression I am tr

Re: [Mingw-w64-public] [PATCH][CRT] Split wassert and assert into different units

2017-10-22 Thread Martin Storsjö
On Sun, 22 Oct 2017, Tamar Christina wrote: Actually.. This may not be the right fix. The regression I am trying to fix is a duplicate symbols error on _wassert when linking both mscvrt and mingwex. But I now see that: commit 1035bed24e833ea5eb487c78f4f350ea48f31e8b Author: Martin Storsjö Da

Re: [Mingw-w64-public] [PATCH][CRT] Split wassert and assert into different units

2017-10-22 Thread Yuta Nakai
CC: JonY<mailto:jo...@users.sourceforge.net>; mingw-w64-public<mailto:mingw-w64-public@lists.sourceforge.net> 件名: Re: [Mingw-w64-public] [PATCH][CRT] Split wassert and assert into different units Actually.. This may not be the right fix. The regression I am trying to fix is a duplicate

Re: [Mingw-w64-public] [PATCH][CRT] Split wassert and assert into different units

2017-10-22 Thread Tamar Christina
Actually.. This may not be the right fix. The regression I am trying to fix is a duplicate symbols error on _wassert when linking both mscvrt and mingwex. But I now see that: commit 1035bed24e833ea5eb487c78f4f350ea48f31e8b Author: Martin Storsjö Date: Fri Sep 29 12:42:59 2017 +0300 crt:

Re: [Mingw-w64-public] [PATCH][CRT] Split wassert and assert into different units

2017-10-21 Thread Tamar Christina
Ah, weird. Trying again. thanks. On Sat, 21 Oct 2017 23:36:27 + JonY via Mingw-w64-public wrote > On 10/21/2017 10:35 PM, Tamar Christina wrote: > > Hi All, > > > > This patch splits wassert and assert off into their own units > > so they end up in different object fi

Re: [Mingw-w64-public] [PATCH][CRT] Split wassert and assert into different units

2017-10-21 Thread JonY via Mingw-w64-public
On 10/21/2017 10:35 PM, Tamar Christina wrote: > Hi All, > > This patch splits wassert and assert off into their own units > so they end up in different object files to give a bit more > freedom during linking. > > OK for master? > Looks like SF ate your patch. Try attaching as a .txt. signa

[Mingw-w64-public] [PATCH][CRT] Split wassert and assert into different units

2017-10-21 Thread Tamar Christina
Hi All, This patch splits wassert and assert off into their own units so they end up in different object files to give a bit more freedom during linking. OK for master? Thanks, Tamar -- Check out the vibrant tech communi