---- On Sun, 22 Oct 2017 15:22:58 +0000 Yuta Nakai <[email protected]> wrote ---- > Hi, Tamar > > Attached patch may fix the regression. > Please try it.
Hi Yuta, yes this does fix it, but I'm curious at to what happened. I'll expand on this further in my reply to Martin. > > > Windows 10 版のメール<https://go.microsoft.com/fwlink/?LinkId=550986>から送信 > > 差出人: Tamar Christina<mailto:[email protected]> > 送信日時: 2017年10月22日 18:42 > 宛先: mingw-w64-public<mailto:[email protected]> > CC: JonY<mailto:[email protected]>; > mingw-w64-public<mailto:[email protected]> > 件名: Re: [Mingw-w64-public] [PATCH][CRT] Split wassert and assert into > different units > > Actually.. > > This may not be the right fix. The regression I am trying to fix is a > duplicate symbols error on _wassert when > linking both mscvrt and mingwex. But I now see that: > > commit 1035bed24e833ea5eb487c78f4f350ea48f31e8b > Author: Martin Storsjö <[email protected]> > Date: Fri Sep 29 12:42:59 2017 +0300 > > crt: More strictly flag functions in the unified msvcrt.def.in > > Now the output from the unified msvcrt.def.in should be almost identical > to what it was before, except for some new *_dbg and __p_* functions. > > The functions that were included for 32 and 64 bit x86 in the > unification > were originally believed to be harmless, but some of them turned out to > be function that we have compatibility fallbacks for, that were missed > when libmsvcrt.a suddenly started exporting them. This broke > compatibility > with XP in some cases. > > Signed-off-by: Martin Storsjö <[email protected]> > > added the change > > -_wassert > +F_ARM_ANY(_wassert) > > and I don't know why... it's there on x86 as well. > > I'm dubious about this patch as all of these F_ARM_ANY'ed values are also > available on x86, this is causing an annoying linking problem. As I want to > link to the > msvcrt functions first and only mingwex for the extensions it provides. > > > ---- On Sun, 22 Oct 2017 03:23:19 +0000 Tamar Christina <[email protected]> > wrote ---- > > Ah, weird. Trying again. > > > > thanks. > > > > > > ---- On Sat, 21 Oct 2017 23:36:27 +0000 JonY via Mingw-w64-public > <[email protected]> wrote ---- > > > On 10/21/2017 10:35 PM, Tamar Christina wrote: > > > > Hi All, > > > > > > > > This patch splits wassert and assert off into their own units > > > > so they end up in different object files to give a bit more > > > > freedom during linking. > > > > > > > > OK for master? > > > > > > > > > > Looks like SF ate your patch. Try attaching as a .txt. > > > > > > > ------------------------------------------------------------------------------ > > > > Check out the vibrant tech community on one of the world's most > > > engaging tech sites, Slashdot.org! > http://sdm.link/slashdot_______________________________________________ > > > Mingw-w64-public mailing list > > > [email protected] > > > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > > > > > ------------------------------------------------------------------------------ > > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! > http://sdm.link/slashdot_______________________________________________ > > Mingw-w64-public mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > > > > > ------------------------------------------------------------------------------ > > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Mingw-w64-public mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > > ------------------------------------------------------------------------------ > > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! > http://sdm.link/slashdot_______________________________________________ > Mingw-w64-public mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
