Hi, Tamar
Attached patch may fix the regression.
Please try it.
Windows 10 版のメール<https://go.microsoft.com/fwlink/?LinkId=550986>から送信
差出人: Tamar Christina<mailto:[email protected]>
送信日時: 2017年10月22日 18:42
宛先: mingw-w64-public<mailto:[email protected]>
CC: JonY<mailto:[email protected]>;
mingw-w64-public<mailto:[email protected]>
件名: Re: [Mingw-w64-public] [PATCH][CRT] Split wassert and assert into different
units
Actually..
This may not be the right fix. The regression I am trying to fix is a duplicate
symbols error on _wassert when
linking both mscvrt and mingwex. But I now see that:
commit 1035bed24e833ea5eb487c78f4f350ea48f31e8b
Author: Martin Storsjö <[email protected]>
Date: Fri Sep 29 12:42:59 2017 +0300
crt: More strictly flag functions in the unified msvcrt.def.in
Now the output from the unified msvcrt.def.in should be almost identical
to what it was before, except for some new *_dbg and __p_* functions.
The functions that were included for 32 and 64 bit x86 in the unification
were originally believed to be harmless, but some of them turned out to
be function that we have compatibility fallbacks for, that were missed
when libmsvcrt.a suddenly started exporting them. This broke compatibility
with XP in some cases.
Signed-off-by: Martin Storsjö <[email protected]>
added the change
-_wassert
+F_ARM_ANY(_wassert)
and I don't know why... it's there on x86 as well.
I'm dubious about this patch as all of these F_ARM_ANY'ed values are also
available on x86, this is causing an annoying linking problem. As I want to
link to the
msvcrt functions first and only mingwex for the extensions it provides.
---- On Sun, 22 Oct 2017 03:23:19 +0000 Tamar Christina <[email protected]> wrote
----
> Ah, weird. Trying again.
>
> thanks.
>
>
> ---- On Sat, 21 Oct 2017 23:36:27 +0000 JonY via Mingw-w64-public
> <[email protected]> wrote ----
> > On 10/21/2017 10:35 PM, Tamar Christina wrote:
> > > Hi All,
> > >
> > > This patch splits wassert and assert off into their own units
> > > so they end up in different object files to give a bit more
> > > freedom during linking.
> > >
> > > OK for master?
> > >
> >
> > Looks like SF ate your patch. Try attaching as a .txt.
> >
> >
> ------------------------------------------------------------------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org!
> http://sdm.link/slashdot_______________________________________________
> > Mingw-w64-public mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
> >
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org!
> http://sdm.link/slashdot_______________________________________________
> Mingw-w64-public mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
From cb3f2583ced4ecc85fe2d6d9c78be9cdf1f64d00 Mon Sep 17 00:00:00 2001
From: Yuta Nakai <[email protected]>
Date: Mon, 23 Oct 2017 00:15:33 +0900
Subject: [PATCH] crt: Fix duplicate symbols error on _wassert.
- _wassert is available on all architechtures.
- We have our implementation of _wassert in libmingwex, so we should add DATA.
---
mingw-w64-crt/lib-common/msvcrt.def.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mingw-w64-crt/lib-common/msvcrt.def.in
b/mingw-w64-crt/lib-common/msvcrt.def.in
index bbf751ec..8d43bfe9 100644
--- a/mingw-w64-crt/lib-common/msvcrt.def.in
+++ b/mingw-w64-crt/lib-common/msvcrt.def.in
@@ -1136,7 +1136,7 @@ _waccess
; _waccess_s Replaced by emu
_wasctime
; _wasctime_s Replaced by emu
-F_ARM_ANY(_wassert)
+_wassert DATA
_wchdir
_wchmod
_wcmdln DATA
--
2.14.2
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
