[Mesa-dev] [RFC PATCH] dri megadriver_stub: provide compatibility with older DRI loader

2013-12-06 Thread Jordan Justen
laddr function which gives the path of the dynamic library's name that was being loaded. Signed-off-by: Jordan Justen Cc: "10.0" --- Trying to allow Mesa 10 to be loaded by older DRI loaders. This seems to help glxinfo get the i965 driver if Mesa 10's i965_dri.so is added to in

Re: [Mesa-dev] [RFC PATCH] dri megadriver_stub: provide compatibility with older DRI loader

2013-12-06 Thread Jordan Justen
On Fri, Dec 6, 2013 at 2:35 AM, Jordan Justen wrote: > To help the transition period when DRI loaders are being updated > to support the newer __driDriverExtensions_foo mechanism, > we populate __DRIextension with the extensions returned > by __driDriverExtensions_foo during a librar

Re: [Mesa-dev] [RFC PATCH] dri megadriver_stub: provide compatibility with older DRI loader

2013-12-06 Thread Jordan Justen
On Fri, Dec 6, 2013 at 3:50 PM, Ian Romanick wrote: > On 12/06/2013 01:12 PM, Jordan Justen wrote: >> On Fri, Dec 6, 2013 at 2:35 AM, Jordan Justen >> wrote: >>> To help the transition period when DRI loaders are being updated >>> to support the newer __driDrive

[Mesa-dev] [PATCH v2] dri megadriver_stub: provide compatibility with older DRI loader

2013-12-06 Thread Jordan Justen
laddr function which gives the path of the dynamic library's name that was being loaded. v2: * dladdr on public symbol __driDriverExtensions rather than static megadriver_stub_init. * Incorporate fixes and suggestions from Keith Signed-off-by: Jordan Justen Cc: "10.0" ---

Re: [Mesa-dev] i965: Remove surface state Tile-X / Tile-Y offsets (GEN8 enabling)

2013-12-09 Thread Jordan Justen
On Mon, Dec 9, 2013 at 8:18 AM, Abdiel Janulgue wrote: > (cover letter seems to be lost in the way for the patch series but here it is) > > Gen 6/7 hardware support for tile_x and tile_y offset fields in SURFACE_STATE > has been removed in Gen8. All code dependencies must be removed. This patch >

[Mesa-dev] [PATCH v3] dri megadriver_stub: add compatibility for older DRI loaders

2013-12-09 Thread Jordan Justen
g the dladdr function which gives the path of the dynamic library's name that was being loaded. v2: * dladdr on public symbol __driDriverExtensions rather than static megadriver_stub_init. * Incorporate fixes and suggestions from Keith v3: * Incorporate suggestions from Matt Signed-off-

Re: [Mesa-dev] [PATCH 7/7] i965: Add support for Broadwell's new register types.

2013-12-16 Thread Jordan Justen
"m_" in patch 1 seems a bit odd, but I've nothing better to suggest. Patch 5 seems like a definite improvement. Series Reviewed-by: Jordan Justen On Tue, Dec 10, 2013 at 2:33 AM, Kenneth Graunke wrote: > Broadwell introduces support for Q, UQ, and HF types. It also exten

Re: [Mesa-dev] [PATCH 2/2] i965: Use {point_sprite, flat}_enable variable names instead of dw*.

2013-12-16 Thread Jordan Justen
> - OUT_BATCH(dw16); /* point sprite texcoord bitmask */ > - OUT_BATCH(dw17); /* constant interp bitmask */ > + OUT_BATCH(point_sprite_enables); > + OUT_BATCH(flat_enables); What about? OUT_BATCH(point_sprite_enables); /* dw16 */ Sometimes the dw# is helpful when looking

Re: [Mesa-dev] [PATCH 3/3] i965/Gen7: Only emit cube face enables for cubes.

2014-01-08 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On Wed, Jan 8, 2014 at 1:11 PM, Chris Forbes wrote: > This is not observed to actually fix anything, but the PRM says this > field must be zero for other surface types. > > Signed-off-by: Chris Forbes > --- > src/mesa/drivers/dri/i965/gen7_

Re: [Mesa-dev] [PATCH] glsl: Optimize open-coded lrp into lrp.

2014-01-09 Thread Jordan Justen
On Thu, Jan 9, 2014 at 12:14 PM, Matt Turner wrote: > From: Jordan Justen > > total instructions in shared programs: 1498191 -> 1487051 (-0.74%) > instructions in affected programs: 669388 -> 658248 (-1.66%) > GAINED:

Re: [Mesa-dev] [PATCH] glsl: Optimize open-coded lrp into lrp.

2014-01-09 Thread Jordan Justen
On Thu, Jan 9, 2014 at 4:27 PM, Matt Turner wrote: > On Thu, Jan 9, 2014 at 2:37 PM, Jordan Justen wrote: >> On Thu, Jan 9, 2014 at 12:14 PM, Matt Turner wrote: >>> From: Jordan Justen >>> >>> total instructions in shared programs: 1498191 -> 148705

Re: [Mesa-dev] [PATCH] i965/fs: Optimize LRP with x == y into a MOV.

2014-01-09 Thread Jordan Justen
Reviewed-by: Jordan Justen On Thu, Jan 9, 2014 at 8:58 PM, Matt Turner wrote: > total instructions in shared programs: 1487331 -> 1485988 (-0.09%) > instructions in affected programs: 45638 -> 44295 (-2.94%) > GAINED:

Re: [Mesa-dev] [PATCH 06/16] i965/fs: Assert that var < num_vars.

2014-01-10 Thread Jordan Justen
Patches 1-6 Reviewed-by: Jordan Justen On Thu, Dec 19, 2013 at 1:40 PM, Matt Turner wrote: > Helped to track down a problem in a version of the next commit. > --- > src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 16/16] i965/fs: Print the maximum register pressure.

2014-01-10 Thread Jordan Justen
gt; } > + printf("Maximum %3d registers live at once.\n", max_pressure); How about "Max number of live registers: %3d\n" or "Maximum of %3d registers simultaneously live.\n"? Patches 14, 15 (w/Ken's improved commit message) and 16 Reviewed-by:

Re: [Mesa-dev] [PATCH 07/16] i965/fs: Support coalescing registers of size > 1.

2014-01-10 Thread Jordan Justen
On Thu, Dec 19, 2013 at 1:40 PM, Matt Turner wrote: > total instructions in shared programs: 1550048 -> 1549880 (-0.01%) > instructions in affected programs: 1896 -> 1728 (-8.86%) > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 80 > ++-- > 1 file changed, 58 i

Re: [Mesa-dev] [PATCH 07/16] i965/fs: Support coalescing registers of size > 1.

2014-01-10 Thread Jordan Justen
On Fri, Jan 10, 2014 at 11:12 AM, Jordan Justen wrote: > On Thu, Dec 19, 2013 at 1:40 PM, Matt Turner wrote: >> total instructions in shared programs: 1550048 -> 1549880 (-0.01%) >> instructions in affected programs: 1896 -> 1728 (-8.86%) >> --- >> src/mesa

Re: [Mesa-dev] [PATCH 07/16] i965/fs: Support coalescing registers of size > 1.

2014-01-10 Thread Jordan Justen
Patches 7 & 8 Reviewed-by: Jordan Justen On Fri, Jan 10, 2014 at 1:41 PM, Matt Turner wrote: > On Fri, Jan 10, 2014 at 11:12 AM, Jordan Justen wrote: >> On Thu, Dec 19, 2013 at 1:40 PM, Matt Turner wrote: >>> total instructions in shared programs: 1550048 -> 1549880

Re: [Mesa-dev] [PATCH 09/16] i965/fs: Calculate interference better in register_coalesce.

2014-01-10 Thread Jordan Justen
On Thu, Dec 19, 2013 at 1:40 PM, Matt Turner wrote: > Previously we simply considered two registers whose live ranges > overlapped to interfere. Cases such as > >set A -- >... | >mov B, A --| >... | B | A >use B --| >...

Re: [Mesa-dev] [PATCH 09/16] i965/fs: Calculate interference better in register_coalesce.

2014-01-10 Thread Jordan Justen
On Fri, Jan 10, 2014 at 5:59 PM, Matt Turner wrote: > On Fri, Jan 10, 2014 at 5:19 PM, Jordan Justen wrote: >> On Thu, Dec 19, 2013 at 1:40 PM, Matt Turner wrote: >>> + live_intervals->start[var_to] = >>> MIN

Re: [Mesa-dev] [PATCH 09/16] i965/fs: Calculate interference better in register_coalesce.

2014-01-15 Thread Jordan Justen
t; - continue; > + !inst->dst.equals(inst->src[0])) { > + > + if (live_intervals->end[var_to] > live_intervals->end[var_from]) > + continue; > + > + bool overwritten = false; > + int scan_ip =

Re: [Mesa-dev] [PATCH 11/16] i965/fs: Add local value numbering optimization pass.

2014-01-17 Thread Jordan Justen
On Thu, Dec 19, 2013 at 1:40 PM, Matt Turner wrote: > total instructions in shared programs: 1520829 -> 1511991 (-0.58%) > instructions in affected programs: 559725 -> 550887 (-1.58%) > GAINED:6 > LOST: 9 > --- > src/mesa/driver

Re: [Mesa-dev] [PATCH 11/16] i965/fs: Add local value numbering optimization pass.

2014-01-17 Thread Jordan Justen
he > + * destination is not null. > + */ > +struct value_numbering_hash_key *destination_key = > + rzalloc(ht, struct value_numbering_hash_key); > +destination_key->src = inst->dst; > + &g

Re: [Mesa-dev] [PATCH 13/16] i965/fs: Add a saturation propagation optimization pass.

2014-01-17 Thread Jordan Justen
])) > + continue; > + > + int scan_ip = ip; > + bool interfered = false; > + for (fs_inst *scan_inst = (fs_inst *) inst->prev; > + scan_inst != block->start->prev; > + scan_inst = (fs_inst *) scan_inst->prev) { > +

Re: [Mesa-dev] [PATCH 01/10] loader: introduce the loader util lib

2014-01-21 Thread Jordan Justen
On Sat, Jan 11, 2014 at 8:54 AM, Emil Velikov wrote: > All the various window system integration layers duplicate roughly the > same code for figuring out device and driver name, pci-id's, etc. Which > is sad. So extract it out into a loader util lib. > > Signed-off-by: Rob Clark > > v2 (Emil)

[Mesa-dev] [PATCH 2/2] main/get: support ARB_gpu_shader5

2014-01-25 Thread Jordan Justen
If a driver enables ARB_gpu_shader5 and sets Const.MaxVertexSteams >= 4, then piglit's arb_gpu_shader5-minmax test should now pass. Signed-off-by: Jordan Justen --- src/mesa/main/config.h | 9 + src/mesa/main/context.c | 4 src/mesa/main/get.c

[Mesa-dev] [PATCH 1/2] glapi: add definitions for ARB_gpu_shader5

2014-01-25 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mapi/glapi/gen/ARB_gpu_shader5.xml | 15 +++ src/mapi/glapi/gen/gl_API.xml | 2 ++ 2 files changed, 17 insertions(+) create mode 100644 src/mapi/glapi/gen/ARB_gpu_shader5.xml diff --git a/src/mapi/glapi/gen/ARB_gpu_shader5.xml b/src

Re: [Mesa-dev] [PATCH 2/2] main/get: support ARB_gpu_shader5

2014-01-26 Thread Jordan Justen
On Sat, Jan 25, 2014 at 2:05 PM, Matt Turner wrote: > On Sat, Jan 25, 2014 at 10:55 AM, Jordan Justen > wrote: >> If a driver enables ARB_gpu_shader5 and sets >> Const.MaxVertexSteams >= 4, then piglit's >> arb_gpu_shader5-minmax test should now pass. &g

[Mesa-dev] [PATCH v2 3/3] main/get: support ARB_gpu_shader5

2014-01-26 Thread Jordan Justen
gl_constants Signed-off-by: Jordan Justen Reviewed-by: Matt Turner (v1) --- src/mesa/main/config.h | 9 + src/mesa/main/get.c | 2 ++ src/mesa/main/get_hash_params.py | 8 +++- 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/config.

[Mesa-dev] [PATCH v2 2/3] glapi: add definitions for ARB_gpu_shader5

2014-01-26 Thread Jordan Justen
Signed-off-by: Jordan Justen Reviewed-by: Matt Turner --- src/mapi/glapi/gen/ARB_gpu_shader5.xml | 15 +++ src/mapi/glapi/gen/gl_API.xml | 2 ++ 2 files changed, 17 insertions(+) create mode 100644 src/mapi/glapi/gen/ARB_gpu_shader5.xml diff --git a/src/mapi/glapi/gen

[Mesa-dev] [PATCH v2 1/3] main/get: support const normalized float values

2014-01-26 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/get.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 16dce5b..4435c09 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main/get.c @@ -116,7 +116,8 @@ enum

[Mesa-dev] [PATCH 0/7] i965/gen7 instanced GS support for ARB_gpu_shader5

2014-01-26 Thread Jordan Justen
highlighting these issues. Patches are available at: git://people.freedesktop.org/~jljusten/mesa gs-inv-id Jordan Justen (7): glsl: parse invocations layout qualifier for ARB_gpu_shader5 glsl/linker: produce gl_shader_program Geom.Invocations mesa: initialize gl_geometry_program Invocations

[Mesa-dev] [PATCH 1/7] glsl: parse invocations layout qualifier for ARB_gpu_shader5

2014-01-26 Thread Jordan Justen
_mesa_glsl_parse_state::gs_invocations will store the invocation count. Signed-off-by: Jordan Justen --- src/glsl/ast.h| 15 +-- src/glsl/ast_to_hir.cpp | 14 ++ src/glsl/ast_type.cpp | 11 +++ src/glsl/glsl_parser.yy | 19

[Mesa-dev] [PATCH 4/7] main/shaderapi: GL_GEOMETRY_SHADER_INVOCATIONS GetProgramiv support

2014-01-26 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/shaderapi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index a8336c9..fb107d5 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c @@ -603,6 +603,12

[Mesa-dev] [PATCH 2/7] glsl/linker: produce gl_shader_program Geom.Invocations

2014-01-26 Thread Jordan Justen
Grab the parsed invocation count, check for consistency during linking, and finally save the result in gl_shader_program Geom.Invocations. Signed-off-by: Jordan Justen --- src/glsl/glsl_parser_extras.cpp | 2 ++ src/glsl/linker.cpp | 18 ++ src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 7/7] i965: support instanced GS on gen7

2014-01-26 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/brw_defines.h | 1 + src/mesa/drivers/dri/i965/brw_vec4_gs.c | 1 + src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 6 -- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 5/7] glsl: add gl_InvocationID variable for ARB_gpu_shader5

2014-01-26 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/glsl/builtin_variables.cpp | 2 ++ src/mesa/main/mtypes.h | 2 ++ src/mesa/program/prog_print.c | 10 ++ 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index

[Mesa-dev] [PATCH 3/7] mesa: initialize gl_geometry_program Invocations field

2014-01-26 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/mtypes.h | 1 + src/mesa/main/shaderapi.c | 1 + src/mesa/program/program.c | 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 + src/mesa/state_tracker/st_program.c| 1 + 5 files

[Mesa-dev] [PATCH 6/7] i965: support gl_InvocationID for gen7

2014-01-26 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/brw_defines.h | 5 + src/mesa/drivers/dri/i965/brw_vec4_gs.c | 3 +++ src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 17 + 4 files

Re: [Mesa-dev] [PATCH 1/2] glcpp: Check version_resolved in the proper place.

2014-01-26 Thread Jordan Justen
On Sun, Jan 26, 2014 at 6:14 PM, Matt Turner wrote: > The check was in the wrong place, such that if a shader incorrectly put > a preprocessor token before the #version declaration, the version would > be resolved twice, leading to a segmentation fault when attempting to > redefine the __VERSION__

Re: [Mesa-dev] [PATCH 2/2] glcpp: Resolve implicit GLSL version to 100 if the API is ES.

2014-01-26 Thread Jordan Justen
On Sun, Jan 26, 2014 at 6:14 PM, Matt Turner wrote: > Fixes a regression since b2d1c579 where ES shaders without a #version > declaration would fail to compile if their precision declaration was > wrapped in the standard #ifdef GL_ES check. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?i

Re: [Mesa-dev] [PATCH 1/2] glcpp: Check version_resolved in the proper place.

2014-01-26 Thread Jordan Justen
On Sun, Jan 26, 2014 at 8:23 PM, Matt Turner wrote: > On Sun, Jan 26, 2014 at 8:15 PM, Jordan Justen wrote: >> On Sun, Jan 26, 2014 at 6:14 PM, Matt Turner wrote: >>> The check was in the wrong place, such that if a shader incorrectly put >>> a preprocessor token befo

Re: [Mesa-dev] [PATCH 5/7] glsl: add gl_InvocationID variable for ARB_gpu_shader5

2014-01-27 Thread Jordan Justen
Paul pointed out that that gl_InvocationID should be a system value variable. Therefore, patches 5 and 6 are self-NAK'd. -Jordan On Sun, Jan 26, 2014 at 12:52 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/glsl/builtin_variables.cpp | 2 ++ > src/m

[Mesa-dev] [PATCH v2 0/7] i965/gen7 instanced GS support for ARB_gpu_shader5

2014-01-28 Thread Jordan Justen
are pre-existing bugs) Piglit master has tests highlighting these issues. Patches are available at: git://people.freedesktop.org/~jljusten/mesa gs-inv-id-v2 Jordan Justen (7): glsl: parse invocations layout qualifier for ARB_gpu_shader5 glsl/linker: produce gl_shader_program Geom.Invocations

[Mesa-dev] [PATCH v2 1/7] glsl: parse invocations layout qualifier for ARB_gpu_shader5

2014-01-28 Thread Jordan Justen
_mesa_glsl_parse_state::gs_invocations will store the invocation count. Signed-off-by: Jordan Justen --- src/glsl/ast.h| 15 +-- src/glsl/ast_to_hir.cpp | 14 ++ src/glsl/ast_type.cpp | 11 +++ src/glsl/glsl_parser.yy | 19

[Mesa-dev] [PATCH v2 3/7] mesa: initialize gl_geometry_program Invocations field

2014-01-28 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/mtypes.h | 1 + src/mesa/main/shaderapi.c | 1 + src/mesa/program/program.c | 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 + src/mesa/state_tracker/st_program.c| 1 + 5 files

[Mesa-dev] [PATCH v2 6/7] i965: support gl_InvocationID for gen7

2014-01-28 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_defines.h | 5 + src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 24 --- 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa

[Mesa-dev] [PATCH v2 4/7] main/shaderapi: GL_GEOMETRY_SHADER_INVOCATIONS GetProgramiv support

2014-01-28 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/main/shaderapi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index a8336c9..fb107d5 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c @@ -603,6 +603,12

[Mesa-dev] [PATCH v2 5/7] glsl: add gl_InvocationID variable for ARB_gpu_shader5

2014-01-28 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/glsl/builtin_variables.cpp | 2 ++ src/mesa/main/mtypes.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index d6bc3c0..d9ed2db 100644 --- a/src/glsl/builtin_variables.cpp +++ b

[Mesa-dev] [PATCH v2 7/7] i965: support instanced GS on gen7

2014-01-28 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/brw_defines.h | 1 + src/mesa/drivers/dri/i965/brw_vec4_gs.c | 2 ++ src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 6 -- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH v2 2/7] glsl/linker: produce gl_shader_program Geom.Invocations

2014-01-28 Thread Jordan Justen
Grab the parsed invocation count, check for consistency during linking, and finally save the result in gl_shader_program Geom.Invocations. Signed-off-by: Jordan Justen --- src/glsl/glsl_parser_extras.cpp | 2 ++ src/glsl/linker.cpp | 18 ++ src/mesa/main/mtypes.h

Re: [Mesa-dev] [PATCH 1/2] glcpp: Don't enter lexer's NEWLINE_CATCHUP start state for single-line comments

2014-01-29 Thread Jordan Justen
om the > single-line comment case, (preserving it only in exactly the cases where the > lexer is actually emitting a NEWLINE token). > > My utmost tany hanks to Petri Latvala for reporting this bug and for providing "tany hanks" => "thanks" Series Reviewed-by: J

Re: [Mesa-dev] [PATCH] glcpp: Reject #version after the version has been resolved.

2014-01-29 Thread Jordan Justen
Reviewed-by: Jordan Justen On Wed, Jan 29, 2014 at 12:48 PM, Matt Turner wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74166 > --- > src/glsl/glcpp/glcpp-parse.y | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/glsl/glcpp/glcpp-parse.y b/sr

[Mesa-dev] [PATCH] i965/gen8: add debug code to show FS disasm with jump locations

2014-04-11 Thread Jordan Justen
Copied from similar code in gen8_vec4_generator.cpp. Signed-off-by: Jordan Justen Cc: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen8_fs_generator.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i965/gen8_fs_generator.cpp b/src/mesa/drivers/dri/i965

Re: [Mesa-dev] Regressions due to commit 1afe3359258

2014-04-18 Thread Jordan Justen
On 2014-04-18 08:46:00, Kenneth Graunke wrote: > On 04/18/2014 12:09 AM, Ilia Mirkin wrote: > > Hi Ken, > > > > I just did a bisect looking for the failure that's causing a few > > gs-related piglits to fail on nv50, and it came up with the below. Any > > ideas? Here are the tests that are failing

Re: [Mesa-dev] Regressions due to commit 1afe3359258

2014-04-19 Thread Jordan Justen
On Sat, Apr 19, 2014 at 10:03 AM, Ilia Mirkin wrote: > On Fri, Apr 18, 2014 at 1:35 PM, Jordan Justen > wrote: >> On 2014-04-18 08:46:00, Kenneth Graunke wrote: >>> On 04/18/2014 12:09 AM, Ilia Mirkin wrote: >>> > Hi Ken, >>> > >>> > I j

Re: [Mesa-dev] Regressions due to commit 1afe3359258

2014-04-22 Thread Jordan Justen
On Tue, Apr 22, 2014 at 8:54 AM, Ian Romanick wrote: > On 04/19/2014 11:44 AM, Jordan Justen wrote: >> On Sat, Apr 19, 2014 at 10:03 AM, Ilia Mirkin wrote: >>> On Fri, Apr 18, 2014 at 1:35 PM, Jordan Justen >>> wrote: >>>> On 2014-04-18 08:46:00, Kenneth G

Re: [Mesa-dev] [PATCH] i965: Set miptree target field when creating from a BO.

2014-05-02 Thread Jordan Justen
Reviewed-by: Jordan Justen On Thu, May 1, 2014 at 11:48 PM, Kenneth Graunke wrote: > Prior to commit 8435b60a3577d2d905eae189cd7e770500177e99, the region > equivalent of this function called intel_miptree_create_layout, which > set mt->target to target. With that commit, it no l

Re: [Mesa-dev] [PATCH 1/2] mesa: Fix MaxNumLayers for 1D array textures.

2014-05-07 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On Wed, May 7, 2014 at 3:22 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Wed, May 7, 2014 at 11:35 PM, Kenneth Graunke > wrote: >> 1D array targets store the number of slices in the Height field. >> >

Re: [Mesa-dev] [PATCH] i965: Fix GPU hangs on Broadwell in shaders with some control flow.

2014-05-09 Thread Jordan Justen
Reviewed-by: Jordan Justen On Thu, May 8, 2014 at 4:44 PM, Kenneth Graunke wrote: > According to the documentation, we need to set the source 0 register > type to IMM for flow control instructions that have both JIP and UIP. > > Fixes GPU hangs in approximately 10 Piglit tests,

Re: [Mesa-dev] [PATCH] ralloc: Omit detailed license information about talloc.

2014-05-09 Thread Jordan Justen
On Fri, May 9, 2014 at 2:55 AM, wrote: > From: José Fonseca > > That information misleads source code auditing tools to think that > ralloc itself is released under LGPL v3. > > Instead, simply state talloc is not licensed under a permissive license. > --- > src/glsl/ralloc.h | 7 +++ > 1 f

[Mesa-dev] [PATCH 4/4] i965/gen8 depth: Set depth size based on LOD0 for 3D textures

2014-05-10 Thread Jordan Justen
Signed-off-by: Jordan Justen Cc: Chris Forbes --- src/mesa/drivers/dri/i965/gen8_depth_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_depth_state.c b/src/mesa/drivers/dri/i965/gen8_depth_state.c index 31d6d56..0bed3b4 100644 --- a

[Mesa-dev] [PATCH 1/4] i965/gen7 renderbuffer: Set depth size based on LOD0 for 3D textures

2014-05-10 Thread Jordan Justen
If blorp is disabled for color clears, then piglit's 'gl-3.2-layered-rendering-clear-color-all-types 3d mipmapped' will fail. Currently, gen8 fails similarly on this test because gen8 does not use blorp. Signed-off-by: Jordan Justen Cc: Chris Forbes --- src/mesa/d

[Mesa-dev] [PATCH 0/4] Set render depth size based on LOD0 for 3D textures

2014-05-10 Thread Jordan Justen
also fixes that. For the depth patches, I did not find a piglit test case that they fix, but I think we should be using LOD0's depth size there as well. No piglit regressions observed on gen7 / gen8. Jordan Justen (4): i965/gen7 renderbuffer: Set depth size based on LOD0 for 3D textures

[Mesa-dev] [PATCH 3/4] i965/gen7 depth: Set depth size based on LOD0 for 3D textures

2014-05-10 Thread Jordan Justen
Signed-off-by: Jordan Justen Cc: Chris Forbes --- src/mesa/drivers/dri/i965/gen7_misc_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_misc_state.c b/src/mesa/drivers/dri/i965/gen7_misc_state.c index d8efa76..22911bf 100644 --- a

[Mesa-dev] [PATCH 2/4] i965/gen8 renderbuffer: Set depth size based on LOD0 for 3D textures

2014-05-10 Thread Jordan Justen
Fixes piglit's 'gl-3.2-layered-rendering-clear-color-all-types 3d mipmapped' Signed-off-by: Jordan Justen Cc: Chris Forbes --- src/mesa/drivers/dri/i965/gen8_surface_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/gen8_sur

[Mesa-dev] [PATCH] i965/gen8: Set depth extent field

2014-05-13 Thread Jordan Justen
The depth extent field is used to limit the allowed slice range that can be rendered to. With the previous setting, only slice 0 could be rendered. This fixes piglit amd_vertex_shader_layer-layered-depth-texture-render. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965

Re: [Mesa-dev] Mesa 10.2 release candidate 2

2014-05-14 Thread Jordan Justen
On Wed, May 14, 2014 at 3:14 PM, Ian Romanick wrote: > On 05/09/2014 08:28 PM, Ian Romanick wrote: >> (This is a re-send with a GPG signature.) >> >> Mesa 10.2 release candidate 2 is now available for testing. The current >> plan of record is to have an additional release candidate each Friday >>

[Mesa-dev] [PATCH] i965 meta up/downsample: Fix renderbuffer _BaseFormat

2014-05-14 Thread Jordan Justen
mt->format is of type mesa_format, and therefore can't be used with _mesa_base_fbo_format which requires a GLenum input. On gen8, this fixes various piglit fbo-depthstencil tests with samples > 1. Signed-off-by: Jordan Justen Cc: Topi Pohjolainen Cc: Kenneth Graunke --- This wa

[Mesa-dev] [PATCH] meta blit: Set Z texcoord during meta blit to sample the right layer

2014-05-21 Thread Jordan Justen
If the source renderbuffer has a depth > 0, then send a Z texcoord which is set to the source attachment Z index. This fixes piglit's gl-3.2-layered-rendering-gl-layer-render with the GL_TEXTURE_2D_MULTISAMPLE_ARRAY case test on i965/gen8. Signed-off-by: Jordan Justen Cc: "10.2&quo

[Mesa-dev] [RFC PATCH 00/16] Gen6 render surface state changes

2014-05-29 Thread Jordan Justen
piglit's quick suite on gen6 and gm45: gen6: 10 fixes, 0 regressions gm45: no changes The last five patches in the series are a bit hackish, but I had trouble finding a better looking solution that also kept stencil & hiz happy. (These patches are the RFC part :) Jordan Justen (16): i9

[Mesa-dev] [RFC PATCH 02/16] i965/gen6: add support for layered renderbuffers

2014-05-29 Thread Jordan Justen
Rather than pointing the surface_state directly at a single sub-image of the texture for rendering, we now point the surface_state at the top level of the texture, and configure the surface_state as needed based on this. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_defines.h

[Mesa-dev] [RFC PATCH 05/16] i965/gen6 depth surface: calculate more specific surface type

2014-05-29 Thread Jordan Justen
(171e633 for gen6) This will be used in 3DSTATE_DEPTH_BUFFER in a later patch. Note: Cube maps are treated as 2D arrays with 6 times as many array elements as the cube map array would have. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/gen6_blorp.cpp | 17 ++ src

[Mesa-dev] [RFC PATCH 04/16] i965: Split gen6 depth state out from brw

2014-05-29 Thread Jordan Justen
We will program the gen6 depth state differently to enable layered rendering on gen6. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_context.c | 2 +- src/mesa/drivers/dri/i965/brw_context.h | 13 ++ src/mesa

[Mesa-dev] [RFC PATCH 15/16] i965/gen6: Force W tiling alignment with array_spacing_lod0

2014-05-29 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_tex_layout.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c b/src/mesa/drivers/dri/i965/brw_tex_layout.c index 8a0912d..9293229 100644 --- a/src/mesa

[Mesa-dev] [RFC PATCH 14/16] i965/gen6: Stencil/hiz needs an offset for LOD > 0

2014-05-29 Thread Jordan Justen
Since gen6 stencil only supports LOD0, we need to program an offset to the LOD when emitting the stencil/hiz. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/gen6_blorp.cpp | 10 - src/mesa/drivers/dri/i965/gen6_depth_state.c | 32 ++-- 2 files

[Mesa-dev] [RFC PATCH 09/16] i965/gen6 blorp depth: calculate base surface width/height

2014-05-29 Thread Jordan Justen
(e3a49e1 for gen6) This will be used in 3DSTATE_DEPTH_BUFFER in a later patch. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/gen6_blorp.cpp | 13 + 1 file changed, 13 insertions(+) diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.cpp b/src/mesa/drivers/dri/i965

[Mesa-dev] [RFC PATCH 10/16] i965/gen6 fbo: make unmatched depth/stencil configs return unsupported

2014-05-29 Thread Jordan Justen
(f3c886b for gen6) Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/intel_fbo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c b/src/mesa/drivers/dri/i965/intel_fbo.c index e43e18b..22f707f 100644 --- a/src/mesa/drivers

[Mesa-dev] [RFC PATCH 11/16] i965/gen6 depth surface: program 3DSTATE_DEPTH_BUFFER to top of surface

2014-05-29 Thread Jordan Justen
must disable brw_workaround_depthstencil_alignment for gen >= 6. Now the hardware will handle alignment when rendering to additional slices/LODs. Signed-off-by: Jordan Justen Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56127 --- src/mesa/drivers/dri/i965/brw_misc_state.c | 4 +- s

[Mesa-dev] [RFC PATCH 03/16] i965/gen6: Align height to 2 with MSAA for certain surface heights

2014-05-29 Thread Jordan Justen
n the equation above , for every other odd Surface Height starting from 1 i.e. 1,5,9,13" Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/gen6_surface_state.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/gen6_surface_state.c

[Mesa-dev] [RFC PATCH 16/16] i965/gen6: Force array_spacing_lod0 for stencil/hiz

2014-05-29 Thread Jordan Justen
up like the hardware expects, and also tries to minimize the overall texture size. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa

[Mesa-dev] [RFC PATCH 01/16] i965: Split gen6 renderbuffer surface state from gen5 and older

2014-05-29 Thread Jordan Justen
We will program the gen6 renderbuffer surface state differently to enable layered rendering on gen6. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_context.c| 4 + src/mesa/drivers/dri/i965/brw_state.h

[Mesa-dev] [RFC PATCH 13/16] i965: Support array_spacing_lod0 for multiple miplevels

2014-05-29 Thread Jordan Justen
-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_tex_layout.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c b/src/mesa/drivers/dri/i965/brw_tex_layout.c index 76044b2..8a0912d 100644 --- a/src/mesa/drivers

[Mesa-dev] [RFC PATCH 06/16] i965/gen6 depth surface: calculate depth (array size) for depth surface

2014-05-29 Thread Jordan Justen
(bc1acaa for gen6) This will be used in 3DSTATE_DEPTH_BUFFER in a later patch. Note: Cube maps are treated as 2D arrays with 6 times as many array elements as the cube map array would have. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/gen6_blorp.cpp | 2 ++ src/mesa/drivers

[Mesa-dev] [RFC PATCH 07/16] i965/gen6 depth surface: calculate LOD being rendered to

2014-05-29 Thread Jordan Justen
(08ef1dd for gen6) This will be used in 3DSTATE_DEPTH_BUFFER in a later patch. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/gen6_blorp.cpp | 3 +++ src/mesa/drivers/dri/i965/gen6_depth_state.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965

[Mesa-dev] [RFC PATCH 08/16] i965/gen6 depth surface: calculate minimum array element being rendered

2014-05-29 Thread Jordan Justen
(a23cfb8 for gen6) In layered rendering this will be 0. Otherwise it will be the selected slice. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/gen6_blorp.cpp | 3 +++ src/mesa/drivers/dri/i965/gen6_depth_state.c | 10 ++ 2 files changed, 13 insertions(+) diff --git a

[Mesa-dev] [RFC PATCH 12/16] i965: Allow forcing a LOD0 spacing miptree layout

2014-05-29 Thread Jordan Justen
gen6 does not support multiple miplevels with stencil. Therefore we need to layout it's miptree with no LOD0 spacing between the slices of each miplevel. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/intel_fbo.c | 3 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.c

Re: [Mesa-dev] [RFC PATCH 13/16] i965: Support array_spacing_lod0 for multiple miplevels

2014-06-02 Thread Jordan Justen
On Mon, Jun 2, 2014 at 2:36 AM, Pohjolainen, Topi wrote: > On Thu, May 29, 2014 at 01:53:52PM -0700, Jordan Justen wrote: >> Previously array spacing lod0 was only used with a single mip level. >> >> It indicated that no mip level spacing should be used between array >>

Re: [Mesa-dev] [RFC PATCH 13/16] i965: Support array_spacing_lod0 for multiple miplevels

2014-06-02 Thread Jordan Justen
On Mon, Jun 2, 2014 at 2:42 AM, Pohjolainen, Topi wrote: > On Thu, May 29, 2014 at 01:53:52PM -0700, Jordan Justen wrote: >> Previously array spacing lod0 was only used with a single mip level. >> >> It indicated that no mip level spacing should be used between array >>

Re: [Mesa-dev] [RFC PATCH 15/16] i965/gen6: Force W tiling alignment with array_spacing_lod0

2014-06-02 Thread Jordan Justen
On Mon, Jun 2, 2014 at 3:03 AM, Pohjolainen, Topi wrote: > On Thu, May 29, 2014 at 01:53:54PM -0700, Jordan Justen wrote: >> Signed-off-by: Jordan Justen >> --- >> src/mesa/drivers/dri/i965/brw_tex_layout.c | 16 +--- >> 1 file changed, 13 insertions(+)

Re: [Mesa-dev] [RFC PATCH 13/16] i965: Support array_spacing_lod0 for multiple miplevels

2014-06-02 Thread Jordan Justen
On Mon, Jun 2, 2014 at 10:29 AM, Pohjolainen, Topi wrote: > On Mon, Jun 02, 2014 at 09:44:16AM -0700, Jordan Justen wrote: >> On Mon, Jun 2, 2014 at 2:36 AM, Pohjolainen, Topi >> wrote: >> > On Thu, May 29, 2014 at 01:53:52PM -0700, Jordan Justen wrote: >> >&g

Re: [Mesa-dev] [PATCH 0/6] Initial no-op implementation of `precise`

2014-06-03 Thread Jordan Justen
Based on the results of your piglit tests on NVidia, there might be some follow up tweaks to this. But, series Reviewed-by: Jordan Justen On Sat, Apr 26, 2014 at 9:03 PM, Chris Forbes wrote: > This series adds compiler support for the `precise` qualifier from > ARB_gpu_shader5. The p

[Mesa-dev] [PATCH 04/17] glsl parser: reject VS+in & FS+out interface blocks

2013-04-19 Thread Jordan Justen
Signed-off-by: Jordan Justen Reviewed-by: Eric Anholt Reviewed-by: Kenneth Graunke --- src/glsl/glsl_parser.yy | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index 0a2a77b..dbc25a4 100644 --- a/src/glsl/glsl_parser.yy

[Mesa-dev] [PATCH 00/17] GLSL 1.50 interface blocks support

2013-04-19 Thread Jordan Justen
unmatched interface blocks is not working * Piglit tests for known issues have been sent to piglit list Jordan Justen (17): glsl: rename ast_uniform_block to ast_interface_block glsl parser: rename uniform block to interface block glsl: parse in/out types for interface blocks glsl

[Mesa-dev] [PATCH 01/17] glsl: rename ast_uniform_block to ast_interface_block

2013-04-19 Thread Jordan Justen
Signed-off-by: Jordan Justen Reviewed-by: Eric Anholt Reviewed-by: Kenneth Graunke --- src/glsl/ast.h |4 ++-- src/glsl/ast_to_hir.cpp |6 +++--- src/glsl/glsl_parser.yy | 14 +++--- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/glsl/ast.h b

[Mesa-dev] [PATCH 02/17] glsl parser: rename uniform block to interface block

2013-04-19 Thread Jordan Justen
Signed-off-by: Jordan Justen Reviewed-by: Eric Anholt Reviewed-by: Kenneth Graunke --- src/glsl/glsl_parser.yy | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index cd33078..33b74ea 100644 --- a

[Mesa-dev] [PATCH 03/17] glsl: parse in/out types for interface blocks

2013-04-19 Thread Jordan Justen
Previously only 'uniform' was allowed for uniform blocks. Now, in/out can be parsed, but it will only be allowed for GLSL >= 150. Signed-off-by: Jordan Justen Reviewed-by: Eric Anholt --- src/glsl/glsl_parser.yy | 51 +-- 1 fil

[Mesa-dev] [PATCH 05/17] glsl parser: on desktop GL require GLSL 150 for instance names

2013-04-19 Thread Jordan Justen
Interface blocks in GLSL 150 allow an instance name to be used. v2: * use state->check_version Signed-off-by: Jordan Justen Reviewed-by: Eric Anholt Reviewed-by: Kenneth Graunke --- src/glsl/glsl_parser.yy |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/

[Mesa-dev] [PATCH 13/17] glsl linker: remove interface block instance names

2013-04-19 Thread Jordan Justen
Convert interface blocks with instance names into flat interface blocks without an instance name. Signed-off-by: Jordan Justen --- src/glsl/Makefile.sources |1 + src/glsl/ir_optimization.h|1 + src/glsl/linker.cpp |6 + src/glsl

[Mesa-dev] [PATCH 06/17] glsl parser: handle interface block member qualifier

2013-04-19 Thread Jordan Justen
with the member, it will adopt the same type as the interface block. Signed-off-by: Jordan Justen --- src/glsl/glsl_parser.yy | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index 70764d6..c254a2f 100644 --- a/src

[Mesa-dev] [PATCH 10/17] glsl ast_to_hir: move uniform block symbols to interface blocks namespace

2013-04-19 Thread Jordan Justen
Uniform/interface blocks are a separate namespace from types. Signed-off-by: Jordan Justen --- src/glsl/ast_to_hir.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 612b3e4..9913309 100644 --- a/src/glsl

<    2   3   4   5   6   7   8   9   10   11   >