ine.
> +entrypoints=$(grep EGL_ENTRYPOINT "$srcdir"/main/eglentrypoint.def)
> +sorted=$(sort <<< "$entrypoints")
> +test "$entrypoints" = "$sorted"
Cannot spot any bashisms here. checkbashisms also cannot find any.
s|bash|sh| in the
On 21 February 2017 at 11:02, Eric Engestrom wrote:
> On Tuesday, 2017-02-21 09:41:18 +0100, Nicolai Hähnle wrote:
>> On 20.02.2017 20:27, Emil Velikov wrote:
>> > From: Emil Velikov
>> >
>> > Suggested-by: Eric Engestrom
>> > Signed-off-by: Emil Ve
Reviewed-by: Emil Velikov
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
e.org/web/20021211151318/http://www.inforamp.net/~poynton/notes/colour_and_gamma/GammaFAQ.html
>
> Signed-off-by: Eric Engestrom
> ---
> v2: fix link name as well
Reviewed-by: Emil Velikov
-Emil
___
mesa-dev mailing list
er
>>
>>
>> Thanks Elie.
>>
>> Given we are both "new-er" Mesa contributors I might wait for one more
>> Reviewed-by before asking for it to be merged.
>
>
> Ping.
> Are you OK with this patch? If yes, can you merge it
pipe_common.o):
> In function `r600_disk_cache_create':
> r600_pipe_common.c:(.text+0x2000): undefined reference to
> `LLVMInitializeAMDGPUTargetInfo'
> collect2: error: ld returned 1 exit status
> make[4]: *** [Makefile:791: libomx_mesa.la] Fehler 1
> make[4]: Verzeichnis
or "Fixes: $sha1 ("$commit summary")" will do.
Haven't looked at the series, so not sure how much of the work is
safe/applicable.
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 22 February 2017 at 03:38, Jason Ekstrand wrote:
> While we're here, we also fix the alphabetization of the list of
> genx_* files.
Reviewed-by: Emil Velikov
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedeskto
On 22 February 2017 at 14:57, Marc Dietrich wrote:
> Am Mittwoch, 22. Februar 2017, 15:48:18 CET schrieb Emil Velikov:
>> On 22 February 2017 at 13:31, Marc Dietrich wrote:
>> > Am Mittwoch, 22. Februar 2017, 04:45:46 CET schrieb Timothy Arceri:
>> >> For gpu gener
an/anv_entrypoints_gen.py
> @@ -22,10 +22,14 @@
> # IN THE SOFTWARE.
> #
>
> +import os
> import sys
> import textwrap
> import xml.etree.ElementTree as et
>
> +VK_XML = os.path.join(
> +os.path.dirname(__file__), '..', '..', 'vulkan',
>
Please pass a "-o $dst_dir" type of argument. It will be/is broken otherwise.
Small suggestion to update the Android.mk file. Feel free to Cc
Tapani/Mauro so that they can test/address any concerns.
Mauro, Tapani,
Afaict earlier series [1] have broken
in the correct section - 20-30 lines
further down ;-)
>>
>> > So the remaining question is what actually pulls in LLVMAMDGPUInfo, and
>> > why
>> > isn't it pulled here?
>>
>> This may still need to be answered for linking LLVM statically th
On 22 February 2017 at 23:36, Dylan Baker wrote:
> +void anv_set_dispatch_devinfo(const struct gen_device_info *info);
Dead declaration since commit 6d557ae4032adafc85a4cb5a76d8653bf0cf6639.
Worth fixing before, with or after this patch/series ?
-E
x-check and
../some/crazy/path/to/dispatch-index-check also work.
Perhaps reuse the autogen.sh magic ?
Feel free to do that as follow-up or let me know otherwise and I'll
fix it. I'm just fixing our "broken since day 1" glsl tests ;-)
As-is for this patch
From: Emil Velikov
Otherwise we'll fail when invoking the script outside of "make check"
Signed-off-by: Emil Velikov
---
src/compiler/glsl/tests/optimization-test | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/compiler/glsl/tests/optimization-test
b/sr
up
in the bin, now that we have Dylan back ;-)
So the questions are:
- Do we care about those tests ?
- Dylan any interest in giving it a stab ?
Thanks
Emil
Cc: Dylan Baker
Cc: Kenneth Graunke
Cc: Matt Turner
Emil Velikov (4):
glsl/tests/optimisation-test: make sure that $PYTHON2 is se
From: Emil Velikov
At the moment things are completely bonkers (as can be seen from last
commit). Regardless if we run the test as part of "make check" or
standalone the most of the paths are wrong.
Untangle things by issuing "cd `dirname "$0`" and working from the
From: Emil Velikov
Bail out early if the script is not where we expect it to be.
Signed-off-by: Emil Velikov
---
src/compiler/glsl/tests/optimization-test | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/compiler/glsl/tests/optimization-test
b/src/compiler/glsl/tests/optimization
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/compiler/glsl/tests/optimization-test | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/src/compiler/glsl/tests/optimization-test
b/src/compiler/glsl/tests/optimization-test
index ec0f09b125..d84b83cfaa
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/gallium/drivers/vc4/Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/vc4/Makefile.am
b/src/gallium/drivers/vc4/Makefile.am
index 291c28fa92..b361a0c588 100644
--- a/src/gallium/drivers/vc4/Makefile.am
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/intel/Makefile.blorp.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/intel/Makefile.blorp.am b/src/intel/Makefile.blorp.am
index 36d99dfa1f..971c1bad06 100644
--- a/src/intel/Makefile.blorp.am
+++ b/src/intel/Makefile.blorp.am
From: Emil Velikov
The final user of it was st/vega.
Cc: Andreas Boll
Signed-off-by: Emil Velikov
---
Andreas this (and earlier) patches address some of the
extend-diff-ignore cases. Thanks for these.
Unrelated: can I interest you in updating the git-cleanup.sh script ?
---
src/mapi
From: Emil Velikov
Similar to other accompanying documentation we have in-tree.
For example glsl/README.
Signed-off-by: Emil Velikov
---
src/compiler/Makefile.nir.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/Makefile.nir.am b/src/compiler/Makefile.nir.am
index
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/intel/vulkan/Makefile.am | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am
index 449188fe1e..a7e2d8e2b4 100644
--- a/src/intel/vulkan/Makefile.am
+++ b/src
Afaict there was no [documented] users since it was introduced.
Cc: Ian Romanick
Signed-off-by: Emil Velikov
---
src/mapi/glapi/gen/next_available_offset.sh | 39 -
1 file changed, 39 deletions(-)
delete mode 100755 src/mapi/glapi/gen/next_available_offset.sh
diff
From: Emil Velikov
All of the scripts are [must be] executed via $PYTHON2 [or equivalent]
hence why they are missing the execute bit.
Signed-off-by: Emil Velikov
---
src/compiler/glsl/ir_expression_operation.py | 1 -
src/compiler/glsl/tests/compare_ir.py| 1 -
2 files changed, 2
From: Emil Velikov
Nearly all the python scripts used in-tree are invoked via $PYTHON2 or
equivalent. As such having the execute bit not needed and generally
ill-advised.
Signed-off-by: Emil Velikov
---
src/compiler/glsl/tests/compare_ir.py | 0
1 file changed, 0 insertions(+), 0 deletions
This is a spec file which is parsed by scripts.
Signed-off-by: Emil Velikov
---
src/mapi/glapi/registry/gl.xml | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644 src/mapi/glapi/registry/gl.xml
diff --git a/src/mapi/glapi/registry/gl.xml b/src/mapi/glapi/regis
From: Emil Velikov
The file is meant to be called with $(PYTHON2) and not executed
directly.
Signed-off-by: Emil Velikov
---
src/gallium/drivers/freedreno/ir3/ir3_nir_trig.py | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644 src/gallium/drivers/freedreno/
The file is used to generate svgadump/svga_dump.c... in theory at least.
Atm. the file is checked in-tree but that is about to change later
commits.
As we get to that we'll use $PYTHON2 or equivalent as used throughout
the tree.
Signed-off-by: Emil Velikov
---
src/gallium/drivers/svga/svg
From: Emil Velikov
Note that all the symbols/ABI checks in tree do so :-\
Signed-off-by: Emil Velikov
---
Mostly an RFC since the es*api code might be going soon.
---
src/mapi/es2api/ABI-check | 4
1 file changed, 4 insertions(+)
diff --git a/src/mapi/es2api/ABI-check b/src/mapi/es2api
From: Emil Velikov
This makes it easier/clearer as to:
- if the file should have the execute bit set (.py should not)
- do we need the shebang in the first place and if so what it should be
Signed-off-by: Emil Velikov
---
This is going to clash with my earlier fixes in the area.
---
src
From: Emil Velikov
Analogous to earlier commit(s).
Signed-off-by: Emil Velikov
---
src/amd/common/sid_tables.py | 0
src/amd/vulkan/vk_format_parse.py | 0
src/amd/vulkan/vk_format_table.py | 0
3 files changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644 src/amd/com
From: Emil Velikov
Analogous to earlier commit(s).
Signed-off-by: Emil Velikov
---
src/gallium/drivers/svga/svgadump/svga_dump.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/gallium/drivers/svga/svgadump/svga_dump.py
b/src/gallium/drivers/svga/svgadump/svga_dump.py
index
From: Emil Velikov
Analogous to earlier commit(s).
Signed-off-by: Emil Velikov
---
src/gallium/auxiliary/util/u_format_parse.py | 0
src/gallium/auxiliary/util/u_format_table.py | 0
2 files changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644 src/gallium/auxiliary/u
From: Emil Velikov
Analogous to earlier commit(s).
Signed-off-by: Emil Velikov
---
src/gallium/auxiliary/indices/u_indices_gen.py | 1 -
src/gallium/auxiliary/indices/u_unfilled_gen.py | 1 -
src/gallium/auxiliary/util/u_format_pack.py | 1 -
src/gallium/auxiliary/util/u_format_parse.py
From: Emil Velikov
Analogous to earlier commit(s).
Signed-off-by: Emil Velikov
---
src/gallium/drivers/freedreno/ir3/ir3_nir_trig.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/gallium/drivers/freedreno/ir3/ir3_nir_trig.py
b/src/gallium/drivers/freedreno/ir3/ir3_nir_trig.py
index
From: Emil Velikov
Analogous to earlier commit(s).
Signed-off-by: Emil Velikov
---
src/mesa/main/format_info.py| 1 -
src/mesa/main/format_pack.py| 1 -
src/mesa/main/format_parser.py | 1 -
src/mesa/main/format_unpack.py | 1 -
src/mesa/main/get_hash_generator.py
From: Emil Velikov
Analogous to earlier commit(s).
Signed-off-by: Emil Velikov
---
src/amd/common/sid_tables.py | 1 -
src/amd/vulkan/vk_format_parse.py | 1 -
src/amd/vulkan/vk_format_table.py | 1 -
3 files changed, 3 deletions(-)
diff --git a/src/amd/common/sid_tables.py b/src/amd
From: Emil Velikov
Analogous to earlier commit(s).
Signed-off-by: Emil Velikov
---
src/mesa/drivers/dri/common/xmlpool/gen_xmlpool.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mesa/drivers/dri/common/xmlpool/gen_xmlpool.py
b/src/mesa/drivers/dri/common/xmlpool/gen_xmlpool.py
From: Emil Velikov
Analogous to earlier commit(s).
Signed-off-by: Emil Velikov
---
src/intel/genxml/gen_pack_header.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/intel/genxml/gen_pack_header.py
b/src/intel/genxml/gen_pack_header.py
index 1024745bfb..a1befaf45e 100644
--- a/src
From: Emil Velikov
Seemingly there is nothing bash specific in these. The Debian
checkbashisms does not spot neither run in zsh.
Signed-off-by: Emil Velikov
---
src/mapi/es1api/ABI-check | 2 +-
src/mapi/es2api/ABI-check | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a
From: Emil Velikov
Analogous to earlier commit(s).
Signed-off-by: Emil Velikov
---
src/mesa/main/format_parser.py | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644 src/mesa/main/format_parser.py
diff --git a/src/mesa/main/format_parser.py b/src/mesa/m
From: Emil Velikov
This is a python2 script and the generic "python" may point to python3.
Cc: Andreas Boll
Signed-off-by: Emil Velikov
---
We really want to prune/rename all the conflicting entrypoints.
In the radeon/r200 case we could even:
- fold the common code to a simple pla
From: Emil Velikov
Analogous to earlier commit(s).
Signed-off-by: Emil Velikov
---
src/mesa/drivers/dri/i965/brw_nir_trig_workarounds.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_nir_trig_workarounds.py
b/src/mesa/drivers/dri/i965
From: Emil Velikov
These are python2 scripts and the generic "python" may point to
python3.
Signed-off-by: Emil Velikov
---
src/gallium/tools/trace/diff_state.py | 2 +-
src/gallium/tools/trace/dump.py | 2 +-
src/gallium/tools/trace/dump_state.py | 2 +-
src/gallium/t
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/compiler/glsl/tests/optimization-test.sh | 4 ++--
src/compiler/glsl/tests/warnings-test.sh | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/compiler/glsl/tests/optimization-test.sh
b/src/compiler/glsl
From: Emil Velikov
Analogous to earlier commit(s).
Signed-off-by: Emil Velikov
---
src/compiler/nir/nir_algebraic.py| 1 -
src/compiler/nir/nir_builder_opcodes_h.py| 1 -
src/compiler/nir/nir_constant_expressions.py | 1 -
src/compiler/nir/nir_opcodes.py | 1
From: Emil Velikov
Analogous to earlier commit(s).
Signed-off-by: Emil Velikov
---
src/util/format_srgb.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/util/format_srgb.py b/src/util/format_srgb.py
index d5cbcf7646..44b35a061d 100644
--- a/src/util/format_srgb.py
+++ b/src/util
From: Emil Velikov
We don't use DRYRUN (and no others scripts have one) so just drop it.
This allows us to rework the loop to the more commonly used "git |
while read foo; do ... done"
That in itself gets rid of the only remaining bashism and we can toggle
the shebang to /
It is not guaranteed to be in /bin
Signed-off-by: Emil Velikov
---
src/gallium/tools/addr2line.sh | 2 +-
src/gallium/tools/trace/tracediff.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/tools/addr2line.sh b/src/gallium/tools/addr2line.sh
index
From: Emil Velikov
Remove the typeset built-in and toggle to /bin/sh
Signed-off-by: Emil Velikov
---
Sidenote: seems like there is something in the script which causes bash
to trip in the odd occasion while zsh works like a charm.
Namely "[rasterizer]" would become "z" wh
From: Emil Velikov
There's nothing bash specific in the script.
Signed-off-by: Emil Velikov
---
src/egl/egl-symbols-check | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/egl/egl-symbols-check b/src/egl/egl-symbols-check
index 409867fab6..4c5232cb6c 100755
--- a/sr
From: Emil Velikov
To provide direct feedback about the file in question.
Cc: José Fonseca
Signed-off-by: Emil Velikov
---
Jose, I sincerely hope this doesn't cause issues on your end.
---
bin/{perf-annotate-jit => perf-annotate-jit.py} | 0
docs/llvmp
From: Emil Velikov
Analogous to previous commit.
Signed-off-by: Emil Velikov
---
src/gbm/gbm-symbols-check | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gbm/gbm-symbols-check b/src/gbm/gbm-symbols-check
index 5a333ffcda..34fe11b874 100755
--- a/src/gbm/gbm-symbols
From: Emil Velikov
Silly thinko on my end, as I was writing the script. There is nothing
bash specific in there.
Signed-off-by: Emil Velikov
---
bin/get-fixes-pick-list.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bin/get-fixes-pick-list.sh b/bin/get-fixes-pick
From: Emil Velikov
Just like the the dozens of other shaders, the file is parsed by
separate tool and not executed.
Cc: José Fonseca
Signed-off-by: Emil Velikov
---
Jose, please double-check since I've got no idea how there are used.
Out of curiosity - do you guys still use these ? A
From: Emil Velikov
Analogous to earlier commit(s).
Signed-off-by: Emil Velikov
---
src/mesa/drivers/dri/i965/brw_nir_trig_workarounds.py | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644
src/mesa/drivers/dri/i965/brw_nir_trig_workarounds.py
diff --git a/
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/egl/wayland/wayland-egl/wayland-egl-symbols-check | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/egl/wayland/wayland-egl/wayland-egl-symbols-check
b/src/egl/wayland/wayland-egl/wayland-egl-symbols-check
index
From: Emil Velikov
All of those should be executed $PYTHON2/python2 [or equivalent] hence
why they are missing the execute bit.
Signed-off-by: Emil Velikov
---
src/mapi/glapi/gen/glX_XML.py | 1 -
src/mapi/glapi/gen/glX_proto_common.py | 1 -
src/mapi/glapi/gen/glX_proto_recv.py
From: Emil Velikov
Signed-off-by: Emil Velikov
---
Is this still used ? Running it produces some some 250+ diff stat.
---
src/gallium/state_trackers/xa/Makefile.am | 2 +-
src/gallium/state_trackers/xa/{xa-indent => xa-indent.sh} | 2 +-
2 files changed, 2 insertions(+)
On 23 February 2017 at 17:22, Dylan Baker wrote:
> Quoting Emil Velikov (2017-02-23 02:32:17)
>> On 22 February 2017 at 23:35, Dylan Baker wrote:
>> > This changes the python generator to write the files itself, rather than
>> > piping them out. This has a coup
On 23 February 2017 at 17:34, Matt Turner wrote:
> s/flacky/flakey/ in the title.
>
> On Thu, Feb 23, 2017 at 9:13 AM, Emil Velikov
> wrote:
>> From: Emil Velikov
>>
>> Note that all the symbols/ABI checks in tree do so :-\
>>
>> Signed-off-by: Emil
On 23 February 2017 at 17:54, Matt Turner wrote:
> On Thu, Feb 23, 2017 at 9:29 AM, Emil Velikov
> wrote:
>> On 23 February 2017 at 17:22, Dylan Baker wrote:
>>> Quoting Emil Velikov (2017-02-23 02:32:17)
>>>> On 22 February 2017 at 23:35, Dylan Baker wrot
lf-rejected by dropping the nomination tag,
prior to commiting to master.
Please let me know if that's incorrect and you'd like this in stable -
personally, I'm split if it's a good idea to merge it or not.
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 24 February 2017 at 12:52, Andreas Boll wrote:
> 2017-02-23 18:13 GMT+01:00 Emil Velikov :
>> From: Emil Velikov
>>
>> This is a python2 script and the generic "python" may point to python3.
>>
>> Cc: Andreas Boll
>> Signed-off-by: Emil Veli
On 24 February 2017 at 12:30, Andreas Boll wrote:
> 2017-02-23 17:48 GMT+01:00 Emil Velikov :
>> From: Emil Velikov
>>
>> The final user of it was st/vega.
>>
>> Cc: Andreas Boll
>> Signed-off-by: Emil Velikov
>> ---
>> Andreas this (and
vk_gen.py, don't edit directly. */
>
> s/vk_gen.py/anv_entrypoints_gen.py/ :)
>
This seems to be rather common across projects. Just an idea -
sys.argv[0] should work right ?
IMHO, feel free to address that whenever you prefer.
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
yes, please.
Reviewed-by: Emil Velikov
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_egl" = xyes; then
> +require_basic_egl "radeonsi"
> +fi
I'm split if we want to keep the check as-is or move within
require_basic_egl. In either case:
Fixes: 1ac40173c2a ("configure.ac: simplify EGL requirements for
drivers dependent on E
anv_entrypoints.h: anv_entrypoints.c
anv_entrypoints.c: anv_entrypoints_gen.py $(vulkan_api_xml)
...
Not 100% sure on the above suggestion - someone please correct me.
Yet again, we have this (bug?) rather often so feel free to address it
(and other comment from Eric) as follow-up ?
IMHO the only "blocker" is the missing --outdir in Android.mk
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
hanks for omitting the execute bit !
Maybe drop this, since one should/can not execute the file directly ?
> +
> +if args.header:
> +header_file = open(args.header, 'w')
> +
> +
> +h(copyright)
> +h("""#pragma once
Use proper ifndef guards please.
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 24 February 2017 at 14:25, Leo Liu wrote:
> On 02/24/2017 09:07 AM, Emil Velikov wrote:
>>
>> On 23 February 2017 at 18:43, Leo Liu wrote:
>>>
>>> Otherwise the configuration fails when building independant libs
>>> like vdpau, vaapi or omx
>&g
On 24 February 2017 at 14:58, Eric Engestrom wrote:
> On Thursday, 2017-02-23 16:07:36 +0000, Emil Velikov wrote:
>> You're a star Eric, thank you !
>>
>> On 22 February 2017 at 11:24, Eric Engestrom
>> wrote:
>> > Signed-off-by: Eric Engestrom
>&
On 24 February 2017 at 15:42, Eric Engestrom wrote:
> On Thursday, 2017-02-23 16:43:08 +0000, Emil Velikov wrote:
>> From: Emil Velikov
>>
>> Bail out early if the script is not where we expect it to be.
>>
>> Signed-off-by: Emil Velikov
>> ---
>>
On 24 February 2017 at 15:58, Eric Engestrom wrote:
> On Thursday, 2017-02-23 16:43:09 +0000, Emil Velikov wrote:
>> From: Emil Velikov
>>
>> Signed-off-by: Emil Velikov
>> ---
>> src/compiler/glsl/tests/optimization-test | 13 -
>> 1 fil
On 24 February 2017 at 15:34, Eric Engestrom wrote:
> On Thursday, 2017-02-23 16:43:07 +0000, Emil Velikov wrote:
>> From: Emil Velikov
>>
>> Otherwise we'll fail when invoking the script outside of "make check"
>>
>> Signed-off-by: Emil Velikov
On 24 February 2017 at 16:13, Eric Engestrom wrote:
> On Thursday, 2017-02-23 16:43:10 +0000, Emil Velikov wrote:
>> From: Emil Velikov
>>
>> At the moment things are completely bonkers (as can be seen from last
>> commit). Regardless if we run the test as part of &q
Humble ping anyone ?
-Emil
On 24 January 2017 at 21:21, Emil Velikov wrote:
> From: Emil Velikov
>
> Using typedef(s) is not always the answer and makes it harder for people
> to do clever (or one might call nasty) things with the code.
>
> Add a struct name which we will
ths... around the same time mesa 17.1. Which makes me lean even
more towards no.
Do we have (m)any compelling reasons to have this in 17.0 ?
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
'--output-path', help=textwrap.dedent('''\
> + -o $(top_builddir)/src/vulkan/util for Linux builds
> + -o $(intermediates)/util for Android builds'''),
Not sure if we need all this help string. Not to mention that we'll
forget to update as we
ine change in the
makefile(s). Perhaps I should have made that clearer :-(
That aside - tried to pull/test your series, but patchwork has gone
crazy (doesn't like git series?). Do you have a branch somewhere ?
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
ad.
>
> I just pushed a1e5e55989 ("check: mark two tests are requiring bash")
> which fixes this by simply asking for bash in the shebang, which was
> what my original patch did, and was changed just before pushing because
> of a review comment that turned out to be wrong :)
>
Yes, my bad on that one - guess I shouldn't trust checkbashisms/zsh that much.
I won't object if we can make these tests 'generic' sh - patches welcome ;-)
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
ng run,
it's better to fix the tool (ASAN/other) than trying to "fix" all the
cases in mesa and dozens of other projects. But until then patches are
safe enough ;-)
That's my take on it, at least.
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
27;t started drawing the next frame at this
>> point, and so hasn't requested the new buffers for the drawable yet,
>> hence the old width and height were being returned.
>
>
> OK thanks for clarifying, these changes look good to
Reviewed-by: Emil Velikov
Nicely spotted, thanks.
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
which uses --link{static/shared] for 3.9+ ? For
earlier LLVM versions we might need to stick with the current code...
which shouldn't use LLVM_COMPONENTS in the static case (another
patch).
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
gt;
// To avoid adding extra guard (BUILD_OPENCL) in the r600/radeon
common code, simply link with LLVM when present.
// Otherwise we'll need to track and extra macro for r600 and always
enable it for radeonsi - the latter a workaround in order to get
things to build properly.
if test "x$enable_llvm" = xyes; then
The above should be sufficient, afaict. Please polish/wrap in a
commit, cc stable and feel free to reuse (elaborate) any of my comment
above.
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
might need the LLVM/LIBELF_CFLAGS
-> quick (mv && nano libelf.pc) will do the latter.
> libradeon_la_LIBADD = \
> $(CLOCK_LIB) \
> $(LLVM_LIBS) \
> $(LIBELF_LIBS)
Although we might need to move CLOCK/LIBELF_LIB to
src/gallium/drivers/{r600,radeonsi}/Automake.inc TARGET_LIB_DEPS
Can you address that (as follow-up is fine) please ?
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
: Marc Dietrich
Reviewed-by: Emil Velikov
Barring any objections I'll commit this later today.
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 27 February 2017 at 19:20, Dylan Baker wrote:
> Quoting Emil Velikov (2017-02-26 10:26:24)
>> On 24 February 2017 at 18:21, Dylan Baker wrote:
>> > There are a number of small style cleanups and simplifications in this
>> > series,
>> > but the main chan
From: Emil Velikov
Since both r600 and radeonsi use code from libamd_common they need to
static link it. At the same time, adding a common library to LIB_DEPS is
fragile [can lean to multiple symbol definitions] and non-obvious - I
had to do a double-take how things work atm.
So follow the
is correct we have a nice error message at configure ;-)
> Also, you can see fedora's configure parameters at
> https://src.fedoraproject.org/cgit/rpms/mesa.git/tree/mesa.spec#n399
>
Tl;Dr: If you are not too sure just copy the lot (literally) from your
distro ;-)
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> $(vulkan_api_xml)
>> $(MKDIR_GEN)
>> - $(PYTHON_GEN) $(srcdir)/util/gen_enum_to_str.py
>> + $(PYTHON_GEN) $(srcdir)/util/gen_enum_to_str.py -o
>> $(top_builddir)/src/vulkan/util
>
> Just like the other Makefile patch a few days ago, this rule will run
> the python scrip
On 27 February 2017 at 19:36, Emil Velikov wrote:
> On 27 February 2017 at 19:20, Dylan Baker wrote:
>> Quoting Emil Velikov (2017-02-26 10:26:24)
>>> On 24 February 2017 at 18:21, Dylan Baker wrote:
>>> > There are a number of small style cleanups and simplif
o foo
> foo
> echo bar
> bar
>
> It runs both targets, regardless of the fact they have the same rule.
>
I was wondering about the "foo.c: bar.h" case, like below.
8<
all: foo.c bar.h
bar.h:
@echo $@
foo.c: bar.h
>8
$make -f foo
bar.h
It does it onc
From: Emil Velikov
Do not hardcode the file in the python script, but pass it via the build
system(s). The former is the only one that should know about the file
locaiton/tree structure.
Cc: Dylan Baker
Signed-off-by: Emil Velikov
---
src/vulkan/Android.mk | 2 +-
src/vulkan
OSMesaPixelsStore typo
Chad Versace (1):
mesa: Fix generation of git_sha1.h.tmp for gitlinks
Christian König (2):
vl: cleanup video buffer private when the decoder is destroyed
st/vdpau: fix mixer size checks
Emil Velikov (4):
docs: Add sha256 checksums for the 10.6.2 release
On 21 July 2015 at 16:43, Boyan Ding wrote:
> Signed-off-by: Boyan Ding
> ---
> configure.ac|8 +-
> src/loader/Makefile.am |9 +
> src/loader/loader_dri3_helper.c | 1397
> +++
> src/loader/loader_dri3_helper.h | 226 +++
On 21 July 2015 at 16:44, Boyan Ding wrote:
> Signed-off-by: Boyan Ding
> ---
> configure.ac | 6 +
> src/egl/drivers/dri2/Makefile.am | 5 +
> src/egl/drivers/dri2/egl_dri2.c | 66 +++-
> src/egl/drivers/dri2/egl_dri2.h | 14 +-
> src/
901 - 1000 of 8586 matches
Mail list logo
