On 21 February 2017 at 11:02, Eric Engestrom <eric.engest...@imgtec.com> wrote: > On Tuesday, 2017-02-21 09:41:18 +0100, Nicolai Hähnle wrote: >> On 20.02.2017 20:27, Emil Velikov wrote: >> > From: Emil Velikov <emil.veli...@collabora.com> >> > >> > Suggested-by: Eric Engestrom <eric.engest...@imgtec.com> >> > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> >> > --- >> > docs/releasing.html | 6 +++--- >> > 1 file changed, 3 insertions(+), 3 deletions(-) >> > >> > diff --git a/docs/releasing.html b/docs/releasing.html >> > index 048aa1f7a4..26daf505a5 100644 >> > --- a/docs/releasing.html >> > +++ b/docs/releasing.html >> > @@ -171,9 +171,9 @@ Now go to >> > <a >> > href="https://bugs.freedesktop.org/editversions.cgi?action=add&product=Mesa"; >> > target="_parent">Bugzilla</a> and add the new Mesa version X.Y. >> > </p> >> > <p> >> > -Check for rare that there are no distribution breaking changes and revert >> > them >> > -if needed. Extremely rare - we had only one case so far (see >> > -commit 2ced8eb136528914e1bf4e000dea06a9d53c7e04). >> > +Check that there are no distribution breaking changes and revert them if >> > needed. >> > +For example: files being overwritten on install, etc. Happens extremely >> > rare - > > s/rare/rarely/ > > With that, > Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > >> > +we had only one case so far (see commit >> > 2ced8eb136528914e1bf4e000dea06a9d53c7e04). >> >> Any advice on *how* to find such changes? > > +1 > How did you find you needed 2ced8eb136528, for instance? > In this particular case I've explained [tried to at least] how it will break things, nacked the patch(es) was ignored and things got merged. Generally I skim through the Makefile changes, although I should think of something better.
-Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
