On 24 February 2017 at 14:58, Eric Engestrom <eric.engest...@imgtec.com> wrote: > On Thursday, 2017-02-23 16:07:36 +0000, Emil Velikov wrote: >> You're a star Eric, thank you ! >> >> On 22 February 2017 at 11:24, Eric Engestrom <eric.engest...@imgtec.com> >> wrote: >> > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> >> > --- >> > v2: make sure the list is in the order C's strcmp uses (Ilia) >> > Ilia: I used LC_ALL instead of LANG, as it takes precedence >> > (ie. LANG=C in this script would be overridden by >> > LC_ALL=en_US in the environment). >> Personally I'm safe even without the LC_ALL bit, but it seems like a good >> idea. >> >> Perhaps we want that for the EGL test as well ? > > Of course, I just didn't want to send a bunch of versions of each until > something was accepted by everyone. > >> In both cases we really want to set srcdir, such that ./dispatch-index-check >> and >> ../some/crazy/path/to/dispatch-index-check also work. >> >> Perhaps reuse the autogen.sh magic ? > > Sure, I could, but I'm not sure I see the point? Are these tests ever > run not through `make check` ? > And if someone does do that, surely they can be expected to know they > need to set $srcdir correctly? > The other tests we have use srcdir, if available, and fallback appropriately. Modulo other other bugs of course ;-)
-Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
