0) rather than explicit.
the same comment applies to your v2.
Jan
Thanks for the input. Now when I think about it again this is probably a
bad change.
Didn't think about the lower bound. So this patch should probably not be
pushed.
--
Mvh Jakob Sin
V2: Removed "- PIPE_SWIZZLE_X" for more consistency.
CID: 1337954
Signed-off-by: Jakob Sinclair
---
src/gallium/drivers/radeon/r600_texture.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/gallium/drivers/radeon/r600_texture.c
b/src/gallium/drivers/radeon/r600_te
Reviewed-by: Nicolai Hähnle
Thanks!
--
Mvh Jakob Sinclair
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
gned-off-by: Jakob Sinclair
---
I don't have push access so anyone reviewing this could push it. Thanks!
src/gallium/drivers/radeon/r600_texture.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeon/r600_texture.c
b/src/gallium/drivers/radeo
On 2016-06-06 15:48, Iago Toral wrote:
Reviewed-by: Iago Toral Quiroga
I don't have push access so I would be very happy if you could push this
patch for me. Thanks!
--
Mvh Jakob Sinclair
On Sat, 2016-06-04 at 01:09 +0200, Jakob Sinclair wrote:
Could cause issues if you tried to
Could cause issues if you tried to read from an uninitialised pointer.
This just initalises the pointer to null to avoid that being a problem.
Discovered by Coverity.
CID: 1343616
Signed-off-by: Jakob Sinclair
---
src/compiler/glsl/glsl_parser_extras.cpp | 1 +
1 file changed, 1 insertion
Coverity is getting a false positive that a division by zero can occur
here. This change will silence the Coverity warnings as a division by zero
cannot occur in this case.
Signed-off-by: Jakob Sinclair
---
Changes since V1: We realised that Coverity was actually giving out a false
positive and
On 2016-05-18 16:08, Nicolai Hähnle wrote:
On 18.05.2016 08:17, Jakob Sinclair wrote:
In the function r600_test_dma the max_width and max_height can be set
to
zero.
Thanks for looking into that. Can they really? I see
max_width = MIN2(tsrc.width0, tdst.width0);
max_height = MIN2
width or height to one. Issue was discoverd by Coverity.
CID: 1361542, 1361543
Signed-off-by: Jakob Sinclair
---
src/gallium/drivers/radeon/r600_test_dma.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/radeon/r600_test_dma.c
b/src/gallium
e constructors.
This issue was discovered by Coverity.
CID: 401603, 401604, 401605, 401610
Signed-off-by: Jakob Sinclair
---
I don't have push access so anyone reviewing this patch could push it. Thank
you!
src/compiler/glsl/ir.cpp | 5 +
1 file changed, 5 insertions(+)
diff --git a/s
e constructors.
This issue was discovered by Coverity.
CID: 401603, 401604, 401605, 401610
Signed-off-by: Jakob Sinclair
---
src/compiler/glsl/ir.cpp | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/compiler/glsl/ir.cpp b/src/compiler/glsl/ir.cpp
index d69ab13..9637d7a 100644
--- a/src/
Reviewed-by: Jakob Sinclair
On 2016-05-02 07:15, Jan Vesely wrote:
From: Jan Vesely
Signed-off-by: Jan Vesely
---
src/gallium/auxiliary/util/u_blitter.c| 10 +-
src/gallium/auxiliary/util/u_cpu_detect.c | 2 +-
src/gallium/auxiliary/util/u_format.c | 4
re careful with testing the patch. Anyways
this looks all good to me. By the fact that you are using assert I'm
guessing that first_non_void shouldn't be negative very often and that
when it is negative something has gone horribly wrong.
On 2016-04-27 12:17, Marek Olšák wrote:
Reviewed-by: Marek Olšák
Marek
On Mon, Apr 25, 2016 at 9:03 AM, Jakob Sinclair
wrote:
Fixes a Coverity defect by adding checks to see if a value is negative
before using it to index an array. By checking the value first it
makes
the code a bit safer
Fixes a Coverity defect by adding checks to see if a value is negative
before using it to index an array. By checking the value first it makes
the code a bit safer but overall should not have a big impact.
CID: 1355598
Signed-off-by: Jakob Sinclair
---
Resending this patch because I did not
Fixes a Coverity defect by adding checks to see if a value is negative
before using it to index an array. By checking the value first it makes
the code more clean and it doesn't change the outcome of the function.
CID: 1355598
Signed-off-by: Jakob Sinclair
---
src/gallium/drivers/rad
This patch fixes a Coverity defect. By checking if the value is negative before
using it to index an array it makes the code a bit safer and cleaner but it
should not actually change the outcome of the functions.
CID: 1355598
Jakob Sinclair (1):
radeonsi: check if value is negative
src
e that object to create a new surface which the old
surface can now point too.
Did I get the idea behind it or did I misunderstand the whole thing?
--
Mvh Jakob Sinclair
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedes
implementation of the same function. I don't have push access so someone
reviewing this can push it.
Regards
Jakob Sinclair
Jakob Sinclair (4):
gallium/radeon: add clear_texture function
gallium/radeonsi: enable ARB_clear_texture
gallium/r600: enable ARB_clear_texture
docs/GL3.txt:
tures...)
Thanks for the heads up. It did at least not cause any errors on the
piglit test.
I will need to probably check with other radeon developers to see if
this is actually safe.
--
Mvh Jakob Sinclair
___
mesa-dev mailing list
mes
Signed-off-by: Jakob Sinclair
---
src/gallium/drivers/r600/r600_pipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/r600/r600_pipe.c
b/src/gallium/drivers/r600/r600_pipe.c
index c594f5c..7d1d6b2 100644
--- a/src/gallium/drivers/r600/r600_pipe.c
+++ b
Tested with piglit. All ARB_clear_texture tests passed.
Signed-off-by: Jakob Sinclair
---
docs/GL3.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index dc75cf8..654c856 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -192,7 +192,7 @@ GL 4.4
This patch adds the needed function for ARB_clear_texture.
The function itself is mostly based on the nouveau implementation.
Signed-off-by: Jakob Sinclair
---
src/gallium/drivers/radeon/r600_texture.c | 72 +++
1 file changed, 72 insertions(+)
diff --git a/src
Signed-off-by: Jakob Sinclair
---
src/gallium/drivers/radeonsi/si_pipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_pipe.c
b/src/gallium/drivers/radeonsi/si_pipe.c
index 6a990ed..2382b1d 100644
--- a/src/gallium/drivers/radeonsi/si_pipe.c
Signed-off-by: Jakob Sinclair
---
src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp | 2 +-
src/mesa/math/m_debug_norm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp
b/src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp
index
Removes all acidental semi-colons in egl.
Signed-off-by: Jakob Sinclair
---
src/egl/drivers/dri2/platform_android.c | 2 +-
src/egl/drivers/dri2/platform_surfaceless.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_android.c
b/src/egl
Signed-off-by: Jakob Sinclair
---
src/glx/dri2_glx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c
index 7710349..eae3c0f 100644
--- a/src/glx/dri2_glx.c
+++ b/src/glx/dri2_glx.c
@@ -405,7 +405,7 @@ dri2CreateDrawable(struct
Signed-off-by: Jakob Sinclair
---
src/gallium/drivers/freedreno/a3xx/fd3_emit.c | 2 +-
src/gallium/drivers/ilo/ilo_resource.c| 2 +-
src/gallium/drivers/ilo/shader/ilo_shader_gs.c| 2 +-
src/gallium/drivers/nouveau/codegen/nv50_ir_ssa.cpp | 2
yet either.
Regards
Jakob Sinclair
Jakob Sinclair (4):
egl: Remove every double semi-colon
gallium: Remove every double semi-colon
glx: Remove every double semi-colon
mesa: Remove every double semi-colon
src/egl/drivers/dri2/platform_android.c | 2 +-
src/egl/dr
On 2016-04-14 00:43, Ian Romanick wrote:
It looks like there are a couple other instances dangling around the
tree. src/glx/dri2_glx.c, src/mesa/math/m_debug_norm.c, etc.
I did 'grep -r ';[[:space:]]*;' src/'. Most of the hits were
for-loops.
On 04/13/2016 09:43 AM,
he uniform storage so it just uses the
gl_constant_value could lead to much simplier, but also more effiecient,
code.
So is it a reasonable idea to implement right now?
What kind of problems could you expect and would anyone benefit from
it?
--
Mvh Jako
Trivial change. Removing unnecessary semi-colons from the code.
I don't have push access so someone reviewing this can push it.
Signed-off-by: Jakob Sinclair
---
src/compiler/glsl/ast_function.cpp | 2 +-
src/compiler/glsl/ir_rvalue_visitor.cpp | 2 +-
2 files changed, 2 insertions(
Trivial change. Removing unnecessary semi-colons from the code.
I don't have push access so someone reviewing this can push it.
Signed-off-by: Jakob Sinclair
---
src/gallium/drivers/r600/sb/sb_bc_parser.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/dr
Trivial change. Removing unnecessary semi-colons from the code.
I don't have push access so someone reviewing this can push it.
Signed-off-by: Jakob Sinclair
---
src/mesa/main/pipelineobj.c | 2 +-
src/mesa/main/shaderapi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
On 2016-04-12 11:00, Timothy Arceri wrote:
On Sun, 2016-04-10 at 21:45 +0200, Jakob Sinclair wrote:
Hi! My name is Jakob Sinclair and I would like to start contributing
to
mesa development. I was wondering if anyone has any easy tasks that I
as
a newbie could start working on. I tried looking
ne that is reviewing this patch can push this.
Signed-off-by: Jakob Sinclair
---
src/mesa/state_tracker/st_cb_bufferobjects.c | 8
src/mesa/state_tracker/st_cb_drawpixels.c| 8
src/mesa/state_tracker/st_cb_readpixels.c| 4 ++--
src/mesa/state_tracker/st_cb_texture.c
On 2016-04-11 17:25, Ilia Mirkin wrote:
On Mon, Apr 11, 2016 at 11:18 AM, Jakob Sinclair
wrote:
Thanks for the tips! I have been looking at the
ARB_shader_image_load_store
and ARB_shader_image size extensions for GL ES 3.1 and noticed that
the
radeonsi drivers does not support them even
the driver supports the extensions in the core profile. From what
I can tell all supported functions are already in the driver. What needs
to be added to the driver to gain support for the extensions in a GL ES
3.1 context?
On Mon, Apr 11, 2016 at 11:54 AM, Jakob Sinclair
wrote:
On 2016-04-11 09
Really appreciate it.
On Sun, Apr 10, 2016 at 12:45 PM, Jakob Sinclair
wrote:
Hi! My name is Jakob Sinclair and I would like to start contributing
to mesa development. I was wondering if anyone has any easy tasks
that I as a newbie could start working on. I tried looking at
https://wiki.freedesk
Hi! My name is Jakob Sinclair and I would like to start contributing to
mesa development. I was wondering if anyone has any easy tasks that I as
a newbie could start working on. I tried looking at
https://wiki.freedesktop.org/dri/NewbieProjects/ but it seems that page
is outdated and most of
40 matches
Mail list logo
