On 2016-06-13 12:02, Nicolai Hähnle wrote:
Meh. This is the kind of thing where Coverity should perhaps just shut up :/
I do agree with you that Coverity should perhaps shut up about this kinda thing but I couldn't see a reason to have these checks in the code. They really didn't contribute to my understanding of the code. Although I may be missing something
important here.
Anyway... I think for consistency, you should also remove the '- PIPE_SWIZZLE_X' here, similar to the first hunk. With that changed,
Forgot about that one. I agree with this change.
Reviewed-by: Nicolai Hähnle <[email protected]>
Thanks! -- Mvh Jakob Sinclair _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
