Re: [Mesa-dev] [PATCH 2/3] panfrost: Make the gitlab-ci.yml file more robust

On 6/20/19 6:33 PM, Rohan Garg wrote: Not sure I understand how this works. Isn't this going to cause unnecessary container builds? And, why cannot developers just add whatever they want to DEBIAN_TAG to that end? This will spin a container for each branch, yes, though I think that is how it

Re: [Mesa-dev] [PATCH 8/8] radeonsi: rename and re-document cache flush flags

For the series Tested-by: Dieter Nützel on Polaris 20 Except gfx10 stuff...;-) Dieter Am 20.06.2019 06:19, schrieb Marek Olšák: From: Marek Olšák SMEM and VMEM caches are L0 on gfx10. --- src/gallium/drivers/radeonsi/si_compute.c | 2 +- .../drivers/radeonsi/si_compute_blit.c

Re: [Mesa-dev] [PATCH 7/7] radeonsi: don't use the low-optimizing compiler on LLVM 9

Yeah, I dropped it because LLVM is still slow. Marek On Thu, Jun 20, 2019 at 6:45 PM Dieter Nützel wrote: > Hello Marek, > > is this (#7) obsolete, now? > Kind reminder. > > Thanks, > Dieter > > Am 13.06.2019 02:40, schrieb Marek Olšák: > > From: Marek Olšák > > > > The compilation is faster o

Re: [Mesa-dev] [PATCH 7/7] radeonsi: don't use the low-optimizing compiler on LLVM 9

Hello Marek, is this (#7) obsolete, now? Kind reminder. Thanks, Dieter Am 13.06.2019 02:40, schrieb Marek Olšák: From: Marek Olšák The compilation is faster on LLVM 9. --- src/gallium/drivers/radeonsi/si_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/galliu

[Mesa-dev] [Bug 110953] Adding a redundant single-iteration do-while loop causes different image to be rendered

https://bugs.freedesktop.org/show_bug.cgi?id=110953 Ian Romanick changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |i...@freedesktop.org |

[Mesa-dev] renderdoc-traces: like shader-db for runtime

Hey folks, I wanted to show you this follow-on to shader-db I've been working on: https://gitlab.freedesktop.org/anholt/renderdoc-traces For x86 development I've got a collection of ad-hoc scripts to capture FPS numbers from various moderately interesting open source apps so I could compare-perf

Re: [Mesa-dev] [PATCH v2] ehl: disable repacking for compression for compatibilty

+mesa-dev On Thu, Jun 20, 2019 at 12:20 PM Anuj Phogat wrote: > > I sent out comments on your older patch. They applies to this patch too. > Split i965 and anv changes in separate patches. > > On Thu, Jun 20, 2019 at 11:25 AM Dongwon Kim wrote: > > > > Repacking components in certain pixel forma

Re: [Mesa-dev] [PATCH] iris/ehl: disable repacking for compression for compatibilty

On Tue, Jun 4, 2019 at 9:20 AM Dongwon Kim wrote: > > Repacking components in certain pixel formats before compression > shouldn't be done for EHL to keep the compatibility with decompression > capability in its display controller. > > Signed-off-by: Dongwon Kim > --- > src/gallium/drivers/iris/

[Mesa-dev] [PATCH] panfrost: ci: Update expectations

These tests have been fixed recently. Signed-off-by: Tomeu Vizoso --- .../drivers/panfrost/ci/expected-failures.txt | 54 --- 1 file changed, 54 deletions(-) diff --git a/src/gallium/drivers/panfrost/ci/expected-failures.txt b/src/gallium/drivers/panfrost/ci/expected-failures.t

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/3] amd: Apply elf relocations and allow code with relocations

On Sat, 2019-06-15 at 07:38 +0200, Dieter Nützel wrote: > Am 14.06.2019 08:13, schrieb Jan Vesely: > > On Thu, 2019-06-13 at 21:20 +0200, Dieter Nützel wrote: > > > Am 13.06.2019 07:10, schrieb Marek Olšák: > > > > FYI, I just pushed the new linker. > > > > > > > > Marek > > > > > > Thank you ver

[Mesa-dev] [PATCH] panfrost: Implement command stream scoreboarding

This is a rather complex change, adding a lot of code but ideally cleaning up quite a bit as we go. Within a batch (single frame), there are multiple distinct Mali job types: SET_VALUE, VERTEX, TILER, FRAGMENT for the few that we emit right now (eventually more for compute and geometry shaders). E

Re: [Mesa-dev] [PATCH] llvmpipe: make remove_shader_variant static.

Reviewed-by: Roland Scheidegger Am 19.06.19 um 22:47 schrieb Dave Airlie: > From: Dave Airlie > > this isn't used outside this file. > --- > src/gallium/drivers/llvmpipe/lp_state_fs.c | 2 +- > src/gallium/drivers/llvmpipe/lp_state_fs.h | 4 > 2 files changed, 1 insertion(+), 5 deletions(

[Mesa-dev] [Bug 110953] Adding a redundant single-iteration do-while loop causes different image to be rendered

https://bugs.freedesktop.org/show_bug.cgi?id=110953 Bug ID: 110953 Summary: Adding a redundant single-iteration do-while loop causes different image to be rendered Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] ?= [PATCH] android:=?utf-8?q? virgl: fix libmesa_virgil_common build and dependencies

On Thu, Jun 20, 2019 at 08:20:12AM +0100, Alexandros Frantzis wrote: On Saturday, June 15, 2019 06:39 BST, Mauro Rossi wrote: Fixes the following building errors and resolves Bug 110922 Fixes gallium_dri target missing symbols at linking. Thanks for the fix. I wonder what would be involved i

Re: [Mesa-dev] [PATCH 2/3] panfrost: Make the gitlab-ci.yml file more robust

Not sure I understand how this works. Isn't this going to cause unnecessary container builds? And, why cannot developers just add whatever they want to DEBIAN_TAG to that end? This will spin a container for each branch, yes, though I think that is how it should be. The patch allows for someone

[Mesa-dev] [Bug 110709] g_glxglvnddispatchfuncs.c and glxglvnd.c fail to build with clang 8.0

https://bugs.freedesktop.org/show_bug.cgi?id=110709 Eric Engestrom changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] panfrost: Skip shading unaffected tiles

On Thu, 20 Jun 2019 at 16:56, Alyssa Rosenzweig wrote: > > > Isn't enough with ctx->blitter->running ? > > What if we're legitimately blitting something? Forgot about that. Reviewed-by: Tomeu Vizoso Thanks! Tomeu ___ mesa-dev mailing list mesa-dev@l

Re: [Mesa-dev] [PATCH] panfrost: Set job requirements during draw

On Thursday, 20 June 2019 16:06:57 CEST you wrote: > Right now we are doing it at a moment when we don't have all the > information we need. > > Signed-off-by: Tomeu Vizoso > Suggested-by: Alyssa Rosenzweig > Cc: Rohan Garg > Fixes: bfca21b622df ("panfrost: Figure out job requirements in pan_jo

Re: [Mesa-dev] [PATCH] panfrost: Skip shading unaffected tiles

> Isn't enough with ctx->blitter->running ? What if we're legitimately blitting something? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] panfrost: Skip shading unaffected tiles

On 6/20/19 4:18 PM, Alyssa Rosenzweig wrote: Looking at the scissor, we can discard some tiles. We specifially don't care about the scissor on the wallpaper, since that's a no-op if the entire tile is culled. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c |

Re: [Mesa-dev] [PATCH 2/3] panfrost: Make the gitlab-ci.yml file more robust

On Thu, 20 Jun 2019 at 15:59, Rohan Garg wrote: > > This enables developers to add packages to the container > when working on their own branches by creating > a container tag which features the branch name. Not sure I understand how this works. Isn't this going to cause unnecessary container bui

Re: [Mesa-dev] [PATCH 3/3] panfrost: The working dir is deleted right before

Good commit, but the "what" should be in the subject line and the "why" in the body. With that change: Reviewed-by: Tomeu Vizoso Thanks, Tomeu On Thu, 20 Jun 2019 at 15:59, Rohan Garg wrote: > > Change to /artifacts in order to potentially fix > debootstrap failiures. > --- > src/gallium/dr

[Mesa-dev] [PATCH] panfrost: Skip shading unaffected tiles

Looking at the scissor, we can discard some tiles. We specifially don't care about the scissor on the wallpaper, since that's a no-op if the entire tile is culled. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 9 + src/gallium/drivers/panfrost/pan_co

[Mesa-dev] [PATCH] panfrost/midgard: Broadcast swizzle

Fixes regression in shaders using ball/etc. v2: Don't also regress every other swizzle in Equestria. Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 55 +-- 1 file changed, 39 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/p

Re: [Mesa-dev] [PATCH 1/3] panfrost: Print a backtrace if there is one

On Thu, 20 Jun 2019 at 15:59, Rohan Garg wrote: > > --- > src/gallium/drivers/panfrost/ci/create-rootfs.sh | 2 +- > src/gallium/drivers/panfrost/ci/deqp-runner.sh | 6 ++ > src/gallium/drivers/panfrost/ci/gitlab-ci.yml| 4 ++-- > src/gallium/drivers/panfrost/ci/lava-deqp.ym

Re: [Mesa-dev] [PATCH] panfrost: Set job requirements during draw

R-b, though let's wait for Rohan :) signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] panfrost: Set job requirements during draw

Right now we are doing it at a moment when we don't have all the information we need. Signed-off-by: Tomeu Vizoso Suggested-by: Alyssa Rosenzweig Cc: Rohan Garg Fixes: bfca21b622df ("panfrost: Figure out job requirements in pan_job.c") --- src/gallium/drivers/panfrost/pan_context.c | 2 ++ src

[Mesa-dev] [PATCH 3/3] panfrost: The working dir is deleted right before

Change to /artifacts in order to potentially fix debootstrap failiures. --- src/gallium/drivers/panfrost/ci/debian-install.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/panfrost/ci/debian-install.sh b/src/gallium/drivers/panfrost/ci/debian-install.sh index 8a8b4ec9a47

[Mesa-dev] [PATCH 2/3] panfrost: Make the gitlab-ci.yml file more robust

This enables developers to add packages to the container when working on their own branches by creating a container tag which features the branch name. Dropped the IMAGE_LOCAL variable since I did not see it being used anywhere. --- src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 6 +++--- 1 file

[Mesa-dev] [PATCH 1/3] panfrost: Print a backtrace if there is one

--- src/gallium/drivers/panfrost/ci/create-rootfs.sh | 2 +- src/gallium/drivers/panfrost/ci/deqp-runner.sh | 6 ++ src/gallium/drivers/panfrost/ci/gitlab-ci.yml| 4 ++-- src/gallium/drivers/panfrost/ci/lava-deqp.yml.jinja2 | 3 +++ 4 files changed, 12 insertions(+), 3 deleti

[Mesa-dev] [PATCH 0/3] panfrost: CI improvements

I've made a few improvements to make the CI a bit more robust. Rohan Garg (3): panfrost: Print a backtrace if there is one panfrost: Make the gitlab-ci.yml file more robust panfrost: The working dir is deleted right before src/gallium/drivers/panfrost/ci/create-rootfs.sh | 2 +- src/ga

Re: [Mesa-dev] [PATCH 3/3] panfrost: Allocate panfrost_job in panfrost_context

R-b, good one :) signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] panfrost: Release transient pools

Makes sense, R-b :) signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] panfrost: Move ra_regs to the screen context

Oh, this looks lovely! Thank you! One concern I have is that we're leaking work_vec* for REGS_VARIANTS_COUNT-1 variants, since we reinitialize those classes for each RA variant (I believe that is correct behaviour) but only store the last one (I believe that is incorrect). Perhaps we should make

Re: [Mesa-dev] [PATCH 1/3] Revert "panfrost/midgard: Enable autovectorization"

On 6/20/19 3:28 PM, Alyssa Rosenzweig wrote: NAK. There's a patch for this I pushed to your repo which should fix these regressions (they were legitimate bugs that had nothing to do with autovectorization and would have cropped up anyhow). You mean this commit? https://gitlab.freedesktop.org/t

Re: [Mesa-dev] [PATCH 3/3] panfrost: ci: Exclude flip-flops from results

> dEQP-GLES2.functional.shaders.matrix.mul.dynamic_highp_mat4_vec4_vertex No clue what's up here, but I suppose A-b for the moment :( signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freede

Re: [Mesa-dev] [PATCH 2/3] Revert "panfrost: Figure out job requirements in pan_job.c"

How about a partial revert: call panfrost_job_set_requirements() in emit_for_draw(), so the flow is the same, but we still have the code logically with the other panfrost_job code? signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-

Re: [Mesa-dev] [PATCH 1/3] Revert "panfrost/midgard: Enable autovectorization"

NAK. There's a patch for this I pushed to your repo which should fix these regressions (they were legitimate bugs that had nothing to do with autovectorization and would have cropped up anyhow). signature.asc Description: PGP signature ___ mesa-dev mail

[Mesa-dev] [PATCH 3/3] panfrost: Allocate panfrost_job in panfrost_context

Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/pan_job.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/pan_job.c b/src/gallium/drivers/panfrost/pan_job.c index 14efa71fb055..ecc0ac7be8e1 100644 --- a/src/gallium/drivers/panfrost/pa

[Mesa-dev] [PATCH 1/3] panfrost: Move ra_regs to the screen context

Signed-off-by: Tomeu Vizoso --- .../drivers/panfrost/midgard/compiler.h | 2 + .../panfrost/midgard/midgard_compile.c| 13 +- .../panfrost/midgard/midgard_compile.h| 17 ++- .../drivers/panfrost/midgard/midgard_ra.c | 116 ++ .../panfrost/midgard/midg

[Mesa-dev] [PATCH 2/3] panfrost: Release transient pools

Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/pan_context.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c index 7c0ba679dd91..78976facda3d 100644 --- a/src/gallium/

[Mesa-dev] [PATCH 0/3] panfrost: Fix a few memory leaks

Hi, we often OOM when trying to run test suites as the leaks quickly accumulate. With these patches things get much better. Thanks, Tomeu Tomeu Vizoso (3): panfrost: Move ra_regs to the screen context panfrost: Release transient pools panfrost: Allocate panfrost_job in panfrost_context

[Mesa-dev] [PATCH 3/3] panfrost: ci: Exclude flip-flops from results

These tests are failing at times, blacklist for now: dEQP-GLES2.functional.fbo.render.shared_colorbuffer_clear.tex2d_rgba dEQP-GLES2.functional.fbo.render.shared_colorbuffer_clear.tex2d_rgb dEQP-GLES2.functional.shaders.matrix.mul.dynamic_highp_mat4_vec4_vertex Signed-off-by: Tomeu Vizoso --- s

[Mesa-dev] [PATCH 2/3] Revert "panfrost: Figure out job requirements in pan_job.c"

This reverts commit bfca21b622dfd2fcfe32494339aea9061070c7e5. --- src/gallium/drivers/panfrost/pan_context.c | 8 src/gallium/drivers/panfrost/pan_job.c | 12 src/gallium/drivers/panfrost/pan_job.h | 4 3 files changed, 8 insertions(+), 16 deletions(-) diff --

[Mesa-dev] [PATCH 1/3] Revert "panfrost/midgard: Enable autovectorization"

This reverts commit 9402970751ca04c4d6edb3a0441a4063a975295c. --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_comp

[Mesa-dev] [PATCH 0/3] Make CI green again

Hi, the two commits reverted introduced some regressions and don't have an obvious fix, so I propose to revert them while we fix them properly. I also add some tests to the ignore list because they pass and fail randomly. Thanks, Tomeu Tomeu Vizoso (3): Revert "panfrost/midgard: Enable autov

Re: [Mesa-dev] [PATCH v2 2/9] radv: record if a render pass has depth/stencil resolve attachments

R-b On Wed, Jun 12, 2019, 11:44 AM Samuel Pitoiset wrote: > Only supported with vkCreateRenderPass2(). > > v2: - do not set has_resolve (now has_color_resolve) for ds resolves > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_pass.c| 27 ++- > src/amd/v

Re: [Mesa-dev] [PATCH v2 1/9] radv: rename has_resolve to has_resolve_color

Please fix the title to use the correct variable name. Otherwise r-b On Wed, Jun 12, 2019, 11:44 AM Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_resolve.c | 2 +- > src/amd/vulkan/radv_pass.c | 4 ++-- > src/amd/vulkan/radv_private.h | 4

Re: [Mesa-dev] [PATCH v2 1/6] radv: initialize levels without DCC during layout transitions

R-b for the series On Thu, Jun 20, 2019, 9:14 AM Samuel Pitoiset wrote: > v2: use a different path for GFX9 > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 49 +++- > 1 file changed, 48 insertions(+), 1 deletion(-) > > diff --git a/src/

Re: [Mesa-dev] [PATCH] radv: disable viewport clamping even if FS doesn't write Z

On 6/20/19 10:54 AM, Juan A. Suarez Romero wrote: On Tue, 2019-06-18 at 18:58 +0200, Samuel Pitoiset wrote: This fixes new CTS dEQP-VK.pipeline.depth_range_unrestricted.*. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

Re: [Mesa-dev] [PATCH] radv: disable viewport clamping even if FS doesn't write Z

On Tue, 2019-06-18 at 18:58 +0200, Samuel Pitoiset wrote: > This fixes new CTS dEQP-VK.pipeline.depth_range_unrestricted.*. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_pipeline.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > could this patch be a candidate for

Re: [Mesa-dev] ?= [PATCH] android:=?utf-8?q? virgl: fix libmesa_virgil_common build and dependencies

On 2019-06-20 9:20 a.m., Alexandros Frantzis wrote: > > I wonder what would be involved in adding an Android build job in the > gitlab CI. In a nutshell: You'd need to add a build+test stage job for the Android build. For the docker image used by that job, there are multiple options: 1. Maybe

Re: [Mesa-dev] ?==?utf-8?q? ?==?utf-8?q? [PATCH] android:?==?utf-8?q? virgl: fix libmesa_virgil_common build and dependencies

On Saturday, June 15, 2019 06:39 BST, Mauro Rossi wrote: > Fixes the following building errors and resolves Bug 110922 > Fixes gallium_dri target missing symbols at linking. Thanks for the fix. I wonder what would be involved in adding an Android build job in the gitlab CI. It would be nice t

[Mesa-dev] [PATCH v2 2/6] radv: re-initialize DCC metadata after decompressing using compute

Signed-off-by: Samuel Pitoiset Reviewed-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_meta_fast_clear.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_meta_fast_clear.c b/src/amd/vulkan/radv_meta_fast_clear.c index 0e6c7ba72ff..71cf90c611e 100644 -

[Mesa-dev] [PATCH v2 6/6] radv: enable DCC for mipmapped color textures on GFX8

It's tricky on GFX9, so only GFX8 for now. Signed-off-by: Samuel Pitoiset Reviewed-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_image.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index 4bea09a8a2b..cf3f

[Mesa-dev] [PATCH v2 4/6] radv: add fast clears support for mipmapped color images with DCC

Signed-off-by: Samuel Pitoiset Reviewed-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_meta_clear.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c index dea0cae6d96..b8ca5c2c9b2 100644 --- a/src/

[Mesa-dev] [PATCH v2 1/6] radv: initialize levels without DCC during layout transitions

v2: use a different path for GFX9 Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 49 +++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 756c97983af..f311b9

[Mesa-dev] [PATCH v2 3/6] radv: add radv_dcc_clear_level() helper

For clearing only one level. v2: do not use the legacy stuff on GFX9+ Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta.h | 3 +++ src/amd/vulkan/radv_meta_clear.c | 30 +++--- 2 files changed, 30 insertions(+), 3 deletions(-) diff --git a/src/amd/vulka

[Mesa-dev] [PATCH v2 5/6] radv: do not fast clears if one level can't be fast cleared

And fallback to slow color clears. v2: add a check for GFX8 Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_clear.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c index b8ca5c2c9b2..6263b6d6f58