Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

On 11/1/18 11:59 AM, Erik Faye-Lund wrote: On Thu, 2018-11-01 at 07:49 +0200, Tapani Pälli wrote: On 10/31/18 7:03 PM, Ilia Mirkin wrote: On Wed, Oct 31, 2018 at 12:37 PM Erik Faye-Lund wrote: On Wed, 2018-10-31 at 12:01 -0400, Ilia Mirkin wrote: I had to do a double (or triple) take on

Re: [Mesa-dev] [PATCH mesa] util: use *unsigned* ints for bit operations

On Tue, 23 Oct 2018 at 10:57, Eric Anholt wrote: > > Eric Engestrom writes: > > > Fixes errors thrown by GCC's Undefined Behaviour sanitizer (ubsan) every > > time this macro is used. This seems to be causing problems for me here on gcc8 (8.0.1 and 8.2.1) in Fedora 28. ./bin/texelFetch fs usamp

Re: [Mesa-dev] [PATCH v2 00/13] Engine parameter for instructions

On Thu, Nov 1, 2018 at 5:51 AM Toni Lönnberg wrote: > On Wed, Oct 31, 2018 at 01:18:11PM -0500, Jason Ekstrand wrote: > > On Wed, Oct 31, 2018 at 11:10 AM Toni Lönnberg > > wrote: > > > > > When we debug media or 3d+media workloads, we'd like to be able to see > > > what is > > > in the aub dump

Re: [Mesa-dev] [PATCH] virgl/vtest-winsys: Use virgl version of bind flags

On Thu, 1 Nov 2018 at 19:50, Gert Wollny wrote: > > From: Gert Wollny > > The bind flags defined by mesa/gallium might not always be in sync > with the ones copied to virglrenderer/gallium. Therefore, use the > flags defined in virgl like it is done for all the other calls to > create resources.

[Mesa-dev] [PATCH 1/4] i965: Move some genX infrastructure to genX_boilerplate.h.

This will let us make multiple genX_*.c files, without copy and pasting all this boilerplate. --- src/mesa/drivers/dri/i965/Makefile.sources| 10 ++ src/mesa/drivers/dri/i965/genX_boilerplate.h | 160 ++ src/mesa/drivers/dri/i965/genX_state_upload.c | 129 +- src/

[Mesa-dev] [PATCH 2/4] i965: Rename ISP_DIS to INDIRECT_STATE_POINTERS_DISABLE.

Clearer name. --- src/mesa/drivers/dri/i965/brw_pipe_control.c | 2 +- src/mesa/drivers/dri/i965/brw_pipe_control.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_pipe_control.c b/src/mesa/drivers/dri/i965/brw_pipe_control.c index 122ac260703.

[Mesa-dev] [PATCH 4/4] i965: Reimplement all the PIPE_CONTROL rules.

This implements virtually all documented PIPE_CONTROL restrictions in a centralized helper. You now simply ask for the operations you want, and the pipe control "brain" will figure out exactly what pipe controls to emit to make that happen without tanking your system. The hope is that this will f

[Mesa-dev] [PATCH 3/4] i965: Use genxml for emitting PIPE_CONTROL.

While this does add a bunch of boilerplate, it also protects us against the hardware moving bits, or changing their meaning. For something as finnicky as PIPE_CONTROL, the extra safety seems worth it. We turn PIPE_CONTROL_* into an bitfield of arbitrary flags, and then pack them appropriately. --

[Mesa-dev] [PATCH] intel: Use a URB start offset of 0 for disabled stages.

There are some cases where the VS is the only stage enabled, it uses the entire URB, and the URB is large enough that placing later stages after the VS exceeds the number of bits for "URB Starting Address". For example, on Icelake GT2, "varying-packing-simple mat2x4 array" from Piglit is getting a

Re: [Mesa-dev] [PATCH] winsys/amdgpu: Stop using amdgpu_bo_handle_type_kms_noimport

Tested-by: Dieter Nützel Bugzilla: https://bugs.freedesktop.org/108096 is (code)FIXED with this. Thank you very much, Michel! Dieter Am 01.11.2018 12:31, schrieb Michel Dänzer: From: Michel Dänzer It only behaves any different from amdgpu_bo_handle_type_kms with libdrm 2.4.93, and it break

[Mesa-dev] [PATCH] ac/nir_to_llvm: fix b2f for f64

Fixes: d7e0d47b9de3 ("nir: Add a bunch of b2[if] optimizations") --- src/amd/common/ac_nir_to_llvm.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index e5fbe003f53..c950b81dca2 100644 --- a/sr

Re: [Mesa-dev] [PATCH] amd: Make vgpr-spilling depend on llvm version

Tested-by: Dieter Nützel Thanks! Dieter Am 01.11.2018 19:52, schrieb Jan Vesely: The option was removed in LLVM r345763 Signed-off-by: Jan Vesely --- src/amd/common/ac_llvm_util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_util.c b/src/amd/

Re: [Mesa-dev] [PATCH] amd: Make vgpr-spilling depend on llvm version

Reviewed-by: Marek Olšák Marek On Thu, Nov 1, 2018 at 2:52 PM Jan Vesely wrote: > The option was removed in LLVM r345763 > Signed-off-by: Jan Vesely > --- > src/amd/common/ac_llvm_util.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/amd/common/ac_llvm_util.c

Re: [Mesa-dev] [PATCH] winsys/amdgpu: Stop using amdgpu_bo_handle_type_kms_noimport

Reviewed-by: Marek Olšák Marek On Thu, Nov 1, 2018 at 7:33 AM Michel Dänzer wrote: > From: Michel Dänzer > > It only behaves any different from amdgpu_bo_handle_type_kms with > libdrm 2.4.93, and it breaks if an older version is picked up. > > Bugzilla: https://bugs.freedesktop.org/108096 > S

Re: [Mesa-dev] [Mesa-stable] [PATCH] mapi: avoid text relocation in x86 tsd stubs

On Thu, Nov 01, 2018 at 12:26:34PM -0700, Ian Romanick wrote: > On 10/31/2018 09:08 PM, Jonathan Gray wrote: > > Make similiar changes to libglvnd to avoid a text relocation in > > x86 tsd stubs fixing the build with lld. > > > > Signed-off-by: Jonathan Gray > > Cc: mesa-sta...@lists.freedesktop.

[Mesa-dev] [PATCH 2/2] glsl: Add pragma to disable all warnings

From: Ian Romanick warnings. This is a big hammer. If we ever need a smaller hammer, we can enhance this functionality. There is one lame thing about this. Because we parse everything, create an AST, then convert the AST to GLSL IR, we have to treat the #pragma like a statment. This means th

[Mesa-dev] [PATCH 1/2] glsl: Add warning tests for identifiers with __

From: Ian Romanick Signed-off-by: Ian Romanick Cc: Matt Turner --- .../tests/warnings/031-__-in-function-name.vert| 22 ++ .../warnings/031-__-in-function-name.vert.expected | 3 +++ 2 files changed, 25 insertions(+) create mode 100644 src/compiler/glsl/tests/warning

Re: [Mesa-dev] [PATCH] nir: allow propagation of if evaluation for bcsel

On Thu, Nov 1, 2018 at 4:53 PM Timothy Arceri wrote: > Cc: Jason Ekstrand > --- > src/compiler/nir/nir_opt_if.c | 26 +- > 1 file changed, 17 insertions(+), 9 deletions(-) > > diff --git a/src/compiler/nir/nir_opt_if.c b/src/compiler/nir/nir_opt_if.c > index 1fe95e53766.

[Mesa-dev] [PATCH] nir: allow propagation of if evaluation for bcsel

Cc: Jason Ekstrand --- src/compiler/nir/nir_opt_if.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/src/compiler/nir/nir_opt_if.c b/src/compiler/nir/nir_opt_if.c index 1fe95e53766..50e8947eaa1 100644 --- a/src/compiler/nir/nir_opt_if.c +++ b/src/co

Re: [Mesa-dev] [PATCH v2] glsl: Correct several built-in functions availability

On 10/31/2018 03:05 PM, Timothy Arceri wrote: > If we are going to start tightening up this stuff I would really really > like to see CTS tests (not piglit tests) to go along with this stuff. > > We are already way stricter with these type of things than the closed > source drivers and this leads

Re: [Mesa-dev] [Mesa-stable] [PATCH] mapi: avoid text relocation in x86 tsd stubs

On 10/31/2018 09:08 PM, Jonathan Gray wrote: > Make similiar changes to libglvnd to avoid a text relocation in > x86 tsd stubs fixing the build with lld. > > Signed-off-by: Jonathan Gray > Cc: mesa-sta...@lists.freedesktop.org > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108541 > ---

[Mesa-dev] [PATCH] amd: Make vgpr-spilling depend on llvm version

The option was removed in LLVM r345763 Signed-off-by: Jan Vesely --- src/amd/common/ac_llvm_util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_util.c b/src/amd/common/ac_llvm_util.c index 69d9f7b9f3..dc9b684e9d 100644 --- a/src/amd/common/ac_llvm_u

Re: [Mesa-dev] [PATCH v5 2/3] mesa/st: enable EXT_sRGB_write_control for Gallium drivers that support it

Two chunks are leftovers that I have removed locally (see below) Am Donnerstag, den 01.11.2018, 12:30 +0100 schrieb Gert Wollny: > From: Gert Wollny > > With this patch the extension EXT_sRGB_write_control is enabled for > gallium drivers that support sRGB formats as render targets. > > Tested

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

Am Donnerstag, den 01.11.2018, 12:32 -0400 schrieb Ilia Mirkin: > > > > > It is not different, this extension was specifically written to > > bring GLES on par with GL in this asspect (although with a > > different default). [...] > EXT_framebuffer_sRGB is a desktop GL ext. EXT_sRGB_write_contr

Re: [Mesa-dev] [PATCH mesa] egl: use the LC_ALL hammer instead of LANG

On 2018-11-01 5:57 p.m., Eric Engestrom wrote: > Some environment (like Travis apparently) set LC_* vars, messing up the > sort ordering, so let's use envvar with the highest priority to make > sure this is actually sorted in ASCII order. > > Suggested-by: Michel Dänzer > Fixes: b42dc50a5f1b22103

[Mesa-dev] [PATCH mesa] egl: use the LC_ALL hammer instead of LANG

Some environment (like Travis apparently) set LC_* vars, messing up the sort ordering, so let's use envvar with the highest priority to make sure this is actually sorted in ASCII order. Suggested-by: Michel Dänzer Fixes: b42dc50a5f1b22103b26 "egl: fix entrypoint sorting test" Signed-off-by: Eric

Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

On Thursday, 2018-11-01 17:37:57 +0100, Mathias Fröhlich wrote: > Hi, > > On Thursday, 1 November 2018 17:28:48 CET Eric Engestrom wrote: > > Pushed now, but travis still fails: > > https://travis-ci.org/mesa3d/mesa/jobs/449405406 > > > > I'm really confused here, because the LANG is now fixed, s

Re: [Mesa-dev] [PATCH] mesa: Remove needless indirection in some draw functions.

Hi Brian, On Thursday, 1 November 2018 17:02:38 CET Brian Paul wrote: > Reviewed-by: Brian Paul Thanks! there is more in the queue. Mathias ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-

Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

Hi, On Thursday, 1 November 2018 17:28:48 CET Eric Engestrom wrote: > Pushed now, but travis still fails: > https://travis-ci.org/mesa3d/mesa/jobs/449405406 > > I'm really confused here, because the LANG is now fixed, so it shouldn't > behave differently on different environments? > > If anyone

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

On Thu, Nov 1, 2018 at 12:17 PM Gert Wollny wrote: > > Am Donnerstag, den 01.11.2018, 12:03 -0400 schrieb Ilia Mirkin: > > On Thu, Nov 1, 2018 at 11:45 AM Gert Wollny > m> wrote: > > > > > > Am Donnerstag, den 01.11.2018, 11:19 -0400 schrieb Ilia Mirkin: > > > > On Thu, Nov 1, 2018 at 10:41 AM Ge

Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

On Thursday, 2018-11-01 16:56:50 +0100, Mathias Fröhlich wrote: > Hi Michel, > > > > There seems to be a failure with the latest patches you pushed. > > > The patch fixes a failure with the sort order in egl symbols. > > > > Well, now it's broken with other locales. :) > > > > I guess src/egl/eg

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

Am Donnerstag, den 01.11.2018, 12:03 -0400 schrieb Ilia Mirkin: > On Thu, Nov 1, 2018 at 11:45 AM Gert Wollny m> wrote: > > > > Am Donnerstag, den 01.11.2018, 11:19 -0400 schrieb Ilia Mirkin: > > > On Thu, Nov 1, 2018 at 10:41 AM Gert Wollny > > a.co > > > m> wrote: > > > > > > > > Am Donnersta

Re: [Mesa-dev] [PATCH] meson: don't install translation files

On Thursday, 2018-11-01 09:06:13 -0700, Dylan Baker wrote: > CC: eric.engest...@intel.com > Fixes: 7834926a4f5ca0a60ec3d18c87a1e0a68b615820 >("meson: add support for generating translation mo files") Tested-by: Eric Engestrom Reviewed-by: Eric Engestrom Thanks :) > --- > src/util/xmlp

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

On 2018-11-01 5:03 p.m., Jan Vesely wrote: > On Wed, 2018-10-31 at 18:40 +, Emil Velikov wrote: >> On Wed, 31 Oct 2018 at 17:41, Jan Vesely wrote: >>> On Wed, 2018-10-31 at 17:22 +, Emil Velikov wrote: On Wed, 31 Oct 2018 at 16:24, Michel Dänzer wrote: > On 2018-10-31 5:19 p.m.,

Re: [Mesa-dev] [PATCH v3] autotools: library-dependency when no sse and 32-bit

Reviewed-by: Dylan Baker Quoting Sergii Romantsov (2018-11-01 04:02:43) > Building of 32bit Mesa may fail if __SSE__ is not specified. > Added missed dependency from libm. > > v2: avoided dependecy on any flag, just link > > v3: meson doesn't fail, but have added dependency on libm > > CC: Dyl

Re: [Mesa-dev] [PATCH v2] autotools: library-dependency when no sse and 32-bit

Please feel free to CC me on the meson patch. Quoting Sergii Romantsov (2018-11-01 03:46:46) > Hi, > meson doesn't fail, but, probably, better to add for sure. > Will do soon. > > On Thu, Nov 1, 2018 at 12:25 PM Lionel Landwerlin < > lionel.g.landwer...@intel.com> wrote: > > Hi Sergii, > >

[Mesa-dev] [PATCH] meson: don't install translation files

CC: eric.engest...@intel.com Fixes: 7834926a4f5ca0a60ec3d18c87a1e0a68b615820 ("meson: add support for generating translation mo files") --- src/util/xmlpool/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/xmlpool/meson.build b/src/util/xmlpool/meson.

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

On Thu, Nov 1, 2018 at 11:45 AM Gert Wollny wrote: > > Am Donnerstag, den 01.11.2018, 11:19 -0400 schrieb Ilia Mirkin: > > On Thu, Nov 1, 2018 at 10:41 AM Gert Wollny > m> wrote: > > > > > > Am Donnerstag, den 01.11.2018, 10:34 -0400 schrieb Ilia Mirkin: > > > > On Thu, Nov 1, 2018 at 10:31 AM Ge

Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

On 2018-11-01 4:56 p.m., Mathias Fröhlich wrote: > >>> There seems to be a failure with the latest patches you pushed. >>> The patch fixes a failure with the sort order in egl symbols. >> >> Well, now it's broken with other locales. :) >> >> I guess src/egl/egl-entrypoint-check itself should make

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

On Wed, 2018-10-31 at 18:40 +, Emil Velikov wrote: > On Wed, 31 Oct 2018 at 17:41, Jan Vesely wrote: > > On Wed, 2018-10-31 at 17:22 +, Emil Velikov wrote: > > > On Wed, 31 Oct 2018 at 16:24, Michel Dänzer wrote: > > > > On 2018-10-31 5:19 p.m., Jan Vesely wrote: > > > > > On Wed, 2018-10

Re: [Mesa-dev] [PATCH] mesa: Remove needless indirection in some draw functions.

On 11/01/2018 01:46 AM, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Hi Paul, > > There is plenty more cleanup opportunity. > We can probably use a lot more from the generated glapi also for > these draw functions. But for now what you requested in the last mail. > > please rev

Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

Hi Michel, > > There seems to be a failure with the latest patches you pushed. > > The patch fixes a failure with the sort order in egl symbols. > > Well, now it's broken with other locales. :) > > I guess src/egl/egl-entrypoint-check itself should make sure sort runs > with locale settings resu

[Mesa-dev] [PATCH mesa] intel: add comment explaining weird-looking code

Clang throws warnings here (-Wgnu-variable-sized-type-not-at-end) because of a variable-sized array at the end of `drm_i915_query_topology_info` being aliased by the `data` field in `topology`, but that's the point here, so let's explain it so that the next me doesn't blindly listen to the compiler

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

Am Donnerstag, den 01.11.2018, 11:19 -0400 schrieb Ilia Mirkin: > On Thu, Nov 1, 2018 at 10:41 AM Gert Wollny m> wrote: > > > > Am Donnerstag, den 01.11.2018, 10:34 -0400 schrieb Ilia Mirkin: > > > On Thu, Nov 1, 2018 at 10:31 AM Gert Wollny > > a.co > > > m> wrote: > > > > > > > > Am Donnersta

[Mesa-dev] [Bug 90157] GLSL ES does not allow non-constant initializers for globals

https://bugs.freedesktop.org/show_bug.cgi?id=90157 Mark Janes changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |i...@freedesktop.org |org

Re: [Mesa-dev] [PATCH mesa] egl: fix entrypoint sorting test

Hi, On Thursday, 1 November 2018 16:35:30 CET Eric Engestrom wrote: > Fixes: 68dc591af16ebb36814e "egl: Fix eglentrypoint.h sort order." > Cc: Emil Velikov > Cc: Mathias Fröhlich > Cc: Tapani Pälli > Signed-off-by: Eric Engestrom > --- > src/egl/egl-entrypoint-check | 2 +- > 1 file changed,

[Mesa-dev] [PATCH mesa] egl: fix entrypoint sorting test

Fixes: 68dc591af16ebb36814e "egl: Fix eglentrypoint.h sort order." Cc: Emil Velikov Cc: Mathias Fröhlich Cc: Tapani Pälli Signed-off-by: Eric Engestrom --- src/egl/egl-entrypoint-check | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/egl-entrypoint-check b/src/egl/eg

Re: [Mesa-dev] [PATCH mesa] move variable-sized struct at the end of parent struct

On 11/01/2018 09:29 AM, Eric Engestrom wrote: > On Thursday, 2018-11-01 12:19:10 +, Lionel Landwerlin wrote: >> On 01/11/2018 11:59, andrey simiklit wrote: >>> Hello, >>> >>> Please find my comments below: >>> >>> On Thu, Nov 1, 2018 at 12:24 PM Eric Engestrom >>

Re: [Mesa-dev] [PATCH mesa] move variable-sized struct at the end of parent struct

On Thursday, 2018-11-01 12:19:10 +, Lionel Landwerlin wrote: > On 01/11/2018 11:59, andrey simiklit wrote: > > Hello, > > > > Please find my comments below: > > > > On Thu, Nov 1, 2018 at 12:24 PM Eric Engestrom > > wrote: > > > >   warning: field 'base'

Re: [Mesa-dev] [PATCH v2 2/4] Gallium: Add format PIPE_FORMAT_R8_SRGB

Am 01.11.18 um 15:48 schrieb Gert Wollny: > Am Dienstag, den 30.10.2018, 16:04 + schrieb Roland Scheidegger: >> With the format ordering in svga_format.c as Ilia mentioned fixed >> Reviewed-by: Roland Scheidegger > > CMIIW, but I guess was that your R-b was only for this patch, right? Right,

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

On Thu, Nov 1, 2018 at 10:41 AM Gert Wollny wrote: > > Am Donnerstag, den 01.11.2018, 10:34 -0400 schrieb Ilia Mirkin: > > On Thu, Nov 1, 2018 at 10:31 AM Gert Wollny > m> wrote: > > > > > > Am Donnerstag, den 01.11.2018, 10:15 -0400 schrieb Ilia Mirkin: > > > > So ... thinking about this a littl

Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

Hi Mathias, On 2018-11-01 8:40 a.m., mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Hi Emil, > > There seems to be a failure with the latest patches you pushed. > The patch fixes a failure with the sort order in egl symbols. Well, now it's broken with other locales. :) I gues

Re: [Mesa-dev] [PATCH v2 2/4] Gallium: Add format PIPE_FORMAT_R8_SRGB

Am Dienstag, den 30.10.2018, 16:04 + schrieb Roland Scheidegger: > With the format ordering in svga_format.c as Ilia mentioned fixed > Reviewed-by: Roland Scheidegger CMIIW, but I guess was that your R-b was only for this patch, right? Best, Gert > > Am 30.10.18 um 11:46 schrieb Gert Wol

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

Am Donnerstag, den 01.11.2018, 10:34 -0400 schrieb Ilia Mirkin: > On Thu, Nov 1, 2018 at 10:31 AM Gert Wollny m> wrote: > > > > Am Donnerstag, den 01.11.2018, 10:15 -0400 schrieb Ilia Mirkin: > > > So ... thinking about this a little more ... how is the new > > > enable > > > different from the e

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

On Thu, Nov 1, 2018 at 10:31 AM Gert Wollny wrote: > > Am Donnerstag, den 01.11.2018, 10:15 -0400 schrieb Ilia Mirkin: > > So ... thinking about this a little more ... how is the new enable > > different from the existing "EXT_framebuffer_sRGB" enable? When would > > one be set but not the other?

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

Am Donnerstag, den 01.11.2018, 10:15 -0400 schrieb Ilia Mirkin: > So ... thinking about this a little more ... how is the new enable > different from the existing "EXT_framebuffer_sRGB" enable? When would > one be set but not the other? This one is a GLES extension, there, if the surface attached

Re: [Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

So ... thinking about this a little more ... how is the new enable different from the existing "EXT_framebuffer_sRGB" enable? When would one be set but not the other? On Thu, Nov 1, 2018 at 7:30 AM Gert Wollny wrote: > > From: Gert Wollny > > Dear all, > > yet another update, only to the Gallium

Re: [Mesa-dev] [PATCH v3 3/4] mesa/st: Add support for EXT_texture_sRGB_R8

Reviewed-by: Ilia Mirkin But one very very minor change, no need to re-send, just fix it up locally: On Thu, Nov 1, 2018 at 8:00 AM Gert Wollny wrote: > > From: Gert Wollny > > This only adds support on the Gallium core level, for the drivers > it is likely that additional changes are needed t

Re: [Mesa-dev] [PATCH v3 2/4] Gallium: Add format PIPE_FORMAT_R8_SRGB

Reviewed-by: Ilia Mirkin On Thu, Nov 1, 2018 at 8:00 AM Gert Wollny wrote: > > From: Gert Wollny > > This format is needed to support EXT_texture_sRGB_R8. THe patch adds a new > format enum, the format entries in Gallium and and svga, the mapping between > sRGB and linear formats, and tests. > >

Re: [Mesa-dev] [PATCH v3 1/4] mesa/core: Add definitions and translations for EXT_texture_sRGB_R8

Reviewed-by: Ilia Mirkin On Thu, Nov 1, 2018 at 8:00 AM Gert Wollny wrote: > > From: Gert Wollny > > v2: - fix format definition line > - disable for desktop GL > - don't add GL_R8_EXT to glext.h since it is already in > GLES2/gl2ext.h in glext.h and include this header where nee

[Mesa-dev] [Bug 108508] Graphic glitches with stream output support on OLAND AMD GPU GCN 1.0

https://bugs.freedesktop.org/show_bug.cgi?id=108508 --- Comment #20 from Ahmed Elsayed --- Is this record enough or do you need something else? Please, tell me. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug._

Re: [Mesa-dev] [PATCH v2] intel/tools: fix resource leak

Pushed to master. Thanks Andrey! On 31/10/2018 11:48, andrey simiklit wrote: Hello, Sorry, one more point here. Could I ask you to push it, because I don't have a push rights :-) Thanks a lot, Andrii. On Fri, Oct 26, 2018 at 6:09 PM Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> w

Re: [Mesa-dev] [PATCH] intel/tools: include stdarg.h in error2aub

Pushed to master. Thanks! On 01/11/2018 10:26, Lionel Landwerlin wrote: Reviewed-by: Lionel Landwerlin On 01/11/2018 04:07, Jonathan Gray wrote: Include stdarg.h in error2aub.c otherwise it fails to build on OpenBSD due to not finding definitions for va_list va_start va_end. Signed-off-by:

Re: [Mesa-dev] [PATCH mesa] move variable-sized struct at the end of parent struct

On 01/11/2018 11:59, andrey simiklit wrote: Hello, Please find my comments below: On Thu, Nov 1, 2018 at 12:24 PM Eric Engestrom mailto:eric.engest...@intel.com>> wrote:   warning: field 'base' with variable sized type 'struct drm_i915_query_topology_info'   not at the end of a s

[Mesa-dev] [PATCH v3 4/4] r600: Add support for EXT_texture_sRGB_R8

From: Gert Wollny Enables on R600 and makes pass: dEQP-GLES31.functional.srgb_texture_decode.skip_decode.sr8.* dEQP-GLES31.functional.texture.filtering.cube_array.formats.sr8* v2: remove chunk for dri/radeon (Emil) Signed-off-by: Gert Wollny --- src/gallium/drivers/r600/r600_state_common.

[Mesa-dev] [PATCH v3 3/4] mesa/st: Add support for EXT_texture_sRGB_R8

From: Gert Wollny This only adds support on the Gallium core level, for the drivers it is likely that additional changes are needed to support the new texture format and thereby enabling the extension. Enables on softpipe and makes pass: dEQP-GLES31.functional.srgb_texture_decode.skip_decode.s

[Mesa-dev] [PATCH v3 2/4] Gallium: Add format PIPE_FORMAT_R8_SRGB

From: Gert Wollny This format is needed to support EXT_texture_sRGB_R8. THe patch adds a new format enum, the format entries in Gallium and and svga, the mapping between sRGB and linear formats, and tests. v2: - add mapping to linear format for PIPE_FORMATR_R8_SRGB v3: - Add texture format t

Re: [Mesa-dev] [PATCH mesa] move variable-sized struct at the end of parent struct

Hello, Please find my comments below: On Thu, Nov 1, 2018 at 12:24 PM Eric Engestrom wrote: > warning: field 'base' with variable sized type 'struct > drm_i915_query_topology_info' > not at the end of a struct or class is a GNU extension > [-Wgnu-variable-sized-type-not-at-end] > > Signed-o

[Mesa-dev] [PATCH v3 1/4] mesa/core: Add definitions and translations for EXT_texture_sRGB_R8

From: Gert Wollny v2: - fix format definition line - disable for desktop GL - don't add GL_R8_EXT to glext.h since it is already in GLES2/gl2ext.h in glext.h and include this header where needed (all Emil) v3: - swrast: Fill the function table for sRGB_R8 The size of t

[Mesa-dev] [PATCH v3 0/4] Add support for EXT_texture_sRGB_R8 to core and gallium

From: Gert Wollny Dear all, This is an update to the series, changes applied as suggested by Ilia and Roland: v3: - Add GL_SR8_EXT enum to glheaders.h and don't include GLES2 headers - reorder svga format table. v2: - split the Gallium-mesa/st patch in two according parts (Roland) - do

[Mesa-dev] [PATCH] gbm: Clarify acceptable formats for gbm_bo

gbm_bo_create() was presumably meant to originally accept gbm_bo_format enums, but it's accepted GBM_FORMAT_* tokens since the dawn of time. This is good, since gbm_bo_format is rarely used and covers a lot less ground than GBM_FORMAT_*. Change the documentation to refer to both; this involves rem

[Mesa-dev] [PATCH v5 2/3] mesa/st: enable EXT_sRGB_write_control for Gallium drivers that support it

From: Gert Wollny With this patch the extension EXT_sRGB_write_control is enabled for gallium drivers that support sRGB formats as render targets. Tested (and pass) on r600 (evergreen) and softpipe: dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_enabled* with "MESA_GLES_VERSI

[Mesa-dev] [PATCH v5 3/3] intel/i965: Enable extension EXT_sRGB_write_control

From: Gert Wollny v2: Fix ordering of extensions (Ian Romanick) Enables and passes on i965: dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_enabled* Signed-off-by: Gert Wollny --- src/mesa/drivers/dri/i965/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[Mesa-dev] [PATCH] winsys/amdgpu: Stop using amdgpu_bo_handle_type_kms_noimport

From: Michel Dänzer It only behaves any different from amdgpu_bo_handle_type_kms with libdrm 2.4.93, and it breaks if an older version is picked up. Bugzilla: https://bugs.freedesktop.org/108096 Signed-off-by: Michel Dänzer --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 6 +++--- 1 file chang

[Mesa-dev] [PATCH v5 1/3] mesa/core: Add support for EXT_sRGB_write_control

From: Gert Wollny This GLES extension gives the applications the control over deciding whether the conversion from linear space to sRGB is necessary by enabling or disabling this conversion at framebuffer write or blending time just like it is possible for desktop GL. v2: - Correct the extension

[Mesa-dev] [PATCH v5 0/3] Add and enable extension EXT_sRGB_write_control

From: Gert Wollny Dear all, yet another update, only to the Gallium part: i.e. the format check was simplified according to Mareks comment, Best, Gert Gert Wollny (3): mesa/core: Add support for EXT_sRGB_write_control mesa/st: enable EXT_sRGB_write_control for Gallium drivers that

[Mesa-dev] [Bug 90157] GLSL ES does not allow non-constant initializers for globals

https://bugs.freedesktop.org/show_bug.cgi?id=90157 --- Comment #1 from vadym --- Looks like this is a duplicate of Bug 92304. Piglit tests which testing this are fixed now: spec/glsl-es-1.00/compiler/global-initializer/from-attribute.vert spec/glsl-es-1.00/compiler/global-initia

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

Hi, On Thursday, 1 November 2018 11:04:27 CET Pekka Paalanen wrote: > On Wed, 31 Oct 2018 16:41:47 -0400 > Marek Olšák wrote: > > > On Wed, Oct 31, 2018 at 11:26 AM Michel Dänzer wrote: > > > > > On 2018-10-31 12:39 a.m., Gustaw Smolarczyk wrote: > > > > śr., 31 paź 2018 o 00:23 Marek Olšák

[Mesa-dev] [PATCH v3] autotools: library-dependency when no sse and 32-bit

Building of 32bit Mesa may fail if __SSE__ is not specified. Added missed dependency from libm. v2: avoided dependecy on any flag, just link v3: meson doesn't fail, but have added dependency on libm CC: Dylan Baker CC: Lionel G Landwerlin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=

Re: [Mesa-dev] [PATCH v2 00/13] Engine parameter for instructions

On Wed, Oct 31, 2018 at 01:18:11PM -0500, Jason Ekstrand wrote: > On Wed, Oct 31, 2018 at 11:10 AM Toni Lönnberg > wrote: > > > When we debug media or 3d+media workloads, we'd like to be able to see > > what is > > in the aub dumps for those workloads. At the moment the decoder can't > > distingu

Re: [Mesa-dev] [PATCH v2] autotools: library-dependency when no sse and 32-bit

Hi, meson doesn't fail, but, probably, better to add for sure. Will do soon. On Thu, Nov 1, 2018 at 12:25 PM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Hi Sergii, > > Do we need the same fix in meson? > > Thanks, > > - > Lionel > > On 01/11/2018 07:25, Sergii Romantsov wrote: > >

[Mesa-dev] [Bug 108620] Vega 8 glitches in VKcube

https://bugs.freedesktop.org/show_bug.cgi?id=108620 --- Comment #4 from Vladislav Kamenev --- Vega 8 from Ryzen 2500u cpu. Mesa 18.2.3 in Manjaro -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

[Mesa-dev] [Bug 108620] Vega 8 glitches in VKcube

https://bugs.freedesktop.org/show_bug.cgi?id=108620 --- Comment #3 from Vladislav Kamenev --- Created attachment 142325 --> https://bugs.freedesktop.org/attachment.cgi?id=142325&action=edit vulkaninfo -- You are receiving this mail because: You are the assignee for the bug. You are the QA Con

[Mesa-dev] [Bug 108620] Vega 8 glitches in VKcube

https://bugs.freedesktop.org/show_bug.cgi?id=108620 --- Comment #2 from Vladislav Kamenev --- Created attachment 142324 --> https://bugs.freedesktop.org/attachment.cgi?id=142324&action=edit glxinfo -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contac

[Mesa-dev] [Bug 108620] Vega 8 glitches in VKcube

https://bugs.freedesktop.org/show_bug.cgi?id=108620 Bug ID: 108620 Summary: Vega 8 glitches in VKcube Product: Mesa Version: 18.2 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal

[Mesa-dev] [Bug 108620] Vega 8 glitches in VKcube

https://bugs.freedesktop.org/show_bug.cgi?id=108620 --- Comment #1 from Vladislav Kamenev --- Created attachment 142323 --> https://bugs.freedesktop.org/attachment.cgi?id=142323&action=edit Video of the bug -- You are receiving this mail because: You are the QA Contact for the bug. You are th

Re: [Mesa-dev] [PATCH] intel/tools: include stdarg.h in error2aub

Reviewed-by: Lionel Landwerlin On 01/11/2018 04:07, Jonathan Gray wrote: Include stdarg.h in error2aub.c otherwise it fails to build on OpenBSD due to not finding definitions for va_list va_start va_end. Signed-off-by: Jonathan Gray Cc: mesa-sta...@lists.freedesktop.org --- src/intel/tools/

Re: [Mesa-dev] [PATCH v2] autotools: library-dependency when no sse and 32-bit

Hi Sergii, Do we need the same fix in meson? Thanks, - Lionel On 01/11/2018 07:25, Sergii Romantsov wrote: Thanks, Dylan. Could, please, somebody push it? On Tue, Oct 30, 2018 at 5:30 PM Dylan Baker > wrote: Reviewed-by: Dylan Baker mailto:dy...@pnwbakers.co

[Mesa-dev] [PATCH mesa] move variable-sized struct at the end of parent struct

warning: field 'base' with variable sized type 'struct drm_i915_query_topology_info' not at the end of a struct or class is a GNU extension [-Wgnu-variable-sized-type-not-at-end] Signed-off-by: Eric Engestrom --- src/intel/dev/gen_device_info.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

On Thursday, 2018-11-01 08:40:08 +0100, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Hi Emil, > > There seems to be a failure with the latest patches you pushed. > The patch fixes a failure with the sort order in egl symbols. > > please review! > > FYI, I observed that the lat

Re: [Mesa-dev] [PATCH 02/12] meson: bump the minimum LLVM version to 5.0.1

On Wednesday, 2018-10-31 16:06:19 -0700, Dylan Baker wrote: > Quoting Emil Velikov (2018-10-31 06:29:54) > > From: Emil Velikov > > > > Currently the minimal version is 3.3 with 3.9 for r600+opencl. > > > > We kept it as low, since transitioning to newer ones is pain on Windows. > > With issues

Re: [Mesa-dev] [PATCH 10/12] llvmpipe: remove pre LLVM 5.0 codepath

On 31/10/2018 13:30, Emil Velikov wrote: From: Emil Velikov LLVM versions earlier than 5.0.1 are no longer supported. Cc: Roland Scheidegger Cc: Jose Fonseca Signed-off-by: Emil Velikov --- src/gallium/drivers/llvmpipe/lp_jit.c | 4 1 file changed, 4 deletions(-) diff --git a/src/g

Re: [Mesa-dev] [PATCH 09/12] gallivm: remove workarounds for pre LLVM 5.0

On 31/10/2018 13:30, Emil Velikov wrote: From: Emil Velikov With LLVM 5.0.1 the minimum required version, we can drop all the dead code. Cc: Roland Scheidegger Cc: Jose Fonseca Signed-off-by: Emil Velikov --- Gents this is a quick and dirty grep job. A couple of places may need the comments

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

On Wed, 31 Oct 2018 16:41:47 -0400 Marek Olšák wrote: > On Wed, Oct 31, 2018 at 11:26 AM Michel Dänzer wrote: > > > On 2018-10-31 12:39 a.m., Gustaw Smolarczyk wrote: > > > śr., 31 paź 2018 o 00:23 Marek Olšák napisał(a): ... > > >> As far as we know, it hurts *only* Blender. > > > > W

Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

On Thu, 2018-11-01 at 07:49 +0200, Tapani Pälli wrote: > > On 10/31/18 7:03 PM, Ilia Mirkin wrote: > > On Wed, Oct 31, 2018 at 12:37 PM Erik Faye-Lund > > wrote: > > > > > > On Wed, 2018-10-31 at 12:01 -0400, Ilia Mirkin wrote: > > > > I had to do a double (or triple) take on this logic as well.

[Mesa-dev] [PATCH] virgl/vtest-winsys: Use virgl version of bind flags

From: Gert Wollny The bind flags defined by mesa/gallium might not always be in sync with the ones copied to virglrenderer/gallium. Therefore, use the flags defined in virgl like it is done for all the other calls to create resources. Signed-off-by: Gert Wollny --- src/gallium/winsys/virgl/vte

Re: [Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

Reviewed-by: Tapani Pälli This fixes: dEQP-EGL.functional.get_proc_address.extension.egl_ext_device_base Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108617 On 11/1/18 9:40 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi Emil, There seems to be a failure with the

Re: [Mesa-dev] [PATCH] r600/sb: Fix constant logical operand in assert.

Good catch, Reviewed-By: Gert Wollny Am Mittwoch, den 31.10.2018, 15:40 -0700 schrieb Vinson Lee: > Fixes: da977ad90747 ("r600/sb: start adding GDS support") > Signed-off-by: Vinson Lee > --- > src/gallium/drivers/r600/sb/sb_bc_builder.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [Mesa-dev] [PATCH] radv: fix begin/end transform feedback with 0 counter buffers.

On 11/1/18 12:59 AM, Dave Airlie wrote: From: Dave Airlie If the user gives 0 counterBuffers then the driver should still enable transform feedback on all targets. This changes the driver to always enable xfb, and use counter buffers where one is defined for the target in question. Fixes: b4

Re: [Mesa-dev] [PATCH] radv: apply xfb buffer offset at buffer binding time not later. (v2)

Seems fine. Reviewed-by: Samuel Pitoiset On 11/1/18 4:00 AM, Dave Airlie wrote: From: Dave Airlie In order to handle pause/resume properly, the offset should be added to the buffer binding not to the begin/end paths. v2: don't add offset to size Fixes ext_transform_feedback-alignment* under

  1   2   >