Pushed to master. Thanks Andrey!
On 31/10/2018 11:48, andrey simiklit wrote:
Hello,
Sorry, one more point here.
Could I ask you to push it, because I don't have a push rights :-)
Thanks a lot,
Andrii.
On Fri, Oct 26, 2018 at 6:09 PM Lionel Landwerlin
<lionel.g.landwer...@intel.com <mailto:lionel.g.landwer...@intel.com>>
wrote:
On 26/10/2018 15:29, asimiklit.w...@gmail.com
<mailto:asimiklit.w...@gmail.com> wrote:
> From: Andrii Simiklit <andrii.simik...@globallogic.com
<mailto:andrii.simik...@globallogic.com>>
>
> Some memory and file descriptors are not freed/closed.
>
> v2: fixed case where we skipped the 'aub' variable initialization
>
> Signed-off-by: Andrii Simiklit <andrii.simik...@globallogic.com
<mailto:andrii.simik...@globallogic.com>>
Still :
Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com
<mailto:lionel.g.landwer...@intel.com>>
Thanks!
> ---
> src/intel/tools/error2aub.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/src/intel/tools/error2aub.c
b/src/intel/tools/error2aub.c
> index 8a23d5ef1e..2b850ce885 100644
> --- a/src/intel/tools/error2aub.c
> +++ b/src/intel/tools/error2aub.c
> @@ -326,6 +326,16 @@ main(int argc, char *argv[])
>
> aub_write_exec(&aub, batch_addr, aub_gtt_size(&aub),
I915_EXEC_RENDER);
>
> + free(out_filename);
> + free(line);
> + if(err_file) {
> + fclose(err_file);
> + }
> + if(aub.file) {
> + aub_file_finish(&aub);
> + } else if(aub_file) {
> + fclose(aub_file);
> + }
> return EXIT_SUCCESS;
> }
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org <mailto:mesa-dev@lists.freedesktop.org>
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
