Re: [Mesa-dev] [PATCH v4 5/8] mesa/main: don't use win _vsnprintf. there is 'util_vsnprintf' function

On Fri, Sep 7, 2018 at 5:38 AM Ian Romanick wrote: > It seems like it might better to just replace all the calllers of > _mesa_*printf with util_*printf. > Thanks. Yes you're right. I am going to rework it today. > On 09/06/2018 07:43 AM, asimiklit.w...@gmail.com wrote: > > From: Andrii Simikl

Re: [Mesa-dev] [PATCH v4 7/7] egl/main: use cross platform implementation 'util_vsnprintf'

On Fri, Sep 7, 2018 at 5:40 AM Ian Romanick wrote: > On 09/06/2018 07:43 AM, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > > I guess it makes this implementation more portable. > > > > Signed-off-by: Andrii Simiklit > > --- > > src/amd/vulkan/radv_util.c | 5 +++-- > > src/eg

Re: [Mesa-dev] [PATCH v4 0/8] mesa: fix usage of [v][s][n]printf functions

On Thu, Sep 6, 2018 at 7:58 PM Eric Engestrom wrote: > On Thursday, 2018-09-06 17:43:50 +0300, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > > This patch improve usage of [v][s][n]printf functions. > > Fixes cross platform implementation of vsnprintf > > > > v2: Linux man about

Re: [Mesa-dev] [PATCH] mesa/util: add missing va_end() after va_copy()

On Thu, Sep 6, 2018 at 3:20 PM Emil Velikov wrote: > Hi Andrii, > > I think you might be overthinking my comments. > There's nothing special, nor am I trying to force my opinion. > > If you think my suggestions make sense, great. Otherwise don't bother too > much. > Thanks a lot for your advices

Re: [Mesa-dev] [PATCH] glsl/linker: Check the invariance of built-in special variables

LGTM It would be nice to have this as part of 'cross_validate_globals' or some other pass but considering how special/specific rules we are dealing with here IMO it's fine to have a separate pass for it. Reviewed-by: Tapani Pälli One tiny nit below .. On 08/29/2018 12:16 PM, Vadym Shovkopl

Re: [Mesa-dev] [PATCH v2] i965: Workaround the gen9 hw astc5x5 sampler bug

Tested on Android with GFXBench 4.0, run multiple times without any issues. Tested-by: Tapani Pälli On 09/06/2018 11:50 PM, Jason Ekstrand wrote: From: Topi Pohjolainen gen9 hardware has a bug in the sampler cache that can cause GPU hangs whenever an texture with aux compression enabled is i

Re: [Mesa-dev] [PATCH 2/4] st/mesa: pin driver threads to a specific L3 cache on AMD Zen (v2)

On Thu, Sep 6, 2018 at 11:51 PM, Brian Paul wrote: > The revised series looks OK to me. One whitespace issue below. > > For the series, > Reviewed-by: Brian Paul Thanks. Does it also include the first 4 patches in the previous series? Thanks, Marek _

Re: [Mesa-dev] [PATCH 1/2] gallium: New cap PIPE_CAP_MAX_VERTEX_ELEMENT_SRC_OFFSET.

Hi, On Thursday, 6 September 2018 23:43:41 CEST Roland Scheidegger wrote: > Looks alright to me, albeit seems a bit weird your hw can have offset of > 255 but only max stride of 128 - max offset being larger than max stride > doesn't really make a whole lot of sense. (Could you handle stride 255 >

Re: [Mesa-dev] [PATCH 2/4] st/mesa: pin driver threads to a specific L3 cache on AMD Zen (v2)

The revised series looks OK to me. One whitespace issue below. For the series, Reviewed-by: Brian Paul On 09/06/2018 07:04 PM, Marek Olšák wrote: From: Marek Olšák v2: use set_context_param --- src/gallium/auxiliary/util/u_helpers.c | 42 +++ src/gallium/auxiliary/util/u

Re: [Mesa-dev] [PATCH 0/4] virgil: fix crash when mapping ms-texture

On Thu, Sep 6, 2018 at 7:58 PM, Erik Faye-Lund wrote: > Here's a series of patches to address a crash when mapping multisampled > textures in piglit. The crash can easily be reproduce using the > following command: > > bin/copyteximage 2D -samples=2 -auto > > However, it's not clear to me if this

Re: [Mesa-dev] [PATCH 1/2] gallium: add PIPE_CAP_MAX_TEXTURE_UPLOAD_MEMORY_BUDGET

It's been 6 days since I sent the patches. I'm thinking about just pushing this. Marek On Tue, Sep 4, 2018 at 8:16 PM, Dieter Nützel wrote: > Hello Marek, > > can you resend? > I want the texture upload speed up... > > Dieter > > > Am 01.09.2018 03:02, schrieb Marek Olšák: >> >> From: Marek Olšá

Re: [Mesa-dev] [PATCH] mesa: enable ARB_vertex_buffer_object in core profile

On 07/09/18 11:49, Ian Romanick wrote: On 09/06/2018 06:08 PM, Timothy Arceri wrote: On 07/09/18 11:00, Ian Romanick wrote: On 09/06/2018 03:24 PM, Timothy Arceri wrote: On 07/09/18 06:18, Ian Romanick wrote: So... this game that requires at least OpenGL 3.2 (by virtue of using core profile)

Re: [Mesa-dev] [PATCH 00/15] RadeonSI Fixes and Cleanups

Does anybody want to review this? Thanks, Marek On Wed, Aug 29, 2018 at 4:12 PM, Marek Olšák wrote: > Hi, > > There are HTILE and CMASK allocator fixes, a GPU hang fix for bindless > textures with LLVM 7.0, partial NIR support for bindless textures, > ddebug fix, and much more. > > Please review

Re: [Mesa-dev] [PATCH v4 7/7] egl/main: use cross platform implementation 'util_vsnprintf'

On 09/06/2018 07:43 AM, asimiklit.w...@gmail.com wrote: > From: Andrii Simiklit > > I guess it makes this implementation more portable. > > Signed-off-by: Andrii Simiklit > --- > src/amd/vulkan/radv_util.c | 5 +++-- > src/egl/main/egllog.c | 3 ++- > 2 files changed, 5 insertions(+), 3 d

Re: [Mesa-dev] [PATCH v4 5/8] mesa/main: don't use win _vsnprintf. there is 'util_vsnprintf' function

It seems like it might better to just replace all the calllers of _mesa_*printf with util_*printf. On 09/06/2018 07:43 AM, asimiklit.w...@gmail.com wrote: > From: Andrii Simiklit > > The win '_vsnprintf' function incompatibility with C99 vsnprintf. > At least for case when the input buffer size

[Mesa-dev] [PATCH] nv50,nvc0: warn on not-explicitly-handled caps

Not handling caps explicitly means that we're likely getting incorrect values -- these need to be reviewed and set appropriately. While we're at it, add in some missing caps, and set all the subpixel stuff to 8 as that seems to be what the blob reports. Signed-off-by: Ilia Mirkin --- src/galliu

Re: [Mesa-dev] [PATCH] mesa: enable ARB_vertex_buffer_object in core profile

On 09/06/2018 06:08 PM, Timothy Arceri wrote: > On 07/09/18 11:00, Ian Romanick wrote: >> On 09/06/2018 03:24 PM, Timothy Arceri wrote: >>> On 07/09/18 06:18, Ian Romanick wrote: So... this game that requires at least OpenGL 3.2 (by virtue of using core profile) is checking for an OpenGL

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

On Thu, Sep 6, 2018 at 5:54 PM, Roland Scheidegger wrote: > Am 06.09.2018 um 22:56 schrieb Axel Davy: >> Yeah by pinning to cores, I meant to group of cores. >> >> I think a reasonable policy would be for the kernel to put all threads >> of a given process on the same L3 >> as long as the number o

Re: [Mesa-dev] [PATCH] mesa: enable ARB_vertex_buffer_object in core profile

On 07/09/18 11:00, Ian Romanick wrote: On 09/06/2018 03:24 PM, Timothy Arceri wrote: On 07/09/18 06:18, Ian Romanick wrote: So... this game that requires at least OpenGL 3.2 (by virtue of using core profile) is checking for an OpenGL 1.4 feature?  That makes me a little sad. Its a little odd

[Mesa-dev] [PATCH 2/4] st/mesa: pin driver threads to a specific L3 cache on AMD Zen (v2)

From: Marek Olšák v2: use set_context_param --- src/gallium/auxiliary/util/u_helpers.c | 42 +++ src/gallium/auxiliary/util/u_helpers.h | 4 ++ src/mesa/state_tracker/st_context.c| 3 ++ src/mesa/state_tracker/st_manager.c| 9 src/util/u_thread.h

[Mesa-dev] [PATCH 3/4] gallium/u_threaded: implement set_context_param for thread pinning (v2)

From: Marek Olšák v2: - use set_context_param - set set_context_param even if the driver doesn't implement it --- .../auxiliary/util/u_threaded_context.c | 40 +++ .../auxiliary/util/u_threaded_context_calls.h | 1 + 2 files changed, 41 insertions(+) diff --git a/src/

[Mesa-dev] [PATCH 4/4] radeonsi: pin the winsys thread to the requested L3 cache (v2)

From: Marek Olšák v2: rebase --- src/gallium/drivers/radeon/radeon_winsys.h| 8 src/gallium/drivers/radeonsi/si_pipe.c| 15 +++ src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 10 ++ src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 13

[Mesa-dev] [PATCH 0/4] Patches 5-8 rework: Gallium/RadeonSI for Ryzen CPUs

This changes the interface to pipe_context::set_context_param. Please review. Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/4] gallium: add pipe_context::set_context_param for tuning perf on AMD Zen (v2)

From: Marek Olšák State trackers will not use the new param directly, but will instead use a helper in MakeCurrent that does the right thing. v2: rework the interface --- .../auxiliary/driver_ddebug/dd_context.c | 11 ++ src/gallium/auxiliary/driver_noop/noop_pipe.c | 7 +++ .

Re: [Mesa-dev] [PATCH] mesa: enable ARB_vertex_buffer_object in core profile

On 09/06/2018 03:24 PM, Timothy Arceri wrote: > On 07/09/18 06:18, Ian Romanick wrote: >> So... this game that requires at least OpenGL 3.2 (by virtue of using >> core profile) is checking for an OpenGL 1.4 feature?  That makes me a >> little sad. > > Its a little odd it creates both a compat prof

Re: [Mesa-dev] [PATCH 5/8] gallium: add pipe_context::pin_threads_to_L3_cache for AMD Zen

On Thu, Sep 6, 2018 at 2:37 PM, Brian Paul wrote: > On 09/05/2018 10:02 PM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> State trackers will not use this directly, but will instead use a helper >> in MakeCurrent that does the right thing. >> --- >> .../auxiliary/driver_ddebug/dd_context.c

Re: [Mesa-dev] [PATCH v4 0/8] mesa: fix usage of [v][s][n]printf functions

On Thu, 2018-09-06 at 17:58 +0100, Eric Engestrom wrote: > On Thursday, 2018-09-06 17:43:50 +0300, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > > This patch improve usage of [v][s][n]printf functions. > > Fixes cross platform implementation of vsnprintf > > > > v2: Linux man a

Re: [Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc6

On Fri, 2018-09-07 at 08:26 +1000, Timothy Arceri wrote: > On 06/09/18 22:36, Andres Gomez wrote: > > On Thu, 2018-09-06 at 14:15 +1000, Timothy Arceri wrote: > > > On 06/09/18 07:57, Andres Gomez wrote:> Hello list, > > > > [...] > > > > > > > > > > Testing reports/general approval > > > >

[Mesa-dev] [PATCH 1/2] anv/pipeline: Rewrite 3DSTATE_VERTEX_ELEMENTS setup

Instead of walking the attribute descriptions and filling the vertex elements packets out in random order, we now do a pre-pass where we build an array of descriptions and walk the vertex elements in order. This has the advantage of making the actual element setup more clear because it's now three

[Mesa-dev] [PATCH] i965: Set minimum message length of 2 for SIMD8 URB write

It fixes simulator error about h/w spec violation with piglit test: glsl-1.50/execution/geometry/generate-zero-primitives.shader_test. Simulator throws an error if dataLength < 1 for URB SIMD 8 write message. Signed-off-by: Anuj Phogat Cc: Kenneth Graunke Cc: --- I doubt if setting final_gs_ver

[Mesa-dev] [PATCH 2/2] intel, nir: Delete shader_info::double_inputs

The one user of this, anv, no longer needs it so lets drop it. --- src/compiler/nir/nir_gather_info.c | 14 -- src/compiler/shader_info.h | 5 - src/intel/compiler/brw_compiler.h | 1 - src/intel/compiler/brw_vec4.cpp| 2 -- 4 files changed, 22 deletions(-) diff --

[Mesa-dev] [PATCH 1/2] anv/pipeline: Rewrite 3DSTATE_VERTEX_ELEMENTS setup

--- src/intel/vulkan/genX_pipeline.c | 178 +-- 1 file changed, 99 insertions(+), 79 deletions(-) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index 297e9455b51..d3c77ecb89b 100644 --- a/src/intel/vulkan/genX_pipeline.c +++ b/src/int

[Mesa-dev] [PATCH] anv/android: handle storage images in vkGetSwapchainGrallocUsageANDROID

Android P and earlier expect that the surface supports storage images, and so many of the tests fail when the framework checks for that support. The framework also includes various image format and usage combinations that are invalid for the hardware. Drop the STORAGE restriction from the HAL and

Re: [Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc6

On 06/09/18 22:36, Andres Gomez wrote: On Thu, 2018-09-06 at 14:15 +1000, Timothy Arceri wrote: On 06/09/18 07:57, Andres Gomez wrote:> Hello list, [...] Testing reports/general approval Any testing reports (or general approval of the state of the branch) w

Re: [Mesa-dev] [PATCH] mesa: enable ARB_vertex_buffer_object in core profile

On 07/09/18 06:18, Ian Romanick wrote: So... this game that requires at least OpenGL 3.2 (by virtue of using core profile) is checking for an OpenGL 1.4 feature? That makes me a little sad. Its a little odd it creates both a compat profile then some core profile threads. It also looks for GL_

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

Am 06.09.2018 um 22:56 schrieb Axel Davy: > Yeah by pinning to cores, I meant to group of cores. > > I think a reasonable policy would be for the kernel to put all threads > of a given process on the same L3 > as long as the number of threads is lower than the L3 group size. > When there is more t

Re: [Mesa-dev] [PATCH] gallium: add PIPE_CAP_RASTERIZER_SUBPIXEL_BITS

On Thu, Sep 6, 2018 at 5:42 PM, Eric Anholt wrote: > Marek Olšák writes: > >> From: Marek Olšák > > Could you please work on providing explanatory text in your commit > messages? Something like: > > This fixes the default value of GL_SUBPIXEL_BITS, while leaving > GL_VIEWPORT_SUBPIXEL_BITS in p

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

Mesa/RadeonSI already has a lot of threads. My CPU has 8C/16T, but if you debug glxgears, you'll see 21 threads in that process with radeonsi. They are mostly shader compiler threads. Games have a bunch of threads too. Only a small number of threads really need be pinned to one L3 cache. Those ar

Re: [Mesa-dev] [PATCH 1/2] gallium: New cap PIPE_CAP_MAX_VERTEX_ELEMENT_SRC_OFFSET.

Looks alright to me, albeit seems a bit weird your hw can have offset of 255 but only max stride of 128 - max offset being larger than max stride doesn't really make a whole lot of sense. (Could you handle stride 255 maybe?) I think in d3d10 these properties are intrinsically tied together, the ma

Re: [Mesa-dev] [PATCH] gallium: add PIPE_CAP_RASTERIZER_SUBPIXEL_BITS

Marek Olšák writes: > From: Marek Olšák Could you please work on providing explanatory text in your commit messages? Something like: This fixes the default value of GL_SUBPIXEL_BITS, while leaving GL_VIEWPORT_SUBPIXEL_BITS in place. Maybe including the test name that motivated the fix. sig

Re: [Mesa-dev] [PATCH v2 2/2] Replace uses of _mesa_bitcount with util_bitcount

Dylan Baker writes: > and _mesa_bitcount_64 with util_bitcount_64. This fixes a build problem > in nir for platforms that don't have popcount or popcountll, such as > 32bit msvc. > > v2: - Fix additional uses of _mesa_bitcount added after this was > originally written Acked-by: Eric Anholt

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

Yeah by pinning to cores, I meant to group of cores. I think a reasonable policy would be for the kernel to put all threads of a given process on the same L3 as long as the number of threads is lower than the L3 group size. When there is more threads I guess it'd need heuristics to pick which

[Mesa-dev] [PATCH v2] i965: Workaround the gen9 hw astc5x5 sampler bug

From: Topi Pohjolainen gen9 hardware has a bug in the sampler cache that can cause GPU hangs whenever an texture with aux compression enabled is in the sampler cache together with an ASTC5x5 texture. Because we can't control what the client binds at any given time, we have two options: resolve t

Re: [Mesa-dev] [PATCH 2/8] intel/decoders: add address space indicator to get BOs

On 06/09/2018 21:01, Jason Ekstrand wrote: On Thu, Sep 6, 2018 at 5:35 AM Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: Some commands like MI_BATCH_BUFFER_START have this indicator. Signed-off-by: Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> ---

Re: [Mesa-dev] [PATCH v2 1/2] move u_math to src/util

On 09/06/2018 10:36 AM, Dylan Baker wrote: > Quoting Ian Romanick (2018-09-05 15:58:11) >> After this patch, are >> >> grep -r '"u_math.h"' >> >> and >> >> grep -r 'auxiliary/util/u_math.h' >> >> empty? > > Yes. Series is Reviewed-by: Ian Romanick > Dylan signature.asc Description:

Re: [Mesa-dev] [PATCH] mesa: enable ARB_vertex_buffer_object in core profile

So... this game that requires at least OpenGL 3.2 (by virtue of using core profile) is checking for an OpenGL 1.4 feature? That makes me a little sad. On 09/05/2018 08:45 PM, Timothy Arceri wrote: > This extension is required by "Wolfenstein: The Old Blood". > > All the functions are just alias

Re: [Mesa-dev] [PATCH] i965: Workaround the gen9 hw astc5x5 sampler bug

So, I just realized this will cause havvoc with MCS. I need to make some fixes and we'll have to hope that MCS + ASTC5x5 is safe because resolves aren't really a thing with MCS. On Thu, Sep 6, 2018 at 1:44 PM Kristian Høgsberg wrote: > On Thu, Sep 6, 2018 at 11:40 AM Jason Ekstrand > wrote: >

Re: [Mesa-dev] [PATCH 1/8] intel/decoders: fix end of batch limit

Reviewed-by: Jason Ekstrand On Thu, Sep 6, 2018 at 6:43 AM Eric Engestrom wrote: > On Thursday, 2018-09-06 12:39:34 +0100, Eric Engestrom wrote: > > On Thursday, 2018-09-06 11:34:44 +0100, Lionel Landwerlin wrote: > > > Pointer arithmetic... > > > > > > Signed-off-by: Lionel Landwerlin > > > -

Re: [Mesa-dev] [PATCH 2/8] intel/decoders: add address space indicator to get BOs

On Thu, Sep 6, 2018 at 5:35 AM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Some commands like MI_BATCH_BUFFER_START have this indicator. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/common/gen_batch_decoder.c | 34 ++ > src/intel/common/gen_deco

[Mesa-dev] [PATCH v3 2/4] intel/decoder: Avoid freeing invalid pointer

v2: Free ctx.spec if error while reading genxml (Lionel Landwerlin) v3: Handle case where genxml is empty (Lionel Landwerlin) Signed-off-by: Sagar Ghuge --- src/intel/common/gen_decoder.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/intel/common/ge

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

Actually, you make a good point about the kernel, but the kernel has no visibility into which threads need to be coupled together. So the kernel can't do anything. Marek On Thu, Sep 6, 2018 at 2:24 PM, Marek Olšák wrote: > I think you are missing the point. This series doesn't pin threads to > c

Re: [Mesa-dev] adriconf - Packaging

From: Veluri Mithun >Hi all, About sandbox permissions What should we use for these --talk-name=, --system-talk-name, --filesystem= finish options? Do we need to use these??? "--t

Re: [Mesa-dev] adriconf - Packaging

Hi all, > > About sandbox permissions > > > What should we use for these --talk-name=, --system-talk-name, > --filesystem= finish options? > Do we need to use these??? > "--talk-nam

Re: [Mesa-dev] [PATCH] i965: Workaround the gen9 hw astc5x5 sampler bug

On Thu, Sep 6, 2018 at 11:40 AM Jason Ekstrand wrote: > > On Thu, Sep 6, 2018 at 1:36 PM Kristian Høgsberg wrote: >> >> On Thu, Sep 6, 2018 at 9:35 AM Jason Ekstrand wrote: >> > >> > From: Topi Pohjolainen >> > >> > gen9 hardware has a bug in the sampler cache that can cause GPU hangs >> > when

Re: [Mesa-dev] [PATCH] i965: Workaround the gen9 hw astc5x5 sampler bug

On Thu, Sep 6, 2018 at 1:36 PM Kristian Høgsberg wrote: > On Thu, Sep 6, 2018 at 9:35 AM Jason Ekstrand > wrote: > > > > From: Topi Pohjolainen > > > > gen9 hardware has a bug in the sampler cache that can cause GPU hangs > > whenever an texture with aux compression enabled is in the sampler ca

Re: [Mesa-dev] [PATCH 5/8] gallium: add pipe_context::pin_threads_to_L3_cache for AMD Zen

On 09/05/2018 10:02 PM, Marek Olšák wrote: From: Marek Olšák State trackers will not use this directly, but will instead use a helper in MakeCurrent that does the right thing. --- .../auxiliary/driver_ddebug/dd_context.c | 10 ++ src/gallium/auxiliary/driver_noop/noop_pipe.c |

Re: [Mesa-dev] [PATCH] i965: Workaround the gen9 hw astc5x5 sampler bug

On Thu, Sep 6, 2018 at 9:35 AM Jason Ekstrand wrote: > > From: Topi Pohjolainen > > gen9 hardware has a bug in the sampler cache that can cause GPU hangs > whenever an texture with aux compression enabled is in the sampler cache > together with an ASTC5x5 texture. Because we can't control what t

Re: [Mesa-dev] [PATCH v3 2/4] intel/decoder: Avoid freeing invalid pointer

Please ignore this patch. On 09/06/2018 11:33 AM, Sagar Ghuge wrote: > v2: Free ctx.spec if error while reading genxml (Lionel Landwerlin) > > v3: Handle case where genxml is empty (Lionel Landwerlin) > > Signed-off-by: Sagar Ghuge > --- > src/intel/common/gen_decoder.c | 17 -

[Mesa-dev] [PATCH v3 2/4] intel/decoder: Avoid freeing invalid pointer

v2: Free ctx.spec if error while reading genxml (Lionel Landwerlin) v3: Handle case where genxml is empty (Lionel Landwerlin) Signed-off-by: Sagar Ghuge --- src/intel/common/gen_decoder.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/intel/common/gen

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

I think you are missing the point. This series doesn't pin threads to cores. It pins threads to one L3, which can have 4 or 8 cores. Marek On Thu, Sep 6, 2018 at 5:22 AM, Axel Davy wrote: > Hi Marek, > > Shouldn't this core pinning be handled by the kernel ? > > Else all multithreaded games (or

Re: [Mesa-dev] [PATCH 3/4] gallium/u_inlines: improve pipe_reference_described perf for debug builds

On Thu, Sep 6, 2018 at 6:25 AM, Michel Dänzer wrote: > On 2018-09-05 11:49 p.m., Marek Olšák wrote: >> On Tue, Sep 4, 2018 at 2:35 PM, Marek Olšák wrote: >>> On Mon, Sep 3, 2018 at 6:08 AM, Michel Dänzer wrote: On 2018-09-01 8:54 a.m., Marek Olšák wrote: > From: Marek Olšák > >

Re: [Mesa-dev] [PATCH v2 2/2] Replace uses of _mesa_bitcount with util_bitcount

Quoting Dylan Baker (2018-09-06 10:33:36) > Quoting Ian Romanick (2018-09-05 15:58:13) > > After this patch, is 'grep -r _mesa_bitcount' empty? > > I'd left the uses inside src/mesa using _mesa_bitcount, would you like me to > replace those with util_bitcount as well? Doh! Grep led me astray by s

Re: [Mesa-dev] [PATCH v2 1/2] move u_math to src/util

Quoting Ian Romanick (2018-09-05 15:58:11) > After this patch, are > > grep -r '"u_math.h"' > > and > > grep -r 'auxiliary/util/u_math.h' > > empty? Yes. Dylan signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.f

Re: [Mesa-dev] [PATCH v2 2/2] Replace uses of _mesa_bitcount with util_bitcount

Quoting Ian Romanick (2018-09-05 15:58:13) > After this patch, is 'grep -r _mesa_bitcount' empty? I'd left the uses inside src/mesa using _mesa_bitcount, would you like me to replace those with util_bitcount as well? Dylan signature.asc Description: signature ___

Re: [Mesa-dev] [PATCH v1] mesa/meson: 32bit xmlconfig linkage

On Thursday, 2018-09-06 17:38:36 +0300, Sergii Romantsov wrote: > Building of 32bit mesa with meson causes linkage issue: > "undefined reference to `util_get_process_name'" > Fixed by adding link-with mesa_util for xmlconfig primary. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=10784

Re: [Mesa-dev] [PATCH] tnl: Fix green gun regression in xonotic.

Quoting Mathias Fröhlich (2018-09-06 09:56:45) > Hi Dylan, > > On Thursday, 6 September 2018 18:11:55 CEST Dylan Baker wrote: > > > Fix an other regression of patch 64d2a2048054 > > > mesa: Make gl_vertex_array contain pointers to first order VAO members. > > > The regression showed up with driver

Re: [Mesa-dev] [PATCH v2 2/4] intel/decoder: Avoid freeing invalid pointer

On 09/06/2018 02:39 AM, Lionel Landwerlin wrote: > On 06/09/2018 05:12, Sagar Ghuge wrote: >> v2: Free ctx.spec if error while reading genxml (Lionel Landwerlin) >> >> Signed-off-by: Sagar Ghuge >> --- >>   src/intel/common/gen_decoder.c | 15 --- >>   1 file changed, 12 insertions(+)

Re: [Mesa-dev] [PATCH v4 0/8] mesa: fix usage of [v][s][n]printf functions

On Thursday, 2018-09-06 17:43:50 +0300, asimiklit.w...@gmail.com wrote: > From: Andrii Simiklit > > This patch improve usage of [v][s][n]printf functions. > Fixes cross platform implementation of vsnprintf > > v2: Linux man about vXXXprintf functions: > "These functions do not call the va_en

Re: [Mesa-dev] [PATCH] tnl: Fix green gun regression in xonotic.

Hi Dylan, On Thursday, 6 September 2018 18:11:55 CEST Dylan Baker wrote: > > Fix an other regression of patch 64d2a2048054 > > mesa: Make gl_vertex_array contain pointers to first order VAO members. > > The regression showed up with drivers using the tnl module and > > was reproducible using xonot

[Mesa-dev] [PATCH] i965: Workaround the gen9 hw astc5x5 sampler bug

From: Topi Pohjolainen gen9 hardware has a bug in the sampler cache that can cause GPU hangs whenever an texture with aux compression enabled is in the sampler cache together with an ASTC5x5 texture. Because we can't control what the client binds at any given time, we have two options: resolve t

Re: [Mesa-dev] [Mesa-stable] [PATCH] glsl: fixer lexer for unreachable defines

Quoting Timothy Arceri (2018-09-05 19:40:34) > Cc: mesa-sta...@lists.freedesktop.org > > On 01/09/18 23:57, Timothy Arceri wrote: > > If we have something like: > > > > #ifdef NOT_DEFINED > > #define A_MACRO(x) \ > > if (x) > > #endif > > > > The # on the #define is not skipped

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] android: broadcom/genxml: fix collision with intel/genxml header-gen macro

Quoting Rob Herring (2018-09-06 07:16:07) > On Mon, Sep 3, 2018 at 4:27 PM Eric Anholt wrote: > > > > Mauro Rossi writes: > > > > > Fixes the following building error, happening when building both intel > > > and broadcom: > > > > I wish someone maintaining android Mesa would work on making the

Re: [Mesa-dev] [PATCH] tnl: Fix green gun regression in xonotic.

Quoting mathias.froehl...@gmx.net (2018-08-21 21:57:57) > From: Mathias Fröhlich > > Hi Ville, Brian, > > The below patch fixes the regression to tnl drivers that Ville reported > a hand full weeks ago. > Please review! > > best > Mathias > > > Fix an other regression of patch 64d2a2048054 >

Re: [Mesa-dev] [PATCH] docs: add the beginning of the 18.3 cycle

On 1 September 2018 at 00:43, Andres Gomez wrote: > Cc: Dylan Baker > Cc: Juan A. Suarez > Cc: Emil Velikov > Signed-off-by: Andres Gomez > --- > docs/release-calendar.html | 25 + > 1 file changed, 25 insertions(+) > > This is just a proposal for the beginning of the

Re: [Mesa-dev] [PATCH v2] docs: add the beginning of the 18.3 cycle

On Thu, 2018-09-06 at 15:56 +0300, Andres Gomez wrote: > v2: Move 18.3.0-rcZ releases to Tuesdays. > > Cc: Dylan Baker > Cc: Juan A. Suarez > Cc: Emil Velikov > Signed-off-by: Andres Gomez > Acked-by: Dylan Baker > --- > > Releases should happen on Wednesdays and X.Y.0-rcZ announcements just

Re: [Mesa-dev] [PATCH v2 0/8] EGLDevice, take 2

Hi Emil, On Tuesday, 4 September 2018 20:32:57 CEST Emil Velikov wrote: > Hi all, > > Here is a re-spin of the EGLDevice series. > > Changelog highlights: > - rebased on top of "egl/android: rework device probing" > - better patch split > - surfaceless cleanups are left to another series > -

Re: [Mesa-dev] [PATCH mesa] meson: drop unnecessary llvm version hacks

Quoting Eric Engestrom (2018-09-06 07:47:49) > The current minimum meson version supported is 0.44.1, so we have met > both the 0.43 and 0.44 requirement to not need these hacks anymore :) > > Signed-off-by: Eric Engestrom > --- > meson.build | 9 - > 1 file changed, 9 deletions(-) > >

Re: [Mesa-dev] [PATCH mesa] meson: drop unnecessary llvm version hacks

On 6 September 2018 at 15:47, Eric Engestrom wrote: > The current minimum meson version supported is 0.44.1, so we have met > both the 0.43 and 0.44 requirement to not need these hacks anymore :) > Yes, please. Reviewed-by: Emil Velikov > Signed-off-by: Eric Engestrom > --- > meson.build | 9

Re: [Mesa-dev] [PATCH mesa] meson: disable asserts by default on release builds

On 6 September 2018 at 16:18, Eric Engestrom wrote: > On Wednesday, 2018-08-29 15:19:34 +0100, Emil Velikov wrote: >> On 29 August 2018 at 15:01, Eric Engestrom wrote: >> > Ping? >> > >> > I think we should land this now, ie. for 18.3. >> > >> > By the time Mesa 18.3 comes out (probably December

Re: [Mesa-dev] [PATCH 0/9] dri2: Swapbuffer update v3.

On 2018-09-06 1:20 p.m., Timothy Arceri wrote: > On 06/09/18 04:57, Thomas Hellstrom wrote: >> On 09/05/2018 04:30 PM, Timothy Arceri wrote: >>> On 05/09/18 23:36, Thomas Hellstrom wrote: On 09/05/2018 02:36 PM, Timothy Arceri wrote: > On 05/09/18 22:09, Thomas Hellstrom wrote: >>

Re: [Mesa-dev] [PATCH mesa] meson: disable asserts by default on release builds

On Wednesday, 2018-08-29 15:19:34 +0100, Emil Velikov wrote: > On 29 August 2018 at 15:01, Eric Engestrom wrote: > > Ping? > > > > I think we should land this now, ie. for 18.3. > > > > By the time Mesa 18.3 comes out (probably December '18), Meson 0.45 will > > be 9 months old (March '18), so I t

[Mesa-dev] [PATCH mesa] meson: drop unnecessary llvm version hacks

The current minimum meson version supported is 0.44.1, so we have met both the 0.43 and 0.44 requirement to not need these hacks anymore :) Signed-off-by: Eric Engestrom --- meson.build | 9 - 1 file changed, 9 deletions(-) diff --git a/meson.build b/meson.build index ae30efbfa4fdcd7c74

Re: [Mesa-dev] [PATCH v1] mesa/meson: 32bit xmlconfig linkage

Probably, here is a sense to remove constructions similar to 'libmesa_util, libxmlconfig' and left only libxmlconfig for the rest of meson.build files. Any doubts? On Thu, Sep 6, 2018 at 5:38 PM, Sergii Romantsov wrote: > Building of 32bit mesa with meson causes linkage issue: > "undefined refer

[Mesa-dev] [PATCH v4 7/8] radv: use cross platform implementation 'util_vsnprintf'

From: Andrii Simiklit I guess it makes this implementation more portable. Signed-off-by: Andrii Simiklit --- src/amd/vulkan/radv_util.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_util.c b/src/amd/vulkan/radv_util.c index 72bedc6..90d3824 100644

Re: [Mesa-dev] [PATCH] mesa: fold _glapi_check_multithread() back into _mesa_make_current

Reviewed-by: Brian Paul On 09/05/2018 10:09 AM, Emil Velikov wrote: From: Emil Velikov With commit c6c0f947142, back in 2006 Brian removed the _glapi_check_multithread() call from core mesa - _mesa_make_current. It was done to remove fairly awkward #ifdef guard which caused subtle difference

[Mesa-dev] [PATCH v4 7/7] egl/main: use cross platform implementation 'util_vsnprintf'

From: Andrii Simiklit I guess it makes this implementation more portable. Signed-off-by: Andrii Simiklit --- src/amd/vulkan/radv_util.c | 5 +++-- src/egl/main/egllog.c | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_util.c b/src/amd/vulkan/radv

[Mesa-dev] [PATCH v4 8/8] egl/main: use cross platform implementation 'util_vsnprintf'

From: Andrii Simiklit I guess it makes this implementation more portable. Signed-off-by: Andrii Simiklit --- src/egl/main/egllog.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/egl/main/egllog.c b/src/egl/main/egllog.c index c223f49..d21b070 100644 --- a/src/egl/mai

[Mesa-dev] [PATCH v4 5/8] mesa/main: don't use win _vsnprintf. there is 'util_vsnprintf' function

From: Andrii Simiklit The win '_vsnprintf' function incompatibility with C99 vsnprintf. At least for case when the input buffer size less than the required size: '_vsnprintf' returns -1 for this case. 'vsnprintf' returns the required size. So use cross platform implementation 'util_vsnprintf'.

[Mesa-dev] [PATCH v4 6/8] mesa/util: use cross platform implementation 'util_vsnprintf'

From: Andrii Simiklit The win '_vsnprintf' function incompatibility with C99 vsnprintf. At least for case when the input buffer size less than the required size: '_vsnprintf' returns -1 for this case. 'vsnprintf' returns the required size. So use cross platform implementation 'util_vsnprintf'.

[Mesa-dev] [PATCH v4 1/8] apple/glx/log: added missing va_end() after va_copy()

From: Andrii Simiklit Each invocation of va_copy() must be matched by a corresponding invocation of va_end() Fixes: 51691f0767f6 "darwin: Use ASL for logging" Signed-off-by: Andrii Simiklit --- src/glx/apple/apple_glx_log.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glx/apple/appl

[Mesa-dev] [PATCH v4 4/8] mesa/util: add missing va_end() after va_copy()

From: Andrii Simiklit MSDN: "va_end must be called on each argument list that's initialized with va_start or va_copy before the function returns." Reviewed-by: Eric Engestrom Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107810 Fixes: c6267ebd6c8a "gallium/util: Stop bundling our snpr

[Mesa-dev] [PATCH v4 2/8] mesa/util: don't use the same 'va_list' instance twice

From: Andrii Simiklit The first usage of the 'va_list' instance could change it. Reviewed-by: Eric Engestrom Fixes: 864148d69e1e "util: add util_vasprintf() for Windows (v2)" Signed-off-by: Andrii Simiklit --- src/util/u_string.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[Mesa-dev] [PATCH v4 3/8] mesa/util: don't ignore NULL returned from 'malloc'

From: Andrii Simiklit We should exit from the function 'util_vasprintf' with error code -1 for case where 'malloc' returns NULL Reviewed-by: Eric Engestrom Fixes: 864148d69e1e "util: add util_vasprintf() for Windows (v2)" Signed-off-by: Andrii Simiklit --- src/util/u_string.h | 2 +- 1 file

[Mesa-dev] [PATCH v4 0/8] mesa: fix usage of [v][s][n]printf functions

From: Andrii Simiklit This patch improve usage of [v][s][n]printf functions. Fixes cross platform implementation of vsnprintf v2: Linux man about vXXXprintf functions: "These functions do not call the va_end macro. Because they invoke the va_arg macro, the value of ap is undefined afte

Re: [Mesa-dev] [PATCH 1/2] gallium: New cap PIPE_CAP_MAX_VERTEX_ELEMENT_SRC_OFFSET.

The series looks good to me. Reviewed-by: Brian Paul On 09/06/2018 08:31 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Introduce a new capability for the maximum value of pipe_vertex_element::src_offset. Initially just every driver backend returns the value previously set from

[Mesa-dev] [Bug 107757] [Regression] Xwayland/Present: Black window with "World of Warcraft" under Wine

https://bugs.freedesktop.org/show_bug.cgi?id=107757 Eero Tamminen changed: What|Removed |Added CC||eero.t.tammi...@intel.com -- You are r

[Mesa-dev] [PATCH] vl/dri3: add support for 10 bits format

Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.c index 8e3c4a0e04d..0233f58441e 100644 --- a/src/gallium/auxi

[Mesa-dev] [PATCH v1] mesa/meson: 32bit xmlconfig linkage

Building of 32bit mesa with meson causes linkage issue: "undefined reference to `util_get_process_name'" Fixed by adding link-with mesa_util for xmlconfig primary. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107843 Signed-off-by: Sergii Romantsov --- src/gbm/meson.build | 2 +- src/g

Re: [Mesa-dev] [PATCH] virgl: Add command and flags to initiate debugging on the host

Am Donnerstag, den 06.09.2018, 15:37 +0200 schrieb Erik Faye-Lund: > > > Jfyi: These are effectively part of the ABI/protocol. A host/guest > > definitions mismatch will result in the wrong debug being printed. > > Ohh "the horror" I know, hence the jfyi ;-) > > Good point. I think they should be

Re: [Mesa-dev] [RFC 00/10] Let us welcome EGLDevice

Hi Emil, On Tuesday, 4 September 2018 22:16:18 CEST Emil Velikov wrote: > Aaand it out, yet I forgot to CC you :-\ Never mind. I have seen that but did not find the time so far to test and review. But that's on my list. best Mathias ___ mesa-dev maili

  1   2   >