[Mesa-dev] [PATCH] radv/query: handle multiview queries properly. (v2)

From: Dave Airlie For multiview we need to emit a number of sequential queries depending on the view mask. This avoids dEQP-VK.multiview.queries.15 waiting forever on the CPU for query results that are never coming. This doesn't make this test pass though, but I can now finish my CTS run. It t

Re: [Mesa-dev] [PATCH v2] nir: add a comparison simplification

Assuming the thing I typed in my phone actually works, r-b. :-). I'm a bit surprised we didn't already have that one. It seems so obvious in hindsight. On March 15, 2018 22:48:24 Timothy Arceri wrote: These can be found in the Tomb Raider shaders, eliminating them helps unroll more loops. --

Re: [Mesa-dev] [PATCH] mesa: RGB9_E5 invalid for CopyTexSubImage* in GLES

On 03/15/2018 02:04 PM, Juan A. Suarez Romero wrote: According to OpenGL ES 3.2, section 8.6, CopyTexSubImage* should return an INVALID_OPERATION if the internalformat of the texture is RGB9_E5. This fixes dEQP-GLES31.functional.debug.negative_coverage.*.copytexsubimage2d_texture_internalformat

[Mesa-dev] [PATCH] radv: handle exporting view index to fragment shader.

From: Dave Airlie The fragment shader was trying to read this, but nothing was exporting it from the vertex shader. This handles it like the prim id export. Fixes: dEQP-VK.multiview.secondary_cmd_buffer.* dEQP-VK.multiview.index.fragment_shader.* Signed-off-by: Dave Airlie --- src/amd/vulkan/

[Mesa-dev] [PATCH 9/9] vbo: Remove now duplicate _DrawVAO notification.

From: Mathias Fröhlich The DriverFlags.NewArray bit is set into NewDriverState already on _mesa_set_draw_vao since we have actually just above changed the VAOs content. So this can be removed. The _vbo_update_inputs is called by the vbo...recalculate_inputs being set through the same mechanism as

[Mesa-dev] [PATCH 4/9] mesa: Set DriverFlags.NewArray together with vbo...recalculate_inputs.

From: Mathias Fröhlich Both mean something very similar and are set at the same time now. For that vbo module to be set from core mesa, implement a public vbo module method to set that flag. In the longer term the flag should vanish in favor of a driver flag of the appropriate driver. Signed-off

[Mesa-dev] [PATCH 5/9] mesa: A change of gl_vertex_processing_mode needs an array update.

From: Mathias Fröhlich Since arrays also handle the mapping of current values into the disabled array slots, we need to tell the array update code that this mapping has changed. Also mark only dirty if it has changed. Signed-off-by: Mathias Fröhlich --- src/mesa/main/state.c | 20 +

[Mesa-dev] [PATCH 3/9] mesa: Update vao internal state when setting the _DrawVAO.

From: Mathias Fröhlich We do care if the vao set as Array._DrawVAO is ready to draw not so much that the current Array.VAO in terms of the OpenGL api is fully up to date for drawing. Also no driver looks at any VAO's NewArrays value from within the Driver.UpdateState callback. So it should be saf

[Mesa-dev] [PATCH 0/9] Clean up draw path state updates.

From: Mathias Fröhlich Hi Brian, This series mostly prepares the pushdown of gl_vertex_array use into the drivers. Once it is there we can fade that out for most of the drivers and change that on a per driver base. The series cleans up when to flag changes of the array state and introduces draw

[Mesa-dev] [PATCH 7/9] vbo: Remove redundant set of DriverFlags.NewArray in vbo_bind_arrays.

From: Mathias Fröhlich Now that setting vbo...recalculate_inputs also sets the DriverFlags.NewArray bits into the NewDriverState setting that from vbo_bind_arrays is redundant. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_context.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src

[Mesa-dev] [PATCH v2] nir: add a comparison simplification

These can be found in the Tomb Raider shaders, eliminating them helps unroll more loops. --- src/compiler/nir/nir_opt_algebraic.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index c9575e6be4..2148bc121b 100644

[Mesa-dev] [PATCH 6/9] vbo: Remove vbo...recalculate_inputs from vbo_exec_invalidate_state.

From: Mathias Fröhlich This flag is now set when the actual Array._DrawVAO changes. So setting this flag is redundant here. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_context.c | 8 1 file changed, 8 deletions(-) diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_co

[Mesa-dev] [PATCH 8/9] vbo: Remove now duplicate _vbo_update_inputs from dlist draw.

From: Mathias Fröhlich At the current state, _vbo_update_inputs is called from the draw callback if vbo...recalculate_inputs is set. But that is now set of the _DrawVAO or its content or the vertex program mode is changed. So remove _vbo_update_inputs from the direct dlist draw path. Signed-off-

[Mesa-dev] [PATCH 2/9] vbo: Move vbo_bind_arrays into a dd_driver_functions draw callback.

From: Mathias Fröhlich Factor out that common call into the almost single place. Remove the _mesa_set_drawing_arrays call from vbo_{exec,save}_draw code paths as the fonction is now called through vbo_bind_arrays. And prepare that task of updating the list of struct gl_vertex_array entries for be

[Mesa-dev] [PATCH 1/9] mesa: Make draw a first place driver method.

From: Mathias Fröhlich Make drawing functions members of struct dd_function_table. What if not drawing, should be the major purpose of an OpenGL driver. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/common/driverfuncs.c | 5 +++ src/mesa/main/dd.h| 81 ++

[Mesa-dev] [Bug 105377] Native dependency 'libtizonia' not found

https://bugs.freedesktop.org/show_bug.cgi?id=105377 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v0] nir: mako all the intrinsics

I think I like this in principal. One question would be what have you done to verify everything is the same? When I've done things like this in the past, I've written a bit of C code to compare all the info struct to ensure that the two generate the same thing. On March 15, 2018 18:43:59 Rob

Re: [Mesa-dev] [PATCH] nir: add some comparison simplifications

I think you can just do (('ine', ('b2i', 'a@bool'), 0), 'a'), Or something like that. I may have gotten the syntax wrong. On March 15, 2018 20:53:44 Timothy Arceri wrote: These can be found in the Tomb Raider shaders, eliminating them helps unroll more loops. --- src/compiler/nir/nir_opt

[Mesa-dev] [PATCH] nir: add some comparison simplifications

These can be found in the Tomb Raider shaders, eliminating them helps unroll more loops. --- src/compiler/nir/nir_opt_algebraic.py | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index c9575e6be4..56dfc53043 100

[Mesa-dev] [Bug 105171] performance regression (3x slower) running glamor with PutImage workload (radeonsi)

https://bugs.freedesktop.org/show_bug.cgi?id=105171 --- Comment #15 from Dieter Nützel --- I can't hardly see any changes.(In reply to Marek Olšák from comment #14) > Can you test this patch? > https://patchwork.freedesktop.org/patch/210920/ I see hardly any changes with radeonsi on RX 580. --

Re: [Mesa-dev] [PATCH 0/3] Meson patches for FreeBSD

On Tue, Mar 6, 2018 at 11:16 AM, Greg V wrote: > Hi! Here's a few more patches that let me successfully build, package > and install fully working Meson-built Mesa-git on my FreeBSD box. > > Greg V (3): > meson: Use system_has_kms_drm in default driver selection > meson: use relative paths in

[Mesa-dev] [PATCH v0] nir: mako all the intrinsics

I threatened to do this a long time ago.. I probably *should* have done it a long time ago when there where many fewer intrinsics. But the system of macro/#include magic for dealing with intrinsics is a bit annoying, and python has the nice property of optional fxn params, making it possible to de

Re: [Mesa-dev] [PATCH 1/5] radeonsi: remove fast color clear for single-sample buffers

Am 15.03.2018 07:56, schrieb Dieter Nützel: For the series (1-3) Tested-by: Dieter Nützel Are these numbers OK? Triangle,Radeon RX 580 Series (POLARIS10 / DRM 3.25.0 / 4.16.0-rc1-1.g7262353-default+, LLVM 7.0.0),3.1 Mesa 18.1.0-devel (git-a8cc051d2e),1920,1080,YES,Off,5240,6,0,314471 Or

Re: [Mesa-dev] [PATCH 1/2] nir: add nir_opt_move_load_ubo() optimization pass

On 09/03/18 01:50, Samuel Pitoiset wrote: This pass moves load UBO operations just before their first use, loosely based on nir_opt_move_comparisons. Signed-off-by: Samuel Pitoiset --- src/compiler/Makefile.sources| 1 + src/compiler/nir/meson.build | 1 + src/

Re: [Mesa-dev] [PATCH] intel/tools: aubinator: Catch gen11 "enhanced execlist" submission

On Fri, Mar 09, 2018 at 04:29:41PM -0800, Scott D Phillips wrote: > Different registers are used for execlist submission in gen11, so > also watch those. This code only watches element zero of the > submit queue, which is all aubdump currently writes. > --- > src/intel/tools/aubinator.c | 26 +

Re: [Mesa-dev] [PATCH] intel/compiler: Check for unsupported register sizes.

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Want to participate in the development

I don't think there area a huge number of common code TODO items. It might be useful if you list the hardware you have/are interested in working on. Tim On 16/03/18 06:37, Kuntal Majumder wrote: Hi I am Kuntal, wanted to participate in the development of mesa. Is there any list of tasks for

[Mesa-dev] [Bug 105171] performance regression (3x slower) running glamor with PutImage workload (radeonsi)

https://bugs.freedesktop.org/show_bug.cgi?id=105171 --- Comment #14 from Marek Olšák --- Can you test this patch? https://patchwork.freedesktop.org/patch/210920/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

[Mesa-dev] [PATCH v2 0/4] Enable object level preemption

I sent a patch a while ago that enables it for gen9+ on both anv and i965, but it turns out gen9 requires some workarounds. So I split the original patch and enabled it only for gen10+, but with a last patch in the series that implements the workarounds for gen9 on i965 only. I plan to implement t

[Mesa-dev] [PATCH v2 4/4] i965/gen9: Add workarounds for object preemption.

Gen9 hardware requires some workarounds to disable preemption depending on the type of primitive being emitted. We implement this by adding a new atom that tracks BRW_NEW_PRIMITIVE. Whenever it happens, we check the current type of primitive and enable/disable object preemption. For now, we just

[Mesa-dev] [PATCH v2 1/4] intel/genxml: Add register for object preemption.

Signed-off-by: Rafael Antognolli --- src/intel/genxml/gen10.xml | 8 src/intel/genxml/gen11.xml | 8 src/intel/genxml/gen9.xml | 8 3 files changed, 24 insertions(+) diff --git a/src/intel/genxml/gen10.xml b/src/intel/genxml/gen10.xml index 2d36957c2a5..f6773074a61 10

[Mesa-dev] [PATCH v2 2/4] anv/gen10: Enable object level preemption.

Set bit when initializing a device. Signed-off-by: Rafael Antognolli --- src/intel/vulkan/genX_state.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_state.c index c6e54046910..3b5ac10b4cd 100644 --- a/src/intel/vulka

[Mesa-dev] [PATCH v2 3/4] i965/gen10+: Enable object level preemption.

Set bit when initializing context. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/brw_defines.h | 5 + src/mesa/drivers/dri/i965/brw_state.h| 3 ++- src/mesa/drivers/dri/i965/brw_state_upload.c | 25

Re: [Mesa-dev] [PATCH] loader: Include include/drm-uapi in the autotools build

Quoting Jason Ekstrand (2018-03-15 14:29:55) > We're already including it in the meson build. This fixes build issues > on systems which have a drm_fourcc.h that doesn't have modifiers. > --- > src/loader/Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/loader/Makefile.am

[Mesa-dev] [PATCH] loader: Include include/drm-uapi in the autotools build

We're already including it in the meson build. This fixes build issues on systems which have a drm_fourcc.h that doesn't have modifiers. --- src/loader/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/loader/Makefile.am b/src/loader/Makefile.am index a0e52c1..7625256 100644 ---

[Mesa-dev] [Bug 105171] performance regression (3x slower) running glamor with PutImage workload (radeonsi)

https://bugs.freedesktop.org/show_bug.cgi?id=105171 Clemens Eisserer changed: What|Removed |Added Resolution|WORKSFORME |--- Status|RESOLVED

[Mesa-dev] [Bug 105171] performance regression (3x slower) running glamor with PutImage workload (radeonsi)

https://bugs.freedesktop.org/show_bug.cgi?id=105171 Marek Olšák changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW

[Mesa-dev] [Bug 105436] Blinking textures in UT2004 [bisected]

https://bugs.freedesktop.org/show_bug.cgi?id=105436 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH v4 17/18] anv: Make blorp update the clear color.

On 2018-03-08 08:49:10, Rafael Antognolli wrote: > Instead of updating the clear color in anv before a resolve, just let > blorp handle that for us during fast clears. > > Signed-off-by: Rafael Antognolli > --- > src/intel/vulkan/anv_blorp.c | 69 > +++--- >

[Mesa-dev] [PATCH] radv/query: handle multiview queries properly.

From: Dave Airlie For multiview we need to emit a number of sequential queries depending on the view mask. This avoids dEQP-VK.multiview.queries.15 waiting forever on the CPU for query results that are never coming. This doesn't make this test pass though, but I can now finish my CTS run. Sign

[Mesa-dev] [PATCH] radeonsi: don't reallocate on DMABUF export if local BOs are disabled

From: Marek Olšák --- src/amd/common/ac_gpu_info.c | 2 ++ src/amd/common/ac_gpu_info.h | 1 + src/gallium/drivers/radeon/r600_texture.c | 4 +++- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 7 +++ 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/a

[Mesa-dev] [PATCH v2 2/2] anv/pipeline: set active_stages early

Since the intermediate states of active_stages are not used, i.e. active_stages is read only after all stages were set into it, just set its value before compiling the shaders. This will allow to conditionally run certain passes based on what other shaders are being used, e.g. a certain pass might

[Mesa-dev] [PATCH v2 1/2] anv/pipeline: fail if TCS/TES compile fail

v2: Add Fixes tag. (Lionel) Fixes: e50d4807a35e679 ("anv: Compile TCS/TES shaders.") Reviewed-by: Lionel Landwerlin --- Lionel, I don't have commit access. Could you apply this patch? src/intel/vulkan/anv_pipeline.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff -

[Mesa-dev] Want to participate in the development

Hi I am Kuntal, wanted to participate in the development of mesa. Is there any list of tasks for someone who is just starting out to get acquainted with the code? Thanks Kuntal M ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://li

Re: [Mesa-dev] [RFC] nir: Add a deref instruction type

On Thu, Mar 15, 2018 at 9:50 AM, Rob Clark wrote: > On Thu, Mar 15, 2018 at 11:51 AM, Jason Ekstrand > wrote: > > On Thu, Mar 15, 2018 at 7:46 AM, Rob Clark wrote: > >> > >> On Thu, Mar 15, 2018 at 1:33 AM, Jason Ekstrand > >> wrote: > >> > This commit adds a new instruction type to NIR for ha

Re: [Mesa-dev] Releasing 18.0

On Thu, Mar 15, 2018 at 2:34 PM, Michel Dänzer wrote: > On 2018-03-15 07:25 PM, Marek Olšák wrote: > > On Thu, Mar 15, 2018 at 2:19 PM, Michel Dänzer > > wrote: > > > > On 2018-03-15 06:01 PM, Marek Olšák wrote: > > > > > > pick a3ac60e ac: move address spa

Re: [Mesa-dev] FLAG-DAY: NIR derefs

For those interested in following along, I've pushed a bunch of stuff to a branch: https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/nir-deref-instr I will continue force-pushing that branch as I go. My current approach to doing things incrementally is to try and do it by type of dereferen

Re: [Mesa-dev] [PATCH] r600: consolidate PIPE_BIND_SHARED/SCANOUT handling

Reviewed-by: Marek Olšák Marek On Thu, Mar 15, 2018 at 2:04 PM, Michel Dänzer wrote: > From: Marek Olšák > > (Ported from radeonsi commit f70f6baaa3bb0f8b280ac2eaea69bbffaf7de840) > > Allows cached BOs to be reused in more cases. > > Bugzilla: https://bugs.freedesktop.org/105171 > Signed-off-

Re: [Mesa-dev] Releasing 18.0

On 2018-03-15 07:25 PM, Marek Olšák wrote: > On Thu, Mar 15, 2018 at 2:19 PM, Michel Dänzer > wrote: > > On 2018-03-15 06:01 PM, Marek Olšák wrote: > > > > pick a3ac60e ac: move address space definitions to common code > > pick 572d46d ac: Use the renumb

Re: [Mesa-dev] Releasing 18.0

On Thu, Mar 15, 2018 at 2:19 PM, Michel Dänzer wrote: > On 2018-03-15 06:01 PM, Marek Olšák wrote: > > > > pick a3ac60e ac: move address space definitions to common code > > pick 572d46d ac: Use the renumbered const address space for LLVM 7. > > # Both are convenient for AMD devs testing 18.0 wit

[Mesa-dev] [Bug 105529] u_debug_stack.c:268: error: #pragma GCC diagnostic not allowed inside functions

https://bugs.freedesktop.org/show_bug.cgi?id=105529 Bug ID: 105529 Summary: u_debug_stack.c:268: error: #pragma GCC diagnostic not allowed inside functions Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] Releasing 18.0

On 2018-03-15 06:01 PM, Marek Olšák wrote: > > pick a3ac60e ac: move address space definitions to common code > pick 572d46d ac: Use the renumbered const address space for LLVM 7. > # Both are convenient for AMD devs testing 18.0 with LLVM master. The > latter depends on the former. It's not real

[Mesa-dev] 2018 X.Org Foundation Election Candidates

To all X.Org Foundation Members: The election for the X.Org Foundation Board of Directors will begin on 22 March 2018. We have 6 candidates who are running for 4 seats. They are (in alphabetical order): Eric Anholt Robert Foss Bryce Harrington Keith Packard Laurent Pinchart Harry Wentland Attac

Re: [Mesa-dev] [PATCH 1/4] mesa: add INTEL_blackhole_render

On 15 March 2018 at 16:08, Lionel Landwerlin wrote: > On 15/03/18 16:03, Emil Velikov wrote: >> >> HI Lionel, >> >> On 15 March 2018 at 14:24, Lionel Landwerlin >> wrote: >>> >>> Signed-off-by: Lionel Landwerlin >>> --- >>> include/GL/glext.h | 5 + >>> include/GLES2/gl2ext

[Mesa-dev] [Bug 105171] performance regression (3x slower) running glamor with PutImage workload (radeonsi)

https://bugs.freedesktop.org/show_bug.cgi?id=105171 --- Comment #11 from Michel Dänzer --- https://patchwork.freedesktop.org/patch/210907/ helps for this benchmark with the r600 driver, but radeonsi already has the same code... Clemens, are you still seeing the problem with current Mesa Git mast

[Mesa-dev] [PATCH] r600: consolidate PIPE_BIND_SHARED/SCANOUT handling

From: Marek Olšák (Ported from radeonsi commit f70f6baaa3bb0f8b280ac2eaea69bbffaf7de840) Allows cached BOs to be reused in more cases. Bugzilla: https://bugs.freedesktop.org/105171 Signed-off-by: Michel Dänzer --- src/gallium/drivers/r600/r600_buffer_common.c | 16 +--- src/galliu

Re: [Mesa-dev] Releasing 18.0

Quoting Kenneth Graunke (2018-03-14 15:24:29) > Hi Emil, all, > > I think we've closed the last of the Mesa 18.0 blocker bugs. It looks > like there are some patches nominated for the 18.0 branch still (fixing > some of those issues), but assuming things are merged, I think we're > ready to relea

Re: [Mesa-dev] [RFC] nir: Add a deref instruction type

On Thu, Mar 15, 2018 at 11:51 AM, Jason Ekstrand wrote: > On Thu, Mar 15, 2018 at 7:46 AM, Rob Clark wrote: >> >> On Thu, Mar 15, 2018 at 1:33 AM, Jason Ekstrand >> wrote: >> > This commit adds a new instruction type to NIR for handling derefs. >> > Nothing uses it yet but this adds the data str

Re: [Mesa-dev] [Mesa-stable] [PATCH] Revert "mesa: do not trigger _NEW_TEXTURE_STATE in glActiveTexture()"

Sounds good to me. Marek On Wed, Mar 14, 2018 at 6:26 AM, Timothy Arceri wrote: > > > On 14/03/18 19:46, Samuel Pitoiset wrote: > >> This reverts commit f314a532fdc7af8381586144d2631d9968331f05. >> >> This appears to introduce some blinking textures in UT2004. Not >> sure exactly what's the roo

Re: [Mesa-dev] [PATCH 2/3] meson: Use the same version for all libdrm checks

Quoting Eric Engestrom (2018-03-15 04:52:41) > On Tuesday, 2018-03-13 11:52:48 -0700, Dylan Baker wrote: > > Currently each driver specifies it's own version, and core libdrm > > specifies a version. In the most common case this is fine, since there > > will be exactly one libdrm installed on a sys

Re: [Mesa-dev] [PATCH 0/3] intel: silence some warnings

On Thu, Mar 15, 2018 at 04:49:07PM +, Lionel Landwerlin wrote: > A few trivial compiler warnings we can get rid of :) Trivial review too :) Reviewed-by: Rafael Antognolli > Cheers, > > Lionel Landwerlin (3): > anv: silence unused function warning on gen11 > i965: silence unused functio

Re: [Mesa-dev] Releasing 18.0

Hi, I'd like to have these in 18.0. People can fetch them here: git://people.freedesktop.org/~mareko/mesa for-18.0 They are already in our AMD internal 18.0 branch, so they get quite a lot of testing. pick 0554172 radeonsi: align command buffer starting address to fix some Raven hangs pick e0

[Mesa-dev] [PATCH 2/3] i965: silence unused function warning

[123/227] Compiling C object 'src/mesa/drivers/dri/i965/libi965_gen110@sta/genX_blorp_exec.c.o'. ../src/mesa/drivers/dri/i965/genX_blorp_exec.c:99:1: warning: ‘blorp_get_surface_base_address’ defined but not used [-Wunused-function] blorp_get_surface_base_address(struct blorp_batch *batch) ^~~~

[Mesa-dev] [PATCH 3/3] anv: silence unused variable warning

Fixes: 59b0ea0c748 ("anv: Stop returning VK_ERROR_INCOMPATIBLE_DRIVER") Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_device.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index d8c4e986316..82b237e76d8 100644

[Mesa-dev] [PATCH 1/3] anv: silence unused function warning on gen11

[84/227] Compiling C object 'src/intel/vulkan/libanv_gen110@sta/genX_blorp_exec.c.o'. ../src/intel/vulkan/genX_blorp_exec.c:68:1: warning: ‘blorp_get_surface_base_address’ defined but not used [-Wunused-function] blorp_get_surface_base_address(struct blorp_batch *batch) ^~~~

[Mesa-dev] [PATCH 0/3] intel: silence some warnings

A few trivial compiler warnings we can get rid of :) Cheers, Lionel Landwerlin (3): anv: silence unused function warning on gen11 i965: silence unused function warning anv: silence unused variable warning src/intel/blorp/blorp_genX_exec.h | 2 +- src/intel/vulkan/anv_device.c

Re: [Mesa-dev] [PATCH 2/2] st/mesa: simplify st_init_limits() via tgsi_processor_to_shader_stage

For the series: Reviewed-by: Marek Olšák Marek On Thu, Mar 15, 2018 at 9:12 AM, Emil Velikov wrote: > From: Emil Velikov > > Reuse the tgis helper and remove a bunch of duplicated code. > > Signed-off-by: Emil Velikov > --- > src/mesa/state_tracker/st_extensions.c | 45 > +

[Mesa-dev] [PATCH] st/dri: don't set queryDmaBufFormats/queryDmaBufModifiers if the driver does not implement it

This is equivalent to commit a65db0ad1c3, but for dri_kms_init_screen. Without this gbm_dri_is_format_supported always returns false. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104926 --- src/gallium/state_trackers/dri/dri2.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

Re: [Mesa-dev] [RFC] nir: Add a deref instruction type

On Thu, Mar 15, 2018 at 8:22 AM, Bas Nieuwenhuizen wrote: > On Thu, Mar 15, 2018 at 6:33 AM, Jason Ekstrand > wrote: > > This commit adds a new instruction type to NIR for handling derefs. > > Nothing uses it yet but this adds the data structure as well as all of > > the code to validate, print,

[Mesa-dev] [Bug 104926] swrast: Mesa 17.3.3 produces: HW cursor for format 875713089 not supported

https://bugs.freedesktop.org/show_bug.cgi?id=104926 --- Comment #3 from Michal Srb --- I was able to reproduce the `gbm_device_is_format_supported` failure. The call sequence is following: * gbm_device_is_format_supported * gbm_dri_is_format_supported (gbm->is_format_supported) - `dri->image->

Re: [Mesa-dev] [PATCH 1/7] radv: only display options that are enabled

On 03/15/2018 05:06 PM, Bas Nieuwenhuizen wrote: One comment on patch 7, and the LLVM dump ordering issue we debugged earlier (where we should dump before compiling), otherwise the series is Yes, v2 was here: https://cgit.freedesktop.org/~hakzsam/mesa/commit/?h=radv_llvm_ir&id=904e9e336cbe94

Re: [Mesa-dev] [RFC] nir: Add a deref instruction type

On Thu, Mar 15, 2018 at 7:46 AM, Rob Clark wrote: > On Thu, Mar 15, 2018 at 1:33 AM, Jason Ekstrand > wrote: > > This commit adds a new instruction type to NIR for handling derefs. > > Nothing uses it yet but this adds the data structure as well as all of > > the code to validate, print, clone,

Re: [Mesa-dev] [PATCH 7/7] radv: dump LLVM IR when AMD_shader_info is used

On 03/15/2018 05:04 PM, Bas Nieuwenhuizen wrote: On Wed, Mar 14, 2018 at 12:27 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index 3

Re: [Mesa-dev] [PATCH 4/4] intel: genxml: add INSTPM/CS_DEBUG_MODE2 registers

On 15 March 2018 at 14:24, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > src/intel/genxml/gen10.xml | 6 ++ > src/intel/genxml/gen11.xml | 6 ++ > src/intel/genxml/gen6.xml | 7 +++ > src/intel/genxml/gen7.xml | 7 +++ > src/intel/genxml/gen75.xml | 7

Re: [Mesa-dev] [PATCH 1/4] mesa: add INTEL_blackhole_render

On 15/03/18 16:03, Emil Velikov wrote: HI Lionel, On 15 March 2018 at 14:24, Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin --- include/GL/glext.h | 5 + include/GLES2/gl2ext.h | 5 + src/mapi/glapi/registry/gl.xml | 8 +++- Please updat

Re: [Mesa-dev] [PATCH 1/7] radv: only display options that are enabled

One comment on patch 7, and the LLVM dump ordering issue we debugged earlier (where we should dump before compiling), otherwise the series is Reviewed-by: Bas Nieuwenhuizen On Wed, Mar 14, 2018 at 12:27 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_de

Re: [Mesa-dev] [PATCH 7/7] radv: dump LLVM IR when AMD_shader_info is used

On Wed, Mar 14, 2018 at 12:27 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_shader.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c > index 327ae9fe3d..1ece13657c 100644 > --- a/src/am

Re: [Mesa-dev] [PATCH 1/4] mesa: add INTEL_blackhole_render

HI Lionel, On 15 March 2018 at 14:24, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > include/GL/glext.h | 5 + > include/GLES2/gl2ext.h | 5 + > src/mapi/glapi/registry/gl.xml | 8 +++- Please update these by pulling the latest files

Re: [Mesa-dev] [RFC] nir: Add a deref instruction type

On Thu, Mar 15, 2018 at 6:33 AM, Jason Ekstrand wrote: > This commit adds a new instruction type to NIR for handling derefs. > Nothing uses it yet but this adds the data structure as well as all of > the code to validate, print, clone, and [de]serialize them. > > Cc: Rob Clark > Cc: Connor Abbott

Re: [Mesa-dev] FLAG-DAY: NIR derefs

On 15/03/18 15:39, Jason Ekstrand wrote: > On Thu, Mar 15, 2018 at 1:12 AM, Alejandro Piñeiro > mailto:apinhe...@igalia.com>> wrote: > > Hi, > > On 14/03/18 21:32, Jason Ekstrand wrote: >> All, >> >> Connor and I along with several others have been discussing for a >> while chan

Re: [Mesa-dev] [PATCH v4 14/18] anv: Add a helper to extract clear color from the attachment.

On Thu, Mar 15, 2018 at 12:20:19AM -0700, Jordan Justen wrote: > On 2018-03-08 08:49:07, Rafael Antognolli wrote: > > Extract the code from color_attachment_compute_aux_usage, so we can > > later reuse it to update the clear color state buffer. > > > > Signed-off-by: Rafael Antognolli > > --- > >

Re: [Mesa-dev] [PATCH v4 10/18] i965/miptree: Add new BO for clear color.

On Wed, Mar 14, 2018 at 05:26:08PM -0700, Jordan Justen wrote: > What about a subject like this? > > i965/miptree: Add new clear color BO for winsys aux buffers It's definitely better. I'll update it. > On 2018-03-08 08:49:03, Rafael Antognolli wrote: > > Add an extra BO to store clear color whe

Re: [Mesa-dev] [RFC] nir: Add a deref instruction type

On Thu, Mar 15, 2018 at 1:33 AM, Jason Ekstrand wrote: > This commit adds a new instruction type to NIR for handling derefs. > Nothing uses it yet but this adds the data structure as well as all of > the code to validate, print, clone, and [de]serialize them. > > Cc: Rob Clark > Cc: Connor Abbott

Re: [Mesa-dev] FLAG-DAY: NIR derefs

On Thu, Mar 15, 2018 at 1:12 AM, Alejandro Piñeiro wrote: > Hi, > On 14/03/18 21:32, Jason Ekstrand wrote: > > All, > > Connor and I along with several others have been discussing for a while > changing the way NIR dereferences work. In particular, adding a new > nir_deref_instr type where the f

Re: [Mesa-dev] [PATCH 3/4] i965: enable INTEL_blackhole_render on haswell+

Quoting Lionel Landwerlin (2018-03-15 14:24:32) > diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c > b/src/mesa/drivers/dri/i965/intel_extensions.c > index 73a6c73f537..12d22e12eee 100644 > --- a/src/mesa/drivers/dri/i965/intel_extensions.c > +++ b/src/mesa/drivers/dri/i965/intel_extensio

[Mesa-dev] [FLAG-DAY-PREP 6/9] nir: use nir_intrinsic_var() accessor

--- src/compiler/nir/nir_gather_info.c | 2 +- src/compiler/nir/nir_inline_functions.c| 6 +++--- src/compiler/nir/nir_linking_helpers.c | 10 -- src/compiler/nir/nir_lower_alpha_test.c| 2 +- src/compiler/nir/nir_lower_atomics.c

[Mesa-dev] [FLAG-DAY-PREP 4/9] mesa/st: use nir_intrinsic_var() accessor

--- src/mesa/state_tracker/st_nir_lower_builtin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_nir_lower_builtin.c b/src/mesa/state_tracker/st_nir_lower_builtin.c index fca0bef6653..29570eaf29b 100644 --- a/src/mesa/state_tracker/st_nir_lower_built

[Mesa-dev] [FLAG-DAY-PREP 8/9] intel: use nir_tex_*_var() accessors

--- src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 18 +++--- src/intel/vulkan/anv_nir_lower_ycbcr_textures.c | 2 +- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/src/intel/vulkan/anv_nir_apply_pipeline_layout.c b/src/intel/vulkan/anv_nir_apply_pipeline_layout

[Mesa-dev] [FLAG-DAY-PREP 7/9] nir: use nir_tex_*_var() accessors

--- src/compiler/nir/nir_instr_set.c | 2 +- src/compiler/nir/nir_lower_samplers.c| 6 -- src/compiler/nir/nir_remove_dead_variables.c | 14 ++ 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/compiler/nir/nir_instr_set.c b/src/compiler/nir

[Mesa-dev] [FLAG-DAY-PREP 9/9] amd: use nir_tex_*_var() accessors

--- src/amd/common/ac_nir_to_llvm.c | 6 -- src/amd/vulkan/radv_shader_info.c | 11 +++ 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 8df00fc3c8c..37e66f081de 100644 --- a/src/amd/common/ac_nir

[Mesa-dev] [FLAG-DAY-PREP 1/9] nir: start to abstract deref chains/instructions

Prep work to convert from deref chains to deref instruction chains, add a accessors so we can start moving code away from direct access to deref chain just for the sake of finding the nir_variable. After conversion to deref instructions, this would be converted to chase the deref instruction ssa l

[Mesa-dev] [FLAG-DAY-PREP 0/9] nir: accessors for deref vars

Since a fair bit of access to nir_deref_var's is just to chase down the nir_variable for an intrinsic (or texture/sampler vars for tex instructions), we can make the flag day slightly less painful with some accessors that could be re-implemented for deref instruction chains. It will still be a fla

[Mesa-dev] [FLAG-DAY-PREP 5/9] intel: use nir_intrinsic_var() accessor

--- src/intel/compiler/brw_fs_nir.cpp | 4 ++-- src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 2 +- src/intel/vulkan/anv_nir_lower_input_attachments.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compi

[Mesa-dev] [FLAG-DAY-PREP 3/9] amd: use nir_intrinsic_var() accessor

--- src/amd/common/ac_nir_to_llvm.c | 70 +++- src/amd/vulkan/radv_shader_info.c| 11 ++--- src/gallium/drivers/radeonsi/si_shader_nir.c | 4 +- 3 files changed, 44 insertions(+), 41 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/

[Mesa-dev] [FLAG-DAY-PREP 2/9] freedreno/ir3: use nir_intrinsic_var() accessor

--- src/gallium/drivers/freedreno/ir3/ir3_compiler_nir.c | 8 src/gallium/drivers/freedreno/ir3/ir3_nir.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/freedreno/ir3/ir3_compiler_nir.c b/src/gallium/drivers/freedreno/ir3/ir3_compiler_

[Mesa-dev] [PATCH 4/4] intel: genxml: add INSTPM/CS_DEBUG_MODE2 registers

Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml | 6 ++ src/intel/genxml/gen11.xml | 6 ++ src/intel/genxml/gen6.xml | 7 +++ src/intel/genxml/gen7.xml | 7 +++ src/intel/genxml/gen75.xml | 7 +++ src/intel/genxml/gen8.xml | 7 +++ src/intel/genxml/gen9.

[Mesa-dev] [PATCH 3/4] i965: enable INTEL_blackhole_render on haswell+

Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/brw_defines.h | 8 ++- src/mesa/drivers/dri/i965/brw_misc_state.c| 33 +++ src/mesa/drivers/dri/i965/brw_state.h | 1 + src/mesa/dr

[Mesa-dev] [PATCH 0/4] mesa/i965: Add support for INTEL_blackhole_render

Hi all, This series implements a new extension that just landed in the Khronos repository : https://github.com/KhronosGroup/OpenGL-Registry/commit/a4f25a7ec733d397d8ea78794a066ea519493688 The purpose of this extension is mostly to enable a feature that is used in GPA [1], allowing to disable all

[Mesa-dev] [PATCH 1/4] mesa: add INTEL_blackhole_render

Signed-off-by: Lionel Landwerlin --- include/GL/glext.h | 5 + include/GLES2/gl2ext.h | 5 + src/mapi/glapi/registry/gl.xml | 8 +++- src/mesa/main/clear.c| 2 +- src/mesa/main/enable.c | 10 ++ src/mesa/main/extensions_table

[Mesa-dev] [PATCH 2/4] i965: pipecontrol: add LRI write immediate flag

Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_pipe_control.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_pipe_control.h b/src/mesa/drivers/dri/i965/brw_pipe_control.h index 651cd4d3e70..4c58e16660f 100644 --- a/src/mesa/drivers/dri/i965/

  1   2   >