Re: [Mesa-dev] [PATCH v3 19/34] intel/compiler: Add union types for prog_data and prog_key stages

2017-10-23 Thread Jordan Justen
On 2017-10-23 23:23:27, Kenneth Graunke wrote: > On Sunday, October 22, 2017 1:01:27 PM PDT Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > --- > > src/intel/compiler/brw_compiler.h | 18 ++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/src/intel/compiler/br

Re: [Mesa-dev] [PATCH v3 20/34] intel/compiler: Add functions to get prog_data and prog_key sizes for a stage

2017-10-23 Thread Kenneth Graunke
On Sunday, October 22, 2017 1:01:28 PM PDT Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/intel/compiler/brw_compiler.c | 36 > src/intel/compiler/brw_compiler.h | 6 ++ > 2 files changed, 42 insertions(+) > > diff --git a/src/intel/comp

Re: [Mesa-dev] [PATCH v3 19/34] intel/compiler: Add union types for prog_data and prog_key stages

2017-10-23 Thread Kenneth Graunke
On Sunday, October 22, 2017 1:01:27 PM PDT Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/intel/compiler/brw_compiler.h | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/src/intel/compiler/brw_compiler.h > b/src/intel/compiler/brw_compiler.h > index 7

Re: [Mesa-dev] [PATCH 3/3] i965: Call gen6_upload_push_constants() even when the stage is disabled.

2017-10-23 Thread Pohjolainen, Topi
On Mon, Oct 23, 2017 at 11:57:53AM -0700, Kenneth Graunke wrote: > This properly sets stage_state->push_constant_dirty = true, so that we > emit 3DSTATE_CONSTANT_XS to disable the constant buffer for the shader > stage. It also sets stage_state->push_const_size = 0. > --- > src/mesa/drivers/dri/i

Re: [Mesa-dev] [PATCH v3 15/34] i965: Don't rely on nir for uses_texture_gather

2017-10-23 Thread Kenneth Graunke
On Sunday, October 22, 2017 1:01:23 PM PDT Jordan Justen wrote: > When a program is restored from the shader cache, prog->nir will be > NULL, but prog->info will be restored. > > Signed-off-by: Jordan Justen Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitally signed me

Re: [Mesa-dev] [PATCH 7/9] wayland-drm: static inline wayland_drm_buffer_get

2017-10-23 Thread Pekka Paalanen
On Mon, 23 Oct 2017 18:05:12 +0100 Emil Velikov wrote: > On 23 October 2017 at 16:41, Daniel Stone wrote: > > Hi Emil, > > > > On 28 September 2017 at 13:36, Emil Velikov > > wrote: > >> On 20 September 2017 at 15:06, Daniel Stone wrote: > >>> On 19 September 2017 at 11:25, Emil Velikov

Re: [Mesa-dev] [PATCH 2/3] i965/blorp: Use more temporary isl_format variables

2017-10-23 Thread Pohjolainen, Topi
On Mon, Oct 23, 2017 at 05:23:08PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 15 +++ > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c > b/src/mesa/drivers/dri/i965/brw_blorp.c > index f7d128d..

Re: [Mesa-dev] [PATCH 2/2] st/program: add support for gs/tes/tcs nir shaders.

2017-10-23 Thread Timothy Arceri
Series: Reviewed-by: Timothy Arceri On 24/10/17 09:41, Dave Airlie wrote: From: Dave Airlie This probably needs more work but this just add the initial code to convert gs/tcs/tes nir based shaders in the state tracker. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_nir.

Re: [Mesa-dev] [PATCH] st/mesa: enable nir path for all shaders.

2017-10-23 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 24/10/17 09:44, Dave Airlie wrote: From: Dave Airlie There is no reason to block this here, if a driver enables it, let it handle it. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 10 +- 1 file changed, 1 insertion(+),

Re: [Mesa-dev] [PATCH 7/9] wayland-drm: static inline wayland_drm_buffer_get

2017-10-23 Thread Pekka Paalanen
On Mon, 23 Oct 2017 16:41:14 +0100 Daniel Stone wrote: > Hi Emil, > > On 28 September 2017 at 13:36, Emil Velikov wrote: > > On 20 September 2017 at 15:06, Daniel Stone wrote: > >> On 19 September 2017 at 11:25, Emil Velikov > >> wrote: > >>> It looks a bit icky and my Wayland knowledge

Re: [Mesa-dev] [PATCH] i965: Don't disable CCS for RT dependencies when dispatching compute.

2017-10-23 Thread Jason Ekstrand
Rb On October 23, 2017 22:21:47 Kenneth Graunke wrote: Compute shaders don't have access to the framebuffer, so there's no point in worrying whether a texture is bound as a render target. This saves a bunch of resolves in GFXBench4 Manhattan 3.1, but doesn't seem to impact performance at all

[Mesa-dev] [PATCH] i965: Don't disable CCS for RT dependencies when dispatching compute.

2017-10-23 Thread Kenneth Graunke
Compute shaders don't have access to the framebuffer, so there's no point in worrying whether a texture is bound as a render target. This saves a bunch of resolves in GFXBench4 Manhattan 3.1, but doesn't seem to impact performance at all, at least on Apollolake. --- src/mesa/drivers/dri/i965/brw_

Re: [Mesa-dev] [PATCH 1/2] mesa: enum checks for GL_EXT_occlusion_query_boolean

2017-10-23 Thread Tapani Pälli
gentle ping .. (after this we could also enable GL_EXT_disjoint_timer_query and have more queries available for gles) On 10/04/2017 02:56 PM, Tapani Pälli wrote: Some of the checks are valid for generic ES 3.2 as well. Signed-off-by: Tapani Pälli --- src/mesa/main/queryobj.c | 44 +++

[Mesa-dev] [PATCH] radv: only emit dfsm packets if dfsm is allowed.

2017-10-23 Thread Dave Airlie
From: Dave Airlie radeonsi only emits these when dfsm is enabled, so for now just hinge them on a flag we never set. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 6 +++--- src/amd/vulkan/radv_private.h| 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v3 00/34] i965 disk shader cache

2017-10-23 Thread Jason Ekstrand
I didn't re-read every thing in v3 but I did read all of v2 on Friday. Assuming you didn't make any massive changes other than those detailed here, the series is Reviewed-by: Jason Ekstrand Except, of course, for the couple of patches written by me. Also, I can't really say I properly reviewed

Re: [Mesa-dev] [PATCH v3 21/34] i965: add initial implementation of on disk shader cache

2017-10-23 Thread Jason Ekstrand
I made one minor comment below. Reviewed-by: Jason Ekstrand On Sun, Oct 22, 2017 at 1:01 PM, Jordan Justen wrote: > From: Timothy Arceri > > This uses the recently-added disk_cache.c to write out the final > linked binary for vertex and fragment shader programs. > > This is based off the init

Re: [Mesa-dev] [PATCH 3/5] compiler: define endian for FreeBSD

2017-10-23 Thread Brian Paul
On 10/23/2017 02:20 PM, Greg V wrote: Obtained from: FreeBSD ports --- src/mesa/main/compiler.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index 43a06b4313..8652aac36c 100644 --- a/src/mesa/main/compiler.h +++ b/src/mesa/main/comp

[Mesa-dev] [PATCH 2/5] loader: use drmGetDeviceNameFromFd2 from libdrm

2017-10-23 Thread Greg V
Reduce code duplication and automatically benefit from OS-specific fixes to libdrm (e.g. in FreeBSD ports). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103283 --- src/loader/loader.c | 36 +--- 1 file changed, 1 insertion(+), 35 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] automake: intel: correctly append to the LIBADD variable

2017-10-23 Thread Hongxu Jia
On 2017年10月23日 20:29, Emil Velikov wrote: From: Emil Velikov Commit 05fc62d89f5 sets the variable, yet it forgot the update the existing reference to append (instead of assign). Thus as-is the expat library was discarded from the link chain when building with Android. Fixes: 05fc62d89f5 ("aut

[Mesa-dev] [PATCH 4/5] winsys/svga/drm: add ERESTART define for *BSD

2017-10-23 Thread Greg V
Obtained from: FreeBSD ports --- src/gallium/winsys/svga/drm/vmw_screen_ioctl.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/winsys/svga/drm/vmw_screen_ioctl.c b/src/gallium/winsys/svga/drm/vmw_screen_ioctl.c index 79f9d950d9..62a2af6d65 100644 --- a/src/gallium/winsys/svg

[Mesa-dev] [PATCH 3/5] compiler: define endian for FreeBSD

2017-10-23 Thread Greg V
Obtained from: FreeBSD ports --- src/mesa/main/compiler.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index 43a06b4313..8652aac36c 100644 --- a/src/mesa/main/compiler.h +++ b/src/mesa/main/compiler.h @@ -51,6 +51,9 @@ #if defined(__li

[Mesa-dev] [PATCH 1/5] anv: add ETIME fallback define

2017-10-23 Thread Greg V
FreeBSD only has ETIMEDOUT, not ETIME --- src/intel/vulkan/anv_device.c | 4 src/intel/vulkan/anv_gem.c| 4 src/intel/vulkan/anv_queue.c | 4 3 files changed, 12 insertions(+) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 67028e8da9..fab2a394

[Mesa-dev] [PATCH 5/5] util: use OpenBSD/NetBSD code on FreeBSD/DragonFly

2017-10-23 Thread Greg V
Obtained from: FreeBSD ports --- src/util/u_endian.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/u_endian.h b/src/util/u_endian.h index b9d563dd43..7be33dd3a5 100644 --- a/src/util/u_endian.h +++ b/src/util/u_endian.h @@ -54,7 +54,7 @@ # define PIPE_ARCH_BIG_ENDIA

[Mesa-dev] [PATCH 0/5] FreeBSD compatibility patches

2017-10-23 Thread Greg V
This set of patches includes a bunch of simple fixes from FreeBSD ports and a loader patch that fixes Wayland/EGL clients not reading GPU device name correctly on FreeBSD. Greg V (5): anv: add ETIME fallback define loader: use drmGetDeviceNameFromFd2 from libdrm compiler: define endian for

Re: [Mesa-dev] [PATCH] mesa: fix GL_{COLOR, DEPTH, STENCIL}_COMPONENTS queries for TBOs

2017-10-23 Thread Ilia Mirkin
On Mon, Oct 23, 2017 at 9:16 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/main/formatquery.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c > index 05b7810..9c53d7c 100644 > --- a/src/mesa/main/form

[Mesa-dev] [PATCH] mesa: fix GL_{COLOR, DEPTH, STENCIL}_COMPONENTS queries for TBOs

2017-10-23 Thread Marek Olšák
From: Marek Olšák --- src/mesa/main/formatquery.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c index 05b7810..9c53d7c 100644 --- a/src/mesa/main/formatquery.c +++ b/src/mesa/main/formatquery.c @@ -1094,43 +1094,54 @@ _

Re: [Mesa-dev] [PATCH v3] egl/wayland: Support for KHR_partial_update

2017-10-23 Thread Harish Krupo
Hi Emil, Emil Velikov writes: > On 23 October 2017 at 11:50, Harish Krupo wrote: >> This passes 33/37 deqp tests related to partial_update, 4 are not >> supported. Tests not supported: >> dEQP-EGL.functional.negative_partial_update.not_postable_surface >> dEQP-EGL.functional.negative_partial_up

Re: [Mesa-dev] [PATCH v3 17/34] intel/compiler: Remove final_program_size from brw_compile_*

2017-10-23 Thread Jason Ekstrand
On Mon, Oct 23, 2017 at 5:11 PM, Jordan Justen wrote: > Attached is the missing change to brw_vec4_gs_visitor.cpp, which Jason > pointed out. The issue was hiding out in a compiler warning. > We should be able to drop the final_program_size variable. I think that would be a bit more fool-proof.

[Mesa-dev] [PATCH 1/3] i965/blorp: Use blorp_to_isl_format for src_isl_format in blit_miptrees

2017-10-23 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_blorp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index ed4f987..f7d128d 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp.c +++ b/src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH 2/3] i965/blorp: Use more temporary isl_format variables

2017-10-23 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_blorp.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index f7d128d..05204a9 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp.c +++ b/src/mesa/driv

[Mesa-dev] [PATCH 3/3] i965/miptree: Take an isl_format in render_aux_usage

2017-10-23 Thread Jason Ekstrand
Not all rendering matches the miptree format. We allow rendering to texture views so there are cases where it may not match. In those cases, our current scheme of just passing the value of ctx->sRGBEnabled isn't viable. Instead, just do what we do for texturing and pass the view format in direct

Re: [Mesa-dev] [PATCH v3 17/34] intel/compiler: Remove final_program_size from brw_compile_*

2017-10-23 Thread Jordan Justen
Attached is the missing change to brw_vec4_gs_visitor.cpp, which Jason pointed out. The issue was hiding out in a compiler warning. -Jordan On 2017-10-22 13:01:25, Jordan Justen wrote: > The caller can now use brw_stage_prog_data::program_size which is set > by the brw_compile_* functions. > > C

[Mesa-dev] [Bug 103312] meson/macOS: Dependency libdrm_intel found: NO

2017-10-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103312 Dylan Baker changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #4 from Dylan Baker

Re: [Mesa-dev] [PATCH] i965: Revert absolute mode for constant buffer pointers.

2017-10-23 Thread Kenneth Graunke
On Monday, October 23, 2017 3:53:15 PM PDT Rodrigo Vivi wrote: > On Mon, Oct 23, 2017 at 10:32:43PM +, Jordan Justen wrote: > > On 2017-10-19 16:30:44, Kristian Høgsberg wrote: > > > On Thu, Oct 19, 2017 at 4:18 PM, Kenneth Graunke > > > wrote: > > > > The kernel doesn't initialize the value

Re: [Mesa-dev] [PATCH] radv: move nir print after linking is done

2017-10-23 Thread Bas Nieuwenhuizen
r-b On Tue, Oct 24, 2017 at 12:59 AM, Timothy Arceri wrote: > We now have linking optimisation so we want to delay dumping the > nir until after these are complete. > > Fixes: 06f05040eb73 (radv: Link shaders) > --- > src/amd/vulkan/radv_pipeline.c | 9 +++-- > src/amd/vulkan/radv_shader.c

[Mesa-dev] [PATCH] radv: move nir print after linking is done

2017-10-23 Thread Timothy Arceri
We now have linking optimisation so we want to delay dumping the nir until after these are complete. Fixes: 06f05040eb73 (radv: Link shaders) --- src/amd/vulkan/radv_pipeline.c | 9 +++-- src/amd/vulkan/radv_shader.c | 3 --- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/sr

Re: [Mesa-dev] [PATCH] i965: Revert absolute mode for constant buffer pointers.

2017-10-23 Thread Rodrigo Vivi
On Mon, Oct 23, 2017 at 10:32:43PM +, Jordan Justen wrote: > On 2017-10-19 16:30:44, Kristian Høgsberg wrote: > > On Thu, Oct 19, 2017 at 4:18 PM, Kenneth Graunke > > wrote: > > > The kernel doesn't initialize the value of the INSTPM or CS_DEBUG_MODE2 > > > registers at context initialization

[Mesa-dev] [PATCH] st/mesa: enable nir path for all shaders.

2017-10-23 Thread Dave Airlie
From: Dave Airlie There is no reason to block this here, if a driver enables it, let it handle it. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH 2/2] st/program: add support for gs/tes/tcs nir shaders.

2017-10-23 Thread Dave Airlie
From: Dave Airlie This probably needs more work but this just add the initial code to convert gs/tcs/tes nir based shaders in the state tracker. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 12 + src/mesa/state_tracker/st_program.c | 45 +

[Mesa-dev] [PATCH 1/2] st/program: rework basic variant interface

2017-10-23 Thread Dave Airlie
From: Dave Airlie This just passes st_common_program and uses it. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom_shader.c | 3 +-- src/mesa/state_tracker/st_program.c | 21 ++--- src/mesa/state_tracker/st_program.h | 3 +-- 3 files changed, 12 insertion

Re: [Mesa-dev] [PATCH] i965: Revert absolute mode for constant buffer pointers.

2017-10-23 Thread Jordan Justen
On 2017-10-19 16:30:44, Kristian Høgsberg wrote: > On Thu, Oct 19, 2017 at 4:18 PM, Kenneth Graunke > wrote: > > The kernel doesn't initialize the value of the INSTPM or CS_DEBUG_MODE2 > > registers at context initialization time. Instead, they're inherited > > from whatever happened to be runni

Re: [Mesa-dev] [PATCH v3 00/34] i965 disk shader cache

2017-10-23 Thread Jordan Justen
On 2017-10-22 13:01:08, Jordan Justen wrote: > > Patch code review status: > > mesa/glsl: add api_enabled flag to gl_transform_feedback_info > > i965: add support for cached shaders with xfb qualifiers It sounds like Tim has a plan for supporting shader cache with transform feedback, but for no

Re: [Mesa-dev] [PATCH] configure: Allow android as an EGL platform

2017-10-23 Thread Benjamin Gordon
On Mon, Oct 23, 2017 at 11:10 AM, Eric Engestrom wrote: > On Friday, 2017-10-20 15:34:57 -0600, Benjamin Gordon wrote: > > I'm working on radeonsi support in the Chrome OS Android container > > (ARC++). Mesa in ARC++ uses autotools instead of Android.mk, but all > > the necessary EGL bits are th

[Mesa-dev] [PATCH] gallium/util: use util_snprintf() in u_socket_connect()

2017-10-23 Thread Brian Paul
Instead of plain snprintf(). To fix the MSVC build. snprintf() is used in various places in Mesa/gallium, but apparently, not in code built with MSVC. --- src/gallium/auxiliary/util/u_network.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_net

[Mesa-dev] [AppVeyor] mesa master #5910 failed

2017-10-23 Thread AppVeyor
Build mesa 5910 failed Commit 069211f205 by Brian Paul on 10/17/2017 7:59 PM: gallium/util: don't call close() on Windows in u_tests.c\n\nReviewed-by: Nicolai Hähnle Configure your notification preferences ___

Re: [Mesa-dev] [PATCH v2 6/8] egl: add dri2_egl_surface_destroy_image_front() helper (v2)

2017-10-23 Thread Mun, Gwan-gyeong
Hi Gurchetan, 2017-10-18 6:02 GMT+09:00 Gurchetan Singh : > dri2_egl_surface_destroy_image_front and dri2_egl_surface_destroy_image_back > are almost identical. Why don't you just create a > dri2_surface_free_image(struct dri2_egl_surface *dri2_surf, __DRIimage > **img) that you will call with bo

[Mesa-dev] [Bug 103427] VK_ERROR_INITIALIZATION_FAILED with 280x: vkEnumeratePhysicalDevices(vk->inst, &num, NULL): VK_ERROR_INITIALIZATION_FAILED

2017-10-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103427 --- Comment #3 from Emil Velikov --- Adding some debug information in radv_EnumeratePhysicalDevices and/or stepping through it with a debugger might be a good idea. There are multiple reasons why enumeration can fail. -- You are receiving this

Re: [Mesa-dev] [PATCH v2 1/8] egl: add dri2_egl_surface_free_outdated_buffers_and_update_size() helper (v2)

2017-10-23 Thread Mun, Gwan-gyeong
Hi Emil and Gurchetan, Thank you for reviewing the patches. 2017-10-20 6:18 GMT+09:00 Gurchetan Singh : > De-duplicating and then trimming down works for me. > > On Thu, Oct 19, 2017 at 3:31 AM, Emil Velikov > wrote: >> >> On 18 October 2017 at 23:36, Gurchetan Singh >> wrote: >> >> Then again

[Mesa-dev] [PATCH 1/3] i965: Move _mesa_shader_write_subroutine_indices down a level.

2017-10-23 Thread Kenneth Graunke
Now we call it in one place instead of making every caller do it. --- src/mesa/drivers/dri/i965/gen6_constant_state.c | 3 +++ src/mesa/drivers/dri/i965/genX_state_upload.c | 6 -- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_constant_state.c

[Mesa-dev] [PATCH 3/3] i965: Call gen6_upload_push_constants() even when the stage is disabled.

2017-10-23 Thread Kenneth Graunke
This properly sets stage_state->push_constant_dirty = true, so that we emit 3DSTATE_CONSTANT_XS to disable the constant buffer for the shader stage. It also sets stage_state->push_const_size = 0. --- src/mesa/drivers/dri/i965/gen6_constant_state.c | 9 +++-- src/mesa/drivers/dri/i965/genX_st

[Mesa-dev] [PATCH 2/3] i965: Drop a bunch of downcasting and upcasting of gl_program pointers.

2017-10-23 Thread Kenneth Graunke
We have a gl_program and we want a gl_program. There's no point in converting to brw_program and back again. This probably made more sense in the old days before Tim dropped a layer of subclassing. --- src/mesa/drivers/dri/i965/genX_state_upload.c | 31 +++ 1 file changed

[Mesa-dev] [Bug 103427] VK_ERROR_INITIALIZATION_FAILED with 280x: vkEnumeratePhysicalDevices(vk->inst, &num, NULL): VK_ERROR_INITIALIZATION_FAILED

2017-10-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103427 --- Comment #2 from Cris --- (In reply to Bas Nieuwenhuizen from comment #1) > So according to the glxinfo log, you're still using the radeon kernel > driver.(See the DRM version bit in the renderer string? 2.x is radeon, 3.x > is amdgpu). radv

[Mesa-dev] [Bug 103427] VK_ERROR_INITIALIZATION_FAILED with 280x: vkEnumeratePhysicalDevices(vk->inst, &num, NULL): VK_ERROR_INITIALIZATION_FAILED

2017-10-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103427 Bas Nieuwenhuizen changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW

[Mesa-dev] [Bug 103427] VK_ERROR_INITIALIZATION_FAILED with 280x: vkEnumeratePhysicalDevices(vk->inst, &num, NULL): VK_ERROR_INITIALIZATION_FAILED

2017-10-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103427 Bug ID: 103427 Summary: VK_ERROR_INITIALIZATION_FAILED with 280x: vkEnumeratePhysicalDevices(vk->inst, &num, NULL): VK_ERROR_INITIALIZATION_FAILED Product: Mesa

Re: [Mesa-dev] [PATCH 1/2] intel: fix memmem() warning first arg shouldn't be NULL

2017-10-23 Thread Matt Turner
On Sun, Oct 22, 2017 at 6:26 PM, Timothy Arceri wrote: > --- > src/intel/compiler/brw_eu_validate.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/intel/compiler/brw_eu_validate.c > b/src/intel/compiler/brw_eu_validate.c > index 9f72c650ddb..07318b9d3c0 100644 > --- a/src/intel/

Re: [Mesa-dev] [PATCH mesa] intel/eu/validate: avoid null deref

2017-10-23 Thread Matt Turner
On Mon, Oct 23, 2017 at 10:08 AM, Eric Engestrom wrote: > src/intel/compiler/brw_eu_validate.c:50:11: warning: argument 1 null where > non-null expected [-Wnonnull] > return memmem(haystack.str, haystack.len, needle.str, needle.len) != NULL; >^~

Re: [Mesa-dev] [PATCH] i965: Fix memmem compiler warnings.

2017-10-23 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] configure: Allow android as an EGL platform

2017-10-23 Thread Eric Engestrom
On Friday, 2017-10-20 15:34:57 -0600, Benjamin Gordon wrote: > I'm working on radeonsi support in the Chrome OS Android container > (ARC++). Mesa in ARC++ uses autotools instead of Android.mk, but all > the necessary EGL bits are there, so the existing check is too strict. > > Signed-off-by: Benj

[Mesa-dev] [PATCH mesa] intel/eu/validate: avoid null deref

2017-10-23 Thread Eric Engestrom
src/intel/compiler/brw_eu_validate.c:50:11: warning: argument 1 null where non-null expected [-Wnonnull] return memmem(haystack.str, haystack.len, needle.str, needle.len) != NULL; ^~ In file included from src/gallium/include/pi

Re: [Mesa-dev] [PATCH 7/9] wayland-drm: static inline wayland_drm_buffer_get

2017-10-23 Thread Emil Velikov
On 23 October 2017 at 16:41, Daniel Stone wrote: > Hi Emil, > > On 28 September 2017 at 13:36, Emil Velikov wrote: >> On 20 September 2017 at 15:06, Daniel Stone wrote: >>> On 19 September 2017 at 11:25, Emil Velikov >>> wrote: It looks a bit icky and my Wayland knowledge is limited to ac

Re: [Mesa-dev] create src/wsi

2017-10-23 Thread Emil Velikov
On 23 October 2017 at 17:05, Nicolai Hähnle wrote: > On 23.10.2017 17:16, Emil Velikov wrote: >> >> On 23 October 2017 at 16:03, Jason Ekstrand wrote: >>> >>> On Mon, Oct 23, 2017 at 6:27 AM, Nicolai Hähnle >>> wrote: On 21.10.2017 03:00, Dylan Baker wrote: > > > This

Re: [Mesa-dev] [PATCH 6/7] glsl/parser: Track built-in types using the glsl_type directly

2017-10-23 Thread Nicolai Hähnle
On 18.10.2017 16:39, Ian Romanick wrote: On 10/17/2017 12:54 PM, Nicolai Hähnle wrote: On 17.10.2017 20:14, Ian Romanick wrote: From: Ian Romanick     text   data    bss    dec    hex    filename 8255243 268856 294072    8818171 868dfb    32-bit i965_dri.so before

Re: [Mesa-dev] [PATCH 5/5] gallium/util: don't call close() on Windows in u_tests.c

2017-10-23 Thread Nicolai Hähnle
For the series: Reviewed-by: Nicolai Hähnle On 17.10.2017 23:17, Brian Paul wrote: --- src/gallium/auxiliary/util/u_tests.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/util/u_tests.c b/src/gallium/auxiliary/util/u_tests.c index 3cc79af..2548b46 100644 --- a/

Re: [Mesa-dev] [PATCH 2/2] ac: Silence a compiler warning about results[0].

2017-10-23 Thread Nicolai Hähnle
Both patches: Reviewed-by: Nicolai Hähnle On 17.10.2017 22:50, Eric Anholt wrote: We know that num_components will be > 0, but it doesn't. --- src/amd/common/ac_nir_to_llvm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.

Re: [Mesa-dev] [PATCH 4/4] radeonsi: postponed KILL isn't postponed anymore, but maintains WQM

2017-10-23 Thread Nicolai Hähnle
I found my peace with the new intrinsic for now. This series is Reviewed-by: Nicolai Hähnle On 14.10.2017 02:58, Marek Olšák wrote: From: Marek Olšák This restores performance for the drirc workaround, i.e. KILL_IF does: visible = src0 >= 0; kill_flag &= visible; // accumulate kills

Re: [Mesa-dev] [PATCH v4 1/2] glsl: allow any l-value of an input variable as interpolant in interpolateAt*

2017-10-23 Thread Nicolai Hähnle
Ping? On 10.10.2017 14:09, Nicolai Hähnle wrote: From: Nicolai Hähnle The intended rule has been clarified in GLSL 4.60, Section 8.13.2 (Interpolation Functions): "For all of the interpolation functions, interpolant must be an l-value from an in declaration; this can include a variab

Re: [Mesa-dev] create src/wsi

2017-10-23 Thread Nicolai Hähnle
On 23.10.2017 17:16, Emil Velikov wrote: On 23 October 2017 at 16:03, Jason Ekstrand wrote: On Mon, Oct 23, 2017 at 6:27 AM, Nicolai Hähnle wrote: On 21.10.2017 03:00, Dylan Baker wrote: This very short series creates a new src/wsi folder, and moves wayland-drm into it. Basically wsi stuff

Re: [Mesa-dev] [ANNOUNCE] mesa 17.3.0-rc1

2017-10-23 Thread Nicolai Hähnle
On 23.10.2017 15:46, Emil Velikov wrote: 1 Nicolai Hähnle 3 Nicolai Hähnle 270 Nicolai Hähnle :( I blame Ubuntu 17.04. Cheers, Nicolai -- Lerne, wie die Welt wirklich ist, Aber vergiss niemals, wie sie sein sollte. ___ mesa-dev m

[Mesa-dev] [PATCH] Haiku: convert to autotools

2017-10-23 Thread Jerome Duval
* configure.ac: -pthread is not available on Haiku. Haiku doesn't require --enable-dri build hgl on Haiku * egl/Makefile.am: define backendfiles for Haiku * src/gallium/Makefile.am: build winsys/sw/hgl, state_trackers/hgl and targets/haiku-softpipe on Haiku. * src/gallium/targets/haiku-softpi

Re: [Mesa-dev] [PATCH V2 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

2017-10-23 Thread Anuj Phogat
Ping. Patches 2-4 in this series are still waiting for review. Anyone interested? Thanks! On Fri, Oct 13, 2017 at 3:35 PM, Rafael Antognolli wrote: > Hi Anuj, sorry that I missed this patch. Please see below. > > On Fri, Oct 06, 2017 at 04:30:47PM -0700, Anuj Phogat wrote: >> There are few othe

Re: [Mesa-dev] [PATCH 7/9] wayland-drm: static inline wayland_drm_buffer_get

2017-10-23 Thread Daniel Stone
Hi Emil, On 28 September 2017 at 13:36, Emil Velikov wrote: > On 20 September 2017 at 15:06, Daniel Stone wrote: >> On 19 September 2017 at 11:25, Emil Velikov wrote: >>> It looks a bit icky and my Wayland knowledge is limited to actually review >>> it. >>> >>> I still think that we're trying

Re: [Mesa-dev] create src/wsi

2017-10-23 Thread Jason Ekstrand
On Mon, Oct 23, 2017 at 8:16 AM, Emil Velikov wrote: > On 23 October 2017 at 16:03, Jason Ekstrand wrote: > > On Mon, Oct 23, 2017 at 6:27 AM, Nicolai Hähnle > wrote: > >> > >> On 21.10.2017 03:00, Dylan Baker wrote: > >>> > >>> This very short series creates a new src/wsi folder, and moves > >

Re: [Mesa-dev] [PATCH v3] egl/wayland: Support for KHR_partial_update

2017-10-23 Thread Emil Velikov
On 23 October 2017 at 11:50, Harish Krupo wrote: > This passes 33/37 deqp tests related to partial_update, 4 are not > supported. Tests not supported: > dEQP-EGL.functional.negative_partial_update.not_postable_surface > dEQP-EGL.functional.negative_partial_update.not_current_surface > dEQP-EGL.fun

Re: [Mesa-dev] create src/wsi

2017-10-23 Thread Emil Velikov
On 23 October 2017 at 16:03, Jason Ekstrand wrote: > On Mon, Oct 23, 2017 at 6:27 AM, Nicolai Hähnle wrote: >> >> On 21.10.2017 03:00, Dylan Baker wrote: >>> >>> This very short series creates a new src/wsi folder, and moves >>> wayland-drm into >>> it. Basically wsi stuff is scattered about, and

Re: [Mesa-dev] create src/wsi

2017-10-23 Thread Jason Ekstrand
On Mon, Oct 23, 2017 at 6:27 AM, Nicolai Hähnle wrote: > On 21.10.2017 03:00, Dylan Baker wrote: > >> This very short series creates a new src/wsi folder, and moves >> wayland-drm into >> it. Basically wsi stuff is scattered about, and is needed by multiple >> components >> within mesa, wayland-d

Re: [Mesa-dev] [PATCH 5/7] u_queue: add a futex-based implementation of fences

2017-10-23 Thread Grazvydas Ignotas
On Mon, Oct 23, 2017 at 4:04 PM, Nicolai Hähnle wrote: > On 23.10.2017 13:50, Grazvydas Ignotas wrote: >> >> On Sun, Oct 22, 2017 at 9:33 PM, Nicolai Hähnle >> wrote: >>> >>> From: Nicolai Hähnle >>> >>> Fences are now 4 bytes instead of 96 bytes (on my 64-bit system). >>> >>> Signaling a fence

Re: [Mesa-dev] [PATCH v2] clover: Fix compilation after clang r315871

2017-10-23 Thread Jan Vesely
On Sun, 2017-10-22 at 20:40 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > From: Jan Vesely > > > > v2: use a more generic compat function > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103388 > > Signed-off-by: Jan Vesely > > --- > > src/gallium/state_trackers/clov

[Mesa-dev] [ANNOUNCE] mesa 17.3.0-rc1

2017-10-23 Thread Emil Velikov
The first release candidate for Mesa 17.3.0 is now available. The plan is to have one release candidate every Friday, until the final release on 11th November 2017. The expectation is that the 17.2 branch will remain alive with bi-weekly releases until the 17.3.1 release. Here are the people whi

Re: [Mesa-dev] create src/wsi

2017-10-23 Thread Nicolai Hähnle
On 21.10.2017 03:00, Dylan Baker wrote: This very short series creates a new src/wsi folder, and moves wayland-drm into it. Basically wsi stuff is scattered about, and is needed by multiple components within mesa, wayland-drm, for example, is used by EGL, GBM, and vulkan wayland-wsi. I think the

Re: [Mesa-dev] [PATCH 7/7] radeonsi: reduce the scope of sel->mutex in si_shader_select_with_key

2017-10-23 Thread Nicolai Hähnle
On 23.10.2017 13:53, Grazvydas Ignotas wrote: On Sun, Oct 22, 2017 at 9:33 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle We only need the lock to guard changes in the variant linked list. The actual compilation can happen outside the lock, since we use the ready fence as a guard. --- src/g

Re: [Mesa-dev] [PATCH 5/7] u_queue: add a futex-based implementation of fences

2017-10-23 Thread Nicolai Hähnle
On 23.10.2017 13:50, Grazvydas Ignotas wrote: On Sun, Oct 22, 2017 at 9:33 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle Fences are now 4 bytes instead of 96 bytes (on my 64-bit system). Signaling a fence is a single atomic operation in the fast case plus a syscall in the slow case. Testin

[Mesa-dev] [PATCH] automake: intel: correctly append to the LIBADD variable

2017-10-23 Thread Emil Velikov
From: Emil Velikov Commit 05fc62d89f5 sets the variable, yet it forgot the update the existing reference to append (instead of assign). Thus as-is the expat library was discarded from the link chain when building with Android. Fixes: 05fc62d89f5 ("automake: intel: move expat handling where it's

Re: [Mesa-dev] [PATCH 3/3] Move src/eg/wayland/wayland-drm into src/wsi

2017-10-23 Thread Daniel Stone
Hi Dylan, I'm not 100% sure how autotools deals with cross-directory dependencies for generated files, but assuming this works, the series is: Reviewed-by: Daniel Stone Thanks for doing this! Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.free

Re: [Mesa-dev] [PATCH 7/7] radeonsi: reduce the scope of sel->mutex in si_shader_select_with_key

2017-10-23 Thread Grazvydas Ignotas
On Sun, Oct 22, 2017 at 9:33 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > We only need the lock to guard changes in the variant linked list. The > actual compilation can happen outside the lock, since we use the ready > fence as a guard. > --- > src/gallium/drivers/radeonsi/si_state_shad

Re: [Mesa-dev] [PATCH 5/7] u_queue: add a futex-based implementation of fences

2017-10-23 Thread Grazvydas Ignotas
On Sun, Oct 22, 2017 at 9:33 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fences are now 4 bytes instead of 96 bytes (on my 64-bit system). > > Signaling a fence is a single atomic operation in the fast case plus a > syscall in the slow case. > > Testing if a fence is signaled is the same

Re: [Mesa-dev] [PATCH 03/25] threads: update for late C11 changes

2017-10-23 Thread Nicolai Hähnle
On 23.10.2017 13:15, Emil Velikov wrote: Hi Nicolai, On 22 October 2017 at 20:07, Nicolai Hähnle wrote: From: Nicolai Hähnle C11 threads were changed to use struct timespec instead of xtime, and thrd_sleep got a second argument. As xtime was replaced with timespec there's a couple of odd b

Re: [Mesa-dev] [PATCH 03/25] threads: update for late C11 changes

2017-10-23 Thread Emil Velikov
Hi Nicolai, On 22 October 2017 at 20:07, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > C11 threads were changed to use struct timespec instead of xtime, and > thrd_sleep got a second argument. > As xtime was replaced with timespec there's a couple of odd bits in the code. > See http://www.o

[Mesa-dev] [PATCH v3] egl/wayland: Support for KHR_partial_update

2017-10-23 Thread Harish Krupo
This passes 33/37 deqp tests related to partial_update, 4 are not supported. Tests not supported: dEQP-EGL.functional.negative_partial_update.not_postable_surface dEQP-EGL.functional.negative_partial_update.not_current_surface dEQP-EGL.functional.negative_partial_update.buffer_preserved dEQP-EGL.fu

[Mesa-dev] [Bug 100202] llvmpipe Windows scons build can't detect Visual Studio 2017 toolchain

2017-10-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100202 Alex Granni changed: What|Removed |Added Resolution|NOTOURBUG |FIXED --- Comment #4 from Alex Granni --

Re: [Mesa-dev] [PATCH v2 00/32] i965 disk shader cache

2017-10-23 Thread Emil Velikov
On 21 October 2017 at 00:28, Jason Ekstrand wrote: > Over-all, I'm very happy with the way this turned out. Good work to all > involved! I made a few comments here and there and a pile on patch 18. > That said, I think they should all be fairly easy to resolve and, should > Emil be willing to ho

Re: [Mesa-dev] [PATCH v2] glsl: fix derived cs variables

2017-10-23 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 10/22/2017 11:37 PM, Ilia Mirkin wrote: There are two issues with the current implementation. First, it relies on the layout(local_size_*) happening in the same shader as the main function, and secondly it doesn't work for variable group sizes. In both cases, th

Re: [Mesa-dev] [PATCH 0/7] u_queue fence patches and a radeonsi fix

2017-10-23 Thread Nicolai Hähnle
On 23.10.2017 11:29, Samuel Pitoiset wrote: Is there a branch somewhere that can be pulled? Thanks I just pushed https://cgit.freedesktop.org/~nh/mesa/log/?h=fences-threads-ddebug, which contains all the patches I sent out yesterday in sequence. Cheers, Nicolai On 10/22/2017 08:33 PM, Ni

[Mesa-dev] [Bug 103412] gallium/wgl: Another fix to context creation without prior SetPixelFormat()

2017-10-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103412 Bug ID: 103412 Summary: gallium/wgl: Another fix to context creation without prior SetPixelFormat() Product: Mesa Version: 17.2 Hardware: Other OS: Windows

[Mesa-dev] [PATCH] radv: Update code pointer correctly if a variant is already created

2017-10-23 Thread Alex Smith
This was the actual cause of GPU hangs fixed by 0fdd531457ec ("radv: Fix pipeline cache locking issues"), since multiple threads would end up trying to create the variants for a single entry. Now that we're locking around the whole of this function, this isn't really necessary (we either create al

Re: [Mesa-dev] [PATCH 0/7] u_queue fence patches and a radeonsi fix

2017-10-23 Thread Samuel Pitoiset
Is there a branch somewhere that can be pulled? Thanks On 10/22/2017 08:33 PM, Nicolai Hähnle wrote: Hi all, Another multi-threading bug I ran into, this time with radeonsi shader fences. Patches 1-5 make util_queue_fence more widely usable, and include an optional futex-based implementation.

Re: [Mesa-dev] [PATCH] radv: Fix pipeline cache locking issues

2017-10-23 Thread Alex Smith
On 21 October 2017 at 02:54, Bas Nieuwenhuizen wrote: > For radv_create_shader_variants_from_pipeline_cache I'm not really > sure why this would cause corruption. Yes we might create the variants > a few times too much, but that should not cause any corruption. > Just had another look and figure

Re: [Mesa-dev] [PATCH] mesa/bufferobj: don't double negate the range

2017-10-23 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 10/23/2017 02:38 AM, Dave Airlie wrote: From: Dave Airlie This fixes a regression I introduced refactoring this code, I managed to invert range twice, I moved the inversion into the common code, but forgot to stop doing it in the callee. Fixes: GL45-CTS.multi_

Re: [Mesa-dev] [PATCH 1/8] mesa: handle OES_texture_half_float formats in _mesa_base_tex_format()

2017-10-23 Thread Tapani Pälli
Maybe combine common items with ARB_texture_float check below? You could introduce something like: if (ctx->Extensions.ARB_texture_float || ctx->Extensions.OES_texture_half_float) { ... } if (ctx->Extensions.ARB_texture_float || ctx->Extensions.OES_texture_float) { ... } On 10/20/2017 11: