Re: [Mesa-dev] [PATCH] radv/formats: add fast clear for 8-bit signed ints.

2017-02-26 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Feb 27, 2017 at 3:15 AM, Dave Airlie wrote: > From: Dave Airlie > > These formats are used by some CTS tests, may as well fill them in. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_formats.c | 16 > 1 file changed, 16 inser

Re: [Mesa-dev] [PATCH] radv: fix depth format in blit2d.

2017-02-26 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Feb 27, 2017 at 8:00 AM, Dave Airlie wrote: > From: Dave Airlie > > For blitting we need to use the depth or stencil format, never > the combined. > > This fixes: > dEQP-VK.texture.shadow.2d.nearest.less_or_equal_d32_sfloat_s8_uint > and a few others. > >

[Mesa-dev] [v2 17/27] i965/gen6/hiz: Add direct buffer size resolver

2017-02-26 Thread Topi Pohjolainen
The apparent hack adding unconditionally two lines into cube maps is taken directly from align_cube(). v2: Apply the cube map hack also for non-mipmapped. But apply it only for cube-map, not for cube-map-array to keep things as they were (use mt->target == GL_TEXTURE_CUBE_MAP instead o

[Mesa-dev] [PATCH] radv: fix depth format in blit2d.

2017-02-26 Thread Dave Airlie
From: Dave Airlie For blitting we need to use the depth or stencil format, never the combined. This fixes: dEQP-VK.texture.shadow.2d.nearest.less_or_equal_d32_sfloat_s8_uint and a few others. Cc: "13.0 17.0" Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_blit2d.c | 7 +-- 1 file

Re: [Mesa-dev] [PATCH mesa] egl/dri3: implement query surface hook

2017-02-26 Thread Tapani Pälli
On 02/24/2017 05:55 PM, Brendan King wrote: Hi, On 20/02/17 07:57, Tapani Pälli wrote: Hi; On 02/17/2017 05:12 PM, Eric Engestrom wrote: From: Brendan King This is a DRI3 version of a change made for DRI2 (4d6d4f939e0af4252e0b, "egl/dri2: implement query surface hook"), that fixed failure

[Mesa-dev] [Bug 99978] rotation causes undefined behavior after updating mesa (radeon, x11, kernel 4.10)

2017-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99978 xaxa...@gmail.com changed: What|Removed |Added CC||xaxa...@gmail.com -- You are receivi

[Mesa-dev] [Bug 99978] rotation causes undefined behavior after updating mesa (radeon, x11, kernel 4.10)

2017-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99978 Bug ID: 99978 Summary: rotation causes undefined behavior after updating mesa (radeon, x11, kernel 4.10) Product: Mesa Version: git Hardware: Other OS: All

[Mesa-dev] [PATCH 4/6] radeon/ac: make ac_shader_binary_config_start() available externally

2017-02-26 Thread Timothy Arceri
The read config functions are different for r600 and radeonsi so we can't just share the one in amd common. So just share this instead. --- src/amd/common/ac_binary.c | 1 - src/amd/common/ac_binary.h | 8 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_bin

Re: [Mesa-dev] [PATCH v2] i965: Implement INTEL_performance_query backend

2017-02-26 Thread Jonathan Gray
On Thu, Feb 16, 2017 at 01:20:37PM +, Robert Bragg wrote: > diff --git a/src/mesa/drivers/dri/i965/brw_performance_query.c > b/src/mesa/drivers/dri/i965/brw_performance_query.c > new file mode 100644 > index 00..f1b6f583bf > --- /dev/null > +++ b/src/mesa/drivers/dri/i965/brw_performan

[Mesa-dev] [PATCH 1/2] radv/winsys: fix freeing imported memory.

2017-02-26 Thread Dave Airlie
From: Andres Rodriguez This bo->fd wasn't setting some stuff correctly that could lead to crashes for anything using this path later. Signed-off-by: Dave Airlie --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/amd/vulkan/winsys/amdgpu/

[Mesa-dev] [PATCH 1/6] radeon/ac: add llvm_ir_string to ac_shader_binary struct

2017-02-26 Thread Timothy Arceri
--- src/amd/common/ac_binary.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/common/ac_binary.h b/src/amd/common/ac_binary.h index 06fd855..df945b2 100644 --- a/src/amd/common/ac_binary.h +++ b/src/amd/common/ac_binary.h @@ -56,20 +56,21 @@ struct ac_shader_binary { /** Lis

Re: [Mesa-dev] [PATCH] mesa: Fix performance query id check

2017-02-26 Thread Manolova, Plamena
Looks good to me :) Reviewed-by: Plamena Manolova On Fri, Feb 24, 2017 at 6:46 PM, Robert Bragg wrote: > In queryid_valid() index is unsigned so checking if it is less > than zero is useless. On queryid_to_index() is comment > saying 0 is reserved to be invalid thus rule it out. > > This is a

[Mesa-dev] [PATCH] radv/formats: add fast clear for 8-bit signed ints.

2017-02-26 Thread Dave Airlie
From: Dave Airlie These formats are used by some CTS tests, may as well fill them in. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_formats.c | 16 1 file changed, 16 insertions(+) diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c index 30a20db..

[Mesa-dev] [PATCH 2/2] radv: Use correct size for availability flag.

2017-02-26 Thread Bas Nieuwenhuizen
Per spec, VK_QUERY_RESULT_64_BIT specifies the integer size and the availability flag is an integer. We apparently handled this correctly already for the copy to buffer case. Signed-off-by: Bas Nieuwenhuizen Cc: 13.0 17.0 --- src/amd/vulkan/radv_query.c | 7 +-- 1 file changed, 5 insertions

[Mesa-dev] [PATCH 1/2] radv: Only use PKT3_OCCLUSION_QUERY when it doesn't hang.

2017-02-26 Thread Bas Nieuwenhuizen
PKT3_OCCLUSION_QUERY hangs when used in a nested IB. This only calls it when in a primary command buffer and we change GetQueryPoolResults to not need it. CmdCopyQueryPoolResults still needs it so we break that behavior for secondary command buffers. However, that would hang already and using an un

[Mesa-dev] [PATCH 1/6] Get rid of trailing whitespace (trivial)

2017-02-26 Thread Constantine Charlamov
From: Hi-Angel Signed-off-by: Constantine Charlamov --- src/gallium/drivers/r600/r600_shader.c | 44 +- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 8cb3f8b2

[Mesa-dev] [PATCH 4/6] Rename tgsi_last_instruction → tgsi_last_channel

2017-02-26 Thread Constantine Charlamov
From: Hi-Angel It's actually iterating through channels, checking whether they're enabled Signed-off-by: Constantine Charlamov --- src/gallium/drivers/r600/r600_shader.c | 56 +- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/src/gallium/drivers

[Mesa-dev] [PATCH 3/6] Replace bit-shifts and cycles with helpers from tgsi_exec.h

2017-02-26 Thread Constantine Charlamov
From: Hi-Angel Changes turned out to be bigger than I expected, so I skipped over every place where I was in doubts. Still, it looks better. Signed-off-by: Constantine Charlamov --- src/gallium/drivers/r600/r600_shader.c | 246 + 1 file changed, 65 insertions(+

[Mesa-dev] [PATCH 2/6] radeon/ac: switch from radeon_shader_binary to ac_shader_binary

2017-02-26 Thread Timothy Arceri
--- src/gallium/drivers/r600/evergreen_compute.c | 4 +- .../drivers/r600/evergreen_compute_internal.h | 2 +- src/gallium/drivers/radeon/r600_pipe_common.c | 4 +- src/gallium/drivers/radeon/r600_pipe_common.h | 43 ++ src/gallium/drivers/radeon/radeon_

[Mesa-dev] [PATCH 5/6] radeon/ac: switch to ac_shader_binary_config_start()

2017-02-26 Thread Timothy Arceri
For radeonsi we could probably switch to ac_shader_binary_read_config(). However the functions have diverged so just share this helper for now. --- src/gallium/drivers/r600/evergreen_compute.c | 3 ++- src/gallium/drivers/radeonsi/si_shader.c | 4 ++-- 2 files changed, 4 insertions(+), 3 delet

[Mesa-dev] [PATCH 6/6] radeon: remove unused radeon_elf_util.{c, h}

2017-02-26 Thread Timothy Arceri
We now use the shared code in AMD common instead. --- src/gallium/drivers/r600/evergreen_compute.c | 1 - src/gallium/drivers/radeon/Android.mk | 1 - src/gallium/drivers/radeon/Makefile.am | 3 - src/gallium/drivers/radeon/Makefile.sources| 4 - src/

Re: [Mesa-dev] [PATCH] doc: GL_ARB_buffer_storage is supported on llvmpipe/swr

2017-02-26 Thread Gregory Hainaut
On 2/25/17, Edward O'Callaghan wrote: > Acked-by: Edward O'Callaghan > > On 02/25/2017 07:45 AM, Gregory Hainaut wrote: >> At least, the extension is exported (gallium capability >> PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT is 1) >> >> Signed-off-by: Gregory Hainaut >> --- >> docs/features.txt |

[Mesa-dev] [PATCH 2/2] radv: add support for NV_dedicated_allocation

2017-02-26 Thread Dave Airlie
From: Dave Airlie This adds initial support for NV_dedicated_allocation, then uses it for the wsi image/memory allocation paths internally in the driver. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 40 +- src/amd/vulkan/radv_entrypoin

[Mesa-dev] [PATCH mesa] docs: fix a few typos

2017-02-26 Thread Eric Engestrom
Noticed a couple, found the rest using vimspell. Signed-off-by: Eric Engestrom --- docs/autoconf.html | 4 ++-- docs/codingstyle.html | 2 +- docs/egl.html | 2 +- docs/envvars.html | 2 +- docs/install.html | 2 +- docs/llvmpipe.html | 2

[Mesa-dev] [PATCH 3/6] radeon/ac: switch from radeon_elf_read() to ac_elf_read()

2017-02-26 Thread Timothy Arceri
--- src/gallium/drivers/r600/evergreen_compute.c| 2 +- src/gallium/drivers/radeonsi/si_compute.c | 3 +-- src/gallium/drivers/radeonsi/si_debug.c | 3 +-- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 2 +- 4 files changed, 4 insertions(+), 6 deletions(-) di

[Mesa-dev] [PATCH] radv/ac: gather4 cube workaround integer

2017-02-26 Thread Dave Airlie
From: Dave Airlie This fix is extracted from amdgpu-pro shader traces. It appears the gather4 workaround for integer types doesn't work for cubes, so instead if forces a float scaled sample, then converts to integer. It modifies the descriptor before calling the gather. This also produces some

[Mesa-dev] [Bug 99959] egl-entrypoint-check fails

2017-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99959 --- Comment #4 from Emil Velikov --- Yes, I was "right" only after I got it wrong - it was me who did suggested sh :-\ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

[Mesa-dev] [PATCH] radv: Reset emitted compute pipeline when calling secondary cmd buffer.

2017-02-26 Thread Bas Nieuwenhuizen
Otherwise if the new compute pipeline is the same as the last used pipeline before the call, we don't emit it again. Signed-off-by: Bas Nieuwenhuizen Cc: 13.0 17.0 --- src/amd/vulkan/radv_cmd_buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd

Re: [Mesa-dev] [PATCH] android: vulkan: add support for libmesa_vulkan_{util, wsi}

2017-02-26 Thread Emil Velikov
Hi Mauro, On 25 February 2017 at 18:31, Mauro Rossi wrote: > The following commits require android porting: > > e9dcb17 "vulkan/util: Add generator for enum_to_str functions" > 8e03250 "vulkan: Combine wsi and util makefiles" > Please add "Fixes: " before each one of these. See commit 5398d006de3

[Mesa-dev] [Bug 99856] OpenCL Hello world returns "unsupported call to function get_local_size"

2017-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99856 --- Comment #16 from Henrique Dante de Almeida --- Weird ! So was this a bug in IR source code ? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.__

Re: [Mesa-dev] [PATCH v3 00/15] cleanup anv_entrpoints_gen.py

2017-02-26 Thread Emil Velikov
On 24 February 2017 at 18:21, Dylan Baker wrote: > There are a number of small style cleanups and simplifications in this series, > but the main changes are: > - use a mako template to generate the header and code rather than prints > - be python 3.x ready (the goal isn't to write python 3 code,

Re: [Mesa-dev] [PATCH] glx/tests: Fix bash-specific code in dispatch-index-check

2017-02-26 Thread Emil Velikov
On 26 February 2017 at 13:51, Eric Engestrom wrote: > On Friday, 2017-02-24 22:03:36 -0600, Aaron Watry wrote: >> Using <<< for variable redirection is bash-specific behavior. >> Ubuntu redirects sh -> dash, so this was erroring out. >> >> Also, the initial error that led me to this was that srcdi

Re: [Mesa-dev] [PATCH] glsl: remove unecessary flags.q.subroutine_def

2017-02-26 Thread Timothy Arceri
On 25/02/17 22:15, Samuel Pitoiset wrote: This bit is definitely not necessary because subroutine_list can be used instead. This frees one more bit in the flags.q struct which is nice because arb_bindless_texture will need 4 bits for the new layout qualifiers. No piglit regressions found (incl

[Mesa-dev] [PATCH 6/6] Remove redudant comparisons

2017-02-26 Thread Constantine Charlamov
From: Hi-Angel Signed-off-by: Constantine Charlamov --- src/gallium/drivers/r600/r600_shader.c | 64 -- 1 file changed, 14 insertions(+), 50 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 3616de57

Re: [Mesa-dev] [PATCH v2] dri: allow 16bit R/GR images to be exported via drm buffers

2017-02-26 Thread Emil Velikov
On 11 January 2017 at 15:43, Ben Widawsky wrote: > On 17-01-05 16:58:56, Rainer Hochecker wrote: >> >> From: Rainer Hochecker >> >> This allows eglCreateImageKHR to access P010 surfaces created by vaapi >> >> Signed-off-by: Rainer Hochecker > > Acked-by: Ben Widawky > There was a request to get

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-26 Thread Jason Ekstrand
On Feb 25, 2017 6:17 PM, "Jacob Lifshay" wrote: Just to double check, is there anything else I need to do to have this patch committed? The only thing I've been waiting for is someone to confirm that they've tested it on a variety of configurations and that it actually does what it claims to do

[Mesa-dev] [PATCH 5/6] Get rid of tgsi_last_channel() wherever possible, rename lasti → last_chan

2017-02-26 Thread Constantine Charlamov
From: Hi-Angel The diff might be confusing: the assignment of last_chan and comparison with last_chan are actually in different cycles. Signed-off-by: Constantine Charlamov --- src/gallium/drivers/r600/r600_shader.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-)

[Mesa-dev] [PATCH 2/6] Rename i→chan_index

2017-02-26 Thread Constantine Charlamov
From: Hi-Angel I might have missed some more opportunities to rename, but oh well. Signed-off-by: Constantine Charlamov --- src/gallium/drivers/r600/r600_shader.c | 590 - 1 file changed, 295 insertions(+), 295 deletions(-) diff --git a/src/gallium/drivers/r600

[Mesa-dev] [PATCH 0/6] r600g: r600_shader.c small cleanups

2017-02-26 Thread Constantine Charlamov
Initially I was trying to implement for r600 optimization like in the d633e23192ef17207f4a6acd3009da3126aab395 commit for radeonsi, but failed because I need to learn some more about GPUs internals. For another time. Anyway, accidentally it turned into a small cleanup of r600_shader.c, here it

Re: [Mesa-dev] [PATCH] radv/ac: enable loop unrolling. (v2)

2017-02-26 Thread Michael Schellenberger Costa
Hi Dave, -Ursprüngliche Nachricht- Von: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] Im Auftrag von Dave Airlie Gesendet: Freitag, 24. Februar 2017 04:59 An: mesa-dev@lists.freedesktop.org Betreff: [Mesa-dev] [PATCH] radv/ac: enable loop unrolling. (v2) From: Dave Airlie Th

Re: [Mesa-dev] [PATCH 8/8] r600/radeonsi: enableglsl/tgsion-diskcache

2017-02-26 Thread Tobias Droste
Mit freundlichen Grüßen Am Freitag, 24. Februar 2017, 11:25:24 CET schrieb Marc Dietrich: > Am Donnerstag, 23. Februar 2017, 11:50:07 CET schrieb Emil Velikov: > > On 23 February 2017 at 10:20, Marc Dietrich wrote: > > > Am Donnerstag, 23. Februar 2017, 10:54:39 CET schrieb Michel Dänzer: > > >>

[Mesa-dev] [Bug 99959] egl-entrypoint-check fails

2017-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99959 Eric Engestrom changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] glx/tests: Fix bash-specific code in dispatch-index-check

2017-02-26 Thread Eric Engestrom
On Friday, 2017-02-24 22:03:36 -0600, Aaron Watry wrote: > Using <<< for variable redirection is bash-specific behavior. > Ubuntu redirects sh -> dash, so this was erroring out. > > Also, the initial error that led me to this was that srcdir is null when > running make check > so I just copied so

[Mesa-dev] [Bug 73777] xf86drm.h:40:17: error: drm.h: No such file or directory

2017-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73777 --- Comment #5 from Joaquín Montero Salinas --- (In reply to Emil Velikov from comment #4) > Joaquín please don't reopen 2+ year old fixed bugs but clearly describe your > issue in a new one. > > In there mention the following - which mesa versi

[Mesa-dev] [Bug 99856] OpenCL Hello world returns "unsupported call to function get_local_size"

2017-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99856 --- Comment #15 from Jan Vesely --- Created attachment 129929 --> https://bugs.freedesktop.org/attachment.cgi?id=129929&action=edit size_t is 32bit in mesa3d building libclc (commit 520743) with this patch applied should produce a working libr

[Mesa-dev] [Bug 73777] xf86drm.h:40:17: error: drm.h: No such file or directory

2017-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73777 Emil Velikov changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 02/24] gallivm, ac: add writeonly and inaccessiblememonly attributes

2017-02-26 Thread Marek Olšák
On Feb 26, 2017 1:09 AM, "Jan Vesely" wrote: On Sun, 2017-02-26 at 00:58 +0100, Marek Olšák wrote: > From: Marek Olšák > > --- > src/amd/common/ac_llvm_util.c | 2 ++ > src/amd/common/ac_llvm_util.h | 2 ++ > src/gallium/auxiliary/gallivm/lp_bld_intr.c | 2 ++ > src/

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

2017-02-26 Thread Kai Wasserbäch
Not from my side. But I can't commit the patch for you. Jason? Jacob Lifshay wrote on 26.02.2017 03:17: > Just to double check, is there anything else I need to do to have this > patch committed? > Jacob Lifshay > > On Feb 19, 2017 02:08, "Kai Wasserbäch" wrote: > >> Jason Ekstrand wrote on 19.