Re: [Mesa-dev] [PATCH] glsl: type check between switch init-expression and case

2014-06-09 Thread Tapani Pälli
On 06/10/2014 08:28 AM, Tapani Pälli wrote: > On 06/09/2014 09:40 PM, Matt Turner wrote: >> On Mon, Jun 9, 2014 at 4:29 AM, Tapani Pälli wrote: >>> Signed-off-by: Tapani Pälli >>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79724 >>> --- >>> src/glsl/ast_to_hir.cpp | 9 + >>>

[Mesa-dev] [Bug 79858] Artifacts/Glitches in Blender menu

2014-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79858 Michel Dänzer changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH 8/8] softpipe: enable AMD_vertex_shader_layer.

2014-06-09 Thread Dave Airlie
From: Dave Airlie This passes tests now on softpipe. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index d22ee27..d

[Mesa-dev] [PATCH 5/8] tgsi_exec: use defines for max inputs/outputs

2014-06-09 Thread Dave Airlie
From: Dave Airlie This fixes the limits for GL 3.2, and subsequently fixes some segfaults in some varying packing tests and max varying tests after the limits bumped. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 6 +++--- src/gallium/auxiliary/tgsi/tgsi_exec.h | 2 +-

[Mesa-dev] [PATCH 7/8] softpipe: enable GLSL 3.30 support.

2014-06-09 Thread Dave Airlie
From: Dave Airlie This enables GL3.3 on softpipe. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index cdbba7d..d22e

[Mesa-dev] [PATCH 3/8] softpipe: add layered rendering support.

2014-06-09 Thread Dave Airlie
From: Dave Airlie This adds support for GL 3.2 layered rendering to softpipe. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_context.h | 3 ++ src/gallium/drivers/softpipe/sp_quad.h | 1 + src/gallium/drivers/softpipe/sp_quad_blend.c | 8 ++--- src

[Mesa-dev] [PATCH 4/8] draw/gs: fix segfault in glsl-1.50-gs-mismatch-prim-type triangles_adjacency

2014-06-09 Thread Dave Airlie
From: Dave Airlie This crashes on softpipe due to a lack of output memory allocated, it appears we allocate memory for enough primtives, but not vertices so convert to number of vertices. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/draw/draw_gs.c | 2 +- 1 file changed, 1 insertion(+

[Mesa-dev] [PATCH 6/8] softpipe: bump the softpipe geometry limits

2014-06-09 Thread Dave Airlie
From: Dave Airlie This just aligns the limits with llvmpipe. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index 78

[Mesa-dev] [PATCH 1/8] softpipe: add depth clamping support.

2014-06-09 Thread Dave Airlie
From: Dave Airlie This passes the piglit depth clamp tests. this is required for GL 3.2. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_quad_depth_test.c | 37 ++- src/gallium/drivers/softpipe/sp_screen.c | 2 +- 2 files changed, 31 insertions(+),

[Mesa-dev] [PATCH 2/8] softpipe: add layering to the surface tile cache.

2014-06-09 Thread Dave Airlie
From: Dave Airlie This adds the layer info to the tile cache. This changes clear_flags to be dynamically allocated as MAX_LAYERS seems like a too big step. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_quad_blend.c | 8 +- src/gallium/drivers/softpipe/sp_quad_depth_te

[Mesa-dev] softpipe GL 3.3 support

2014-06-09 Thread Dave Airlie
Hey, not sure why I bothered but for some reason I took a tangent from ARB_gpu_shader_fp64 into fixing softpipe for GL 3.3 first. This is the results, it also enables AMD_vertex_shader_layer. Some geom shader tests still fail, and I need to do a bit more regression testing, but they seem fine so

Re: [Mesa-dev] [PATCH] glsl: type check between switch init-expression and case

2014-06-09 Thread Tapani Pälli
On 06/09/2014 09:40 PM, Matt Turner wrote: > On Mon, Jun 9, 2014 at 4:29 AM, Tapani Pälli wrote: >> Signed-off-by: Tapani Pälli >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79724 >> --- >> src/glsl/ast_to_hir.cpp | 9 + >> 1 file changed, 9 insertions(+) >> >> diff --git a/s

Re: [Mesa-dev] [PATCH] i965/fs: initialize src as reg_undef for texture opcodes

2014-06-09 Thread Tapani Pälli
On 06/09/2014 05:34 PM, Robert Bragg wrote: > Hey Tapani, > > I came across this issue the other day too and can at least confirm > that I wrote an almost identical patch. > > I was a bit unsure whether this was the best place to fix this issue > since it seems a bit unobvious, in isolation, why we

Re: [Mesa-dev] [PATCH] i965/fs: initialize src as reg_undef for texture opcodes

2014-06-09 Thread Matt Turner
On Mon, Jun 9, 2014 at 2:30 AM, Tapani Pälli wrote: > Commit 07af0ab changed fs_inst to have 0 sources for texture opcodes > in emit_texture_gen5 (Ironlake, Sandybrige) while fs_generator still > uses a single source from brw_reg struct. Patch sets src as reg_undef > which matches the behavior bef

Re: [Mesa-dev] [PATCH 01/11] gallium: Add __DRIimageDriverExtension support to gallium

2014-06-09 Thread Michel Dänzer
On 28.05.2014 18:59, Michel Dänzer wrote: > On 28.05.2014 09:55, Axel Davy wrote: >> From: Keith Packard >> >> Provide the hook to pull textures out of __DRIimage structures and use them >> as >> renderbuffers. >> >> Signed-off-by: Keith Packard > > Enabling DRI3 using this change breaks a numb

[Mesa-dev] [PATCH] configure: Only check for OpenCL without LLVM when the latter is certain

2014-06-09 Thread Michel Dänzer
From: Michel Dänzer LLVM is enabled by default for some architectures, but the test was failing before that. Signed-off-by: Michel Dänzer --- configure.ac | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 7b0009d..0eca945 100644 --- a

[Mesa-dev] [PATCH] glapi: Use GetProcAddress instead of dlsym on Windows.

2014-06-09 Thread Vinson Lee
This patch fixes this MinGW build error. glapi_gentable.c: In function '_glapi_create_table_from_handle': glapi_gentable.c:123:9: error: implicit declaration of function 'dlsym' [-Werror=implicit-function-declaration] *procp = dlsym(handle, symboln); ^ Signed-off-by: Vinson Lee

[Mesa-dev] [PATCH] softpipe: add depth clamping support.

2014-06-09 Thread Dave Airlie
From: Dave Airlie This passes the piglit depth clamp tests. this is required for GL 3.2. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_quad_depth_test.c | 37 ++- src/gallium/drivers/softpipe/sp_screen.c | 2 +- 2 files changed, 31 insertions(+),

Re: [Mesa-dev] [PATCH 5/7] main/extensions: Create extra extensions override string

2014-06-09 Thread Jordan Justen
On Mon, Jun 9, 2014 at 5:50 PM, Ian Romanick wrote: > On 06/08/2014 03:17 PM, Jordan Justen wrote: >> This will allow us to utilize the early MESA_EXTENSION_OVERRIDE >> parsing at the later extension string initialization step. >> >> Signed-off-by: Jordan Justen >> --- >> src/mesa/main/extension

Re: [Mesa-dev] [PATCH 5/7] main/extensions: Create extra extensions override string

2014-06-09 Thread Ian Romanick
On 06/08/2014 03:17 PM, Jordan Justen wrote: > This will allow us to utilize the early MESA_EXTENSION_OVERRIDE > parsing at the later extension string initialization step. > > Signed-off-by: Jordan Justen > --- > src/mesa/main/extensions.c | 38 ++ > 1 file ch

Re: [Mesa-dev] [PATCH] glsl/cs: Fix local_size_y and local_size_z

2014-06-09 Thread Emil Velikov
On 10/06/14 01:46, Jordan Justen wrote: > On Mon, Jun 9, 2014 at 5:29 PM, Emil Velikov wrote: >> On 10/06/14 00:51, Jordan Justen wrote: >>> flags.q.local_size has 3 bits. One each for x, y and z. >>> >>> Fixes piglit's: >>> * spec/ARB_compute_shader/linker/mismatched_local_work_sizes >>> * spec/A

Re: [Mesa-dev] [PATCH 2/2] i965: Invalidate live intervals when inserting Gen4 SEND workarounds.

2014-06-09 Thread Kenneth Graunke
On Monday, June 09, 2014 10:02:38 AM Matt Turner wrote: > On Mon, Jun 9, 2014 at 2:59 AM, Kenneth Graunke wrote: > > We need to invalidate the live intervals when inserting new > > instructions. > > > > Signed-off-by: Kenneth Graunke > > Cc: mesa-sta...@lists.freedesktop.org > > --- > > src/mes

Re: [Mesa-dev] [PATCH] glsl/cs: Fix local_size_y and local_size_z

2014-06-09 Thread Jordan Justen
On Mon, Jun 9, 2014 at 5:29 PM, Emil Velikov wrote: > On 10/06/14 00:51, Jordan Justen wrote: >> flags.q.local_size has 3 bits. One each for x, y and z. >> >> Fixes piglit's: >> * spec/ARB_compute_shader/linker/mismatched_local_work_sizes >> * spec/ARB_compute_shader/compiler/default_local_size.co

[Mesa-dev] [Bug 79852] Mesa-10.2.1/src/gallium/state_trackers/vega/api_params.c:60: possible bad if test ?

2014-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79852 Michel Dänzer changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH] glsl/cs: Fix local_size_y and local_size_z

2014-06-09 Thread Emil Velikov
On 10/06/14 00:51, Jordan Justen wrote: > flags.q.local_size has 3 bits. One each for x, y and z. > > Fixes piglit's: > * spec/ARB_compute_shader/linker/mismatched_local_work_sizes > * spec/ARB_compute_shader/compiler/default_local_size.comp > * spec/ARB_compute_shader/compiler/work_group_size_too

[Mesa-dev] [Bug 79688] [dri3] Latest git breaks PRIME Offloading to Nouveau GPU

2014-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79688 --- Comment #10 from Axel Davy --- Ok, we have discussed on irc and managed to get it working. When ID_PATH_TAG is advertised for /dev/dri/cardX, but not /dev/dri/renderD12X, ones need to add a file containing: SUBSYSTEM=="drm", IMPORT{builtin}

Re: [Mesa-dev] [PATCH] glsl/cs: Fix local_size_y and local_size_z

2014-06-09 Thread Chris Forbes
Reviewed-by: Chris Forbes On Tue, Jun 10, 2014 at 11:51 AM, Jordan Justen wrote: > flags.q.local_size has 3 bits. One each for x, y and z. > > Fixes piglit's: > * spec/ARB_compute_shader/linker/mismatched_local_work_sizes > * spec/ARB_compute_shader/compiler/default_local_size.comp > * spec/ARB_

[Mesa-dev] [PATCH] glsl/cs: Fix local_size_y and local_size_z

2014-06-09 Thread Jordan Justen
flags.q.local_size has 3 bits. One each for x, y and z. Fixes piglit's: * spec/ARB_compute_shader/linker/mismatched_local_work_sizes * spec/ARB_compute_shader/compiler/default_local_size.comp * spec/ARB_compute_shader/compiler/work_group_size_too_large * spec/ARB_compute_shader/compiler/gl_WorkGro

[Mesa-dev] [PATCH] main/cs: Add additional compute shader contant values

2014-06-09 Thread Jordan Justen
This fixes piglit's arb_compute_shader-minmax test. Signed-off-by: Jordan Justen --- src/mesa/main/config.h | 11 +++ src/mesa/main/get_hash_params.py | 7 +++ 2 files changed, 18 insertions(+) diff --git a/src/mesa/main/config.h b/src/mesa/main/config.h index c96502a..4e

Re: [Mesa-dev] [PATCH 1/7] main/extensions: Don't advertise unknown extensions overrides with (-)

2014-06-09 Thread Anuj Phogat
On Sun, Jun 8, 2014 at 3:17 PM, Jordan Justen wrote: > Previously setting: > MESA_EXTENSION_OVERRIDE=-GL_MESA_ham_sandwich > > Would cause Mesa to advertise support for the GL_MESA_ham_sandwich > extension, even though the override specifically asked for it to be > disabled. > > Signed-off-by: Jor

[Mesa-dev] [PATCH 09/11] glsl: Remove unused include from ir_constant_expression.cpp

2014-06-09 Thread thomashelland90
From: Thomas Helland Found with IWYU. Compile-tested on my Ivy-bridge system. Signed-off-by: Thomas Helland --- src/glsl/ir_constant_expression.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/glsl/ir_constant_expression.cpp b/src/glsl/ir_constant_expression.cpp index 8afe8f7..7b4a2

[Mesa-dev] [PATCH 07/11] glsl: Remove unused include from hir_field_selection.cpp

2014-06-09 Thread thomashelland90
From: Thomas Helland Found with IWYU. Compile-tested on my Ivy-bridge system Signed-off-by: Thomas Helland --- src/glsl/hir_field_selection.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/glsl/hir_field_selection.cpp b/src/glsl/hir_field_selection.cpp index 1e92c89..0fa9768 100644 -

[Mesa-dev] [PATCH 10/11] glsl: Remove unused include in ir.cpp

2014-06-09 Thread thomashelland90
From: Thomas Helland Found with IWYU. Compile-tested on my Ivy-bridge system. Signed-off-by: Thomas Helland --- src/glsl/ir.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp index 8fed768..10c0006 100644 --- a/src/glsl/ir.cpp +++ b/src/glsl/ir.cpp @@ -23,

[Mesa-dev] [PATCH 06/11] glsl: Remove unused include from glsl_symbol_table.h

2014-06-09 Thread thomashelland90
From: Thomas Helland Only function-defs use glsl_type so forward declare instead. Compile-tested on my Ivy-bridge system. IWYU also suggests removing #include , and this compiles fine. I'm not familiar enough with memory management in C/C++ that I feel comfortable removing this. Insights would b

[Mesa-dev] [PATCH 11/11] glsl: Remove unused include in expr.flatt.

2014-06-09 Thread thomashelland90
From: Thomas Helland Found with IWYU. Compile-tested on my Ivy-bridge system. Signed-off-by: Thomas Helland --- src/glsl/ir_expression_flattening.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/glsl/ir_expression_flattening.cpp b/src/glsl/ir_expression_flattening.cpp index c1cadb

[Mesa-dev] [PATCH 08/11] glsl: Remove unused include from ir_basic_block.cpp

2014-06-09 Thread thomashelland90
From: Thomas Helland Found with IWYU. Compile-tested on my Ivy-bridge system. Signed-off-by: Thomas Helland --- src/glsl/ir_basic_block.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/glsl/ir_basic_block.cpp b/src/glsl/ir_basic_block.cpp index 426fda2..74ee4b6 100644 --- a/src/gls

[Mesa-dev] [PATCH 04/11] glsl: Remove unused include from builtin_variables.cpp

2014-06-09 Thread thomashelland90
From: Thomas Helland Found with IWYU. Compile-tested on my Ivy-bridge system. Signed-off-by: Thomas Helland --- src/glsl/builtin_variables.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index 9b35850..e22b083 100644 --- a/

[Mesa-dev] [PATCH 00/11] glsl: Remove unused includes found with IWYU

2014-06-09 Thread thomashelland90
From: Thomas Helland This series removes some unused includes in the glsl-directory. These were found with Google's include-what-you-use plugin for clang. Patches have been compile-tested and a quick glxgears-run has been done. I have not done a full piglit-run, let me know if that's wanted. Oh,

[Mesa-dev] [PATCH 03/11] glsl: Remove unused include in ast_to_hir.cpp

2014-06-09 Thread thomashelland90
From: Thomas Helland Found with IWYU. Comment says it's for struct gl_extensions. Grepping for gl_extensions shows no uses. Tested by compiling on my Ivy-bridge system. Signed-off-by: Thomas Helland --- src/glsl/ast_to_hir.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/glsl/ast_to_

[Mesa-dev] [PATCH 02/11] glsl: Remove unused includes in link_uniform_block_active_visitor.h

2014-06-09 Thread thomashelland90
From: Thomas Helland Found with IWYU, compile-tested on my Ivy-bridge system. This is not used in the header, and is included in the source. Signed-off-by: Thomas Helland --- src/glsl/link_uniform_block_active_visitor.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/glsl/link_uniform

[Mesa-dev] [PATCH 05/11] glsl: Remove unused include from glsl_types.cpp

2014-06-09 Thread thomashelland90
From: Thomas Helland Found with IWYU. Compile-tested on my Ivy-bridge system. Added comment about core.h being used for MAX2. Signed-off-by: Thomas Helland --- src/glsl/glsl_types.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl

[Mesa-dev] [PATCH 01/11] glsl: Remove unused includes in link_uniform_init.

2014-06-09 Thread thomashelland90
From: Thomas Helland Found with IWYU, confirmed with grepping for "hash" and "symbol". No negative effects on compilation. IWYU also reported core.h and linker.h could be removed, but I'm unsure if those are false positives. Signed-off-by: Thomas Helland --- src/glsl/link_uniform_initializers

Re: [Mesa-dev] [PATCH 2/2] wglinfo: query and report multisample information

2014-06-09 Thread Jose Fonseca
- Original Message - > On 06/09/2014 11:38 AM, Jose Fonseca wrote: > > > > > > - Original Message - > >> On 06/09/2014 07:22 AM, Jose Fonseca wrote: > >>> I don't think that OpenGL ICD should advertise multi-sample formats via > >>> the > >>> standard DescribePixelFormat. > >>> http

Re: [Mesa-dev] [PATCH 0/2] Build a driswrast-using libGL on non-DRM targets

2014-06-09 Thread Emil Velikov
On 04/06/14 13:36, Jon TURNEY wrote: > On 03/06/2014 17:37, Emil Velikov wrote: >> On 03/06/14 14:14, Jon TURNEY wrote: >>> As a follow-up to my "Fix Apple-DRI GLX" patchset, allow building of a libGL >>> capable of using driswrast on targets without libdrm, and make that the >>> default >>> config

Re: [Mesa-dev] [PATCH] meta: save and restore swizzle for _GenerateMipmap

2014-06-09 Thread Chris Forbes
It would be good to have a piglit test which demonstrates the need for this. Reviewed-by: Chris Forbes On Tue, Jun 10, 2014 at 2:48 AM, Robert Bragg wrote: > This makes sure to use a no-op swizzle while iteratively rendering each > level of a mipmap otherwise we may loose components and effecti

[Mesa-dev] [PATCH 2/3] glsl: Pass in options to do_algebraic().

2014-06-09 Thread Matt Turner
Will be used in the next commit. Reviewed-by: Eric Anholt --- src/glsl/glsl_parser_extras.cpp | 2 +- src/glsl/ir_optimization.h | 3 ++- src/glsl/opt_algebraic.cpp | 11 --- src/glsl/test_optpass.cpp | 2 +- 4 files changed, 12 insertions(+), 6 deletions(-) diff --gi

[Mesa-dev] [PATCH 1/3] glsl: Rebalance expression trees that are reduction operations.

2014-06-09 Thread Matt Turner
The intention of this pass was to give us better instruction scheduling opportunities, but it unexpectedly reduced some instruction counts as well: total instructions in shared programs: 139 -> 1666073 (-0.03%) instructions in affected programs: 54612 -> 54046 (-1.04%) (and trades 4 SIMD16

[Mesa-dev] [PATCH 3/3] glsl: Optimize (v.x + v.y) + (v.z + v.w) into dot(v, 1.0).

2014-06-09 Thread Matt Turner
Cuts five instructions out of SynMark's Gl32VSInstancing benchmark. --- src/glsl/opt_algebraic.cpp | 46 ++ 1 file changed, 46 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index d57c3e8..be65799 100644 --- a/src/gls

Re: [Mesa-dev] [PATCH 2/2] wglinfo: query and report multisample information

2014-06-09 Thread Brian Paul
On 06/09/2014 11:38 AM, Jose Fonseca wrote: - Original Message - On 06/09/2014 07:22 AM, Jose Fonseca wrote: I don't think that OpenGL ICD should advertise multi-sample formats via the standard DescribePixelFormat. http://www.opengl.org/registry/specs/ARB/wgl_pixel_format.txt states:

Re: [Mesa-dev] [PATCH 04/15] glsl: Add preprocessor error condition for #else directive

2014-06-09 Thread Anuj Phogat
On Mon, Jun 9, 2014 at 11:44 AM, Matt Turner wrote: > On Mon, Jun 9, 2014 at 11:40 AM, Anuj Phogat wrote: >> On Fri, Jun 6, 2014 at 9:42 PM, Ian Romanick wrote: >>> I thought Matt already fixed this bug. >> A basic testing shows that below commit fixed the "garbage after #endif" bug >> but "#gar

Re: [Mesa-dev] [PATCH 10/15] mesa: Don't allow snorm internal formats in glCopyTexImage*() in GLES3

2014-06-09 Thread Anuj Phogat
On Fri, Jun 6, 2014 at 5:41 PM, Marek Olšák wrote: > Since this seems to be a GLES-only limitation, the patch should use > _mesa_is_gles3 or _mesa_is_gles. > These changes occur inside a 'if' block testing for gles3 context. > Marek > > On Sat, Jun 7, 2014 at 1:57 AM, Anuj Phogat wrote: >> Fixes

Re: [Mesa-dev] [PATCH] glsl: type check between switch init-expression and case

2014-06-09 Thread Matt Turner
On Mon, Jun 9, 2014 at 4:29 AM, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79724 > --- > src/glsl/ast_to_hir.cpp | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp > i

Re: [Mesa-dev] [PATCH 04/15] glsl: Add preprocessor error condition for #else directive

2014-06-09 Thread Anuj Phogat
On Fri, Jun 6, 2014 at 9:42 PM, Ian Romanick wrote: > I thought Matt already fixed this bug. A basic testing shows that below commit fixed the "garbage after #endif" bug but "#garbage after #else" bug still exists. Absence of tests kept it untested. > > commit 060e69679925f171cfcc2a5f84fab1d833a7

Re: [Mesa-dev] [PATCH 04/15] glsl: Add preprocessor error condition for #else directive

2014-06-09 Thread Matt Turner
On Mon, Jun 9, 2014 at 11:40 AM, Anuj Phogat wrote: > On Fri, Jun 6, 2014 at 9:42 PM, Ian Romanick wrote: >> I thought Matt already fixed this bug. > A basic testing shows that below commit fixed the "garbage after #endif" bug > but "#garbage after #else" bug still exists. Absence of tests kept i

[Mesa-dev] [PATCH v3 5/6] i965/vec4: copy propagate 'NOT' instruction when used with logical operation

2014-06-09 Thread Matt Turner
On Broadwell, this reduces the instruction to a single operation when NOT is used with a logical instruction. Signed-off-by: Abdiel Janulgue --- v3 [mattst88]: Move bits not used by patch 4 into this. src/mesa/drivers/dri/i965/brw_vec4.h | 4 +- .../drivers/dri/i965/brw_vec4_cop

[Mesa-dev] [PATCH v3 3/6] i965/fs: copy propagate 'NOT' instruction when used with logical operation

2014-06-09 Thread Matt Turner
From: Abdiel Janulgue On Broadwell, this reduces the instruction to a single operation when NOT is used with a logical instruction. Signed-off-by: Abdiel Janulgue --- v3 [mattst88]: Move bits not used by patch 2 into this. src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 19 ++

Re: [Mesa-dev] Fix negation source modifer when used with logical instructions on Broadwell (v2)

2014-06-09 Thread Matt Turner
On Thu, Jun 5, 2014 at 11:05 AM, Abdiel Janulgue wrote: > v2 of the fix. > > Abdiel Janulgue (6): > i965/fs: Refactor check for potential copy propagated instructions. > i965/fs: skip copy-propate for logical instructions with negated src > entries > i965/fs: copy propagate 'NOT

Re: [Mesa-dev] [PATCH 2/2] wglinfo: query and report multisample information

2014-06-09 Thread Jose Fonseca
- Original Message - > On 06/09/2014 07:22 AM, Jose Fonseca wrote: > > I don't think that OpenGL ICD should advertise multi-sample formats via the > > standard DescribePixelFormat. > > http://www.opengl.org/registry/specs/ARB/wgl_pixel_format.txt states: > > > > Indices are assigned

Re: [Mesa-dev] [PATCH v2 4/6] i965/vec4: skip copy-propate for logical instructions with negated src entries

2014-06-09 Thread Matt Turner
On Thu, Jun 5, 2014 at 11:05 AM, Abdiel Janulgue wrote: > The negation source modifier on src registers has changed meaning in > Broadwell when > used with logical operations. Don't copy propagate when negate src modifier > is set > and when the destination instruction is a logical op. > > Signe

Re: [Mesa-dev] [PATCH v2 3/6] i965/fs: copy propagate 'NOT' instruction when used with logical operation

2014-06-09 Thread Matt Turner
On Thu, Jun 5, 2014 at 11:05 AM, Abdiel Janulgue wrote: > On Broadwell, this reduces the instruction to a single operation when NOT is > used with > a logical instruction. > > Signed-off-by: Abdiel Janulgue > --- > src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 17 + >

Re: [Mesa-dev] [PATCH v2 2/6] i965/fs: skip copy-propate for logical instructions with negated src entries

2014-06-09 Thread Matt Turner
On Thu, Jun 5, 2014 at 11:05 AM, Abdiel Janulgue wrote: > The negation source modifier on src registers has changed meaning in > Broadwell when > used with logical operations. Don't copy propagate when negate src modifier > is set > and when the destination instruction is a logical op. > > Signe

Re: [Mesa-dev] [PATCH] meta: Label the meta GLSL clear program.

2014-06-09 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] i965: Invalidate live intervals when inserting Gen4 SEND workarounds.

2014-06-09 Thread Matt Turner
On Mon, Jun 9, 2014 at 2:59 AM, Kenneth Graunke wrote: > We need to invalidate the live intervals when inserting new > instructions. > > Signed-off-by: Kenneth Graunke > Cc: mesa-sta...@lists.freedesktop.org > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 6 ++ > 1 file changed, 6 insertions(

Re: [Mesa-dev] [PATCH 1/8] add megadriver_stub_FILES

2014-06-09 Thread Adrian M Negreanu
On Jun 6, 2014 7:56 PM, "Emil Velikov" wrote: > > Hi Adrian, Hi, > I seem to recall seeing this patch although it seems like it never got pushed. > Note sure how the Android development process goes but imho these should be > safe to go in stable. > > Cc: "10.1 10.2" > Reviewed-by: Emil Velikov

[Mesa-dev] [PATCH] i965: Set the fast clear color value for texture surfaces

2014-06-09 Thread Neil Roberts
When a multisampled texture is used for sampling the fast clear color value needs to be programmed into the surface state. This was being left as all zeroes so if the surface was cleared to a value other than black then it wouldn't work properly. This doesn't matter for single-sample textures becau

[Mesa-dev] [Bug 79688] [dri3] Latest git breaks PRIME Offloading to Nouveau GPU

2014-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79688 --- Comment #9 from Tobias Klausmann --- The tag is present for /dev/dri/card0,1 so this may be the best option to use -- You are receiving this mail because: You are the assignee for the bug. ___ mes

Re: [Mesa-dev] [PATCH 2/2] wglinfo: query and report multisample information

2014-06-09 Thread Brian Paul
On 06/09/2014 07:22 AM, Jose Fonseca wrote: I don't think that OpenGL ICD should advertise multi-sample formats via the standard DescribePixelFormat. http://www.opengl.org/registry/specs/ARB/wgl_pixel_format.txt states: Indices are assigned to pixel formats in the following order:

[Mesa-dev] [Bug 54372] GLX_INTEL_swap_event crashes driver when swapping window buffers

2014-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54372 --- Comment #20 from Jesse Barnes --- Ooh I'm going to have to page in the context on this one... but your description does sound correct, and I have no problem with applying the patch to avoid your crashes. I do remember fixing other bugs rela

[Mesa-dev] [PATCH] meta: save and restore swizzle for _GenerateMipmap

2014-06-09 Thread Robert Bragg
This makes sure to use a no-op swizzle while iteratively rendering each level of a mipmap otherwise we may loose components and effectively apply the swizzle twice by the time these levels are sampled. --- src/mesa/drivers/common/meta_generate_mipmap.c | 12 1 file changed, 12 inserti

Re: [Mesa-dev] [PATCH] i965/fs: initialize src as reg_undef for texture opcodes

2014-06-09 Thread Robert Bragg
Hey Tapani, I came across this issue the other day too and can at least confirm that I wrote an almost identical patch. I was a bit unsure whether this was the best place to fix this issue since it seems a bit unobvious, in isolation, why we emit these texture ops with a place holder register, bu

Re: [Mesa-dev] [PATCH 2/2] wglinfo: query and report multisample information

2014-06-09 Thread Jose Fonseca
I don't think that OpenGL ICD should advertise multi-sample formats via the standard DescribePixelFormat. http://www.opengl.org/registry/specs/ARB/wgl_pixel_format.txt states: Indices are assigned to pixel formats in the following order: 1. Accelerated pixel formats that are displayabl

Re: [Mesa-dev] Request for information on Radeon

2014-06-09 Thread Marek Olšák
This is probably one of the most difficult tasks. You'll need to: 1) Add support to Mesa core - new shader stages and the new OpenGL functions and queries (src/mesa/main) 2) Add support to the GLSL compiler (src/glsl) 3) Add support to the Gallium interface and TGSI (src/gallium/include/pipe) an

Re: [Mesa-dev] [PATCH] i965/gen8: Emit color calculator state whenever viewport changes

2014-06-09 Thread Pohjolainen, Topi
On Mon, Jun 09, 2014 at 05:14:38PM +0300, Topi Pohjolainen wrote: > Fixes es3 cts test framebuffer_blit_functionality_scissor_blit.test > on bdw. Viewport changes are tracked by 'brw_cc_vp' which in turn > signals CACHE_NEW_CC_VP that should be tracked by 'brw_cc_unit'. On > gen4 this is the case b

[Mesa-dev] [PATCH] i965/gen8: Emit color calculator state whenever viewport changes

2014-06-09 Thread Topi Pohjolainen
Fixes es3 cts test framebuffer_blit_functionality_scissor_blit.test on bdw. Viewport changes are tracked by 'brw_cc_vp' which in turn signals CACHE_NEW_CC_VP that should be tracked by 'brw_cc_unit'. On gen4 this is the case but not on any newer. For some reason gen5-7 don't suffer from the missing

[Mesa-dev] [Bug 79688] [dri3] Latest git breaks PRIME Offloading to Nouveau GPU

2014-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79688 --- Comment #8 from Axel Davy --- I know ID_PATH_TAG is a rather recent flag. At first it was only computed for /dev/dri/cardX, but with a relatively recent patch (which I believe was merged at the end of last year) it should be computed for /de

[Mesa-dev] [Bug 79688] [dri3] Latest git breaks PRIME Offloading to Nouveau GPU

2014-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79688 --- Comment #7 from Tobias Klausmann --- udevadm info /dev/dri/renderD128 P: /devices/pci:00/:00:02.0/drm/renderD128 N: dri/renderD128 E: DEVNAME=/dev/dri/renderD128 E: DEVPATH=/devices/pci:00/:00:02.0/drm/renderD128 E: DEVTYPE=dr

[Mesa-dev] [Bug 79688] [dri3] Latest git breaks PRIME Offloading to Nouveau GPU

2014-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79688 --- Comment #6 from Axel Davy --- If you have render-nodes, you should have /dev/dri/render12X (X a number) existing. Could you try 'udevadm info' on them ? They should advertise the tag 'ID_PATH_TAG'. If this tag is advertised, could you show

[Mesa-dev] [Bug 79688] [dri3] Latest git breaks PRIME Offloading to Nouveau GPU

2014-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79688 --- Comment #5 from Tobias Klausmann --- Hmm you were right, drm.rnodes=1 was missing but it still fails with a 3.15 kernel. Is there a kernel config i'm missing? :/ -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH] i965/fs: initialize src as reg_undef for texture opcodes

2014-06-09 Thread Pohjolainen, Topi
On Mon, Jun 09, 2014 at 12:30:55PM +0300, Tapani P?lli wrote: > Commit 07af0ab changed fs_inst to have 0 sources for texture opcodes > in emit_texture_gen5 (Ironlake, Sandybrige) while fs_generator still > uses a single source from brw_reg struct. Patch sets src as reg_undef > which matches the beh

[Mesa-dev] [PATCH 2/2] wglinfo: query and report multisample information

2014-06-09 Thread Brian Paul
Before, we always reported zeros in the multisample columns of the format list. Since PIXELFORMATDESCRIPTOR doesn't have fields for multisample, we use a new format_info structure to extend that type. --- src/wgl/wglinfo.c | 145 + 1 file chang

[Mesa-dev] [PATCH 1/2] glinfo_common: fix extension_supported() function

2014-06-09 Thread Brian Paul
The code did not correctly handle super-string handling. For example, if we were searching for "WGL_ARB_pixel_format" but we found "WGL_ARB_pixel_format_float" we'd stop searching and return 0. Now we search past that initial, incorrect match. --- src/xdemos/glinfo_common.c | 22 ++

[Mesa-dev] [PATCH] glsl: type check between switch init-expression and case

2014-06-09 Thread Tapani Pälli
Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79724 --- src/glsl/ast_to_hir.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index d1c77f1..131b25f 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src

[Mesa-dev] [Bug 79688] [dri3] Latest git breaks PRIME Offloading to Nouveau GPU

2014-06-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79688 --- Comment #4 from Axel Davy --- I forgot to precise render-nodes are needed. Did you activate them ? For recent kernels, you need to precise drm.rnodes=1 -- You are receiving this mail because: You are the assignee for the bug. __

[Mesa-dev] [PATCH 1/2] i965: Don't use the head sentinel as an fs_inst in Gen4 workaround code.

2014-06-09 Thread Kenneth Graunke
When walking backwards, we want to stop at the head sentinel, which is where scan_inst->prev->prev == NULL, not scan_inst->prev == NULL. Fixes random crashes, as well as valgrind errors. Signed-off-by: Kenneth Graunke Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/brw_fs.cp

[Mesa-dev] [PATCH 2/2] i965: Invalidate live intervals when inserting Gen4 SEND workarounds.

2014-06-09 Thread Kenneth Graunke
We need to invalidate the live intervals when inserting new instructions. Signed-off-by: Kenneth Graunke Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/brw_fs.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drive

Re: [Mesa-dev] [PATCH] glsl: Validate aux storage qualifier combination with other qualifiers.

2014-06-09 Thread Kenneth Graunke
On Tuesday, June 10, 2014 09:57:51 AM Chris Forbes wrote: > We've been allowing `centroid` and `sample` in all kinds of weird places > where they're not valid. > > Insist that `sample` is combined with `in` or `out`; > and that `centroid` is combined with `in`, `out`, or the deprecated > `varying`

[Mesa-dev] [PATCH v2] Enable GL_ARB_explicit_uniform_location in the drivers.

2014-06-09 Thread Tapani Pälli
v2: enable also for i915 (Ian) Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i915/intel_extensions.c | 1 + src/mesa/drivers/dri/i965/intel_extensions.c | 1 + src/mesa/state_tracker/st_extensions.c | 1 + 3 files changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i915/inte

[Mesa-dev] [PATCH] glsl: Validate aux storage qualifier combination with other qualifiers.

2014-06-09 Thread Chris Forbes
We've been allowing `centroid` and `sample` in all kinds of weird places where they're not valid. Insist that `sample` is combined with `in` or `out`; and that `centroid` is combined with `in`, `out`, or the deprecated `varying`. V2: Validate this in a more sensible place. This does require an ex

Re: [Mesa-dev] [PATCH mesa] add EGL_TEXTURE_EXTERNAL_WL to WL_bind_wayland_display spec

2014-06-09 Thread Pekka Paalanen
On Thu, 16 Aug 2012 17:28:19 -0500 Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > docs/WL_bind_wayland_display.spec |5 + > include/EGL/eglmesaext.h |1 + > 2 files changed, 6 insertions(+) > > diff --git a/docs/WL_bind_wayland_display.spec > b/

Re: [Mesa-dev] [PATCH v2 4/4] i965/fs: Add Gen < 6 runtime checks for line antialiasing.

2014-06-09 Thread Iago Toral
On Mon, 2014-06-09 at 02:31 -0700, Kenneth Graunke wrote: > On Thursday, June 05, 2014 03:03:08 PM Iago Toral Quiroga wrote: > > In Gen < 6 the hardware generates a runtime bit that indicates whether AA > data > > has to be sent as part of the framebuffer write SEND message. This affects > the >

[Mesa-dev] [PATCH] i965/fs: initialize src as reg_undef for texture opcodes

2014-06-09 Thread Tapani Pälli
Commit 07af0ab changed fs_inst to have 0 sources for texture opcodes in emit_texture_gen5 (Ironlake, Sandybrige) while fs_generator still uses a single source from brw_reg struct. Patch sets src as reg_undef which matches the behavior before the constructor got changed. Signed-off-by: Tapani Pälli

Re: [Mesa-dev] [PATCH v2 1/4] i965: Always set a valid block end pointer

2014-06-09 Thread Kenneth Graunke
On Monday, June 09, 2014 11:29:35 AM Iago Toral wrote: > On Mon, 2014-06-09 at 02:22 -0700, Kenneth Graunke wrote: > > On Thursday, June 05, 2014 03:03:05 PM Iago Toral Quiroga wrote: > > > When a instruction stream ends in a block structure (like a IF/ELSE/ENDIF) > > the > > > last block's end p

Re: [Mesa-dev] [PATCH v2 1/4] i965: Always set a valid block end pointer

2014-06-09 Thread Iago Toral
On Mon, 2014-06-09 at 02:22 -0700, Kenneth Graunke wrote: > On Thursday, June 05, 2014 03:03:05 PM Iago Toral Quiroga wrote: > > When a instruction stream ends in a block structure (like a IF/ELSE/ENDIF) > the > > last block's end pointer will not be set, leading to a crash later on in > > fs_live

Re: [Mesa-dev] [PATCH v2 4/4] i965/fs: Add Gen < 6 runtime checks for line antialiasing.

2014-06-09 Thread Kenneth Graunke
On Thursday, June 05, 2014 03:03:08 PM Iago Toral Quiroga wrote: > In Gen < 6 the hardware generates a runtime bit that indicates whether AA data > has to be sent as part of the framebuffer write SEND message. This affects the > specific case where we have setup antialiased line rendering and we

Re: [Mesa-dev] [PATCH v2 1/4] i965: Always set a valid block end pointer

2014-06-09 Thread Kenneth Graunke
On Thursday, June 05, 2014 03:03:05 PM Iago Toral Quiroga wrote: > When a instruction stream ends in a block structure (like a IF/ELSE/ENDIF) the > last block's end pointer will not be set, leading to a crash later on in > fs_live_variables::setup_def_use(). > > If we have not assigned the end po

[Mesa-dev] [PATCH] meta: Label the meta GLSL clear program.

2014-06-09 Thread Kenneth Graunke
Giving the meta clear program a meaningful name makes it easier to find in output such as INTEL_DEBUG=fs or INTEL_DEBUG=shader_time. We already did so for integer programs, but neglected to label the primary program. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/common/meta.c | 1 + 1 fil

Re: [Mesa-dev] [PATCH 11/22] i965/gen7: Configure msaa stencil buffers as single sampled

2014-06-09 Thread Pohjolainen, Topi
On Mon, Jun 09, 2014 at 08:16:57PM +1200, Chris Forbes wrote: > > @@ -465,8 +471,8 @@ gen7_update_renderbuffer_surface(struct brw_context > > *brw, > > bool is_array = false; > > int depth = MAX2(irb->layer_count, 1); > > const uint8_t mocs = GEN7_MOCS_L3; > > - > > - int min_array_e

Re: [Mesa-dev] [PATCH 12/22] i965/gen6: Configure msaa stencil buffers as single sampled

2014-06-09 Thread Chris Forbes
Same concern as in patch 11. On Mon, Jun 9, 2014 at 7:45 PM, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 16 +--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/br

Re: [Mesa-dev] [PATCH 11/22] i965/gen7: Configure msaa stencil buffers as single sampled

2014-06-09 Thread Chris Forbes
> @@ -465,8 +471,8 @@ gen7_update_renderbuffer_surface(struct brw_context *brw, > bool is_array = false; > int depth = MAX2(irb->layer_count, 1); > const uint8_t mocs = GEN7_MOCS_L3; > - > - int min_array_element = irb->mt_layer / MAX2(mt->num_samples, 1); > + const int min_array_el

Re: [Mesa-dev] [PATCH 04/22] i965/fs: Add generator support for fetching texture dimensions

2014-06-09 Thread Pohjolainen, Topi
On Mon, Jun 09, 2014 at 08:04:20PM +1200, Chris Forbes wrote: > If there are going to be three uses of it now (textureSize, > textureQueryLevels, and your internal use), I think your new name is > better (matches the hardware docs). That rename needn't happen in this > series though. I'll try to r

  1   2   >