Re: [Mesa-dev] [PATCH 2/3] i965: Drop bogus F32TO16/F16TO32 instructions on Broadwell - use MOV.

On 01/29/2014 02:36 PM, Kenneth Graunke wrote: > Broadwell removed the F32TO16 and F16TO32 instructions. However, it has > actual support for HF values, so they're actually just MOV. > > Fixes vs-packHalf2x16 and vs-unpackHalf2x16 tests (both the ARB > extension and ES 3.0 variants). > > Signed-

[Mesa-dev] [PATCH] i965: Add missing BRW_NEW_STATE_BASE_ADDRESS to scissor state atom.

The "pointer" value is relative to the base address, so if we change the base address, we'd better re-emit this. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen6_scissor_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/gen6_sc

Re: [Mesa-dev] [PATCH 06/13] mesa: allow buffers mapped with the persistent flag to be used by the GPU

Marek, I think there's an interaction with software primitive restart here. The primitive restart path maps the index buffer (and the indirect buffer, for indirect draws), and relies on these checks to guarantee that's possible. That may not be an issue for your driver, though -- I don't know.

[Mesa-dev] [Bug 74166] piglit CorrectVersion1.V110 regression regression

https://bugs.freedesktop.org/show_bug.cgi?id=74166 Matt Turner changed: What|Removed |Added CC||huax...@intel.com --- Comment #2 from Matt

[Mesa-dev] [Bug 74204] Steam crashes right after upgrading to mesa git driver(oibaf ppa, ubuntu 13.10 64 bit, 3.13 kernel, radeon hd4570)

https://bugs.freedesktop.org/show_bug.cgi?id=74204 --- Comment #3 from Hohahiu --- I'm not sure whether my crashes related to this. But also after today's Mesa upgrade my X server sometimes segfault: [ 6082.060] (EE) [ 6082.060] (EE) Backtrace: [ 6082.060] (EE) 0: /usr/bin/Xorg (xorg_backtra

[Mesa-dev] [Bug 74204] Steam crashes right after upgrading to mesa git driver(oibaf ppa, ubuntu 13.10 64 bit, 3.13 kernel, radeon hd4570)

https://bugs.freedesktop.org/show_bug.cgi?id=74204 --- Comment #2 from Dmitry Avgustis --- Error started occuring after upgrading mesa drivers. Before that I had already all updates installed, including 3.13 kernel. I even played cs:s without any problems. Then I have figured out, that to install

[Mesa-dev] [Bug 74204] Steam crashes right after upgrading to mesa git driver(oibaf ppa, ubuntu 13.10 64 bit, 3.13 kernel, radeon hd4570)

https://bugs.freedesktop.org/show_bug.cgi?id=74204 --- Comment #1 from Michel Dänzer --- Looks like a loader failure. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org ht

[Mesa-dev] [Bug 74204] Steam crashes right after upgrading to mesa git driver(oibaf ppa, ubuntu 13.10 64 bit, 3.13 kernel, radeon hd4570)

https://bugs.freedesktop.org/show_bug.cgi?id=74204 Michel Dänzer changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH] egl/glx: Remove egl_glx driver

egl_gallium also seems to have backends for Wayland, DRM, etc. I guess this should really be in core Mesa though. Marek On Thu, Jan 30, 2014 at 2:39 AM, Matt Turner wrote: > On Wed, Jan 29, 2014 at 4:14 PM, Michel Dänzer wrote: >> On Mit, 2014-01-29 at 12:18 -0800, Matt Turner wrote: >>> On Wed

Re: [Mesa-dev] [PATCH] egl/glx: Remove egl_glx driver

On Wed, Jan 29, 2014 at 4:14 PM, Michel Dänzer wrote: > On Mit, 2014-01-29 at 12:18 -0800, Matt Turner wrote: >> On Wed, Jan 29, 2014 at 9:25 AM, Chad Versace >> wrote: >> > Mesa now has a real, feature-rich EGL implementation on X11 via xcb. >> > Therefore I believe there is no longer a practica

[Mesa-dev] [PATCH] loader: Make drmGetVersion logic conditional on non-pci devices

On systems without libudev, the loader_get_pci_id_for_fd() call will return 0, which will trigger the drmGetVersion logic. Sadly, this logic assumes that the kernel driver name matches the dri driver name, which is not the case on recent intel GPUs (for example i965 dri driver and i915 kernel modul

[Mesa-dev] [PATCH 09/13] r300g, r600g, radeonsi: add support for ARB_buffer_storage

From: Marek Olšák All GTT memory mappings are coherent and therefore can be persistent. --- src/gallium/drivers/r300/r300_screen.c | 1 + src/gallium/drivers/r300/r300_state.c | 5 + src/gallium/drivers/r600/r600_pipe.c| 1 + src/gallium/drivers/radeon/r600_buf

[Mesa-dev] [PATCH 05/13] mesa: add error checks to glMapBufferRange for ARB_buffer_storage

From: Marek Olšák --- src/mesa/main/bufferobj.c | 46 +++--- 1 file changed, 39 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 55184f1..ca0b5dd 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/m

[Mesa-dev] [PATCH 02/13] mesa: add storage flags parameter to Driver.BufferData

From: Marek Olšák It will be used by glBufferStorage. The parameters are chosen according to ARB_buffer_storage. --- src/mesa/drivers/dri/i915/intel_buffer_objects.c| 5 - src/mesa/drivers/dri/i965/intel_buffer_objects.c| 5 - src/mesa/drivers/dri/nouveau/nouveau_bufferobj.c|

[Mesa-dev] [PATCH 06/13] mesa: allow buffers mapped with the persistent flag to be used by the GPU

From: Marek Olšák --- src/mesa/main/api_validate.c | 2 +- src/mesa/main/bufferobj.c | 12 src/mesa/main/bufferobj.h | 8 src/mesa/main/drawpix.c | 4 ++-- src/mesa/main/pbo.c | 4 ++-- src/mesa/main/readpix.c | 2 +- src/mesa/main/texget

[Mesa-dev] [PATCH 08/13] st/mesa: implement ARB_buffer_storage

From: Marek Olšák --- src/mesa/state_tracker/st_cb_bufferobjects.c | 81 +++ src/mesa/state_tracker/st_cb_texturebarrier.c | 17 ++ src/mesa/state_tracker/st_extensions.c| 1 + 3 files changed, 76 insertions(+), 23 deletions(-) diff --git a/src/mesa/state_t

[Mesa-dev] [PATCH 11/13] gallium/upload_mgr: don't unmap buffers if persistent mappings are supported

From: Marek Olšák --- src/gallium/auxiliary/util/u_upload_mgr.c | 65 --- 1 file changed, 51 insertions(+), 14 deletions(-) diff --git a/src/gallium/auxiliary/util/u_upload_mgr.c b/src/gallium/auxiliary/util/u_upload_mgr.c index 7349d00..ccaab27 100644 --- a/src/gal

[Mesa-dev] [PATCH 13/13] docs: update ARB_buffer_storage status

From: Marek Olšák --- docs/GL3.txt| 2 +- docs/relnotes/10.1.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 6d6fe71..04edcef 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -170,7 +170,7 @@ GL 4.4: GLSL 4.4

[Mesa-dev] [PATCH 01/13] mesa: remove unused driver hook BindBuffer

From: Marek Olšák --- src/mesa/main/bufferobj.c | 5 - src/mesa/main/dd.h| 3 --- 2 files changed, 8 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index e305038..802c9e3 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -952,

[Mesa-dev] [PATCH 12/13] gallium/upload_mgr: remove useless variable "size"

From: Marek Olšák --- src/gallium/auxiliary/util/u_upload_mgr.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/util/u_upload_mgr.c b/src/gallium/auxiliary/util/u_upload_mgr.c index ccaab27..80ad5c3 100644 --- a/src/gallium/auxiliary/util/u_u

[Mesa-dev] [PATCH 10/13] gallium: the other drivers don't support ARB_buffer_storage

From: Marek Olšák --- src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/ilo/ilo_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_screen.c | 1 + src/gallium/drivers/nouveau/nv30/nv30_screen.c |

[Mesa-dev] [PATCH 07/13] gallium: add interface for persistent and coherent buffer mappings

From: Marek Olšák Required for ARB_buffer_storage. --- src/gallium/docs/source/context.rst| 22 ++ src/gallium/docs/source/screen.rst | 3 +++ src/gallium/drivers/trace/tr_context.c | 16 src/gallium/include/pipe/p_context.h | 7 ++- src/galli

Re: [Mesa-dev] [PATCH 24/35] meta: Add rectangle textures to the shader-per-sampler-type table

For patches 1-24, Reviewed-by: Brian Paul I have to move onto other tasks for now... -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 04/13] glapi: add ARB_buffer_storage

From: Marek Olšák --- src/mapi/glapi/gen/gl_API.xml | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 193ee37..4a70542 100644 --- a/src/mapi/glapi/gen/gl_API.xml +++ b/src/mapi/glapi/gen/gl_API.xml @@ -848

[Mesa-dev] [PATCH 03/13] mesa: implement glBufferStorage, immutable buffers; add extension enable flag

From: Marek Olšák --- src/mesa/main/bufferobj.c | 98 ++ src/mesa/main/bufferobj.h | 4 ++ src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 2 + 4 files changed, 105 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/ma

[Mesa-dev] [PATCH 00/13] GL_ARB_buffer_storage

This series implements GL_ARB_buffer_storage, which most importantly allows rendering with mapped buffers. There is a new test on the piglit mailing list, which should test all aspects of persistent buffer mappings. I used both the extension specification and the OpenGL 4.4 specification, becau

Re: [Mesa-dev] [PATCH 22/35] meta: Refactor the table of glsl_sampler structures

On Wed, Jan 29, 2014 at 2:53 PM, Ian Romanick wrote: > From: Ian Romanick > > This will allow the same table of shader-per-sampler-type to be used for > paths in meta other than just mipmap generation. This is also the > reason the declarations of the structures was moved towards the top of > t

[Mesa-dev] [PATCH] i965/gs: Fix EndPrimitive on Broadwell.

My earlier patch (i965: Reserve space for "Vertex Count" in GS outputs.) incremented Global Offset for most URB writes to make room for the new "Vertex Count" field, but failed to shift the URB writes used for writing control bits. Confusingly, Global Offset must be incremented by 2 here, rather t

[Mesa-dev] [PATCH 14/25] r600g: emit streamout from dma copy shader

From: Dave Airlie This enables streamout with GS in the mix, from the VS dma shader. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 6 -- src/gallium/drivers/r600/r600_state_common.c | 4 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 13/25] r600g/gs: fix cases where number of gs inputs != number of gs outputs

From: Dave Airlie this fixes a bunch of the geom shader built-in tests --- src/gallium/drivers/r600/r600_shader.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index a3ca43a..93fe851 1006

[Mesa-dev] [PATCH 11/25] r600g: initialise the geom shader loop registers.

From: Dave Airlie As we do for vertex and pixel shaders. ` Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/r600/evergreen_state.c b/src/gallium/drivers/r600/evergreen_state.c index d99f423..75e6

[Mesa-dev] [PATCH 10/25] r600g: emit NOPs at end of shaders in more cases

From: Dave Airlie If the shader has no CF clauses at all emit an nop If the last instruction is an ENDLOOP add a NOP for the LOOP to go to if the last instruction is CALL_FS add a NOP These fix a bunch of hangs in the geometry shader tests. Signed-off-by: Dave Airlie --- src/gallium/drivers/r

[Mesa-dev] [PATCH 15/25] r600g: add primitive input support for gs

From: Dave Airlie only enable prim id if gs uses it Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 6 +- src/gallium/drivers/r600/evergreend.h | 4 src/gallium/drivers/r600/r600_shader.c | 9 + src/gallium/drivers/r600/r600_shader.h |

[Mesa-dev] [PATCH 12/25] r600g: increase array base for exported parameters

From: Dave Airlie Trivial fix to Vadim's code. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index d62267f..a3ca43a 100644 --- a/src/g

[Mesa-dev] [PATCH 08/25] r600g/sb: add MEM_RING support

From: Dave Airlie Although we don't use SB on geom shaders, the VS copy shader will use it so we might as well implement MEM_RING support in sb. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/sb/sb_bc_dump.cpp | 3 +++ src/gallium/drivers/r600/sb/sb_bc_finalize.cpp | 2 +- src/gal

[Mesa-dev] [PATCH 07/25] r600g: don't fail if we can't map VS->GS ring entries

From: Dave Airlie This can happen in normal operation, so don't report an error on it, just continue. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/g

[Mesa-dev] [PATCH 01/25] r600g: split streamout emit code into a separate function

From: Dave Airlie For geometry shaders we need to call this code from a second place. Just move it out for now to keep future patches cleaner. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 213 + 1 file changed, 110 insertions(+), 103

[Mesa-dev] [PATCH 05/25] r600g: add hw register definitions for GS block setup

From: Vadim Girlin Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreend.h | 80 --- src/gallium/drivers/r600/r600d.h | 1 + 2 files changed, 75 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/r600/evergreend.h b/src/gallium/dr

[Mesa-dev] [PATCH 03/25] r600g/bc: add support for indexed memory writes.

From: Dave Airlie It looks like we need these for geom shaders in the future. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/eg_asm.c | 6 -- src/gallium/drivers/r600/r600_asm.c | 9 +++-- src/gallium/drivers/r600/r600_asm.h | 1 + 3 files changed, 12 insertions(+), 4 deleti

[Mesa-dev] [PATCH 09/25] r600g: don't enable SB for geom shaders

From: Dave Airlie SB needs fixes for three GS instructions it seems to raise them outside loops etc despite my best efforts. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/r600/r600_shader.c b/sr

[Mesa-dev] [PATCH 04/25] r600g: defer shader variant selection and depending state updates

From: Vadim Girlin [airlied: fix dropped streamout line - fix for master] Signed-off-by: Vadim Girlin Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/evergreen_state.c | 1 - src/gallium/drivers/r600/r600_state.c| 2 - src/gallium/drivers/r600/r600_state_common.c | 123 +

[Mesa-dev] [PATCH 02/25] r600g: move barrier and end_of_program bits from output to cf struct

From: Vadim Girlin Signed-off-by: Vadim Girlin Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/eg_asm.c | 10 ++ src/gallium/drivers/r600/r600_asm.c| 21 +++-- src/gallium/drivers/r600/r600_asm.h| 4 ++-- src/gallium/drivers/r600/r600_shader.c | 26

[Mesa-dev] r600g - evergreen geometry shader support

This series adds support for geometry shaders to r600g for evergreen and later GPUs. I don't think r600/r700 support is that hard, but I haven't had time to look at it at all, and I expect possible erratum. This passes most of the piglit tests on my BARTS board and doesn't hang the GPU anymore tha

Re: [Mesa-dev] [PATCH 01/35] mesa: Make target_enum_to_index available outside texobj.c

On Wed, Jan 29, 2014 at 2:52 PM, Ian Romanick wrote: > From: Ian Romanick > > The next patch will use this function in another file. > > Signed-off-by: Ian Romanick > --- > src/mesa/main/texobj.c | 6 +++--- > src/mesa/main/texobj.h | 3 +++ > 2 files changed, 6 insertions(+), 3 deletions(-) >

Re: [Mesa-dev] What use do swap interval > 1 and OML_sync_control divisor and remainder have?

[Just for the sake of argument] 2014-01-28 Pekka Paalanen : > Hi Ian and Jason > > On Mon, 27 Jan 2014 12:26:23 -0700 > Ian Romanick wrote: >> There are a number of theoretical uses, but I don't know that we've >> ever seen any in the wild. >> >> One is video playback. You likely want 30fps ther

Re: [Mesa-dev] [PATCH] egl/glx: Remove egl_glx driver

On Mit, 2014-01-29 at 12:18 -0800, Matt Turner wrote: > On Wed, Jan 29, 2014 at 9:25 AM, Chad Versace > wrote: > > Mesa now has a real, feature-rich EGL implementation on X11 via xcb. > > Therefore I believe there is no longer a practical need for the egl_glx > > driver. > > > > Furthermore, egl_g

Re: [Mesa-dev] [PATCH] glcpp: Reject #version after the version has been resolved.

Reviewed-by: Jordan Justen On Wed, Jan 29, 2014 at 12:48 PM, Matt Turner wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74166 > --- > src/glsl/glcpp/glcpp-parse.y | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-

Re: [Mesa-dev] [PATCH 1/2] glcpp: Don't enter lexer's NEWLINE_CATCHUP start state for single-line comments

On Wed, Jan 29, 2014 at 2:20 PM, Carl Worth wrote: > In commit 6005e9cb28 a new start state of NEWLINE_CATCHUP was added to the > lexer. This start state is used whenever the lexer is emitting a NEWLINE token > to emit additional NEWLINE tokens for any newline characters that were skipped > by an

Re: [Mesa-dev] [PATCH 4/7] dri2: Trust our own driver name lookup over the server's.

On Tue, Jan 28, 2014 at 2:13 PM, Ian Romanick wrote: > On 01/28/2014 02:51 PM, Mark Mueller wrote: > > This patch could cause the i965 driver to not load if Mesa was built on > > a system without libudev devel present. For example on Fedora one should > > install systemd-devel before configuring

[Mesa-dev] [PATCH 3/3] i965/fs: Implement FS_OPCODE_[UN]PACK_HALF_2x16_SPLIT[_XY] opcodes.

I'd neglected to port these to Broadwell. Most of this code is copy and pasted from Gen7, but instead of using F32TO16/F16TO32, we just use MOV with HF register types. Fixes fs-packHalf2x16 and fs-unpackHalf2x16 tests (both the ARB extension and ES 3.0 variants). Signed-off-by: Kenneth Graunke

[Mesa-dev] [PATCH 2/3] i965: Drop bogus F32TO16/F16TO32 instructions on Broadwell - use MOV.

Broadwell removed the F32TO16 and F16TO32 instructions. However, it has actual support for HF values, so they're actually just MOV. Fixes vs-packHalf2x16 and vs-unpackHalf2x16 tests (both the ARB extension and ES 3.0 variants). Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen8_

[Mesa-dev] [PATCH 1/3] i965: Fix Gen8+ disassembly of half float subregister numbers.

Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen8_disasm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/gen8_disasm.c b/src/mesa/drivers/dri/i965/gen8_disasm.c index 0ea5e73..387bb71 100644 --- a/src/mesa/drivers/dri/i965/gen8_disasm.c +++ b/src/m

[Mesa-dev] [PATCH 1/3] i965: Create drm_intel_bo_map wrappers with performance warnings.

Mapping a buffer is a common place where we could stall the CPU. In a few places, we've added special code to check whether a buffer is busy and log the stall as a performance warning. Most of these give no indication of the severity of the stall, though, since measuring the time is a small hassl

[Mesa-dev] [PATCH 2/3] i965: Use brw_bo_map() in intel_texsubimage_tiled_memcpy().

This additionally measures the time stalled, while also simplifying the code. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src/mesa/dr

[Mesa-dev] [PATCH 3/3] i965: Use brw_bo_map[_gtt]() in intel_miptree_map_raw().

This moves the intel_batchbuffer_flush before the drm_intel_bo_busy call, so it isn't entirely equivalent, but I think that should be fine. This code is strange anyway; the typical paradigm is to check whether the batch references the buffer, flush it if so, and then check whether it's busy. Sign

Re: [Mesa-dev] [PATCH 1/2] glcpp: Allow integer expression for #line directive.

Carl Worth writes: > Matt Turner writes: >> >> LINE_EXPANDED expression expression NEWLINE > > Yes. Thanks for the catch. I'll expand the testing and follow up with a > new set of patches. Except that that's totally bogus. We can't parse two adjacent expressions with no intervening separator (as

[Mesa-dev] [PATCH 2/2] glcpp: Add "make check" test for comment-parsing bug

This is the innocent-looking but killer test case to verify the bug fixed in the preceding commit. --- src/glsl/glcpp/tests/121-comment-bug-72686.c | 2 ++ src/glsl/glcpp/tests/121-comment-bug-72686.c.expected | 3 +++ 2 files changed, 5 insertions(+) create mode 100644 src/glsl/glcpp/te

[Mesa-dev] [PATCH 1/2] glcpp: Don't enter lexer's NEWLINE_CATCHUP start state for single-line comments

In commit 6005e9cb28 a new start state of NEWLINE_CATCHUP was added to the lexer. This start state is used whenever the lexer is emitting a NEWLINE token to emit additional NEWLINE tokens for any newline characters that were skipped by an immediately preceding multi-line comment. However, that com

[Mesa-dev] [PATCH 33/35] meta: Silence unused parameter warning in _mesa_meta_CopyTexSubImage

From: Ian Romanick drivers/common/meta.c: In function '_mesa_meta_CopyTexSubImage': drivers/common/meta.c:3744:52: warning: unused parameter 'rb' [-Wunused-parameter] Unfortunately, the parameter can't just be removed because it is part of the dd_function_table::CopyTexSubImage interface. Sign

[Mesa-dev] [PATCH 25/35] meta: Improve GLSL version check

From: Ian Romanick We want to use the GLSL 1.30-ish path for OpenGL ES 3.0. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index e7154df..38

[Mesa-dev] [PATCH 07/35] meta: Consistenly use non-Apple VAO functions

From: Ian Romanick For these objects, meta was already using the non-Apple function to delete the objects. Everywhere else in the file uses _mesa_GenVertexArrays and _mesa_BindVertexArrays. Signed-off-by: Ian Romanick Cc: "9.1 9.2 10.0" --- src/mesa/drivers/common/meta.c | 8 1 file

[Mesa-dev] [PATCH 32/35] meta: Silence unused parameter warning in setup_drawpix_texture

From: Ian Romanick drivers/common/meta.c: In function 'setup_drawpix_texture': drivers/common/meta.c:1572:30: warning: unused parameter 'texIntFormat' [-Wunused-parameter] setup_drawpix_texture has never used this paramater. Before the refactor commit 04f8193aa it was used in several locations

[Mesa-dev] [PATCH 19/35] meta: Use common routine to configure fixed-function TNL state

From: Ian Romanick Also... glOrtho(-1.0, 1.0, -1.0, 1.0, -1.0, 1.0) *is* the identity matrix, so drop the unnecessary call to _mesa_Ortho. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 31 --- 1 file changed, 8 insertions(+), 23 deletions(-) diff

[Mesa-dev] [PATCH 20/35] meta: Add storage to the vertex structure for R, G, B, and A

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index d4987ca..2f87d0d 100644 --- a/src/mesa/drivers/common/meta.

[Mesa-dev] [PATCH 09/35] meta: Don't use fixed-function to decompress array textures

From: Ian Romanick Array textures can't be used with fixed-function, so don't. Instead, just drop the decompress request on the floor. This is no worse than what was done previously because generating the GL error (in _mesa_set_enable) broke everything anyway. A later patch will get GL_TEXTURE

[Mesa-dev] [PATCH 29/35] meta: Get the correct info log

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 9e82132..6723263 100644 --- a/src/mesa/drivers/common/meta.c +++ b/src/mesa

[Mesa-dev] [PATCH 35/35] mesa: GL_ARB_half_float_pixel is not optional

From: Ian Romanick Almost every driver already supported it. All current and future Gallium drivers always support it, and most existing classic drivers support it. This only changes radeon and nouveau. This extension only adds data types that can be passed to, for example, glTexImage2D. It d

[Mesa-dev] [PATCH 14/35] meta: Expand the vertex structure for the DrawPixels paths

From: Ian Romanick Another step leading to some code sharing. Note that the new DrawPixels vertex structure is the same as the new vertex structure in BlitFramebuffer and the others. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 23 +-- 1 file changed, 1

[Mesa-dev] [PATCH 08/35] meta: Use NDC in decompress_texture_image

From: Ian Romanick There is no need to use pixel coordinates, and using NDC directly will simplify the GLSL paths. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/common/meta.c

[Mesa-dev] [PATCH 17/35] meta: Refactor common VAO and VBO initialization code

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 309 + 1 file changed, 97 insertions(+), 212 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 6718680..3661173 100644 --- a

[Mesa-dev] [PATCH 12/35] meta: Expand the vertex structure for the CopyPixels paths

From: Ian Romanick Another step leading to some code sharing. Note that the new CopyPixels vertex structure is the same as the new BlitFramebuffer vertex structure. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 23 +-- 1 file changed, 13 insertions(+), 1

[Mesa-dev] [PATCH 24/35] meta: Add rectangle textures to the shader-per-sampler-type table

From: Ian Romanick Rectangle textures were not necessary for mipmap generation (because they cannot have mipmaps), but all of the future users of this common code will need to support rectangle textures. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 8 1 file change

[Mesa-dev] [PATCH 10/35] meta: Silence several 'unused parameter' warnings

From: Ian Romanick Silences many GCC warnings of the form: drivers/common/meta.c: In function 'cleanup_temp_texture': drivers/common/meta.c:1208:41: warning: unused parameter 'ctx' [-Wunused-parameter] drivers/common/meta.c: In function 'setup_ff_blit_framebuffer': drivers/common/meta.c:1453:46

[Mesa-dev] [PATCH 04/35] meta: Release resources used by decompress_texture_image

From: Ian Romanick decompress_texture_image creates an FBO, an RBO, a VBO, a VAO, and a sampler object, but none of them are ever released. Later patches will add program objects, exacerbating the problem. Leaking piles of memory is generally frowned upon. Signed-off-by: Ian Romanick Cc: "9.1

[Mesa-dev] [PATCH 22/35] meta: Refactor the table of glsl_sampler structures

From: Ian Romanick This will allow the same table of shader-per-sampler-type to be used for paths in meta other than just mipmap generation. This is also the reason the declarations of the structures was moved towards the top of the file. Signed-off-by: Ian Romanick --- src/mesa/drivers/commo

[Mesa-dev] [PATCH 28/35] meta: Expand texture coordinate from vec3 to vec4

From: Ian Romanick This will be necessary to support cubemap array textures because they use all four components. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b

[Mesa-dev] [PATCH 30/35] meta: Add cubemap array support to generic blit shader code

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 6723263..500311d 100644 --- a/src/mesa/drivers/common/meta.c +++ b/src/mesa/d

[Mesa-dev] [PATCH 16/35] meta: Track the _mesa_meta_DrawPixels VBO just like the others

From: Ian Romanick All of the other meta routines have a particular pattern for creating and tracking the VAO and VBO. This one function deviated from that pattern for no apparent reason. Almost all of the code added in this patch will be removed shortly. Signed-off-by: Ian Romanick --- src/

[Mesa-dev] [PATCH 23/35] meta: Refactor shader generation code out of mipmap generation path

From: Ian Romanick This is quite like code we want for blits. Pull it out so that it can be shared by other paths. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 169 ++--- 1 file changed, 91 insertions(+), 78 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH 13/35] meta: Expand the vertex structure for the Clear paths

From: Ian Romanick Another step leading to some code sharing. Note that the new Clear vertex structure is the same as the new BlitFramebuffer and CopyPixels vertex structure. The "sizeof(float) * 7" hack is temporary. It will magically disappear in a just a couple more patches. Signed-off-by:

[Mesa-dev] [PATCH 34/35] mesa: Fix extension dependency for half-float TexBOs

From: Ian Romanick Half-float TexBOs should require both GL_ARB_half_float_pixel and GL_ARB_texture_float. This doesn't matter much in practice. Every driver that supports GL_ARB_texture_buffer_object already supports GL_ARB_half_float_pixel. We only expose the TexBO extension in core profiles

[Mesa-dev] [PATCH 03/35] !UPSTREAM: Disable non-meta paths

From: Ian Romanick This is a temporary commit so that i965 will hit the paths in meta that are modified by later patches in this series. --- src/mesa/drivers/dri/i965/brw_clear.c| 3 ++- src/mesa/drivers/dri/i965/intel_fbo.c| 3 +++ src/mesa/drivers/dri/i965/intel_pixel_copy.c |

[Mesa-dev] [PATCH 11/35] meta: Expand the vertex structure for the BlitFramebuffer paths

From: Ian Romanick This is the first of several steps leading to some code sharing. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 66 +++--- 1 file changed, 36 insertions(+), 30 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/s

[Mesa-dev] [PATCH 15/35] meta: Expand the vertex structure for the GenerateMipmap and decompress paths

From: Ian Romanick Final intermediate step leading to some code sharing. Note that the new GemerateMipmap and decompress vertex structures are the same as the new vertex structure in BlitFramebuffer and the others. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 29 ++

[Mesa-dev] [PATCH 26/35] meta: Use common GLSL code for blits

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 108 + 1 file changed, 13 insertions(+), 95 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 380ee32..363b1ac 100644 --- a/

[Mesa-dev] [PATCH 06/35] meta: Fallback to software for GetTexImage of compressed GL_TEXTURE_CUBE_MAP_ARRAY

From: Ian Romanick The hardware decompression path isn't even close to being able to handle this. This converts the crash (assertion failure) in "EXT_texture_compression_s3tc/getteximage-targets S3TC CUBE_ARRAY" to a plain old failure. Signed-off-by: Ian Romanick Cc: "9.1 9.2 10.0" --- src/m

[Mesa-dev] [PATCH 05/35] meta: Release resources used by _mesa_meta_DrawPixels

From: Ian Romanick _mesa_meta_DrawPixels creates a VAO and (potentially) two fragment programs, but none of them are ever released. Leaking piles of memory is generally frowned upon. Signed-off-by: Ian Romanick Cc: "9.1 9.2 10.0" --- src/mesa/drivers/common/meta.c | 19 +++ 1

[Mesa-dev] [PATCH 31/35] meta: Enable cubemap array texture support to decompress_texture_image

From: Ian Romanick Fixed piglit test getteximage-targets S3TC CUBE_ARRAY on systems that don't have libtxc_dxtn installed. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/common/

[Mesa-dev] [PATCH 21/35] meta: Use common vertex setup code for _mesa_meta_Bitmap too

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 48 +++--- 1 file changed, 12 insertions(+), 36 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 2f87d0d..a987fd7 100644 --- a/

[Mesa-dev] [PATCH 27/35] meta: Use GLSL to decompress 2D-array textures

From: Ian Romanick Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72582 --- src/mesa/drivers/common/meta.c | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drive

[Mesa-dev] [PATCH 02/35] mesa: Use common _mesa_target_enum_to_index in tex param code

From: Ian Romanick TEXTURE_BUFFER_INDEX has to be specially called out because it is not allowed in any of the glTexParameter or glGetTexParameter functions. Signed-off-by: Ian Romanick --- src/mesa/main/texparam.c | 66 ++-- 1 file changed, 8 insert

[Mesa-dev] [PATCH 18/35] meta: Clean up stray binding calls

From: Ian Romanick Clean up a few stray calls to _mesa_BindVertexArray and _mesa_BindBuffer that are no longer necessary after the previous refactor. Note: This should get squashed in with the previous commit when the series is pushed. --- src/mesa/drivers/common/meta.c | 21 ---

[Mesa-dev] [PATCH 01/35] mesa: Make target_enum_to_index available outside texobj.c

From: Ian Romanick The next patch will use this function in another file. Signed-off-by: Ian Romanick --- src/mesa/main/texobj.c | 6 +++--- src/mesa/main/texobj.h | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 24ff

[Mesa-dev] [Bug 74166] piglit CorrectVersion1.V110 regression regression

https://bugs.freedesktop.org/show_bug.cgi?id=74166 Matt Turner changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |matts...@gmail.com |org

Re: [Mesa-dev] [PATCH 8/8] configure: cleanup libudev handling

On Wed, Jan 29, 2014 at 3:23 PM, Emil Velikov wrote: > Add the explicit note about the required version during configure. > Require the same version (151) of udev when building the pipe-loader. > Mention the udev version requirement in GBM Requires.private. > > Signed-off-by: Emil Velikov > --- >

[Mesa-dev] [PATCH] glcpp: Reject #version after the version has been resolved.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74166 --- src/glsl/glcpp/glcpp-parse.y | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index 17bc649..4dba051 100644 --- a/src/glsl/glcpp/glcpp-parse.y +++ b/src/glsl/glcpp/

Re: [Mesa-dev] [PATCH 8/8] configure: cleanup libudev handling

On 29/01/14 20:25, Ilia Mirkin wrote: > On Wed, Jan 29, 2014 at 3:23 PM, Emil Velikov > wrote: >> Add the explicit note about the required version during configure. >> Require the same version (151) of udev when building the pipe-loader. >> Mention the udev version requirement in GBM Requires.pri

Re: [Mesa-dev] [PATCH 8/8] configure: cleanup libudev handling

On Wed, Jan 29, 2014 at 3:23 PM, Emil Velikov wrote: > Add the explicit note about the required version during configure. > Require the same version (151) of udev when building the pipe-loader. > Mention the udev version requirement in GBM Requires.private. > > Signed-off-by: Emil Velikov > --- >

[Mesa-dev] [PATCH 2/8] configure: drop LIBUDEV_CFLAGS from X11_INCLUDES

The cflags are explicitly included in the only Makefile that handles udev dependant code. Signed-off-by: Emil Velikov --- configure.ac | 5 - 1 file changed, 5 deletions(-) diff --git a/configure.ac b/configure.ac index ba158e8..994b3b2 100644 --- a/configure.ac +++ b/configure.ac @@ -856,1

[Mesa-dev] [PATCH 5/8] gallium/tests: do not link against libudev

Previously the linking was required due to dependency of udev in the pipe-loader. Now this is no longer the case, as we dlopen the library. Signed-off-by: Emil Velikov --- src/gallium/tests/trivial/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/tests/trivial/Makefile.

  1   2   >