[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-20 Thread via lldb-commits
jimingham wrote: The way interruption works in lldb is that the first time you dispatch an interrupt, it just raises the "voluntary interrupt" flag. Turns out the process attach part of lldb isn't written in a way that makes checking for the interrupt flag possible, so that doesn't work. The

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-20 Thread via lldb-commits
jimingham wrote: The way the test works, we run one real process and let it exit. Then we do "attach -w -n noone_would_use_this_name" because we don't want the second attach attempt to be able to succeed. lldb should just stay stuck till the interrupt succeeds, there shouldn't be anything ot

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-20 Thread via lldb-commits
jimingham wrote: You are right, there is a racy bit here - I was also getting ~one fails per 50 runs. The raciness is due to the time it takes between when we send the interrupt and when we finish up the command and produce the results. So we can end up reading from the command output befo

[Lldb-commits] [lldb] [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (PR #66949)

2023-09-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes `std::basic_string` is not a regex, and treating it as such could unintentionally cause a formatter to substring match a template type parameter, for example: `std::vector>`. Differential Revision: https://revi

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-20 Thread via lldb-commits
jimingham wrote: Interesting... I split the end stage of the test up into: (a) wait for up to 20 seconds the state to switch to eStateExited (b) wait another second, then check the command output file On macOS, as I said, that seemed to make the test quite robust, but when I checked the test

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-20 Thread via lldb-commits
jimingham wrote: > On Sep 20, 2023, at 1:39 PM, Jim Ingham ***@***.***> wrote: > > Interesting... I split the end stage of the test up into: > > (a) wait for up to 20 seconds the state to switch to eStateExited > (b) wait another second, then check the command output file > > On macOS, as I

[Lldb-commits] [lldb] [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (PR #66949)

2023-09-20 Thread via lldb-commits
jimingham wrote: In this case, it's clearly not a regex, so this change is fine. But ALSO, any regex matches against std types should be `^std::whatever` and not just `std::whatever` to avoid this sort of unintended matching. Jim > On Sep 20, 2023, at 1:37 PM, Walter Erquinigo ***@***.***>

[Lldb-commits] [lldb] 56b148a - [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (#66949)

2023-09-20 Thread via lldb-commits
Author: Dave Lee Date: 2023-09-20T14:24:04-07:00 New Revision: 56b148aa8d6fcc61f0619d74cf5edca4d842 URL: https://github.com/llvm/llvm-project/commit/56b148aa8d6fcc61f0619d74cf5edca4d842 DIFF: https://github.com/llvm/llvm-project/commit/56b148aa8d6fcc61f0619d74cf5edca4d842.diff LOG:

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-20 Thread via lldb-commits
jimingham wrote: N_SO is the stab moniker for a source file, and N_OSO is the object file associated with that source file (N_SO was in Sun's implementation, we made up N_OSO). Most nm''s leave off the N_ when they print stabs, so then this became just OSO... We don't do DWO on Darwin, and n

[Lldb-commits] [lldb] [libc++] Implement ranges::contains (PR #65148)

2023-09-20 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148 >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/11] [libc++] Implement ranges::contains Differential Revision

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-20 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH] [libc++] Implement ranges::contains_subrange --- libcxx/inclu

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-20 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH] [libc++] Implement ranges::contains_subrange --- libcxx/inclu

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-20 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH 1/2] [libc++] Implement ranges::contains_subrange --- libcxx/i

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes ## Description This pull request adds a new `start` command to LLDB, allowing users to launch a process and pause execution at either the `main` function or the first instruction. ## Motivation The `start` command provides a convenient way

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-21 Thread via lldb-commits
https://github.com/jimingham requested changes to this pull request. Half of this command is just `process launch --stop-at-entry`. If you wanted to can the "break at main" part, then add a --stop-at-main to process launch. And if you want a "start" command, the lldb way to do that would be t

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-21 Thread via lldb-commits
jimingham wrote: Even if this were enough behavior to warrant a new command, it would live under the `process launch` node, not as a top level command. We try not to make lots of top level commands so as to leave plenty of namespace in the easy access commands for user customization. https:/

[Lldb-commits] [lldb] [lldb][NFCI] Change parameter type in UserExpression::GetObjectPointer (PR #67055)

2023-09-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes GetObjectPointer (and other related methods) do not need `ConstString` parameters. The string parameter in these methods boil down to getting a StringRef and calling `StackFrame::GetValueForVariableExpressionPath` which takes a `StringRef`

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-21 Thread via lldb-commits
https://github.com/ZijunZhaoCCK ready_for_review https://github.com/llvm/llvm-project/pull/66963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Lazy deference underlying object for shared/weak/unique_ptr synthetic… (PR #67069)

2023-09-21 Thread via lldb-commits
https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/67069 We noticed some performance issue while in lldb-vscode for grabing the name of the SBValue. Profiling shows SBValue::GetName() can cause synthetic children provider of shared/unique_ptr to deference underly

[Lldb-commits] [lldb] Lazy deference underlying object for shared/weak/unique_ptr synthetic… (PR #67069)

2023-09-21 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes We noticed some performance issue while in lldb-vscode for grabing the name of the SBValue. Profiling shows SBValue::GetName() can cause synthetic children provider of shared/unique_ptr to deference underlying object and complete it type.

[Lldb-commits] [lldb] 9faf8b5 - Lazy deference underlying object for shared/weak/unique_ptr synthetic… (#67069)

2023-09-21 Thread via lldb-commits
Author: jeffreytan81 Date: 2023-09-21T15:45:42-07:00 New Revision: 9faf8b5117758cc6f117465fc6ce995a30864ae7 URL: https://github.com/llvm/llvm-project/commit/9faf8b5117758cc6f117465fc6ce995a30864ae7 DIFF: https://github.com/llvm/llvm-project/commit/9faf8b5117758cc6f117465fc6ce995a30864ae7.diff

[Lldb-commits] [lldb] Lazy deference underlying object for shared/weak/unique_ptr synthetic… (PR #67069)

2023-09-21 Thread via lldb-commits
https://github.com/jeffreytan81 closed https://github.com/llvm/llvm-project/pull/67069 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Lazy deference underlying object for shared/weak/unique_ptr synthetic… (PR #67069)

2023-09-21 Thread via lldb-commits
jimingham wrote: Supposedly, Update returns true or false based on whether the update succeeds. If we took that seriously, then it would be worrisome that you move one of the possible failure modes from Update to GetChildAtIndex. But both these functions return false no matter what happens,

[Lldb-commits] [lldb] Lazy deference underlying object for shared/weak/unique_ptr synthetic… (PR #67069)

2023-09-21 Thread via lldb-commits
jimingham wrote: How right you are. I was thinking this was the ValueObject updated stuff, but it's the SyntheticChildrenFrontEnd::Update. If I'm reading the code in ValueObjectSyntheticFilter.cpp aright, the return for that actually means the opposite of what you remembered. If you retur

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread via lldb-commits
https://github.com/aokblast created https://github.com/llvm/llvm-project/pull/67106 This commit is moved from [llvm-phabricator](https://reviews.llvm.org/D159076). The implemtation support parsing kernel module for FreeBSD Kernel and has been test on x86-64 and arm64. In summary, this class par

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3f78d6ab146874d20144f9f5fcbb894931279c7d dc15a7dc299e36930fa52405a4137c184e252305 --

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes This commit is moved from [llvm-phabricator](https://reviews.llvm.org/D159076). The implemtation support parsing kernel module for FreeBSD Kernel and has been test on x86-64 and arm64. In summary, this class parse the linked list resides in

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread via lldb-commits
https://github.com/aokblast updated https://github.com/llvm/llvm-project/pull/67106 >From f8ed3ed64be0a451542a4ec71f254dc9038b2d19 Mon Sep 17 00:00:00 2001 From: aokblast Date: Fri, 22 Sep 2023 18:11:07 +0800 Subject: [PATCH 1/2] feat: add DynamicLoaderFreeBSDKernel --- .../Plugins/DynamicLoa

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread via lldb-commits
https://github.com/aokblast updated https://github.com/llvm/llvm-project/pull/67106 >From f8ed3ed64be0a451542a4ec71f254dc9038b2d19 Mon Sep 17 00:00:00 2001 From: aokblast Date: Fri, 22 Sep 2023 18:11:07 +0800 Subject: [PATCH 1/2] feat: add DynamicLoaderFreeBSDKernel --- .../Plugins/DynamicLoa

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread via lldb-commits
https://github.com/aokblast updated https://github.com/llvm/llvm-project/pull/67106 >From f8ed3ed64be0a451542a4ec71f254dc9038b2d19 Mon Sep 17 00:00:00 2001 From: aokblast Date: Fri, 22 Sep 2023 18:11:07 +0800 Subject: [PATCH 1/2] feat: add DynamicLoaderFreeBSDKernel --- .../Plugins/DynamicLoa

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread via lldb-commits
https://github.com/aokblast updated https://github.com/llvm/llvm-project/pull/67106 >From f8ed3ed64be0a451542a4ec71f254dc9038b2d19 Mon Sep 17 00:00:00 2001 From: aokblast Date: Fri, 22 Sep 2023 18:11:07 +0800 Subject: [PATCH 1/2] feat: add DynamicLoaderFreeBSDKernel --- .../Plugins/DynamicLoa

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes Prior to this the command would simply crash when run on a running process. Of the three register commands, "info" was the only one missing these requirements. On some level it makes sense because you're not going to read a value or modify

[Lldb-commits] [lldb] [cmake] Add LLVM_FORCE_VC_REVISION option (PR #67125)

2023-09-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes This patch adds a LLVM_FORCE_VC_REVISION option to force a custom VC revision to be included instead of trying to fetch one from a git command. This is helpful in environments where git is not available or is non-functional but the vc revisi

[Lldb-commits] [lldb] bb01fd5 - [lldb] Require paused process and frame for "register info" command (#67124)

2023-09-22 Thread via lldb-commits
Author: David Spickett Date: 2023-09-22T15:55:27+01:00 New Revision: bb01fd57bcaec533cd08b4d107979511d893f5b3 URL: https://github.com/llvm/llvm-project/commit/bb01fd57bcaec533cd08b4d107979511d893f5b3 DIFF: https://github.com/llvm/llvm-project/commit/bb01fd57bcaec533cd08b4d107979511d893f5b3.diff

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread via lldb-commits
jimingham wrote: process attach --continue won't return till the process stops when in sync mode. That's really what sync mode means: "commands that continue the target don't return till the target stops". But if the process is hitting a breakpoint or exiting and we aren't exiting the `proc

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: https://github.com/jimingham commented: The reason that gdb has a "start" command is that not all languages and their runtimes use the same name for the the entry point function. So `start` does "figure out what the start function in the m

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: jimingham wrote: I can't tell how to read the "Files Changed" part of the GitHub PR change. It looks like the --stop-at-main is additive, but to be clear, the second of these two commits looks okay to me, but the first commit is still not

[Lldb-commits] [lldb] Lazy deference underlying object for shared/weak/unique_ptr synthetic… (PR #67069)

2023-09-22 Thread via lldb-commits
jimingham wrote: The comment in front of the `SyntheticChildProviderFrontEnd::Update` is actually pretty clear about what it does, the problem is that it isn't really obvious from the comment when discarding the cached children would be a good or bad idea. I'm not sure you could express that

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: jimingham wrote: The other improvement I'd suggest here is that the breakpoints you set to implement the "stop at main" behavior need to be be "one-shot" breakpoints. Otherwise, if you do: (lldb) process launch --stop-at-main ... the proc

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

2023-09-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes This prevents undefined vtable errors when linking these libraries from out-of-tree. I'm facing this issue as I work on my new language plugin. --- Full diff: https://github.com/llvm/llvm-project/pull/67165.diff 4 Files Affected: - (mod

[Lldb-commits] [lldb] 55ec9db - [lldb][NFCI] Change parameter type in UserExpression::GetObjectPointer (#67055)

2023-09-22 Thread via lldb-commits
Author: Alex Langford Date: 2023-09-22T10:10:21-07:00 New Revision: 55ec9db42ae03661d1a2913423f56b58db581199 URL: https://github.com/llvm/llvm-project/commit/55ec9db42ae03661d1a2913423f56b58db581199 DIFF: https://github.com/llvm/llvm-project/commit/55ec9db42ae03661d1a2913423f56b58db581199.diff

[Lldb-commits] [lldb] c0a9722 - [lldb][NFC] Move some ctors and tors to cpp files (#67165)

2023-09-22 Thread via lldb-commits
Author: Walter Erquinigo Date: 2023-09-22T13:33:07-04:00 New Revision: c0a9722bd66d3452ba095d9f9ef6ab67b9965c76 URL: https://github.com/llvm/llvm-project/commit/c0a9722bd66d3452ba095d9f9ef6ab67b9965c76 DIFF: https://github.com/llvm/llvm-project/commit/c0a9722bd66d3452ba095d9f9ef6ab67b9965c76.di

[Lldb-commits] [lldb] [lldb] Modify the DWARFDebugAbbrev interface to be closer to LLVM's (PR #67190)

2023-09-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes I want to work towards unifying the implementations. It would be a lot easier to do if LLDB's DWARFDebugAbbrev looked more similar to LLVM's implementation, so this change moves in that direction. --- Full diff: https://github.com/llvm/llv

[Lldb-commits] [lldb] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

2023-09-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-llvm Changes I think this is very helpful for reading generated `.inc` files. --- Patch is 31.85 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/65744.diff 22 Files Affected: - (modified) clang/utils/T

[Lldb-commits] [lldb] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

2023-09-23 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b8b4ee6b450766796b162b4811a6b3f723d07268 d07486764071679c8cbcd5e7c4905eb41b4770b3 --

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-23 Thread via lldb-commits
https://github.com/huixie90 requested changes to this pull request. Thank you for contributing! I have not looked at the tests yet. Please let me know if my comments on the header file is unclear. Thank you! https://github.com/llvm/llvm-project/pull/66963 ___

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-23 Thread via lldb-commits
@@ -0,0 +1,145 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-23 Thread via lldb-commits
@@ -0,0 +1,145 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-23 Thread via lldb-commits
https://github.com/huixie90 edited https://github.com/llvm/llvm-project/pull/66963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-23 Thread via lldb-commits
https://github.com/huixie90 edited https://github.com/llvm/llvm-project/pull/66963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-24 Thread via lldb-commits
goldsteinn wrote: LGTM. https://github.com/llvm/llvm-project/pull/65852 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-24 Thread via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h" +#in

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-24 Thread via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h" +#in

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-24 Thread via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h" +#in

[Lldb-commits] [lldb] [lldb] Add SetValueFromCString API to SyntheticFronend (PR #67309)

2023-09-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes It is a first of three patches neded for adding an ability to update std::string/wstring/etc during debug process. This patch adds to the synthetic child interface a “change value” method which goes back to the synthetic child provider and

[Lldb-commits] [lldb] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

2023-09-25 Thread via lldb-commits
cor3ntin wrote: @tru I'd ask @AaronBallman. My vote would be to reformat. https://github.com/llvm/llvm-project/pull/65744 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 247b7d0 - [cmake] Add LLVM_FORCE_VC_REVISION option (#67125)

2023-09-25 Thread via lldb-commits
Author: David Truby Date: 2023-09-25T14:32:52+01:00 New Revision: 247b7d068497de085b7fd66c6531034afa9709f0 URL: https://github.com/llvm/llvm-project/commit/247b7d068497de085b7fd66c6531034afa9709f0 DIFF: https://github.com/llvm/llvm-project/commit/247b7d068497de085b7fd66c6531034afa9709f0.diff L

[Lldb-commits] [lldb] [lldb] Add SetValueFromCString API to SyntheticFronend (PR #67309)

2023-09-25 Thread via lldb-commits
jimingham wrote: Getting the SyntheticFrontEnd to try updating the synthetic value is a good addition. But I'm not sure that ValueObject should be the one that should provide access directly to the FrontEnd? Why isn't it enough to have the ValueObjectSynthetic's SetValueFromCString do this?

[Lldb-commits] [lldb] d3505c2 - [lldb] Modify the DWARFDebugAbbrev interface to be closer to LLVM's (#67190)

2023-09-25 Thread via lldb-commits
Author: Alex Langford Date: 2023-09-25T13:11:39-07:00 New Revision: d3505c28a770fabd77d7483afbca383d453bef02 URL: https://github.com/llvm/llvm-project/commit/d3505c28a770fabd77d7483afbca383d453bef02 DIFF: https://github.com/llvm/llvm-project/commit/d3505c28a770fabd77d7483afbca383d453bef02.diff

[Lldb-commits] [lldb] [lldb] [debugserver] Preserve signing bits on lr in debugserver (PR #67384)

2023-09-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes In https://reviews.llvm.org/D136620 I changed debugserver to stop using the kernel-provided functions arm_thread_state64_get_{pc,lr,sp,fp} to postprocess those four registers on aarch64 systems after we thread_get_state() them. The kernel s

[Lldb-commits] [lldb] [lldb] [debugserver] Preserve signing bits on lr in debugserver (PR #67384)

2023-09-25 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff feb7b1914d513c709b9e024dfed709bb889cc853 5e588f4163c5d6790ac6b8836558aa3a5bf1ccfc --

[Lldb-commits] [lldb] b7961f2 - [lldb] [debugserver] Preserve signing bits on lr in debugserver (#67384)

2023-09-25 Thread via lldb-commits
Author: Jason Molenda Date: 2023-09-25T17:02:25-07:00 New Revision: b7961f2cb97556bfc50f7828d5f869d96ab9352e URL: https://github.com/llvm/llvm-project/commit/b7961f2cb97556bfc50f7828d5f869d96ab9352e DIFF: https://github.com/llvm/llvm-project/commit/b7961f2cb97556bfc50f7828d5f869d96ab9352e.diff

[Lldb-commits] [lldb] [lldb] add stop-at-main option to process launch (PR #67019)

2023-09-25 Thread via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue( case 's': // Stop at program entry point launch_info.GetFlags().Set(eLaunchFlagStopAtEntr

[Lldb-commits] [lldb] [lldb] add stop-at-main option to process launch (PR #67019)

2023-09-25 Thread via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue( case 's': // Stop at program entry point launch_info.GetFlags().Set(eLaunchFlagStopAtEntr

[Lldb-commits] [lldb] [lldb] add stop-at-main option to process launch (PR #67019)

2023-09-25 Thread via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue( case 's': // Stop at program entry point launch_info.GetFlags().Set(eLaunchFlagStopAtEntr

[Lldb-commits] [lldb] [lldb] add stop-at-main option to process launch (PR #67019)

2023-09-25 Thread via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -675,6 +675,8 @@ let Command = "platform shell" in { let Command = "process launch" in { def process_launch_stop_at_entry : Option<"stop-at-entry", "s">, De

[Lldb-commits] [lldb] [lldb] add stop-at-main option to process launch (PR #67019)

2023-09-25 Thread via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue( case 's': // Stop at program entry point launch_info.GetFlags().Set(eLaunchFlagStopAtEntr

[Lldb-commits] [lldb] [lldb] add stop-at-main option to process launch (PR #67019)

2023-09-25 Thread via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue( case 's': // Stop at program entry point launch_info.GetFlags().Set(eLaunchFlagStopAtEntr

[Lldb-commits] [lldb] [lldb] add stop-at-main option to process launch (PR #67019)

2023-09-25 Thread via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue( case 's': // Stop at program entry point launch_info.GetFlags().Set(eLaunchFlagStopAtEntr

[Lldb-commits] [lldb] b0e28eb - [llvm][tblgen] Add `Source Filename` for `emitSourceFileHeader` (#65744)

2023-09-25 Thread via lldb-commits
Author: Shao-Ce SUN Date: 2023-09-26T13:40:56+08:00 New Revision: b0e28eb832710964067a17d845de15ada2da2b9c URL: https://github.com/llvm/llvm-project/commit/b0e28eb832710964067a17d845de15ada2da2b9c DIFF: https://github.com/llvm/llvm-project/commit/b0e28eb832710964067a17d845de15ada2da2b9c.diff L

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h" +#in

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast edited https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast updated https://github.com/llvm/llvm-project/pull/67106 >From f8ed3ed64be0a451542a4ec71f254dc9038b2d19 Mon Sep 17 00:00:00 2001 From: aokblast Date: Fri, 22 Sep 2023 18:11:07 +0800 Subject: [PATCH 1/3] feat: add DynamicLoaderFreeBSDKernel --- .../Plugins/DynamicLoa

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast updated https://github.com/llvm/llvm-project/pull/67106 >From f8ed3ed64be0a451542a4ec71f254dc9038b2d19 Mon Sep 17 00:00:00 2001 From: aokblast Date: Fri, 22 Sep 2023 18:11:07 +0800 Subject: [PATCH 1/3] feat: add DynamicLoaderFreeBSDKernel --- .../Plugins/DynamicLoa

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast updated https://github.com/llvm/llvm-project/pull/67106 >From f8ed3ed64be0a451542a4ec71f254dc9038b2d19 Mon Sep 17 00:00:00 2001 From: aokblast Date: Fri, 22 Sep 2023 18:11:07 +0800 Subject: [PATCH 1/3] feat: add DynamicLoaderFreeBSDKernel --- .../Plugins/DynamicLoa

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast resolved https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast resolved https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast resolved https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast resolved https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast resolved https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast resolved https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast resolved https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast resolved https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast unresolved https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast unresolved https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast resolved https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast resolved https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast resolved https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
https://github.com/aokblast resolved https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-26 Thread via lldb-commits
aokblast wrote: I fix all mentioned issue and test on both x86-64 and arm64. Hope everyone can give it a review. Thanks! https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [lldb] [lldb] Add SetValueFromCString API to SyntheticFronend (PR #67309)

2023-09-26 Thread via lldb-commits
jimingham wrote: This part of the change seems straightforward, if the synthetic child provider can set a value it will have to have this API... But yes, if there are a bunch of patches that build on one another, if they aren't too big one patch that shows the functionality is easier to unders

[Lldb-commits] [lldb] [lldb] add stop-at-main option to process launch (PR #67019)

2023-09-26 Thread via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: jimingham wrote: > On Sep 26, 2023, at 7:55 AM, José Lira Junior ***@***.***> wrote: > > > @junior-jl commented on this pull request. > > In lldb/source/Commands/CommandOptionsPro

[Lldb-commits] [lldb] [lldb] add stop-at-main option to process launch (PR #67019)

2023-09-26 Thread via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: jimingham wrote: Yes that's right. Normally what happens in program execution is the main executable gets loaded along with the dynamic loader, and then the loader runs, leading the

[Lldb-commits] [lldb] [lldb] add stop-at-main option to process launch (PR #67019)

2023-09-26 Thread via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: jimingham wrote: > On Sep 26, 2023, at 7:29 AM, José Lira Junior ***@***.***> wrote: > > > @junior-jl commented on this pull request. > > In lldb/source/Commands/CommandOptionsPro

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

2023-09-26 Thread via lldb-commits
pizzud wrote: Extracted the shared_ptr parts to https://github.com/llvm/llvm-project/pull/67467. I'll continue the unique_ptr portion here and respond to those comments later today. https://github.com/llvm/llvm-project/pull/66139 ___ lldb-commits mai

[Lldb-commits] [lldb] Implement thread local storage for linux (PR #67470)

2023-09-26 Thread via lldb-commits
https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/67470 None >From 5e8b4a44bf48216785f5ecb412e145a7ac4d3a55 Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Tue, 26 Sep 2023 11:04:08 -0700 Subject: [PATCH] Implement thread local storage for linux --- lldb/inc

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

2023-09-26 Thread via lldb-commits
https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/66139 >From b699129b21c95571410a809d16fdf8cfcf1526c5 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 12 Sep 2023 13:24:48 -0700 Subject: [PATCH 1/3] [clang-tidy] Add performance-move-smart-pointer-contents chec

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

2023-09-26 Thread via lldb-commits
https://github.com/pizzud resolved https://github.com/llvm/llvm-project/pull/66139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

2023-09-26 Thread via lldb-commits
@@ -0,0 +1,23 @@ +.. title:: clang-tidy - performance-move-smart-pointer-contents + +performance-move-smart-pointer-contents +=== + +Given a smart pointer containing a movable type, such as a pizzud wrote: Done. https://github

[Lldb-commits] [lldb] [lldb] Implement thread local storage for linux (PR #67470)

2023-09-26 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/67470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    28   29   30   31   32   33   34   35   36   37   >