jimingham wrote: The comment in front of the `SyntheticChildProviderFrontEnd::Update` is actually pretty clear about what it does, the problem is that it isn't really obvious from the comment when discarding the cached children would be a good or bad idea. I'm not sure you could express that in a name, we really need a better doc.
Jim > On Sep 22, 2023, at 6:46 AM, Walter Erquinigo ***@***.***> wrote: > > > Do you think it would be a good idea to provide aliases for the return values > of the Update method with better names that match the behavior you just > discovered? I'm not a fan of true/false in this case, because it confuses > synthetic type developers, but I'm just trying to think of ways to improve > this without breaking any existing code. > > — > Reply to this email directly, view it on GitHub > <https://github.com/llvm/llvm-project/pull/67069#issuecomment-1731449437>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADUPVW7CPPBX5CHQWSJBZP3X3WJDLANCNFSM6AAAAAA5CHOB7M>. > You are receiving this because you were mentioned. > https://github.com/llvm/llvm-project/pull/67069 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
