jimingham wrote: In this case, it's clearly not a regex, so this change is fine. But ALSO, any regex matches against std types should be `^std::whatever` and not just `std::whatever` to avoid this sort of unintended matching.
Jim > On Sep 20, 2023, at 1:37 PM, Walter Erquinigo ***@***.***> wrote: > > > @walter-erquinigo approved this pull request. > > Good catch! I think I have suffered because of this at some point. > > — > Reply to this email directly, view it on GitHub > <https://github.com/llvm/llvm-project/pull/66949#pullrequestreview-1636465803>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADUPVWY4RBH5JH3GUIU6IUTX3NHYFANCNFSM6AAAAAA5APBMII>. > You are receiving this because your review was requested. > https://github.com/llvm/llvm-project/pull/66949 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
