zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Ahh, you're right, I didn't notice that.
http://reviews.llvm.org/D18912
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.
Thanks. One more question. Does SymbolFile::FindTypes need to be able to
handle the case of a null type name (which I guess would indicate to find
every type)?
On Fri, Apr 8, 2016 at 3:24 PM Greg Clayton wrote:
> clayborg added a comment.
>
> In http://reviews.llvm.org/D18848#395933, @zturner
I have a feeling this breaks something, but I'm not sure what. I remember
specifically needing this for some reason.
Did you verify that the gtest suite as well as the dotest suite and the
interactive interpreter all still pass / work?
On Mon, Apr 11, 2016 at 6:14 PM Enrico Granata via lldb-commit
tests.
> However, I have reverted this change until that happens to keep to bots
> green.
>
> pl
>
> On 12 April 2016 at 02:41, Enrico Granata via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>>
>> On Apr 11, 2016, at 6:28 PM, Zachary Turner
The expected behavior imo is to normalize before returning in
GetDirectory(). Perhaps you could add a boolean with default value true?
On Wed, Apr 13, 2016 at 8:26 AM Pavel Labath wrote:
> labath created this revision.
> labath added a reviewer: zturner.
> labath added a subscriber: lldb-commits.
Ahh that's unfortunate. I guess the thing to do is make SetFile and
SetDirectory. At least by changing the return type we can get the compiler
to tell us everywhere this is happening. Did you run the test suite on
Windows to make sure this doesnt break anything?
On Wed, Apr 13, 2016 at 8:36 AM Pave
Ok sounds good
On Wed, Apr 13, 2016 at 9:56 AM Pavel Labath wrote:
> labath added a comment.
>
> In http://reviews.llvm.org/D19060#399915, @zturner wrote:
>
> > Ahh that's unfortunate. I guess the thing to do is make SetFile and
> > SetDirectory. At least by changing the return type we can get t
I'll let Sean comment on the content of the patch, but please add a test
that runs such an expression and demonstrates the correct output.
On Thu, Apr 14, 2016 at 10:01 AM Cameron via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> cameron314 created this revision.
> cameron314 added a revie
zturner added a subscriber: zturner.
zturner added a comment.
I'll let Sean comment on the content of the patch, but please add a test
that runs such an expression and demonstrates the correct output.
Repository:
rL LLVM
http://reviews.llvm.org/D19124
__
http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc2015
My build bot which uses MSVC 2015 is workign fine. What kind of error are
you seeing?
On Thu, Apr 14, 2016 at 10:14 AM Cameron wrote:
> cameron314 added a comment.
>
> Ah, that's a bit tricky at the moment. The LLVM tip no longer comp
zturner updated this revision to Diff 53775.
zturner added a comment.
Changes from first patch:
1. Based on your other comment that it wasn't actually necessary to create a
`TypeSP` for builtin types, I went ahead and removed all the code that was
looking at bit and byte sizes. So all that stu
zturner updated this revision to Diff 53780.
zturner added a comment.
Generated the wrong patch last time. This one should be good
http://reviews.llvm.org/D18848
Files:
include/lldb/Symbol/ClangASTContext.h
source/Plugins/SymbolFile/PDB/CMakeLists.txt
source/Plugins/SymbolFile/PDB/PDBAST
zturner added a comment.
That should be fine, but as long as I don't have to create a `TypeSP` for it
when someone calls `FindTypes`, which is the only thing I'm implementing here,
I think I should be ok. When I go to create `CXXRecordDecls` to complete class
types, or when I add support for s
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
I think you can probably leave buffering turned off for stdout and only do this
change for stdin unless we find some other bug. AFAIK the problem is confined
to stdin. I'd probably leave a
Author: zturner
Date: Thu Apr 14 19:21:26 2016
New Revision: 266392
URL: http://llvm.org/viewvc/llvm-project?rev=266392&view=rev
Log:
Initial support for reading type information from PDBs.
This implements a PDBASTParser and corresponding logic in
SymbolFilePDB to do type lookup by name. This is
A new file was added, Greg or someone else at Apple may need to add it to
the Xcode workspace
On Thu, Apr 14, 2016 at 6:26 PM Vedant Kumar wrote:
> vsk added a subscriber: vsk.
> vsk added a comment.
>
> Hi @zturner, this seems to have upset an lldb bot. Could you take a look (
> https://llvm.org
zturner added a comment.
A new file was added, Greg or someone else at Apple may need to add it to
the Xcode workspace
http://reviews.llvm.org/D18848
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
I wrote a library in llvm which is independent of the Windows system dll
and is abstracted such that we can plug in a non Windows specific version
of a pdb parser once we understand the format well enough.
For now, if you're not on Windows this library will just return an error if
you try to creat
zturner added a comment.
I wrote a library in llvm which is independent of the Windows system dll
and is abstracted such that we can plug in a non Windows specific version
of a pdb parser once we understand the format well enough.
For now, if you're not on Windows this library will just return an
Don't use an environment variable, add a command line flag to the script
instead
On Fri, Apr 15, 2016 at 3:27 PM Francis Ricci wrote:
> fjricci added a comment.
>
> So I looked at `finishSwigPythonLLDB.py`, and it does look like that's
> where the bug is. This script sets the end of the symlink p
zturner added a subscriber: zturner.
zturner added a comment.
Don't use an environment variable, add a command line flag to the script
instead
http://reviews.llvm.org/D19067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
zturner added inline comments.
Comment at: packages/Python/lldbsuite/test/test_runner/lldb_utils.py:1
@@ +1,2 @@
+"""
+The LLVM Compiler Infrastructure
I feel like this entire file should go under `lldbsuite/support`. If it's
under `test/test_runner` we can't us
It seems very strange to me to be changing a .pyc filename to a .py
filename. I think we should try to understand where the .pyc filename is
coming from to begin with, and this is just masking the real error.
On Mon, Apr 18, 2016 at 10:10 AM Pavel Labath via lldb-commits <
lldb-commits@lists.llvm
hould turn it off again...
>
> Jim
>
> > On Apr 18, 2016, at 11:01 AM, Zachary Turner via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
> >
> > It seems very strange to me to be changing a .pyc filename to a .py
> filename. I think we should try to unders
p.
>
> Jim
>
> > On Apr 18, 2016, at 11:29 AM, Zachary Turner wrote:
> >
> > That's normal, but why would that cause an issue for the test suite?
> What is leading to it thinking that it should execute a .pyc file in the
> first place?
> >
> > On Mon
(not sure how much though, as I haven't actually measured it)
On Mon, Apr 18, 2016 at 11:40 AM Zachary Turner wrote:
> They make the test suite run faster. when a file wasn't changed.
>
> On Mon, Apr 18, 2016 at 11:34 AM Jim Ingham wrote:
>
>> That I don't
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
thanks
http://reviews.llvm.org/D19216
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
This is going to break the windows build, as getpwuid doesnt exist. Can you
wrap this?
As an aside, why not submit a patch to the llvm function instead, it makes
more sense there
On Tue, Apr 19, 2016 at 4:10 PM Greg Clayton via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: gclayton
I was under the impression the make build was officially unsupported/dead?
On Wed, Apr 20, 2016 at 4:26 AM Jonas Hahnfeld
wrote:
> Hahnfeld added a subscriber: Hahnfeld.
> Hahnfeld added a comment.
>
> I think this one is breaking `make check-all` for me because it cannot
> find and copy `test-pd
zturner added a comment.
I was under the impression the make build was officially unsupported/dead?
http://reviews.llvm.org/D18848
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
Hmm, ok i will check it out later. I'm not sure why it's even trying to
copy an exe, should be only doing the pdb. Exe isn't even checked in
http://reviews.llvm.org/D18848
___
lldb-commits mailing list
lldb-commits@lists.llv
Hmm, ok i will check it out later. I'm not sure why it's even trying to
copy an exe, should be only doing the pdb. Exe isn't even checked in
On Wed, Apr 20, 2016 at 8:08 AM Pavel Labath wrote:
> labath added a subscriber: labath.
> labath added a comment.
>
> In http://reviews.llvm.org/D18848#406
Author: zturner
Date: Wed Apr 20 11:41:02 2016
New Revision: 266886
URL: http://llvm.org/viewvc/llvm-project?rev=266886&view=rev
Log:
Add missing file needed for PDB unittests.
Added:
lldb/trunk/unittests/SymbolFile/PDB/Inputs/test-pdb-types.exe
Added: lldb/trunk/unittests/SymbolFile/PDB/Inp
It should be fixed now, please sync and try again
On Thu, Apr 21, 2016 at 4:04 AM Jonas Hahnfeld
wrote:
> Hahnfeld added a comment.
>
> In http://reviews.llvm.org/D18848#406521, @labath wrote:
>
> > In http://reviews.llvm.org/D18848#406509, @zturner wrote:
> >
> > > I was under the impression the
zturner added a comment.
It should be fixed now, please sync and try again
http://reviews.llvm.org/D18848
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Resending to new mailing list. @cs.uiuc.edu doesn't work anymore, all
messages should go to @lists.llvm.org.
On Thu, Aug 6, 2015 at 8:46 AM Zachary Turner wrote:
> This patch (http://reviews.llvm.org/D11717) was supposed to fix it, but I
> don't see anything posted to lldb-co
Sorry, I don't have much to add here. I guess you need to wait for Sean or
Jim to respond.
On Thu, Aug 6, 2015 at 1:22 PM Dawn Perchik wrote:
> dawn added a comment.
>
> Please review? Thank you.
>
>
> http://reviews.llvm.org/D11102
>
>
>
>
___
lldb-
zturner created this revision.
zturner added reviewers: dawn, chaoren.
zturner added a subscriber: lldb-commits.
Previously all test output was reported by each individual
instance of dotest.py. After a recent patch, dosep gets dotest
outptu via a pipe, and selectively decides which output to
pri
zturner added a comment.
I want to make it clear again though that we do not support relying on the
output of dotest.py when running dosep. The patch which originally broke this
made it possible to collect detailed information about the tests that were run
from within dosep. If you want to pr
zturner added inline comments.
Comment at: test/dosep.py:82
@@ +81,3 @@
+with output_lock:
+print >> sys.stderr, stdout
+print >> sys.stderr, "[%s] FAILED" % name
chaoren wrote:
> Why did you move this here? Could you please move stderr here to
zturner added inline comments.
Comment at: test/dosep.py:82
@@ +81,3 @@
+with output_lock:
+print >> sys.stderr, stdout
+print >> sys.stderr, "[%s] FAILED" % name
zturner wrote:
> chaoren wrote:
> > Why did you move this here? Could you please
zturner added inline comments.
Comment at: test/dosep.py:142
@@ -128,2 +141,3 @@
passes, failures = parse_test_results(output)
-update_status(name, command, output if exit_status != 0 else None)
+if exit_status == 0:
+report_test_pass(name, output[1])
zturner updated this revision to Diff 31482.
http://reviews.llvm.org/D11816
Files:
test/dosep.py
Index: test/dosep.py
===
--- test/dosep.py
+++ test/dosep.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python
"""
R
zturner updated this revision to Diff 31491.
zturner added a comment.
Merge the test name into the progress line. If we want to get overwritable
lines we will need to use a stateful line printer that can clear the contents
of the current line after issuing a carriage return.
http://reviews.ll
zturner added a comment.
Dawn are you ok with this? I believe this fixes your issue, so i want to make
sure before I commit.
http://reviews.llvm.org/D11816
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
I was hoping to get my change in first, what do you think?
On Fri, Aug 7, 2015 at 12:54 PM Chaoren Lin wrote:
> chaoren created this revision.
> chaoren added a reviewer: zturner.
> chaoren added a subscriber: lldb-commits.
>
> Update to D11816.
>
> http://reviews.llvm.org/D11843
>
> Files:
>
Ahh, ignore my comment then :)
On Fri, Aug 7, 2015 at 12:59 PM Chaoren Lin wrote:
> chaoren added a comment.
>
> > I was hoping to get my change in first, what do you think?
>
>
> What do you mean? This is an update to http://reviews.llvm.org/D11816. I
> can't commit it without your change.
>
>
lgtm
On Mon, Aug 10, 2015 at 2:15 AM Keno Fischer
wrote:
> loladiro created this revision.
> loladiro added a reviewer: zturner.
> loladiro added a subscriber: lldb-commits.
> loladiro set the repository for this revision to rL LLVM.
>
> We get an assertion otherwise because the None Interpreter
zturner added a comment.
Chaoren, am I still missing any requested changes or is this good to go? I'm
not sure if some of your original concerns still stand after the latest
discussion.
http://reviews.llvm.org/D11816
___
lldb-commits mailing list
Author: zturner
Date: Mon Aug 10 12:46:11 2015
New Revision: 244469
URL: http://llvm.org/viewvc/llvm-project?rev=244469&view=rev
Log:
Allow dosep.py to print dotest.py output on success.
Previously all test output was reported by each individual
instance of dotest.py. After a recent patch, dosep
lgtm
On Mon, Aug 10, 2015 at 9:50 AM Chaoren Lin wrote:
> chaoren created this revision.
> chaoren added a reviewer: zturner.
> chaoren added a subscriber: lldb-commits.
>
> http://reviews.llvm.org/D11909
>
> Files:
> test/dosep.py
>
> Index: test/dosep.py
> ===
zturner added a comment.
lgtm
http://reviews.llvm.org/D11910
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Sorry, will get to this first thing tomorroow
On Tue, Aug 11, 2015 at 4:47 PM Chaoren Lin wrote:
> chaoren added a comment.
>
> Ping?
>
>
> http://reviews.llvm.org/D11843
>
>
>
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.ll
You need to use LIBLLDB_API instead of __declspec(export). Otherwise
someone linking against liblldb and trying to call this won't work
correctly. Check the annotation given to the classes in the SB headers for
the exact name of the macro.
On Tue, Aug 11, 2015 at 6:23 PM Chaoren Lin wrote:
> T
True that it only needs to be included if it's part of the api. Are we
sure it can't happen through a transitive include?
As long as the user of liblldb doesn't see the declaration it shouldn't be
a problem.
On Tue, Aug 11, 2015 at 6:54 PM Chaoren Lin via lldb-commits <
lldb-commits@lists.llvm.o
zturner added inline comments.
Comment at: test/dosep.py:215
@@ +214,3 @@
+# Only interested in test files with the "Test*.py" naming pattern.
+return name.startswith("Test") and name.endswith(".py")
+
How was this working before? Seems ri
Author: zturner
Date: Thu Aug 13 15:49:43 2015
New Revision: 244950
URL: http://llvm.org/viewvc/llvm-project?rev=244950&view=rev
Log:
XFAIL Watchpoint tests on Windows.
https://llvm.org/pr24446 tracks getting these tests re-enabled.
Modified:
lldb/trunk/test/functionalities/watchpoint/hello
Author: zturner
Date: Thu Aug 13 15:50:17 2015
New Revision: 244951
URL: http://llvm.org/viewvc/llvm-project?rev=244951&view=rev
Log:
Disable lldb-mi tests on Windows.
Most were already XFAIL'ed, but the reason for the XFAIL is that
we don't have a suitable pexpect implementation on Windows. Thi
Author: zturner
Date: Thu Aug 13 17:05:54 2015
New Revision: 244963
URL: http://llvm.org/viewvc/llvm-project?rev=244963&view=rev
Log:
Remove Unicode byte-order mark from python files.
This was caused by a bug in the PTVS source file editor, which has
since been fixed and awaiting a new release.
zturner created this revision.
zturner added a reviewer: chaoren.
zturner added a subscriber: lldb-commits.
New output looks like this:
FAIL: LLDB (suite) :: TestThreadStepOut.py (Windows zturner-win81 8 6.2.9200
AMD64 Intel64 Family 6 Model 45 Stepping 7, GenuineIntel)
FAIL: LLDB (suite) :: Tes
zturner added inline comments.
Comment at: test/dosep.py:266
@@ -259,2 +266,2 @@
timed_out = sum([result[0] for result in test_results], [])
passed = sum([result[1] for result in test_results], [])
chaoren wrote:
> There's a line above this:
> ```
> # re
zturner updated this revision to Diff 32110.
http://reviews.llvm.org/D12020
Files:
test/dosep.py
Index: test/dosep.py
===
--- test/dosep.py
+++ test/dosep.py
@@ -121,23 +121,28 @@
def parse_test_results(output):
passes = 0
zturner added inline comments.
Comment at: test/dosep.py:500
@@ +499,3 @@
+print "\nUnexpected Successes (%d)" % len(unexpected_successes)
+for u in unexpected_successes:
+print "UNEXPECTED SUCCESS: LLDB (suite) :: %s (%s)" % (u,
system_info)
-
Author: zturner
Date: Fri Aug 14 11:45:32 2015
New Revision: 245066
URL: http://llvm.org/viewvc/llvm-project?rev=245066&view=rev
Log:
Update dosep to print unexpected successes at the end.
Modified:
lldb/trunk/test/dosep.py
Modified: lldb/trunk/test/dosep.py
URL:
http://llvm.org/viewvc/llvm
Is Objective C++ even a thing on non-Apple platforms? I dont' think we
should be forcing a default *anything* to a language that only exists on a
subset of supported platforms. But even ignoring that, I don't think
preferential treatment should be given to any particular language.
If there is go
zturner created this revision.
zturner added a reviewer: chaoren.
zturner added a subscriber: lldb-commits.
http://reviews.llvm.org/D12039
Files:
test/lldbtest.py
Index: test/lldbtest.py
===
--- test/lldbtest.py
+++ test/lldbtest.
zturner added inline comments.
Comment at: test/lldbtest.py:943
@@ -947,1 +942,3 @@
+def skipUnlessArch(archlist):
+def myImpl(func):
chaoren wrote:
> Is there a reason
> ```
> return unittest2.skipUnless(getArchitecture() in archlist, ...)
> ```
> is not su
zturner created this revision.
zturner added reviewers: clayborg, jingham.
zturner added a subscriber: lldb-commits.
This eliminates portability issues among platforms that don't have a pthreads
implementation.
There was one situation in TestTlsGlobals.py where it seems the intention is to
comp
zturner updated this revision to Diff 32195.
zturner added a comment.
Remove unicode byte-order-marks from python files
http://reviews.llvm.org/D12043
Files:
test/functionalities/expr-doesnt-deadlock/Makefile
test/functionalities/expr-doesnt-deadlock/TestExprDoesntBlock.py
test/functional
Author: zturner
Date: Fri Aug 14 18:28:49 2015
New Revision: 245125
URL: http://llvm.org/viewvc/llvm-project?rev=245125&view=rev
Log:
Disable libstdc++ and libcxx data formatter tests on Windows.
Neither of these libraries has been ported to Windows. Eventually
if they are ever ported we can re-
Author: zturner
Date: Fri Aug 14 18:29:17 2015
New Revision: 245126
URL: http://llvm.org/viewvc/llvm-project?rev=245126&view=rev
Log:
XFAIL some data formatter tests on Windows.
Fixing these bugs is tracked by http://llvm.org/pr24462.
Modified:
lldb/trunk/test/functionalities/data-formatter
Author: zturner
Date: Fri Aug 14 18:29:24 2015
New Revision: 245127
URL: http://llvm.org/viewvc/llvm-project?rev=245127&view=rev
Log:
Make skipUnlessArch decorator actually skip instead of XFAIL.
Modified:
lldb/trunk/test/lldbtest.py
Modified: lldb/trunk/test/lldbtest.py
URL:
http://llvm.or
Author: zturner
Date: Fri Aug 14 18:29:32 2015
New Revision: 245128
URL: http://llvm.org/viewvc/llvm-project?rev=245128&view=rev
Log:
Enable settings test for i686 as well as i386.
Modified:
lldb/trunk/test/settings/TestSettings.py
Modified: lldb/trunk/test/settings/TestSettings.py
URL:
htt
Author: zturner
Date: Mon Aug 17 15:12:04 2015
New Revision: 245234
URL: http://llvm.org/viewvc/llvm-project?rev=245234&view=rev
Log:
Convert all use of pthreads in tests to c++11 threads.
This eliminates portability issues among platforms that don't have
a pthreads implementation.
Differential
Strange, I'll take a look tomorrow. Thanks for catching this
On Mon, Aug 17, 2015 at 5:28 PM Chaoren Lin via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: chaoren
> Date: Mon Aug 17 19:27:08 2015
> New Revision: 245262
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245262&view=r
Author: zturner
Date: Tue Aug 18 15:01:28 2015
New Revision: 245338
URL: http://llvm.org/viewvc/llvm-project?rev=245338&view=rev
Log:
[Windows] XFAIL tests that depend on expression name lookup.
Name lookup doesn't work properly with Windows targets. This is
most likely due to issues with name m
Rather than all of this ugly error-prone code, can we instead use
llvm::sys::fs::root_name to check whether the path contains a drive letter?
On Tue, Aug 18, 2015 at 1:52 PM Dawn Perchik via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> dawn created this revision.
> dawn added reviewers: a
Author: zturner
Date: Tue Aug 18 17:25:40 2015
New Revision: 245371
URL: http://llvm.org/viewvc/llvm-project?rev=245371&view=rev
Log:
Fix TestArrayTypes on Windows.
Whether or not frames print their tid in hex or decimal is apparently
hardcoded to depend on the operating system. For now a commen
Are you saying that there is a situation where you are given a path, and
you have no idea whether it is a posix path or a windows path? That seems
strange to me. Surely you must know (or be able to find out) if the
computer you are interfacing with is running Windows or non-Windows, right?
On Tu
zturner added a comment.
I would really like to start seeing tests go in at the same time as the
patches. Can any of this functionality be tested yet? i.e. are there commands
that will exercise this code? Also still haven't seen tests go in for the
basic minidump functionality, like a test t
zturner added inline comments.
Comment at: source/Plugins/Process/win-minidump/ProcessWinMiniDump.cpp:172
@@ -174,1 +171,3 @@
{
+if (m_data_up) return;
+if (m_data_up->m_exception_sp) return;
I know :-/ Not saying I agree or disagree, it's just the LLVM
Seems reasonable to move that to lldb-dev.
On Wed, Aug 19, 2015 at 12:56 PM Dawn Perchik wrote:
> dawn planned changes to this revision.
> dawn added a comment.
>
> In http://reviews.llvm.org/D12115#227613, @abidh wrote:
>
> > This command uses "target modules lookup" [...]
>
>
> Good point. Ye
looks good, can you add a comment to explain why it's inlined though.
On Thu, Aug 20, 2015 at 12:14 PM Chaoren Lin wrote:
> chaoren created this revision.
> chaoren added a reviewer: zturner.
> chaoren added a subscriber: lldb-commits.
>
> dllexport doesn't work if linking against a static libra
Author: zturner
Date: Thu Aug 20 17:08:48 2015
New Revision: 245627
URL: http://llvm.org/viewvc/llvm-project?rev=245627&view=rev
Log:
XFAIL TestAnonymous.test_expr_null_with_dwarf on Windows.
This bug is tracked in llvm.org/pr21550, and also reproduces on
FreeBSD apparently.
Modified:
lldb/t
Author: zturner
Date: Thu Aug 20 17:08:38 2015
New Revision: 245626
URL: http://llvm.org/viewvc/llvm-project?rev=245626&view=rev
Log:
[ProcessWindows] Fix rare crash on shutdown.
There might be an underlying race condition here that should be
figured out, but this at least prevents the crash for
Author: zturner
Date: Thu Aug 20 17:08:57 2015
New Revision: 245628
URL: http://llvm.org/viewvc/llvm-project?rev=245628&view=rev
Log:
XFAIL TestBSDArchives.py on Windows
llvm.org/pr24527 tracks this bug. Makefile.rules does not know
how to build static libraries on Windows.
Modified:
lldb/t
Author: zturner
Date: Thu Aug 20 17:09:35 2015
New Revision: 245630
URL: http://llvm.org/viewvc/llvm-project?rev=245630&view=rev
Log:
[Windows] XFAIL tests that require calling a function in target.
This has known issues on Windows. Fixing this is tracked by
http://llvm.org/pr21765
Modified:
Author: zturner
Date: Thu Aug 20 17:09:08 2015
New Revision: 245629
URL: http://llvm.org/viewvc/llvm-project?rev=245629&view=rev
Log:
XFAIL breakpoint tests on Windows
llvm.org/pr24528 tracks fixing this test.
Modified:
lldb/trunk/test/functionalities/breakpoint/breakpoint_command/TestBreak
Author: zturner
Date: Thu Aug 20 17:25:45 2015
New Revision: 245631
URL: http://llvm.org/viewvc/llvm-project?rev=245631&view=rev
Log:
Change TestBSDArchives to expectedFailureWindows.
Modified:
lldb/trunk/test/functionalities/archives/TestBSDArchives.py
Modified: lldb/trunk/test/functionalit
zturner added a comment.
Can you verify that this does not break local debugging on Windows?
http://reviews.llvm.org/D12245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Tested on Windows, I don't see any problems, so lgtm.
If you're going to be doing a non-trivial amount of work on ProcessWindows
or DynamicLoaderWindows, would it be possible for you to set up a Windows
box you can test from? I'm happy to help you get this set up if you need.
On Fri, Aug 21, 201
Author: zturner
Date: Fri Aug 21 17:11:21 2015
New Revision: 245748
URL: http://llvm.org/viewvc/llvm-project?rev=245748&view=rev
Log:
Skip TestCreateAfterAttach on Windows.
As with every other platform, this test occasionally hangs on
Windows.
Modified:
lldb/trunk/test/functionalities/threa
Author: zturner
Date: Fri Aug 21 17:11:09 2015
New Revision: 245747
URL: http://llvm.org/viewvc/llvm-project?rev=245747&view=rev
Log:
XFAIL Tests that require C++ exceptions on Windows.
clang-cl does not yet support C++ exceptions, so these tests will
not even compile.
Re-enabling these tests is
Author: zturner
Date: Fri Aug 21 17:11:40 2015
New Revision: 245750
URL: http://llvm.org/viewvc/llvm-project?rev=245750&view=rev
Log:
Fix TestPaths on Windows.
Modified:
lldb/trunk/test/functionalities/paths/TestPaths.py
Modified: lldb/trunk/test/functionalities/paths/TestPaths.py
URL:
http
Author: zturner
Date: Fri Aug 21 17:11:50 2015
New Revision: 245751
URL: http://llvm.org/viewvc/llvm-project?rev=245751&view=rev
Log:
XFAIL pthreads test on Windows.
This test needs to be ported to c++ threads.
Modified:
lldb/trunk/test/functionalities/expr-doesnt-deadlock/TestExprDoesntBloc
Author: zturner
Date: Fri Aug 21 17:11:31 2015
New Revision: 245749
URL: http://llvm.org/viewvc/llvm-project?rev=245749&view=rev
Log:
XFAIL the last Windows test that calls a function in the target.
Modified:
lldb/trunk/test/lang/cpp/static_methods/TestCPPStaticMethods.py
Modified: lldb/trun
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Looks good. I'm guessing that at some point the RegisterContext and
ExceptionRecord stuff will be moved to Common?
http://reviews.llvm.org/D12252
___
Author: zturner
Date: Fri Aug 21 18:57:25 2015
New Revision: 245765
URL: http://llvm.org/viewvc/llvm-project?rev=245765&view=rev
Log:
Revert "Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD."
This reverts commit 7749a10ddbe22767d0e055753c674fcde7f28d39.
This commit introduce
Hi Stephane, I'm sorry but I had to revert this change. When I tested it
locally, I did it without running the full test suite, but when I did run
the full test suite it showed about 15-20 new test failures. I should have
caught this earlier by running the full test suite, so sorry about that.
I
By the way, I'm actively working on getting the test suite completely
running on a buildbot, but I need to get down to a green baseline first.
Still a few weeks out, but hopefully this type of thing will be caught
automatically in the future.
On Fri, Aug 21, 2015 at 5:00 PM Zachary Turner
2001 - 2100 of 3010 matches
Mail list logo
