Don't use an environment variable, add a command line flag to the script
instead
On Fri, Apr 15, 2016 at 3:27 PM Francis Ricci <fjri...@fb.com> wrote:
> fjricci added a comment.
>
> So I looked at `finishSwigPythonLLDB.py`, and it does look like that's
> where the bug is. This script sets the end of the symlink path with:
>
> strSrc = os.path.join("lib", "liblldb" + strLibFileExtn)
>
> Note here that "lib" is hardcoded, and doesn't use the
> `LLVM_LIBDIR_SUFFIX`, which is why the symlink is broken. The only way I
> can think of to communicate this suffix from cmake into python would be by
> having cmake set an environment variable (presumably with the same name).
> Does this seem reasonable, or do you think there's a better solution?
>
> The solution from `finish-swig-Python-LLDB.sh` would also probably work
> (enforcing that liblldb.so and python2.7/site-packages/lldb be in the same
> directory). That solution actually would be more consistent with the way
> the unit test suite works anyway. It does seem less flexible though.
>
>
> http://reviews.llvm.org/D19067
>
>
>
>
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
