zturner added inline comments.
================
Comment at: test/lldbtest.py:943
@@ -947,1 +942,3 @@
+def skipUnlessArch(archlist):
+ def myImpl(func):
----------------
chaoren wrote:
> Is there a reason
> ```
> return unittest2.skipUnless(getArchitecture() in archlist, ...)
> ```
> is not sufficient?
>
> Also, please add a doc string, like the other skip{If,Unless} methods.
`getArchitecture()` is a member of `self`, which is not defined here. TBH this
stuff is beyond my Python level, I tried simpler versions but this is how I
ultimately got it working after seeing what some of the other decorators did.
http://reviews.llvm.org/D12039
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
