zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Where did you get this version of Python? I don't see anything wrong with this
patch, but I'm a little curious what this + means
Repository:
rL LLVM
http://reviews.llvm.org/D15566
__
Author: zturner
Date: Mon Dec 28 16:09:29 2015
New Revision: 256526
URL: http://llvm.org/viewvc/llvm-project?rev=256526&view=rev
Log:
Update .clang-format file to support break after return type.
This depends on having a recently built version of clang-format
installed, as the patch to support th
zturner added inline comments.
Comment at: source/Plugins/Process/Windows/Live/ProcessWindowsLive.cpp:601-605
@@ -579,5 +600,7 @@
{
+// The thread hit a hard-coded breakpoint like an `int 3` or
`__debugbreak()`.
WINLOG_IFALL(WINDOWS_L
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Windows stuff looks good to me.
http://reviews.llvm.org/D15834
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/
Author: zturner
Date: Fri Jan 8 15:08:19 2016
New Revision: 257207
URL: http://llvm.org/viewvc/llvm-project?rev=257207&view=rev
Log:
Remove XFAIL from TestThreadStates on Windows.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py
Modified:
Author: zturner
Date: Fri Jan 8 15:08:24 2016
New Revision: 257208
URL: http://llvm.org/viewvc/llvm-project?rev=257208&view=rev
Log:
XFAIL 2 more tests based on SWIG version.
There's a bug in versions of SWIG prior to 3.0.8 that prevent
these tests from succeeding with Python 3.x
Modified:
Author: zturner
Date: Fri Jan 8 16:21:40 2016
New Revision: 257219
URL: http://llvm.org/viewvc/llvm-project?rev=257219&view=rev
Log:
Remove XFAIL from a few tests that have been fixed on Windows.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/language_cat
What's the extra frame? Why does Python have an effect on the number of
frames seen by the minidump? Something seems wrong about that.
On Fri, Jan 8, 2016 at 3:41 PM Adrian McCarthy wrote:
> amccarth created this revision.
> amccarth added a reviewer: zturner.
> amccarth added a subscriber: ll
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D16017#323550, @amccarth wrote:
> In http://reviews.llvm.org/D16017#322830, @zturner wrote:
>
> > What's the extra frame? Why does Python have an effect on the num
There's no test here.
On Mon, Jan 11, 2016 at 1:22 AM Bhushan Attarde via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> bhushan added a comment.
>
> Summary:
>
> Get the load address for the address given by 'symbol' and 'function'.
> Earlier, this was done for 'function' only, this patch
zturner added a subscriber: zturner.
zturner added a comment.
There's no test here.
Repository:
rL LLVM
http://reviews.llvm.org/D16049
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
Author: zturner
Date: Mon Jan 11 12:49:30 2016
New Revision: 257363
URL: http://llvm.org/viewvc/llvm-project?rev=257363&view=rev
Log:
Don't run dwo tests for windows targets.
-gsplit-dwarf is not implemented by clang on Windows. As such,
all the dwo tests are having the -gsplit-dwarf command lin
Author: zturner
Date: Mon Jan 11 16:16:12 2016
New Revision: 257397
URL: http://llvm.org/viewvc/llvm-project?rev=257397&view=rev
Log:
Introduce a PythonBytes class into PythonDataObjects.
This class behaves the same as PythonString on Python2, but differently
on Python3. Unittests are added as w
Author: zturner
Date: Mon Jan 11 16:16:17 2016
New Revision: 257398
URL: http://llvm.org/viewvc/llvm-project?rev=257398&view=rev
Log:
Fix Python 3 issues related to OS plugins.
* lldb::tid_t was being converted incorrectly, so this is updated to use
PythonInteger instead of manual Python Native A
Author: zturner
Date: Mon Jan 11 17:10:32 2016
New Revision: 257409
URL: http://llvm.org/viewvc/llvm-project?rev=257409&view=rev
Log:
Don't define Bytes and String to be the same number on Py2.
This is causing issues with case labels having the same value.
Modified:
lldb/trunk/source/Plugins
Author: zturner
Date: Tue Jan 12 14:45:29 2016
New Revision: 257513
URL: http://llvm.org/viewvc/llvm-project?rev=257513&view=rev
Log:
Fix TestThreadJump on Windows.
The system can create threads for a system threadpool, so there is
no guarantee that the thread that is stopped is thread 1. So use
This isn't going to work either, because Windows doesn't the name=
portion. God I really hate these tests that do substring matching.
I guess there's no easy way to guarantee that the main.cpp: is
on the same frame as the breakpoint. Can you change it to:
substrs = ['stopped',
'main.cpp:{}'
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
If this passes on your side, go ahead. Just from looking, I think it should
pass on Windows.
http://reviews.llvm.org/D16125
___
lldb-commits
zturner created this revision.
zturner added a reviewer: amccarth.
zturner added a subscriber: lldb-commits.
There were a number of problems preventing this from working:
1. The SWIG typemaps for converting Python lists to and from C++
arrays were not updated for Python 3. So they
zturner added a comment.
In the future when you update the diff of a review, you need to base the diff
against the original code, not against your first diff. So the new diff should
be a superset of your old diff.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1221-12
zturner added a comment.
Yea, supporting GetStdio is really difficult on Windows. We might try to do it
again someday. Putting it in a char[] variable and reading the variable seems
like a decent solution, I will try that.
There's lots of tests currently that redirect stdio, are those all bro
On Wed, Jan 13, 2016 at 10:15 AM Enrico Granata via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> +
> +class CommandScriptImmediateOutputTestCase (PExpectTest):
>
Does the bug that you were trying to fix occur only when using the
command_script.py file from the lldb command line? If you lo
On Wed, Jan 13, 2016 at 10:25 AM Enrico Granata wrote:
> On Jan 13, 2016, at 10:21 AM, Zachary Turner wrote:
>
>
> On Wed, Jan 13, 2016 at 10:15 AM Enrico Granata via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>> +
>> +class CommandScript
Thanks! btw would having the command write its output to a file instead of
stdout solve the pexpect problme as well?
On Wed, Jan 13, 2016 at 11:22 AM Enrico Granata wrote:
>
> On Jan 13, 2016, at 10:34 AM, Zachary Turner wrote:
>
>
>
> On Wed, Jan 13, 2016 at 10:25 AM Enric
zturner created this revision.
zturner added a reviewer: granata.enrico.
zturner added a subscriber: lldb-commits.
We already have char** typemaps and they are exact copy-pastes. No reason to
have both, I tested this and diffed the generated code and it doesn't seem to
be any different with thi
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
looks good, thanks
http://reviews.llvm.org/D16150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
zturner added a comment.
I just moved tid to the bottom because it was in the middle of the in, out, and
typecheck versions of the char** typemap. So I wanted to group them all
together.
Anyway, yea this didn't seem too controversial to me but I figured I'd throw it
up here for review in case
Author: zturner
Date: Wed Jan 13 15:22:00 2016
New Revision: 257671
URL: http://llvm.org/viewvc/llvm-project?rev=257671&view=rev
Log:
Fix some compiler warnings with MSVC 2015.
Modified:
lldb/trunk/source/DataFormatters/StringPrinter.cpp
lldb/trunk/source/Expression/ExpressionSourceCode.c
Author: zturner
Date: Wed Jan 13 15:21:49 2016
New Revision: 257669
URL: http://llvm.org/viewvc/llvm-project?rev=257669&view=rev
Log:
Fix TestProcessLaunch for Python 3.
There were a number of problems preventing this from working:
1. The SWIG typemaps for converting Python lists to and from C++
Author: zturner
Date: Wed Jan 13 15:21:54 2016
New Revision: 257670
URL: http://llvm.org/viewvc/llvm-project?rev=257670&view=rev
Log:
Get rid of const char** typemaps.
We already have char** typemaps which were near copy-pastes of
the const char** versions. This way we have only one version that
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257684: Rename MSVC top-level folder to avoid name
collision. (authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D16150?vs=44775&id=44787#toc
Repository:
rL LLVM
http://reviews.
Author: zturner
Date: Wed Jan 13 16:00:44 2016
New Revision: 257684
URL: http://llvm.org/viewvc/llvm-project?rev=257684&view=rev
Log:
Rename MSVC top-level folder to avoid name collision.
If you have two folders with the same name but different cases,
MSBuild gets confused and generates an error
Author: zturner
Date: Wed Jan 13 16:32:31 2016
New Revision: 257690
URL: http://llvm.org/viewvc/llvm-project?rev=257690&view=rev
Log:
Revert changes to TestProcessLaunch.py as they are breaking a build.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestPr
zturner added a comment.
In http://reviews.llvm.org/D16049#326634, @labath wrote:
> In http://reviews.llvm.org/D16049#326631, @bhushan wrote:
>
> > Hi Zachary,
> >
> > If we use @skipIf then the list would require to contain all possible MIPS
> > variations and the list will grow long.
> > for
t;> Hello Enrico,
>>>
>>> The new test has been failing on Ubuntu buildbot. But it's passing on
>>> some offline Ubuntu machines, I don't understand what caused the difference.
>>> Could you please help to take a look?
>>>
>>>
&g
g it.
>
> If you want to separate the two issues, then it would be fine to write
> another test that just tests the type maps for FILE *, but I still think
> this one is valuable.
>
> Jim
>
> > On Jan 14, 2016, at 10:16 AM, Zachary Turner via lldb-commits <
> lldb-
Author: zturner
Date: Thu Jan 14 13:14:02 2016
New Revision: 257788
URL: http://llvm.org/viewvc/llvm-project?rev=257788&view=rev
Log:
Resubmit the fixes for TestProcessLaunch.py.
I was calling the base class tearDown() function the wrong way
which for some reason is ok on Python 3 but not on Pyth
On Fri, Jan 15, 2016 at 11:57 AM Adrian McCarthy
wrote:
> amccarth created this revision.
> amccarth added a reviewer: zturner.
> amccarth added a subscriber: lldb-commits.
>
> Tested on Windows with Python 3.5.
>
> http://reviews.llvm.org/D16237
>
> Files:
> packages/Python/lldbsuite/test/logg
looks good
On Fri, Jan 15, 2016 at 12:44 PM Adrian McCarthy
wrote:
> amccarth updated this revision to Diff 45023.
> amccarth added a comment.
>
> Used the more explicit assertion methods.
>
>
> http://reviews.llvm.org/D16237
>
> Files:
> packages/Python/lldbsuite/test/logging/TestLogging.py
>
Author: zturner
Date: Fri Jan 15 16:22:40 2016
New Revision: 257946
URL: http://llvm.org/viewvc/llvm-project?rev=257946&view=rev
Log:
Fix TestDebugBreak.py.
We can't assume that the main thread of an inferior has index 0,
even in a single-threaded app.
Modified:
lldb/trunk/packages/Python/l
Author: zturner
Date: Fri Jan 15 16:22:35 2016
New Revision: 257945
URL: http://llvm.org/viewvc/llvm-project?rev=257945&view=rev
Log:
Fix ResourceWarning about unclosed file in use_lldb_suite_root.py.
Modified:
lldb/trunk/scripts/Python/use_lldb_suite.py
lldb/trunk/scripts/use_lldb_suite.
64-ubuntu-14.04-cmake/builds/10400
>
> If I replace lldb.eStopReasonException with lldb.eStopReasonSignal on
> my local machine, it works.
>
> On Fri, Jan 15, 2016 at 2:22 PM, Zachary Turner via lldb-commits
> wrote:
> > Author: zturner
> > Date: Fri Jan 15 16:22:40 20
Sure
On Fri, Jan 15, 2016 at 3:25 PM Siva Chandra wrote:
> SGTM. You want to do it?
>
> On Fri, Jan 15, 2016 at 3:24 PM, Zachary Turner
> wrote:
> > How about `lldb.eStopReasonException if osIsWindows() else
> > lldb.eStopReasonSignal`?
> >
> > Seem
Author: zturner
Date: Fri Jan 15 17:44:45 2016
New Revision: 257959
URL: http://llvm.org/viewvc/llvm-project?rev=257959&view=rev
Log:
On non-Windows platforms, asm int 3 generates an eStopReasonSignal.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/debugbreak/
zturner created this revision.
zturner added a reviewer: jingham.
zturner added a subscriber: lldb-commits.
Even in a single-threaded app, Windows will often create background threads on
startup and these threads can appear in any order with respect to the actual
main thread. So everywhere that
It's a holiday over here today, so i can't look at this until tomorrow.
On Mon, Jan 18, 2016 at 6:04 AM Pavel Labath wrote:
> labath added a comment.
>
> I don't quite know how windows linking works, so please give this a run to
> make sure it does not break anything for you.
>
>
> http://review
zturner added a comment.
Yea that seems like a good idea. I can do that in a followup.
Jim, does this patch look ok to you?
http://reviews.llvm.org/D16247
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
This is needed in order to prevent MSVC from warning about this case. I
explicitly added these last week. Can I ask that you revert this change?
On Tue, Jan 19, 2016 at 2:03 PM Davide Italiano via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: davide
> Date: Tue Jan 19 15:59:12 20
zturner updated this revision to Diff 45302.
zturner added a comment.
Fix incorrect usage of `get_threads_stopped_at_breakpoint` by adding a new
function that returns the first thread stopped at a breakpoint.
http://reviews.llvm.org/D16247
Files:
packages/Python/lldbsuite/test/expression_com
zturner added a comment.
Fixed that issue. The other issue you pointed out about using
`get_stopped_thread` sometimes is because in those tests breakpoints were
created using `runCmd` so we don't have an `SBBreakpoint` handy like we do in
the other cases.
http://reviews.llvm.org/D16247
__
:
return true;
default:
return false;
}
On Tue, Jan 19, 2016 at 2:10 PM Davide Italiano wrote:
> On Tue, Jan 19, 2016 at 2:08 PM, Davide Italiano
> wrote:
> > On Tue, Jan 19, 2016 at 2:05 PM, Zachary Turner
> wrote:
> >> This is needed
zturner added a comment.
Maybe I can give it an argument like `require_exactly_one_thread` which
defaults to True. That way at least you can still use the same function in the
case where you just want the first thread (which is how `get_stopped_thread`
works)
http://reviews.llvm.org/D16247
Should be fine. I probably don't need to try out the patch, it looks good
as is (and I'm not in a state where I can try it for a while)
On Tue, Jan 19, 2016 at 2:22 PM Davide Italiano wrote:
> On Tue, Jan 19, 2016 at 2:11 PM, Zachary Turner
> wrote:
> > What about th
zturner added a comment.
I don't think something has changed within lldb though, because jsut updating
lldb without updating llvm and clang also don't trigger this problem. I think
we should try to figure out what really broke.
http://reviews.llvm.org/D16334
___
zturner added a comment.
fwiw, `thread step-over` is *still* broken on Windows (because, well, fixing it
is kind of hard). So I'm not surprised that breaks (although I'm a little
surprised it worked in the first place). But at the same time this test
broken, about 15 other tests broke as well
zturner added a comment.
I get linker errors on Windows with this. The reason is that Windows doesn't
have getopt, but getopt is called from from Driver.cpp and linked into the main
lldb executable. Since liblldb is built as a shared library, when the keyword
is public it's linking the liblld
zturner added a comment.
FWIW, I think Adrian's original point is that testing the behavior of signed
types shouldn't depend on step over functionality. It's good practice in
general to make tests depend on as little debugger functionality as possibly to
reliably test the thing you want to tes
zturner added a comment.
In http://reviews.llvm.org/D16334#331338, @jingham wrote:
> I sort of agree with this and sort of don't. Formally, I agree with the
> notion of limited focused tests. But in practice it is often the noise in
> tests that catches bugs that we don't yet have tests for.
zturner added a comment.
For example, what if someone adds a test that uses a very small amount of
functionality but tests the thing it's supposed to test. Do we block the
change and say "please make this test more complicated, we want to test as much
stuff as possible"? Of course not. It's
zturner added a comment.
I don't know, I still disagree. If something in step-over breaks, I dont' want
to dig through a list of 30 other tests that have nothing to do with the
problem, only to find out 2 days later that the problem is actually in step
over. The only reason this helps is beca
On Wed, Jan 20, 2016 at 11:48 AM Zachary Turner wrote:
>
> If the problem is that people don't have the time because they've got too
> much other stuff on their plate, that's not a good excuse and I don't think
> we should intentionally encourage writing p
that isn't being used anywhere yet". But even that is still
testable. That's exactly what unit tests, mock implementations, and
dependency injection are for.
On Wed, Jan 20, 2016 at 11:57 AM Zachary Turner wrote:
> On Wed, Jan 20, 2016 at 11:48 AM Zachary Turner
> wrote:
&
zturner added a subscriber: zturner.
zturner added a comment.
Perhaps a middle ground to these two sides could be something along the
lines of "If you're going to make sweeping changes to remove a particular
feature from a set of tests, make sure there's a reasonable amount of
isolated coverage of
zturner added a comment.
In http://reviews.llvm.org/D16334#331420, @tberghammer wrote:
> In http://reviews.llvm.org/D16334#331368, @zturner wrote:
>
> > I don't know, I still disagree. If something in step-over breaks, I dont'
> > want to dig through a list of 30 other tests that have nothing t
zturner added a comment.
In http://reviews.llvm.org/D16334#331420, @tberghammer wrote:
> It is true that every CL can be tested but a lot of change is going in to
> address a specific edge case generated by a specific compiler in a strange
> situation. To create a reliable test from it we have
zturner added a comment.
Unfortunately that's not going to work. Because lldb libraries are not layered
very well, linking against any one library is going to cause a transitive link
dependency on every other library. I did a lot of work to improve that in
order to get the Python stuff separa
zturner added a comment.
Sure, an interface change to Process might break the mock, but it would break
at compile time, you just fix it up. It's not something that would happen
frequently, this is the same situation going on in LLVM where there are unit
tests, sometimes they break, and people
zturner added a reviewer: clayborg.
zturner added a comment.
looks fine to me, but some Apple targets use PE, so +greg in case he can think
of a reason why this will mess up something on the Apple side.
http://reviews.llvm.org/D16415
___
lldb-commi
it does is pollute failure logs. Fuzziness is better tested by fuzz
tests.
On Thu, Jan 21, 2016 at 11:46 AM Jim Ingham wrote:
>
> > On Jan 21, 2016, at 10:17 AM, Zachary Turner wrote:
> >
> > zturner added a comment.
> >
> > Sure, an interface change to Process mi
zturner added a comment.
Right, but I don't agree in this case that "different" has to mean "we
discourage the use of reduced test cases". I have a hard time imagining a
scenario where not having reduced test cases is an advantage. It's also
easy to explain to people. "Write reduced test cases"
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258432: Remove assumptions that thread 0 is always the main
thread. (authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D16247?vs=45302&id=45587#toc
Repository:
rL LLVM
http://re
Author: zturner
Date: Thu Jan 21 15:07:30 2016
New Revision: 258432
URL: http://llvm.org/viewvc/llvm-project?rev=258432&view=rev
Log:
Remove assumptions that thread 0 is always the main thread.
Starting with Windows 10, the Windows loader is itself multi-threaded,
meaning that the loader spins up
gt; I am also not against writing more focused tests when that is
> appropriate. But I am also pretty sure formal considerations are unlikely
> to outweigh this pretty consistent experience of writing tests for
> debuggers.
>
> Jim
>
> > On Jan 21, 2016, at 11:54 AM, Zachary Turner vi
zturner created this revision.
zturner added a reviewer: gkistanova.
zturner added a subscriber: lldb-commits.
x86 builds of libclang.dll are failing with out of memory errors (Example:
http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc/builds/14604). This
patch is a global change against
Author: zturner
Date: Fri Jan 22 17:54:41 2016
New Revision: 258586
URL: http://llvm.org/viewvc/llvm-project?rev=258586&view=rev
Log:
More fixes related to counting threads on Windows.
The Windows 10 loader spawns threads at startup, so
tests which count threads or assume that a given user
thread
Author: zturner
Date: Fri Jan 22 17:54:45 2016
New Revision: 258587
URL: http://llvm.org/viewvc/llvm-project?rev=258587&view=rev
Log:
Un xfail TestSettings.test_run_args_and_env_vars_with_dwarf
Modified:
lldb/trunk/packages/Python/lldbsuite/test/settings/TestSettings.py
Modified: lldb/trunk/
Author: zturner
Date: Fri Jan 22 17:54:49 2016
New Revision: 258588
URL: http://llvm.org/viewvc/llvm-project?rev=258588&view=rev
Log:
Decode files with UTF-8 in lldbutil.line_number.
Since Unicode support is different in Py2 and Py3, Py3 was throwing
exceptions about being unable to decode the fi
Yea, that's a good idea. Thanks for the suggestion
On Fri, Jan 22, 2016 at 4:05 PM Jim Ingham wrote:
> Would you mind adding a comment telling people how to do this correctly to
> the "Writing test cases" section of the README-testsuite?
>
> Jim
>
> >
n multiple
threads are involved as opposed to just the main thread)
On Fri, Jan 22, 2016 at 4:10 PM Zachary Turner wrote:
> Yea, that's a good idea. Thanks for the suggestion
>
> On Fri, Jan 22, 2016 at 4:05 PM Jim Ingham wrote:
>
>> Would you mind adding a comment telling peop
Author: zturner
Date: Fri Jan 22 18:49:11 2016
New Revision: 258592
URL: http://llvm.org/viewvc/llvm-project?rev=258592&view=rev
Log:
Fix missing function argument passthrough.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py
Modified: lldb/trunk/packages/Python/lldbsuite/test
What is this fixing and how can we write a test for it?
On Sat, Jan 23, 2016 at 2:40 AM Mohit K. Bhakkad via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: mohit.bhakkad
> Date: Sat Jan 23 04:36:06 2016
> New Revision: 258621
>
> URL: http://llvm.org/viewvc/llvm-project?rev=258621&v
Also various other formatting problems. Please run clang-format in the
future.
Steps to running clang-format
1. Compile it with "ninja clang-format"
2. Add your bin directory to PATH
3. Stage your changes with git add as you normally do
4. Run "git clang-format"
On Mon, Jan 25, 2016 at 11:51 AM
zturner added a subscriber: zturner.
zturner added a comment.
Also various other formatting problems. Please run clang-format in the
future.
Steps to running clang-format
1. Compile it with "ninja clang-format"
2. Add your bin directory to PATH
3. Stage your changes with git add as you normally
Author: zturner
Date: Mon Jan 25 17:21:09 2016
New Revision: 258741
URL: http://llvm.org/viewvc/llvm-project?rev=258741&view=rev
Log:
Fix swig typemap for SBEvent.
This needs to be able to handle bytes, strings, and bytearray objects.
In Python 2 this was easy because bytes and strings are the sa
Author: zturner
Date: Mon Jan 25 17:21:13 2016
New Revision: 258742
URL: http://llvm.org/viewvc/llvm-project?rev=258742&view=rev
Log:
Fix more occurrences of string/bytes/bytearray in swig typemaps.
Modified:
lldb/trunk/scripts/Python/python-typemaps.swig
Modified: lldb/trunk/scripts/Python/
Author: zturner
Date: Mon Jan 25 17:21:18 2016
New Revision: 258743
URL: http://llvm.org/viewvc/llvm-project?rev=258743&view=rev
Log:
Fix some issues with bytes and strings in Python 3.
SBProcess::ReadMemory and other related functions such as
WriteMemory are returning Python string() objects. T
Author: zturner
Date: Mon Jan 25 18:07:09 2016
New Revision: 258751
URL: http://llvm.org/viewvc/llvm-project?rev=258751&view=rev
Log:
Fix TestSyntheticCapping for Python 3.
In Python 3, whitespace inconsistences are errors. This synthetic
provider had mixed tabs and spaces, as well as inconsiste
zturner added inline comments.
Comment at: include/lldb/Core/RangeMap.h:1230
@@ -1229,3 +1229,3 @@
typename Collection::const_iterator pos;
-for(pos = m_entries.begin(); pos != m_entries.end(); pos++)
+for (pos = m_entries.begin();
zturner added inline comments.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:183
@@ +182,3 @@
+}
+return lldb::eSymbolTypeInvalid;
+}
amccarth wrote:
> zturner wrote:
> > Instead of returning `eSymbolTypeInvalid` here, how about
> > `e
Author: zturner
Date: Mon Jan 25 18:59:42 2016
New Revision: 258759
URL: http://llvm.org/viewvc/llvm-project?rev=258759&view=rev
Log:
Write the session log file in UTF-8.
Previously we were writing in the default encoding, which depends
on the operating system and is not guaranteed to be unicode
Author: zturner
Date: Mon Jan 25 19:09:38 2016
New Revision: 258761
URL: http://llvm.org/viewvc/llvm-project?rev=258761&view=rev
Log:
Remove XFAIL Windows from a test that was fixed by r258758.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/python_api/function_symbol/TestSymbolAPI.py
M
Author: zturner
Date: Mon Jan 25 19:19:50 2016
New Revision: 258764
URL: http://llvm.org/viewvc/llvm-project?rev=258764&view=rev
Log:
Fix TestRerun.py on Windows.
This is another example of a test that was looking for the thread
at index 0 instead of requesting the thread that was stopped at
the
Sorry for the delay, lgtm
On Tue, Jan 26, 2016 at 1:59 AM Pavel Labath wrote:
> labath added a comment.
>
> Ping?
>
>
> http://reviews.llvm.org/D16293
>
>
>
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
zturner added a comment.
Sorry for the delay, lgtm
http://reviews.llvm.org/D16293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner created this revision.
zturner added reviewers: tfiala, labath.
zturner added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
This is going to be part of a larger effort to clean up some of these
decorators as the code is getting really unwieldy and
zturner updated this revision to Diff 46086.
zturner added a comment.
Add back the check for `six.callable`. Also added a detailed comment
explaining what this atrocity actually does.
Note that this problem will go away by design once we reduce some of the more
superfluous decorators.
http:/
d with arguments.
On Wed, Jan 27, 2016 at 8:31 AM Todd Fiala wrote:
> On Tue, Jan 26, 2016 at 5:43 PM, Zachary Turner
> wrote:
>
>> zturner updated this revision to Diff 46086.
>> zturner added a comment.
>>
>> Add back the check for `six.callable`. Also add
zturner added a subscriber: zturner.
zturner added a comment.
Yea so basically what it does is allow you to use the same decorator with
arguments or without arguments. Like this:
@expectedFailureWindows # Python actually calls
expectedFailureWindows(func)
@expectedFailureWindows(debug_info='dw
Yea I think this is fine.
On Wed, Jan 27, 2016 at 9:29 AM Hans Wennborg wrote:
> Zach is the lldb cmake owner. Zach, does this seem OK for 3.8?
>
> On Wed, Jan 27, 2016 at 7:13 AM, Pavel Labath wrote:
> > Hi,
> >
> > could we get this patch applied to the 3.8 branch?
> >
> > thanks,
> > pl
> >
Just a heads up, `isinstance(foo, basestring)` doesn't work in Python 3.
You need to use `isinstance(foo, six.string_types)`. I'm checking in a fix
for this, but just wanted to let you know so you can keep this in the back
of your head for future.
On Wed, Jan 27, 2016 at 2:20 AM Bhushan D. Attard
1601 - 1700 of 3010 matches
Mail list logo
