[Lldb-commits] [PATCH] D50304: [lldb] CommandObjectThreadUntil should set breakpoint at either on exact or the nearest subsequent line number but not on all the subsequent line numbers

ramana-nvr added a comment. I do not have the commit permission. Could someone help commit this patch? https://reviews.llvm.org/D50304 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [PATCH] D50304: [lldb] CommandObjectThreadUntil should set breakpoint at either on exact or the nearest subsequent line number but not on all the subsequent line numbers

ramana-nvr created this revision. ramana-nvr added a reviewer: jingham. The requirements for "thread until " are: a) If any code contributed by or the nearest subsequent of is executed before leaving the function, stop b) If you end up leaving the function w/o triggering (a), then stop In case

[Lldb-commits] [PATCH] D50304: [lldb] CommandObjectThreadUntil should set breakpoint at either on exact or the nearest subsequent line number but not on all the subsequent line numbers

ramana-nvr updated this revision to Diff 159517. ramana-nvr added a comment. Yes, updated the patch accordingly. https://reviews.llvm.org/D50304 Files: source/Commands/CommandObjectThread.cpp Index: source/Commands/CommandObjectThread.cpp

[Lldb-commits] [PATCH] D48704: [LLDB] Fix for "Bug 37950: ExecutionContext::GetByteOrder() always returns endian::InlHostByteOrder()"

ramana-nvr added a comment. Sorry, I don't have a test case for this and I am yet to understand lldb test suite to create one. Repository: rLLDB LLDB https://reviews.llvm.org/D48704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu created this revision. Herald added subscribers: luismarques, s.egerton, PkmX, simoncook, arichardson. Herald added a project: All. RamNalamothu requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, wangpc. Herald added projects: LLDB, LLVM. Since th

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu updated this revision to Diff 543406. RamNalamothu added a comment. Refer to the commit which added symbolize operands feature in llvm-objdump. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ https://reviews.llvm.org/D156086

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu marked an inline comment as done. RamNalamothu added inline comments. Comment at: llvm/include/llvm/MC/MCInstrAnalysis.h:80 + } + /// Returns true if at least one of the register writes performed by DavidSpickett wrote: > Does this have test cove

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu added a comment. In D156086#4529791 , @jasonmolenda wrote: > I'm not super familiar with the MCInst class from llvm, and hadn't heard of > MCInstrAnalysis. I was looking through the llvm targets - are these > MCInstrAnalysis primitives go

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu added a comment. In D156086#4536992 , @jasonmolenda wrote: > In D156086#4530507 , @RamNalamothu > wrote: > >> In D156086#4529791 , @jasonmolenda >> wrote:

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu updated this revision to Diff 545753. RamNalamothu added a comment. Add lldb test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ https://reviews.llvm.org/D156086 Files: lldb/source/Plugins/Disassembler/LLVMC/Disassembler

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu updated this revision to Diff 546173. RamNalamothu added a comment. Herald added subscribers: luke, frasercrmck, sameer.abuasal, Jim, jocewei, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, johnrusso, rbar. Added RISC-V specific test whic

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu updated this revision to Diff 546177. RamNalamothu added a comment. Fix RISC-V test name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ https://reviews.llvm.org/D156086 Files: lldb/source/Plugins/Disassembler/LLVMC/Disas

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu updated this revision to Diff 546297. RamNalamothu added a comment. Oops. Didn't notice the changed formatting of the comment after git-clang-format. Fixed the format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ h

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu updated this revision to Diff 546306. RamNalamothu added a comment. Remove left overs of copy-paste. Apologies for so many updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ https://reviews.llvm.org/D156086 Files: ll

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu updated this revision to Diff 546688. RamNalamothu added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ https://reviews.llvm.org/D156086 Files: lldb/source/Plugins/Disassembler/LLVMC/Di

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu marked 3 inline comments as done. RamNalamothu added a comment. Thanks for the comments @MaskRay. Comment at: lldb/unittests/Disassembler/RISCV/TestMCDisasmInstanceRISCV.cpp:23 + +class TestMCDisasmInstanceRISCV : public testing::Test { +public: Ma

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu marked an inline comment as done. RamNalamothu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ https://reviews.llvm.org/D156086 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu added a comment. I think I have addressed all the review feedback. Ok to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ https://reviews.llvm.org/D156086 ___ lldb-commits mai

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu added a comment. Thank you @jasonmolenda. If there are no further comments on llvm side, I will land this in a couple of days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ https://reviews.llvm.org/D156086 __

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG254a31273a27: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin (authored by RamNalamothu). Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D158971: [lldb][NFC] Put disassembler test classes and methods in anonymous namespace

RamNalamothu created this revision. RamNalamothu added reviewers: DavidSpickett, MaskRay. Herald added subscribers: luke, sunshaoce, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, s

[Lldb-commits] [PATCH] D158971: [lldb][NFC] Put disassembler test classes and methods in anonymous namespace

RamNalamothu added a comment. In D158971#4624001 , @DavidSpickett wrote: > And this is being done for what reason? This is a follow-up on https://reviews.llvm.org/D156086#inline-1518306 comment. I see that most of the lldb unit tests follow this style.

[Lldb-commits] [PATCH] D158971: [lldb][NFC] Put disassembler test classes and methods in anonymous namespace

RamNalamothu updated this revision to Diff 555271. RamNalamothu added a comment. Update commit message to refer to anonymous namespace guideline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158971/new/ https://reviews.llvm.org/D158971 Files: l

[Lldb-commits] [PATCH] D158971: [lldb][NFC] Put disassembler test classes and methods in anonymous namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rGdfa8a15d7886: [lldb][NFC] Put disassembler test classes and methods in anonymous namespace (authored by RamNalamothu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D158971: [lldb][NFC] Put disassembler test classes and methods in anonymous namespace

RamNalamothu added a comment. In D158971#4633434 , @RamNalamothu wrote: > Update commit message to refer to anonymous namespace guideline. Ah, seems like I have messed up with an arcanist option and the commit message update didn't get picked here/in t

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. @jingham Sorry for spamming. But I am not sure if you have received my previous messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50304/new/ https://reviews.llvm.org/D50304 _

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. Thank you. In D50304#3608740 , @jingham wrote: > In D50304#3592849 , @RamNalamothu > wrote: > >> In D50304#3586710 , @jingham wrote: >> >>> Fo

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

This revision was automatically updated to reflect the committed changes. Closed by commit rGa57b62deef37: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers (authored by RamNalamothu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. In D50304#3611390 , @goncharov wrote: > FYI this caused a test breakage at lldb-aarch64-ubuntu, > https://lab.llvm.org/buildbot/#/builders/96/builds/25128. I have reverted > this in fe6db8d03ff16a65f57af24d2cb04f489e2e9b0c

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu updated this revision to Diff 441726. RamNalamothu added a comment. Make the test case insensitive to compiler optimizations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50304/new/ https://reviews.llvm.org/D50304 Files: lldb/sourc

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50304/new/ https://reviews.llvm.org/D50304 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. In D50304#3641971 , @DavidSpickett wrote: >> then we may need to find someone with an arm machine. > > I tried this patch on AArch64 and did not get any new failures. You can go > ahead and reland. If there's still issues I

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

This revision was automatically updated to reflect the committed changes. Closed by commit rG419cc0a0b2ab: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers (authored by RamNalamothu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

RamNalamothu added a subscriber: labath. RamNalamothu added a comment. @jingham @labath I have tried to add a test but it's becoming difficult for me to come-up with a failing test scenario. Is it okay to commit this without a test? Otherwise, I could add the following or error capturing dif

[Lldb-commits] [PATCH] D126596: [lldb, test] Fix typos in the lldb tests

RamNalamothu created this revision. RamNalamothu added reviewers: jingham, labath. Herald added a subscriber: wenlei. Herald added a project: All. RamNalamothu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D126596: [lldb, test] Fix typos in the lldb tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6ad6901734f: [lldb, test] Fix typos in the lldb tests (authored by RamNalamothu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126596/new/ https://review

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu updated this revision to Diff 433784. RamNalamothu retitled this revision from "[lldb] CommandObjectThreadUntil should set breakpoint at either on exact or the nearest subsequent line number but not on all the subsequent line numbers" to "[lldb] Fix thread step until to not set brea

[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

RamNalamothu updated this revision to Diff 433966. RamNalamothu added a comment. Herald added a project: LLDB. Went ahead and added the error capturing for setting incorrect thread id and also the fix. Without the following change/fix diff --git a/lldb/source/Commands/CommandObjectThread.cpp

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. Does this look good now to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50304/new/ https://reviews.llvm.org/D50304 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

RamNalamothu added a comment. Does this look good now to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48865/new/ https://reviews.llvm.org/D48865 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50304/new/ https://reviews.llvm.org/D50304 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

RamNalamothu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48865/new/ https://reviews.llvm.org/D48865 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. Herald added a subscriber: Michael137. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50304/new/ https://reviews.llvm.org/D50304 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

RamNalamothu added a comment. Herald added a subscriber: Michael137. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48865/new/ https://reviews.llvm.org/D48865 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

This revision was automatically updated to reflect the committed changes. Closed by commit rGab7fcf24849d: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID (authored by RamNalamothu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. @jingham looks like you missed to notice this one as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50304/new/ https://reviews.llvm.org/D50304 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. In D50304#3586710 , @jingham wrote: > For some reason I'm not getting mail notifications for review changes, sorry > about that. > > This is certainly better than the original implementation. Among other > things, if we fin

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50304/new/ https://reviews.llvm.org/D50304 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

RamNalamothu created this revision. RamNalamothu added reviewers: JDevlieghere, teemperor, DavidSpickett, zturner. RamNalamothu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Certain commands like 'memory write', 'register read' etc all us

[Lldb-commits] [PATCH] D114544: [lldb] Fix 'memory write' to not allow specifying values when writing file contents

RamNalamothu created this revision. RamNalamothu added reviewers: JDevlieghere, DavidSpickett, zturner, teemperor. RamNalamothu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently the 'memory write' command allows specifying the value

[Lldb-commits] [PATCH] D114544: [lldb] Fix 'memory write' to not allow specifying values when writing file contents

RamNalamothu updated this revision to Diff 389821. RamNalamothu added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114544/new/ https://reviews.llvm.org/D114544 Files: lldb/source/Commands/CommandObjectMemory.

[Lldb-commits] [PATCH] D114544: [lldb] Fix 'memory write' to not allow specifying values when writing file contents

RamNalamothu marked 6 inline comments as done. RamNalamothu added a comment. Thanks for the comments. I wasn't familiar with the Pyhton test infrastructure so I took the files from `commands/memory/read` and updated as needed here. All the comments etc came from that. I think I addressed all t

[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

RamNalamothu added a comment. In D114448#3150900 , @DavidSpickett wrote: > Not sure if you're a regular contributor and already know this but in case > not, I tend to use > https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting > f

[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

RamNalamothu updated this revision to Diff 389884. RamNalamothu edited the summary of this revision. RamNalamothu added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114448/new/ https://reviews.llvm.org/D114448

[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

RamNalamothu updated this revision to Diff 389927. RamNalamothu added a comment. Remove the unnecessary `if {}` gaurding around range for loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114448/new/ https://reviews.llvm.org/D114448 Files: lld

[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

RamNalamothu added inline comments. Comment at: lldb/source/Interpreter/OptionGroupFormat.cpp:66 + 0, + eArgTypeCount, + "The number of total items to display."}, DavidSpickett wrote: > RamNalamothu wrote: > > DavidSpickett wrote: >

[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

RamNalamothu updated this revision to Diff 390022. RamNalamothu added a comment. Re-use the existing constexpr option table. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114448/new/ https://reviews.llvm.org/D114448 Files: lldb/include/lldb/Inte

[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f05ff8be481: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command (authored by ramana-nvr, committed by RamNalamothu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION