Ping.
On Tue, 19 Jun 2018 at 16:04, Pavel Labath wrote:
>
> A test?
>
> It looks like it should be possible to test this in a similar way to
> other CommandCompletion tests
> (unittests/Interpreter/TestCompletion.cpp).
> On Mon, 18 Jun 2018 at 21:16, Raphael Isemann via lldb-commits
> wrote:
> >
Author: labath
Date: Thu Jun 28 03:03:42 2018
New Revision: 335822
URL: http://llvm.org/viewvc/llvm-project?rev=335822&view=rev
Log:
Retrieve a function PDB symbol correctly from nested blocks
Summary:
This patch fixes a problem with retrieving a function symbol by an
address in a nested block. I
Author: labath
Date: Thu Jun 28 07:23:04 2018
New Revision: 335859
URL: http://llvm.org/viewvc/llvm-project?rev=335859&view=rev
Log:
Skip core file tests on build configurations lacking necessary components
Summary:
To successfully open a core file, we need to have LLVM built with
support for the
Author: labath
Date: Fri Jun 29 02:06:42 2018
New Revision: 335955
URL: http://llvm.org/viewvc/llvm-project?rev=335955&view=rev
Log:
Modernize completion tests
Now that we have gmock, we can use its matchers to better express the
test assertions. The main advantage of this is that when things fai
Author: labath
Date: Fri Jun 29 02:22:07 2018
New Revision: 335956
URL: http://llvm.org/viewvc/llvm-project?rev=335956&view=rev
Log:
Fix TestLoadUsingPaths on linux
we need to explicitly link the test program with -ldl for the dlopen
function to be available.
Modified:
lldb/trunk/packages/P
Author: labath
Date: Fri Jun 29 03:27:18 2018
New Revision: 335960
URL: http://llvm.org/viewvc/llvm-project?rev=335960&view=rev
Log:
Fix use-after-free in CommandCompletions.cpp
The code was creating a StringRef to a temporary std::string. The
solution is to just drop the .str() from the original
Author: labath
Date: Fri Jun 29 04:20:29 2018
New Revision: 335963
URL: http://llvm.org/viewvc/llvm-project?rev=335963&view=rev
Log:
UUID: Add support for arbitrary-sized module IDs
Summary:
The data structure is optimized for the case where the UUID size is <=
20 bytes (standard length emitted b
Author: labath
Date: Fri Jun 29 05:15:54 2018
New Revision: 335967
URL: http://llvm.org/viewvc/llvm-project?rev=335967&view=rev
Log:
Add a test for reading lld-generated build-ids
Summary:
This test makes sure we are able to read the shorter build-ids which are
generated by lld.
To make this wor
On Fri, 13 Jul 2018 at 18:36, Jim Ingham via lldb-commits
wrote:
>
> There's code in the ThreadHandler to handle systems with short thread names.
> If that isn't producing readable names, we should fix it there. A better
> algorithm might be to drop the leading "lldb" and then instead of trunc
Author: labath
Date: Mon Jul 16 07:37:58 2018
New Revision: 337173
URL: http://llvm.org/viewvc/llvm-project?rev=337173&view=rev
Log:
Fix TestDataFormatterUnordered for older libc++ versions
clang recently started diagnosing "exception specification in
declaration does not match previous declarati
Author: labath
Date: Mon Jul 16 09:18:52 2018
New Revision: 337188
URL: http://llvm.org/viewvc/llvm-project?rev=337188&view=rev
Log:
Fix typo in find-basic-function test
Wrong FileCheck header meant that we were not matching what we should.
This allows us to get rid of the -allow-deprecated-dag-
Ok, I see what you mean now.
Looking at the other core file plugins (elf, mach-o), it looks like
they do only very basic verification before the accept the file. The
pretty much just check the magic numbers, which would be more-or-less
equivalent to our `MinidumpHeader::Parse` call. As this does n
On Thu, 19 Jul 2018 at 10:04, Aleksandr Urakov via Phabricator
wrote:
> So peoples who commited such spaces found them beautiful (or used the
> approved formatting style, or used them for some special formatting cases),
Or it's simply a typo.
I don't want to make a bigger fuss of this than it a
I knew I should have stayed quiet :P, but now that I am in, here's my reasoning:
> - For eight years (the spaces were commited in 2010) some tests may have
> relied on these spaces. It's a good case - we can run tests and see it;
For seven of those eight years we haven't been using this function
Author: labath
Date: Thu Jul 19 06:30:56 2018
New Revision: 337452
URL: http://llvm.org/viewvc/llvm-project?rev=337452&view=rev
Log:
Fix whitespace formatting in DWARFExpression::DumpLocation
we were printing an extra space before the start for the expression and
an extra space after some dwarf o
Thanks.
I agree you're not in the best position to make these kinds of changes
(and I don't think I would have asked you to do them). In fact, I was
already considering just changing that function myself, so I went
ahead and did that now in r337452. As far as I can tell, no tests need
to be update
Author: labath
Date: Thu Jul 19 07:38:30 2018
New Revision: 337459
URL: http://llvm.org/viewvc/llvm-project?rev=337459&view=rev
Log:
ELF: Replace the header-extension unit test with a lit one
The new test checks that we are actually able to read data from these
kinds of elf headers correctly inst
Well, if it depends on everything, then it can only used from places
that also depend on everything. Right now I don't think it matters now
(though it will create a new Dump <-> "everything calling Dump"
cycle). However, I can imagine this might cause some tricky situations
later on when we try to
This is the current list of files (after this patch) that call
DumpDataExtractor or DumpRegisterValue
source/API/SBData.cpp
source/Commands/CommandObjectMemory.cpp
source/Commands/CommandObjectRegister.cpp
source/Core/Address.cpp
source/Core/EmulateInstruction.cpp
source/Core/Event.cpp
source/Core
Author: labath
Date: Tue Jul 24 03:49:14 2018
New Revision: 337819
URL: http://llvm.org/viewvc/llvm-project?rev=337819&view=rev
Log:
Reimplement EventDataBytes::Dump to avoid DumpDataExtractor
This is the only external non-trivial dependency of the Event classes.
Added:
lldb/trunk/unittests/
Author: labath
Date: Tue Jul 24 08:48:13 2018
New Revision: 337832
URL: http://llvm.org/viewvc/llvm-project?rev=337832&view=rev
Log:
Move dumping code out of RegisterValue class
Summary:
The dump function was the only part of this class which depended on
high-level functionality. This was due to
On Tue, 24 Jul 2018 at 17:17, Leonard Mosescu wrote:
>>
>> The problem is that shared libraries differ on these machines and
>> LLDB either fails to load some libraries or loads wrong ones.
>
>
> Not finding the modules is not surprising but the latter (loading the wrong
> modules) is a bit conce
Author: labath
Date: Wed Jul 25 04:35:28 2018
New Revision: 337908
URL: http://llvm.org/viewvc/llvm-project?rev=337908&view=rev
Log:
Fix PythonString::GetString for >=python-3.7
The return value of PyUnicode_AsUTF8AndSize is now "const char *".
Thanks to Brett Neumeier for testing the patch out
Author: labath
Date: Fri Aug 3 01:47:22 2018
New Revision: 338828
URL: http://llvm.org/viewvc/llvm-project?rev=338828&view=rev
Log:
Revert "Add support for ARM and ARM64 breakpad generated minidump files"
This reverts commit r338734 (and subsequent fixups in r338772 and
r338746), because it brea
I've reverted this to keep the bots green until the issues pointed out
by Stella and Raphael are resolved.
Based on a quick inspection, it seems that the test issue is that
`GetSystemInfo` call that has been added to MinidumpParser::Initialize
is failing. I guess that's because the hand-crafted(?)
Author: labath
Date: Tue Aug 7 05:16:49 2018
New Revision: 339130
URL: http://llvm.org/viewvc/llvm-project?rev=339130&view=rev
Log:
Fix a couple of extended-offsetof warnings that had slipped through
Modified:
lldb/trunk/source/Plugins/Process/minidump/RegisterContextMinidump_ARM64.cpp
Modi
Author: labath
Date: Tue Aug 7 06:10:16 2018
New Revision: 339136
URL: http://llvm.org/viewvc/llvm-project?rev=339136&view=rev
Log:
Move ScalarTest to follow the class being tested
This should have been a part of r339127, but I missed it somehow.
Added:
lldb/trunk/unittests/Utility/ScalarTe
On 20/08/18 08:17, Davide Italiano via lldb-commits wrote:
> On Fri, Aug 17, 2018 at 2:36 AM Stephane Sezer via lldb-commits
> wrote:
>>
>> Author: sas
>> Date: Thu Aug 16 17:35:47 2018
>> New Revision: 339974
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=339974&view=rev
>> Log:
>> Add a relo
Author: labath
Date: Tue Aug 28 09:32:46 2018
New Revision: 340841
URL: http://llvm.org/viewvc/llvm-project?rev=340841&view=rev
Log:
Respect platform sysroot when loading core files
Patch by Eugene Birukov
Differential Revision: https://reviews.llvm.org/D49685
Modified:
lldb/trunk/packages
Author: labath
Date: Thu Aug 30 12:14:02 2018
New Revision: 341096
URL: http://llvm.org/viewvc/llvm-project?rev=341096&view=rev
Log:
Fix deadlock in gdb-client tests
Using a listen queue of length 0 caused a deadlock on my machine in the
gdb-client tests while attempting to establish the loopback
Author: labath
Date: Thu Aug 30 22:18:11 2018
New Revision: 341163
URL: http://llvm.org/viewvc/llvm-project?rev=341163&view=rev
Log:
Silence some "control reaches end of non-void function" warnings with gcc
Modified:
lldb/trunk/source/Core/Mangled.cpp
lldb/trunk/source/Core/RichManglingCo
Author: labath
Date: Thu Aug 30 22:34:03 2018
New Revision: 341164
URL: http://llvm.org/viewvc/llvm-project?rev=341164&view=rev
Log:
Increase qHostInfo packet timeout
Host info computation can involve DNS traffic (to compute the remote
host name). On very unreliable networks (such as free WiFi on
Author: labath
Date: Thu Aug 30 23:01:02 2018
New Revision: 341167
URL: http://llvm.org/viewvc/llvm-project?rev=341167&view=rev
Log:
Fix a typo in mac SIP workaround
presumably the or subexpression was meant to be evaluated first. The way
it is now means that we apply the workaround for any pytho
Author: labath
Date: Fri Aug 31 01:31:27 2018
New Revision: 341186
URL: http://llvm.org/viewvc/llvm-project?rev=341186&view=rev
Log:
XFail one more VSCode test which fails under heavy load
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setFunction
Author: labath
Date: Fri Aug 31 11:25:01 2018
New Revision: 341235
URL: http://llvm.org/viewvc/llvm-project?rev=341235&view=rev
Log:
Avoid using short identifiers in some tests
This applies the same workaround as r321271 to other tests. The root
problem is that lldb finds an internal symbol with
Author: labath
Date: Sat Sep 1 05:15:46 2018
New Revision: 341274
URL: http://llvm.org/viewvc/llvm-project?rev=341274&view=rev
Log:
Ignore unicode decode errors in test suite's encoded_file class
These happen in a couple of tests when lldb tries to pretty print a
const char * variable in the inf
Author: labath
Date: Wed Sep 5 11:08:56 2018
New Revision: 341487
URL: http://llvm.org/viewvc/llvm-project?rev=341487&view=rev
Log:
Modernize NativeProcessProtocol::GetSoftwareBreakpointTrapOpcode
return the opcode as a Expected instead of a
Status+pointer+size combo.
I also move the linux impl
Author: labath
Date: Sat Sep 8 03:33:14 2018
New Revision: 341747
URL: http://llvm.org/viewvc/llvm-project?rev=341747&view=rev
Log:
Revert "Modernize NativeProcessProtocol::GetSoftwareBreakpointTrapOpcode"
This reverts commit r341487. Jan Kratochvil reports it breaks LLDB when
compiling with cla
Author: labath
Date: Sat Sep 8 23:01:12 2018
New Revision: 341758
URL: http://llvm.org/viewvc/llvm-project?rev=341758&view=rev
Log:
Re-commit "Modernize NativeProcessProtocol::GetSoftwareBreakpointTrapOpcode"
This recommits r341487, which was reverted due to failing tests with
clang. It turned o
Author: labath
Date: Sun Sep 9 01:42:00 2018
New Revision: 341759
URL: http://llvm.org/viewvc/llvm-project?rev=341759&view=rev
Log:
Speculative fix for NetBSD bot for r341758
Modified:
lldb/trunk/source/Host/common/NativeProcessProtocol.cpp
lldb/trunk/source/Plugins/Process/Linux/NativeP
Author: labath
Date: Wed Sep 12 01:50:08 2018
New Revision: 342029
URL: http://llvm.org/viewvc/llvm-project?rev=342029&view=rev
Log:
Reduce alignment on struct XSAVE, fixing a gcc warning
The warning is about heap-allocating a struct with bigger alignment
requirements than the standard heap alloc
Author: labath
Date: Wed Sep 12 05:26:05 2018
New Revision: 342050
URL: http://llvm.org/viewvc/llvm-project?rev=342050&view=rev
Log:
Move SafeMachO from Utility to Host
Summary:
One of the conclusions of the discussion on D49740 was that SafeMachO is better
off in the Host module (as that's the o
Author: labath
Date: Wed Sep 12 05:26:11 2018
New Revision: 342051
URL: http://llvm.org/viewvc/llvm-project?rev=342051&view=rev
Log:
Fix two issues in PDBASTParser
- gcc warning about using binary or for or-ing two comparisons (a == b | a == c)
- llvm style prefers static functions to functions i
On 12/09/18 16:37, Greg Clayton wrote:
> Don't we get a blob of register bytes back from ptrace when reading
> registers? The struct we use must match this byte for byte.
That is true. However, this alignment does not set the layout of the
fields in the struct. Rather it sets the alignment of the
Author: labath
Date: Thu Sep 13 13:17:40 2018
New Revision: 342167
URL: http://llvm.org/viewvc/llvm-project?rev=342167&view=rev
Log:
NativeProcessProtocol: Sink ReadMemoryWithoutTrap into base class
The two existing implementations have the function implemented
identically, and there's no reason
Author: labath
Date: Fri Nov 3 05:13:22 2017
New Revision: 317319
URL: http://llvm.org/viewvc/llvm-project?rev=317319&view=rev
Log:
Fix classifications on two concurrent event tests
I have classified one as a watchpoint test even though it wasn't and
vice versa. Fix that.
Modified:
lldb/tr
Author: labath
Date: Fri Nov 3 07:42:37 2017
New Revision: 317326
URL: http://llvm.org/viewvc/llvm-project?rev=317326&view=rev
Log:
Xfail test_stack_info_in_minidump test
The test has been failing since we enabled the i386 ABI plugin on
windows. See pr35193 for details.
Modified:
lldb/trun
Author: labath
Date: Fri Nov 3 08:22:36 2017
New Revision: 317329
URL: http://llvm.org/viewvc/llvm-project?rev=317329&view=rev
Log:
Add float/vector registers for ppc64le
Summary: Add read and write functions for VSX, VMX and float registers and fix
watchpoint size
Reviewers: clayborg
Reviewe
Author: labath
Date: Fri Nov 3 15:12:50 2017
New Revision: 317377
URL: http://llvm.org/viewvc/llvm-project?rev=317377&view=rev
Log:
Remove ProcessGdbRemote::m_flags
The member is completely unused. Discussed on lldb-dev.
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemot
Author: labath
Date: Mon Nov 6 04:34:27 2017
New Revision: 317474
URL: http://llvm.org/viewvc/llvm-project?rev=317474&view=rev
Log:
Extend android xfail in TestTopLevelExprs
The test fails on API level 19 as well. I'm going to assume that it
fails on every API level below 23.
Modified:
lld
Author: labath
Date: Tue Nov 7 02:36:42 2017
New Revision: 317562
URL: http://llvm.org/viewvc/llvm-project?rev=317562&view=rev
Log:
test: Clean up finalize_build_dictionary
We only support API>=16 now, so we don't need to check the API level of
the android device.
Modified:
lldb/trunk/packa
Author: labath
Date: Tue Nov 7 02:36:36 2017
New Revision: 317561
URL: http://llvm.org/viewvc/llvm-project?rev=317561&view=rev
Log:
"Fix" concurrent events test for arm
Summary:
The test incremented an atomic varible to trigger the watchpoint event.
On arm64 this compiled to a ldaxr/stlxr loop,
I could, but I thought this would be more portable. For the Makefile
solution I'd need to do something like
LD_EXTRAS := -Wl,--no-as-needed,--whole-archive
Which is a bit of a hack, as I'm not even using these flags to affect
my own libraries, but the libraries that the compiler adds
automaticall
On 7 November 2017 at 12:46, Zachary Turner wrote:
> I just wonder if we should be disabling linker gc across the board for all
> tests unless you explicitly opt in.
>
> Seems like something we would want only rarely, if ever
Yes, that might be an option. I don't really have a strong opinion on
t
On 7 November 2017 at 13:29, Zachary Turner wrote:
> If it works, is easy, and doesn’t regress anything I’d honestly rather just
> disable linker gc.
Ok, I'll try that.
>
> But I’m not familiar with the method you mentioned. I thought linker gc
> happens when you have -function-sections, -fdata-s
On 7 November 2017 at 13:51, Pavel Labath wrote:
> On 7 November 2017 at 13:29, Zachary Turner wrote:
>> If it works, is easy, and doesn’t regress anything I’d honestly rather just
>> disable linker gc.
> Ok, I'll try that.
I'm starting not to to like this. Adding --whole-archive produces
zillion
Author: labath
Date: Tue Nov 7 14:17:29 2017
New Revision: 317624
URL: http://llvm.org/viewvc/llvm-project?rev=317624&view=rev
Log:
Update tuple/list/deque data formatters to work with newest libc++
Summary:
A couple of members of these data structures have been renamed in recent
months. This ma
Author: labath
Date: Wed Nov 8 02:48:50 2017
New Revision: 317678
URL: http://llvm.org/viewvc/llvm-project?rev=317678&view=rev
Log:
Make TestTopLevelExprs more robust in face of linker GC
Summary:
This test was failing in various configurations on linux in a fairly
unpredictible way. The success
Author: labath
Date: Wed Nov 8 02:48:54 2017
New Revision: 317679
URL: http://llvm.org/viewvc/llvm-project?rev=317679&view=rev
Log:
Log: delimit thread name in log message
The thread name was not followed by a space, which meant it was glued to
the log message. I also align the name as we do tha
Author: labath
Date: Wed Nov 8 03:51:49 2017
New Revision: 317683
URL: http://llvm.org/viewvc/llvm-project?rev=317683&view=rev
Log:
Xfail TestConcurrentTwoWatchpointsOneSignal on arm
r317561 exposed an interesting bug (pr35228) in handling of simultaneous
watchpoint hits. Disabling the test unti
Author: labath
Date: Thu Nov 9 02:43:16 2017
New Revision: 317779
URL: http://llvm.org/viewvc/llvm-project?rev=317779&view=rev
Log:
Simplify NativeProcessProtocol::GetArchitecture/GetByteOrder
Summary:
These functions used to return bool to signify whether they were able to
retrieve the data. Th
Author: labath
Date: Thu Nov 9 07:06:31 2017
New Revision: 317792
URL: http://llvm.org/viewvc/llvm-project?rev=317792&view=rev
Log:
Add a unit test for ClangASTContext template arguments handling
I am planning to make changes to this piece of code, so I wrote this
test to add more coverage to it
Author: labath
Date: Thu Nov 9 07:45:09 2017
New Revision: 317795
URL: http://llvm.org/viewvc/llvm-project?rev=317795&view=rev
Log:
llgs-tests: Replace the "log+return false" pattern with llvm::Error
Summary:
These tests used to log the error message and return plain bool mainly
because at the t
Author: labath
Date: Fri Nov 10 03:05:49 2017
New Revision: 317881
URL: http://llvm.org/viewvc/llvm-project?rev=317881&view=rev
Log:
Clean up NativeRegisterContext
Summary:
This commit removes the concrete_frame_idx member from
NativeRegisterContext and related functions, which was always set to
Author: labath
Date: Mon Nov 13 06:03:17 2017
New Revision: 318039
URL: http://llvm.org/viewvc/llvm-project?rev=318039&view=rev
Log:
Revert "[lldb] Use OrcMCJITReplacement rather than MCJIT as the underlying JIT
for LLDB"
This commit really did not introduce any functional changes (for most
peop
Author: labath
Date: Mon Nov 13 06:26:21 2017
New Revision: 318040
URL: http://llvm.org/viewvc/llvm-project?rev=318040&view=rev
Log:
CompilerType: Add ability to retrieve an integral template argument
Summary:
Despite it's name, GetTemplateArgument was only really working for Type
template argume
Author: labath
Date: Mon Nov 13 07:57:20 2017
New Revision: 318046
URL: http://llvm.org/viewvc/llvm-project?rev=318046&view=rev
Log:
Remove last Host usage from ArchSpec
Summary:
In D39387, I was quick to jump to conclusion that ArchSpec has no
external dependencies. It turns there still was one
Author: labath
Date: Mon Nov 13 08:47:37 2017
New Revision: 318052
URL: http://llvm.org/viewvc/llvm-project?rev=318052&view=rev
Log:
Fix netbsd, freebsd and osx builds for ArchSpec move
Modified:
lldb/trunk/include/lldb/Utility/ArchSpec.h
lldb/trunk/source/Host/macosx/Host.mm
lldb/tru
Author: labath
Date: Tue Nov 14 03:15:03 2017
New Revision: 318145
URL: http://llvm.org/viewvc/llvm-project?rev=318145&view=rev
Log:
Add a data formatter for libc++ std::bitset
Reviewers: jingham, EricWF
Subscribers: mgorny, lldb-commits
Differential Revision: https://reviews.llvm.org/D39966
A
On 15 November 2017 at 03:41, Jason Molenda via lldb-commits
wrote:
> Author: jmolenda
> Date: Tue Nov 14 19:41:47 2017
> New Revision: 318262
>
> URL: http://llvm.org/viewvc/llvm-project?rev=318262&view=rev
> Log:
> Roll back r318260 because it is causing the windows bot to
> break. The alignas(
On 15 November 2017 at 17:42, Zachary Turner wrote:
> Can we just extend llvm's mapped_file_region to support a boolean Writable
> flag?
>
mapped_file_region already can be writable. The feature it is missing
is the ability to *not* use mmap. And that's not a good idea, as the
whole purpose of tha
On 15 November 2017 at 18:11, Zachary Turner wrote:
>
>
> On Wed, Nov 15, 2017 at 9:51 AM Pavel Labath wrote:
>>
>> On 15 November 2017 at 17:42, Zachary Turner wrote:
>> > Can we just extend llvm's mapped_file_region to support a boolean
>> > Writable
>> > flag?
>> >
>> mapped_file_region alrea
Author: labath
Date: Thu Nov 16 05:38:57 2017
New Revision: 318399
URL: http://llvm.org/viewvc/llvm-project?rev=318399&view=rev
Log:
Implement core dump debugging for PPC64le
Summary: Implement core dump debugging for PPC64le.
Reviewers: labath
Reviewed By: labath
Subscribers: JDevlieghere, kr
The issue with the generator expressions is that they are expanded in
only in specific target properties, and here we need them to be
expanded in configure_lit_site_cfg. If you know the right incantation
to make that happen, then please let me know.
Deriving the c++ compiler name is a bit tricky,
Author: labath
Date: Thu Nov 23 02:50:34 2017
New Revision: 318903
URL: http://llvm.org/viewvc/llvm-project?rev=318903&view=rev
Log:
elf-core: Split up parsing code into os-specific functions
Summary:
We've had a single function responsible for splitting a core segment
into notes, and parsing the
Author: labath
Date: Mon Nov 27 05:47:14 2017
New Revision: 319028
URL: http://llvm.org/viewvc/llvm-project?rev=319028&view=rev
Log:
dotest: Mark more android targets as chatty
New android ndk linker started adding more flags to the produced
binaries, which causes older dynamic linkers display wa
Author: labath
Date: Mon Nov 27 09:06:42 2017
New Revision: 319048
URL: http://llvm.org/viewvc/llvm-project?rev=319048&view=rev
Log:
Remove custom TimePoint-formatting code
This was a temporary thing, until llvm has proper support for formatting
time. That time has come, so we can remove the rele
Author: labath
Date: Tue Nov 28 02:56:54 2017
New Revision: 319161
URL: http://llvm.org/viewvc/llvm-project?rev=319161&view=rev
Log:
Fix floating point register write on new x86 linux kernels
Summary:
New linux kernels (on systems that support the XSAVES instruction) will
not update the inferior
Author: labath
Date: Tue Nov 28 03:10:23 2017
New Revision: 319162
URL: http://llvm.org/viewvc/llvm-project?rev=319162&view=rev
Log:
elf-core: Convert remaining register context to use register set maps
In https://reviews.llvm.org/D39681, we started using a map instead
passing a long list of regi
On 28 November 2017 at 17:28, Zachary Turner via lldb-commits
wrote:
>
>
> On Tue, Nov 28, 2017 at 2:48 AM Pavel Labath via Phabricator via
> lldb-commits wrote:
>>
>> labath added a comment.
>>
>> On 28 November 2017 at 06:12, Zachary Turner via lldb-commits
>> wrote:
>>
>> > yaml2core would be
Author: labath
Date: Thu Nov 30 02:16:54 2017
New Revision: 319414
URL: http://llvm.org/viewvc/llvm-project?rev=319414&view=rev
Log:
Fix assertion in ClangASTContext
Summary:
llvm::APSInt(0) asserts because it creates an int with bit-width 0 and
not (as I thought) a value 0.
Theoretically it sho
I have to say I quite like how this test turned out to look like. In
terms of the last night's SBAPI vs. lldb-mi vs. whateever discussion,
i'd can say that there is nothing preventing this test written in
terms of the SB API. I didn't do it that way, because I have
automatically written the test at
Author: labath
Date: Thu Nov 30 07:39:57 2017
New Revision: 319443
URL: http://llvm.org/viewvc/llvm-project?rev=319443&view=rev
Log:
Add a test case for open bug 35480
The test is about failing to hit breakpoints in global constructors in
shared libraries.
Added:
lldb/trunk/packages/Python/
cool. thanks.
On 30 November 2017 at 20:43, Jim Ingham via lldb-commits
wrote:
> Author: jingham
> Date: Thu Nov 30 12:43:00 2017
> New Revision: 319472
>
> URL: http://llvm.org/viewvc/llvm-project?rev=319472&view=rev
> Log:
> Fix this test so that the breakpoints you set are
> unambiguously on o
On 30 November 2017 at 19:08, Jim Ingham wrote:
> We had a similar problem with the tests on macOS. lldb has a facility that
> will do automatic lookup of UUID -> dSYM (macOS's separate debug info format)
> and if you are internal to Apple this will find all the system library debug
> info. T
On 30 November 2017 at 19:10, Zachary Turner via Phabricator
wrote:
> zturner added a comment.
>
> In https://reviews.llvm.org/D40475#935615, @labath wrote:
>
>> The thing to be aware of with this testing strategy is that you will
>> probably be the only person who will be able to run these tests
On 30 November 2017 at 20:17, Jan Kratochvil via Phabricator
wrote:
> jankratochvil added a comment.
>
> In https://reviews.llvm.org/D40475#940462, @labath wrote:
>
>> It looks like it could be a fun project to reimplement `dwz` on top of llvm
>> dwarf library, but I understand that would be a co
Author: labath
Date: Fri Dec 1 04:05:00 2017
New Revision: 319536
URL: http://llvm.org/viewvc/llvm-project?rev=319536&view=rev
Log:
Kill struct IOVEC
struct iovec is used as an interface to system (posix) api's. As such,
we shouldn't be using it in os-independent code, and we shouldn't be
defini
On 1 December 2017 at 19:42, Jim Ingham wrote:
> This certainly should be cleared up and centralized. I'm not quite as sure
> it should be in Platform however. For instance, macOS has the DebugSymbols
> framework that allows users to specify a local lookup tool to find symbol
> files given a
Gdb has no issues with this use case. I'm pretty sure this is a
problem with how our posix dynamic linker plugin catches these events.
I've asked eugene to look into that.
On 1 December 2017 at 18:58, Jim Ingham wrote:
> The fact that this passes on macOS likely does mean the general mechanism
>
The reason you hit the assert there, is because you're running lldb on
an un-linked object file. When you link the file, the linker will
resolve these relocations and they will disappear. This is also the
reason you got those errors after removing the assert (you were
trying to parse unrelocated d
Author: labath
Date: Mon Dec 4 05:31:56 2017
New Revision: 319653
URL: http://llvm.org/viewvc/llvm-project?rev=319653&view=rev
Log:
Makefile.rules: compile all tests with -fno-limit-debug-info
Summary:
This flag is on by default for darwin and freebsd, but off for linux.
Without it, clang will s
On 5 December 2017 at 17:44, Greg Clayton wrote:
> Didn't someone recently submit a patch to allow relocation of .o files? That
> should have taken care of the issue, no?
>
I take it you mean D38142. This made sure that the memory we store the
object file in is writable, which makes sure that we
On 6 December 2017 at 01:54, Jason Molenda wrote:
> It looks like the macos testsuite on the bot is broken with this -
>
> http://lab.llvm.org:8080/green/view/LLDB/job/lldb/3086/
>
> On my desktop with a recent clang, it works fine. But it seems like every
> test? most tests? are failing with
>
Author: labath
Date: Thu Dec 7 02:38:22 2017
New Revision: 320021
URL: http://llvm.org/viewvc/llvm-project?rev=320021&view=rev
Log:
Variable: Fix usage of uninitialised value
Summary:
Variable::GetValuesForVariableExpressionPath was passing an
uninitialised value for the final_task_on_target arg
Author: labath
Date: Mon Dec 11 01:33:18 2017
New Revision: 320345
URL: http://llvm.org/viewvc/llvm-project?rev=320345&view=rev
Log:
MainLoop: avoid infinite loop when pty slave gets closed
Summary:
For ptys (at least on Linux), the end-of-file (closing of the slave FD)
is signalled by the POLLHU
Author: labath
Date: Mon Dec 11 02:09:14 2017
New Revision: 320346
URL: http://llvm.org/viewvc/llvm-project?rev=320346&view=rev
Log:
Move PseudoTerminal to the lldb_private namespace
lldb_utility doesn't make sense, as it is no longer even living in the
"utility" module.
Modified:
lldb/trunk
Author: labath
Date: Mon Dec 11 03:12:22 2017
New Revision: 320349
URL: http://llvm.org/viewvc/llvm-project?rev=320349&view=rev
Log:
Fix osx build broken in r320346
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm
Modified:
lldb/trunk/source/P
Author: labath
Date: Mon Dec 11 06:22:30 2017
New Revision: 320366
URL: http://llvm.org/viewvc/llvm-project?rev=320366&view=rev
Log:
Add a StringList constructor to Args class
Host::GetEnvironment returns a StringList, but the interface for
launching a process takes Args. The fact that we use two
Author: labath
Date: Mon Dec 11 07:28:21 2017
New Revision: 320377
URL: http://llvm.org/viewvc/llvm-project?rev=320377&view=rev
Log:
dotest.py: Correctly annotate lldbinline tests with debug info categories
This enables one to run all dwo tests with dotest.py --category dwo, or
skip them with --s
201 - 300 of 6814 matches
Mail list logo
