On 20/08/18 08:17, Davide Italiano via lldb-commits wrote: > On Fri, Aug 17, 2018 at 2:36 AM Stephane Sezer via lldb-commits > <lldb-commits@lists.llvm.org> wrote: >> >> Author: sas >> Date: Thu Aug 16 17:35:47 2018 >> New Revision: 339974 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=339974&view=rev >> Log: >> Add a relocation for R_AARCH64_ABS32 in ObjectFileELF >> >> Summary: >> .rela.debug_info relocations are being done via >> ObjectFileELF::ApplyRelocations for aarch64. Currently, the switch case >> that iterates over the relocation type is only implemented for a few >> different types and `assert(false)`es over the rest. >> >> Implement the relocation for R_AARCH64_ABS32 in ApplyRelocations >> >> Reviewers: sas, xiaobai, javed.absar, espindola >> >> Reviewed By: sas >> >> Subscribers: emaste, arichardson, kristof.beyls >> >> Differential Revision: https://reviews.llvm.org/D50369 >> >> Change by Nathan Lanza <la...@fb.com> >> > > This change should be unit testable, can you please give it a shot? > Alternatively, you can probably use `lldb-test`, but maybe that > requires some infrastructure to be written that's not there yet and I > think it's not fair to ask you to write it. > > -- > Davide > _______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits >
lldb-test has the ability to dump the contents of object file sections. The applied relocations should be reflected there. pl _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
