labath added a comment.
Could you explain what is the nature of the failure in the vdso parsing?
Otherwise it's quite hard to see what's the relationship of your patch to it,
as it seems that the ObjectFile should be able to handle files which are not
fully contained within the initial read (co
labath added a comment.
In http://reviews.llvm.org/D16107#324594, @labath wrote:
> Could you explain what is the nature of the failure in the vdso parsing?
Strike that. I see that you have linked the bug # in the title...
http://reviews.llvm.org/D16107
_
labath added a subscriber: labath.
labath requested changes to this revision.
labath added a reviewer: labath.
labath added a comment.
This revision now requires changes to proceed.
This will make the test fail on remote platforms, as the redirected file needs
to be transferred in before you can
labath added a comment.
In http://reviews.llvm.org/D16128#325804, @zturner wrote:
> Yea, supporting GetStdio is really difficult on Windows. We might try to do
> it again someday. Putting it in a char[] variable and reading the variable
> seems like a decent solution, I will try that.
Thank
labath added a comment.
In http://reviews.llvm.org/D16128#325814, @labath wrote:
> > There's lots of tests currently that redirect stdio, are those all broken
> > on Linux currently?
>
>
> The redirection works on linux, it's just not 100% reliable in tests. The
> thing is that inferior stdio a
labath added a subscriber: labath.
labath added a comment.
In http://reviews.llvm.org/D16049#326631, @bhushan wrote:
> Hi Zachary,
>
> If we use @skipIf then the list would require to contain all possible MIPS
> variations and the list will grow long.
> for ex: @skipIf(archs=not_in(['mips32','m
I don't really understand the purpose of the test, but if the purpose
of it is to check whether something appears on stdout, then a pexpect
test does seem like the right tool for the job.
I have tried entering the commands from the test manually, and the
required text does *not* appear when using
Author: labath
Date: Fri Jan 15 10:20:01 2016
New Revision: 257901
URL: http://llvm.org/viewvc/llvm-project?rev=257901&view=rev
Log:
Fix decoration of TestConcurrentEvents
TestConcurrentEvents was marked with a XFAIL decorator at class level, which
actually does not
work, and causes the class to
labath created this revision.
labath added a reviewer: zturner.
labath added a subscriber: lldb-commits.
The dependencies of our libraries (only liblldb, really) we marked as public,
which caused all
their dependencies to be repeated when linking any executables to them. This is
a problem becaus
labath added a comment.
I don't quite know how windows linking works, so please give this a run to make
sure it does not break anything for you.
http://reviews.llvm.org/D16293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
Author: labath
Date: Mon Jan 18 08:45:35 2016
New Revision: 258048
URL: http://llvm.org/viewvc/llvm-project?rev=258048&view=rev
Log:
Guard against application of an XFAIL decorator on a class
This does not work and causes the class to be silently skipped, which is a bad
idea. This makes
sure it
Author: labath
Date: Mon Jan 18 09:01:14 2016
New Revision: 258049
URL: http://llvm.org/viewvc/llvm-project?rev=258049&view=rev
Log:
Remove skipIfLinuxClang decorator
it isn't used in the code anymore, and we're trying to cut down on the
decorators.
Modified:
lldb/trunk/packages/Python/lldb
labath added a comment.
I think this looks *much* nicer than the previous version.
I personally would replace the `std::function` dance with something simpler
such as `bool use_memory_fallback`, but I guess that's a matter of taste.
Comment at: source/Plugins/ObjectFile/ELF/Ob
labath added a comment.
Looks good as far as I am concerned. @tberghammer, @ovyalov ?
http://reviews.llvm.org/D16107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Tue Jan 19 04:59:10 2016
New Revision: 258114
URL: http://llvm.org/viewvc/llvm-project?rev=258114&view=rev
Log:
Remove last XTIMEOUTs from android tests
TestHelloWorld seems to be passing now as far as I can tell. TestExitDuringStep
is still hanging.
I have marked the releva
labath created this revision.
labath added a reviewer: tfiala.
labath added a subscriber: lldb-commits.
We already have the ability to collect the server logs when doing local
debugging. This enables
the collection of remote logs as well. This relies on specifying a relative
path "server.log" fo
Author: labath
Date: Wed Jan 20 06:09:12 2016
New Revision: 258304
URL: http://llvm.org/viewvc/llvm-project?rev=258304&view=rev
Log:
Enable TestConcurrentEvents on i386 linux
The test has been passing reliably the last 100 runs of the build bot.
Modified:
lldb/trunk/packages/Python/lldbsuit
Author: labath
Date: Wed Jan 20 06:17:26 2016
New Revision: 258305
URL: http://llvm.org/viewvc/llvm-project?rev=258305&view=rev
Log:
Enable TestInlineStepping on linux i386
Test has been passing at least the last 200 buildbot runs.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functio
Author: labath
Date: Wed Jan 20 06:23:23 2016
New Revision: 258306
URL: http://llvm.org/viewvc/llvm-project?rev=258306&view=rev
Log:
Fix clang warning in RenderScriptRuntime
std::array should have "the same semantics as a struct holding a C-style array
T[N] as its only
non-static data member", s
labath added a comment.
Zachary, could you take a look at this please. I'd like to squeeze this into
3.8 if it is working..
> At some point lldb-argdumper is planned to be reworked just slightly so it
> had no dependencies on the lldb core. (That would have avoided this I
> suspect.)
It woul
labath updated this revision to Diff 45529.
labath added a comment.
Use private keyword for linux only
http://reviews.llvm.org/D16293
Files:
cmake/modules/AddLLDB.cmake
tools/argdumper/CMakeLists.txt
Index: tools/argdumper/CMakeLists.txt
labath added a comment.
I think a similar command as for argdumper would fix this (probably
`target_link_libraries(lldb, lldbHost)`). I thought about doing that instead,
but then I realised that netbsd probably needs this as well, and lldb-mi seems
to be using getopt also, etc. So I figured I'l
labath added a comment.
Any thoughts? Objections? Indifference? :)
http://reviews.llvm.org/D16322
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1385-1386
@@ +1384,4 @@
+# This is executed on a best-effort basis. If the file is not
there, so be it.
+lldb.remote_platform.Get(lldb.SBFileSpec("server.log"),
+
Author: labath
Date: Thu Jan 21 11:54:14 2016
New Revision: 258414
URL: http://llvm.org/viewvc/llvm-project?rev=258414&view=rev
Log:
Enable test log collection from remote debug servers
Summary:
We already have the ability to collect the server logs when doing local
debugging. This enables
the c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258414: Enable test log collection from remote debug servers
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D16322?vs=45273&id=45553#toc
Repository:
rL LLVM
http://reviews.ll
labath accepted this revision.
This revision is now accepted and ready to land.
Comment at: packages/Python/lldbsuite/test/dosep.py:1145
@@ -1144,1 +1144,3 @@
+else:
+target = None
I think this should be `target = platform_name`, so that you
labath updated this revision to Diff 45667.
labath added a comment.
Let's try a different approach. This should disable the logic of
LINK_LLVM_DYLIB for lldb binaries, and thereby enabling that build
to work. It should be the safest thing in the short term, and we
can figure out a better fix later
Author: labath
Date: Fri Jan 22 08:50:29 2016
New Revision: 258501
URL: http://llvm.org/viewvc/llvm-project?rev=258501&view=rev
Log:
Revert "Enable test log collection from remote debug servers"
Unfortunately, this turns out not to be working on the lldb-server tests, as
there the server is
star
labath added a comment.
Ping?
http://reviews.llvm.org/D16293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
I like it. I noticed two small issues when running it though:
- TestFdLeak calls `@expectedFailure`, the expectation fn needs to be updated
to return a tuple
- TestInferiorAssert calls `matchAndroid`, which now returns a tuple. condition
needs updating.
LGTM after that.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258921: Fix linking with LLVM_LINK_LLVM_DYLIB=ON (authored
by labath).
Changed prior to commit:
http://reviews.llvm.org/D16293?vs=45667&id=46116#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1629
Author: labath
Date: Wed Jan 27 05:02:02 2016
New Revision: 258921
URL: http://llvm.org/viewvc/llvm-project?rev=258921&view=rev
Log:
Fix linking with LLVM_LINK_LLVM_DYLIB=ON
Linking with LLVM shared libraries currently produces linker errors. This
works around the issue
(pr24953) by disabling l
Hi,
could we get this patch applied to the 3.8 branch?
thanks,
pl
On 27 January 2016 at 11:02, Pavel Labath via lldb-commits
wrote:
> Author: labath
> Date: Wed Jan 27 05:02:02 2016
> New Revision: 258921
>
> URL: http://llvm.org/viewvc/llvm-project?rev=258921&view=rev
&
labath created this revision.
labath added reviewers: zturner, tfiala.
labath added a subscriber: lldb-commits.
The BUILD_SHARED_LIBS branch of lldb-server link flags was hopelessly broken,
at least since we
started restricting the symbols exported by liblldb. lldb-server depends on
symbols from
Author: labath
Date: Fri Jan 29 05:59:57 2016
New Revision: 259188
URL: http://llvm.org/viewvc/llvm-project?rev=259188&view=rev
Log:
Fix linking of lldb-server with BUILD_SHARED_LIBS
Summary:
The BUILD_SHARED_LIBS branch of lldb-server link flags was hopelessly broken,
at least since we
started
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259188: Fix linking of lldb-server with BUILD_SHARED_LIBS
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D16678?vs=46254&id=46373#toc
Repository:
rL LLVM
http://reviews.llvm.
labath created this revision.
labath added reviewers: clayborg, zturner, tberghammer.
labath added a subscriber: lldb-commits.
I've run into an issue when running unit tests, where the underlying problem
turned out to be
that we were creating Timer objects (through several layers of indirection)
ed in pr26335.
cheers,
pl
On 29 January 2016 at 11:59, Pavel Labath via lldb-commits
wrote:
> Author: labath
> Date: Fri Jan 29 05:59:57 2016
> New Revision: 259188
>
> URL: http://llvm.org/viewvc/llvm-project?rev=259188&view=rev
> Log:
> Fix linking of lldb-server with BUILD_
labath added a comment.
I am confused as to how could this even work, since all your decorators seem to
be ignoring the function they are decorating. I'm pretty sure this is going to
cause some very weird things to happen things to come out of the decoration
process, which might explain your co
labath created this revision.
labath added reviewers: tberghammer, emaste.
labath added subscribers: lldb-commits, abhishek.aggarwal.
Herald added a subscriber: emaste.
r259344 introduced a bug, where we fail to perform a single step, when the
instruction we are
stepping onto contains a breakpoin
labath added a comment.
TestGDBRemoteMemoryRead.py is my test and I gotta admit it is somewhat hackish.
If this is the only issue that is stopping this from going through, then please
xfail it, and i'll rewrite it in some other way.
http://reviews.llvm.org/D16736
___
labath added a comment.
We are still using VS2013 at the moment, but we have started to investigate the
possibility of migrating to 2015. I can report back when I know more, but I
would leave the thread_local keyword out for now.
http://reviews.llvm.org/D16722
__
Author: labath
Date: Mon Feb 1 07:29:41 2016
New Revision: 259356
URL: http://llvm.org/viewvc/llvm-project?rev=259356&view=rev
Log:
Remove Timer::Initialize routine
Summary:
I've run into an issue when running unit tests, where the underlying problem
turned out to be
that we were creating Timer
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259356: Remove Timer::Initialize routine (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D16722?vs=46380&id=46524#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16722
Files
labath updated this revision to Diff 46528.
labath added a comment.
Merged test cases, and updated the FreeBSD version. Please take another look.
http://reviews.llvm.org/D16767
Files:
packages/Python/lldbsuite/test/functionalities/breakpoint/consecutive_breakpoints/TestConsecutiveBreakpoints
Author: labath
Date: Mon Feb 1 10:50:28 2016
New Revision: 259368
URL: http://llvm.org/viewvc/llvm-project?rev=259368&view=rev
Log:
Remove flaky annotation for TestCallWithTimeout on linux
The test has passed last 100 runs of the buildbot.
Modified:
lldb/trunk/packages/Python/lldbsuite/tes
Author: labath
Date: Tue Feb 2 03:49:37 2016
New Revision: 259484
URL: http://llvm.org/viewvc/llvm-project?rev=259484&view=rev
Log:
Fix compiler lookup when specified without path
r259433 introduced a regression, where if a compiler is specified without a
path (e.g., CC=clang,
relying on the fa
labath added a comment.
In http://reviews.llvm.org/D16767#341259, @amccarth wrote:
> I was chasing this same bug on Windows before I noticed you were working on
> it. I patched in your latest diff, and the problem still occurs.
That is not surprising. These fixes (r259344, and this one) are i
Author: labath
Date: Tue Feb 2 04:40:56 2016
New Revision: 259488
URL: http://llvm.org/viewvc/llvm-project?rev=259488&view=rev
Log:
Fix single-stepping onto a breakpoint
Summary:
r259344 introduced a bug, where we fail to perform a single step, when the
instruction we are
stepping onto contains
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259488: Fix single-stepping onto a breakpoint (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D16767?vs=46528&id=46632#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16767
labath added subscribers: lldb-commits, labath.
labath added a comment.
This caused a regression when the compiler was specified without a full path
(I've fixed it in r259484, this is just an FYI).
Also, please put @lldb-commits (not LLVM) as a subscriber on the diff next time.
cheers,
pl
htt
labath added a comment.
LGTM from my side after the two fixes in `no_debug_info_test` and
`skipUnlessListedRemote`
Comment at: packages/Python/lldbsuite/test/lldbtest.py:555
@@ -554,3 +554,3 @@
# Mark this function as such to separate them from the regular tests.
-wrap
Author: labath
Date: Tue Feb 2 07:07:27 2016
New Revision: 259494
URL: http://llvm.org/viewvc/llvm-project?rev=259494&view=rev
Log:
Fix build after clang interface change in r259489
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Modified:
lldb/trunk/so
Author: labath
Date: Tue Feb 2 09:16:16 2016
New Revision: 259513
URL: http://llvm.org/viewvc/llvm-project?rev=259513&view=rev
Log:
Mark TestProcessIO.test_stdin_redirection as flaky on android
bug #26437
Modified:
lldb/trunk/packages/Python/lldbsuite/test/python_api/process/io/TestProcess
Author: labath
Date: Tue Feb 2 09:16:20 2016
New Revision: 259514
URL: http://llvm.org/viewvc/llvm-project?rev=259514&view=rev
Log:
Log error message in SBTarget::Launch
Modified:
lldb/trunk/source/API/SBTarget.cpp
Modified: lldb/trunk/source/API/SBTarget.cpp
URL:
http://llvm.org/viewvc/ll
Author: labath
Date: Tue Feb 2 09:58:30 2016
New Revision: 259517
URL: http://llvm.org/viewvc/llvm-project?rev=259517&view=rev
Log:
Remove redundant test in TestExitDuringStep
After recent changes, test_thread_state_is_stopped has become equivalent to
test_step_in, as the
function exit_during_s
labath added a comment.
> If we haven't already, we should probably have some kind of exception
> wrapper around our decorators that catches non-unittest-related (i.e.
> unexpected) exceptions and somehow makes them more prevalent - maybe a hard
> error on the test or an abort or something.
Author: labath
Date: Tue Feb 2 11:02:58 2016
New Revision: 259527
URL: http://llvm.org/viewvc/llvm-project?rev=259527&view=rev
Log:
XFAIL TestConsecutiveBreakpoints.test_single_step_thread_specific on OSX
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/consecu
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1102
@@ -1164,2 +1101,3 @@
+return func(*args, **kwargs)
return wrapper
zturner wrote:
> labath wrote:
> > zturner wrote:
> > > labath wrote:
> > > > Th
labath added a subscriber: labath.
Comment at: include/lldb/Core/EmulateInstruction.h:406-410
@@ -405,4 +405,7 @@
-virtual bool
-IsInstructionConditional() { return false; }
+// Returns a condition code in the for of uint32_t where UINT32_MAX means
that the instruct
On 2 February 2016 at 23:08, Adrian McCarthy via lldb-commits
wrote:
> Thanks for the confirmation. I'm still not sure how
> TestConsecutiveBreakpoints.py used to work on Windows, but I believe this is
> the right fix.
The test used to be marked with
"@expectedFailureAll("llvm.org/pr23478", os
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Seems to be working after applying the fixes below.
I was considering whether this shouldn't be moved to an even more
platform-specific file (say `androidutil.py` or something), but I'll leave
Author: labath
Date: Wed Feb 3 05:12:23 2016
New Revision: 259638
URL: http://llvm.org/viewvc/llvm-project?rev=259638&view=rev
Log:
Fix an off-by-one in SocketTest::DecodeHostAndPort
65535 is still a valid port. This should fix the android failures we were
getting when we chose
to connect over
Author: labath
Date: Wed Feb 3 05:51:25 2016
New Revision: 259642
URL: http://llvm.org/viewvc/llvm-project?rev=259642&view=rev
Log:
Remove skipUnlessListedRemote test decorator
This decorator was used in only one test, and it's behaviour was quite
complicated. It skipped
if:
- test was remote
-
labath created this revision.
labath added reviewers: tfiala, tberghammer.
labath added a subscriber: lldb-commits.
gdb-remote tests are not able to use the same logging mechanisms as the rest of
our tests, and
currently we get no host logs from them, even though the tests themselves have
loggin
labath added a comment.
I agree that we should not over-engineer things. I'll leave the decision up to
others...
http://reviews.llvm.org/D16814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
+1 for using IR for hand-crafting tricky functions.
On 3 February 2016 at 22:01, Adrian Prantl via lldb-commits
wrote:
>
> On Feb 3, 2016, at 1:58 PM, Zachary Turner wrote:
>
> I was thinking of a really trivial function that just returned an int or
> something. But then again, I don't really
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I think it's a good idea. I haven't given it a spin, but I think we can fix up
any breakages from this on the fly.
http://reviews.llvm.org/D16872
__
Author: labath
Date: Thu Feb 4 03:53:33 2016
New Revision: 259774
URL: http://llvm.org/viewvc/llvm-project?rev=259774&view=rev
Log:
Add verbose logging support to gdb-remote tests
Summary:
gdb-remote tests are not able to use the same logging mechanisms as the rest of
our tests, and
currently w
Author: labath
Date: Thu Feb 4 03:53:37 2016
New Revision: 259775
URL: http://llvm.org/viewvc/llvm-project?rev=259775&view=rev
Log:
Mark TestProcessIO as flaky on android
previously, I have marked only one test as flaky, but now I noticed another
test failing with the
same error. I am going to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259774: Add verbose logging support to gdb-remote tests
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D16858?vs=46795&id=46884#toc
Repository:
rL LLVM
http://reviews.llvm.or
labath added a comment.
In http://reviews.llvm.org/D16858#343140, @tfiala wrote:
> BTW I was planning on re-organizing the lldb-server/debugserver tests
> sometime in the near future to break them into many different directories and
> pull off the dsym/dwarf/dwo changes for the many tests where
Author: labath
Date: Thu Feb 4 05:51:07 2016
New Revision: 259777
URL: http://llvm.org/viewvc/llvm-project?rev=259777&view=rev
Log:
Enable test_lldbmi_settings_set_target_run_args_before on linux
Test has passed last 200 runs of the build bot.
Modified:
lldb/trunk/packages/Python/lldbsuite
On 5 February 2016 at 03:13, Todd Fiala wrote:
> True.
>
> Maybe I'll wait until then.
Just don't hold your breath for too long. What I said is what I would
_like_ to do, but currently I don't see myself having enough time to
do that. If you want to do something sooner, then by all means, go
ahea
Author: labath
Date: Fri Feb 5 05:17:22 2016
New Revision: 259878
URL: http://llvm.org/viewvc/llvm-project?rev=259878&view=rev
Log:
Bump up the packet timeout for gdbremote tests
Log confirmed that the we are sometimes timing out on the receive, even though
the server is
sending the correct pac
Author: labath
Date: Mon Feb 8 03:35:53 2016
New Revision: 260078
URL: http://llvm.org/viewvc/llvm-project?rev=260078&view=rev
Log:
Have lldb-server log the timestamp in its log messages
Modified:
lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp
Modified: lldb/trunk/tools/lldb-server/lldb-gd
labath added a subscriber: labath.
labath added a comment.
Do we have a test for this?
If not, it sounds like it would be an easy thing to add one.
http://reviews.llvm.org/D16975
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
labath added a comment.
Nevermind, I now see you mention TestReturnValue. :/
http://reviews.llvm.org/D16975
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Mon Feb 8 03:58:27 2016
New Revision: 260081
URL: http://llvm.org/viewvc/llvm-project?rev=260081&view=rev
Log:
Revert "Enable test_lldbmi_settings_set_target_run_args_before on linux"
Test is still flaky.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-m
labath accepted this revision.
labath added a comment.
I agree with the idea in general, but I wanted to ask what is your plan with
the android decorators: For them we use the additional `api_levels` flag, which
does not exist on other platforms/decorators. I suppose we could add that flag
to `
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good, after applying one fix.
Comment at: packages/Python/lldbsuite/test/decorators.py:148
@@ +147,3 @@
+skip_for_triple = _match_decorator_property(triple,
lld
labath added a comment.
`Scalar::operator<<=` seems to do a `m_integer <<= ...`. Will it suffer from
the same recursion problem?
In any case, I think the implementations of both methods should use the same
API (it doesn't matter which one if both work).
Also it would be super great if you coul
labath added a comment.
Ah, ok I understand what's going on now. I guess APInt operator >> probably
does not exist because it would be ambiguous (arithmetic or bitwise shift?).
Let's just leave this as it is now.
Could you add that test though?
Repository:
rL LLVM
http://reviews.llvm.org/D
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
That's perfect. Thanks for adding that test.
Do you have commit access, or shall I put this in?
Repository:
rL LLVM
http://reviews.llvm.org/D16868
__
I think this is getting way too complicated. I haven't seen any test
which needs such complicated combinations of skip conditions (and I
hope I never see one).
On 9 February 2016 at 01:24, Zachary Turner wrote:
> 1. Skips if all conditions are true. @skipIf(all(A=a, B=b, C=c))
> 2. Skips if any
labath added a subscriber: labath.
labath added a comment.
I think this is getting way too complicated. I haven't seen any test
which needs such complicated combinations of skip conditions (and I
hope I never see one).
Repository:
rL LLVM
http://reviews.llvm.org/D16936
Author: labath
Date: Tue Feb 9 11:28:01 2016
New Revision: 260239
URL: http://llvm.org/viewvc/llvm-project?rev=260239&view=rev
Log:
Fix invalid shift operator overload in Scalar
Summary: This also fixes an infinite recursion between lldb_private::operator>>
() and Scalar::operator>>= ().
Revie
labath closed this revision.
labath added a comment.
Committed as r260239.
Repository:
rL LLVM
http://reviews.llvm.org/D16868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
On 9 February 2016 at 17:51, Zachary Turner wrote:
> I agree that you don't need arbitrary complexity, but I think there are some
> things we would greatly benefit from. For example, have you ever seen this?
>
> @expectedFailureWindows
> @expectedFailureGcc
> @expectedFailureHostLinux
>
>
labath added a comment.
I like the idea. I think this could help us with the linux vs. android dilemma
we've been having recently: currently, we consider android to be a flavour of
linux, which means it's not possible to XFAIL tests passing on android but
failing on linux. This should make expr
labath added a subscriber: labath.
labath added a comment.
I think this would be better if you could specify the connection direction in
the url. Also, a test for this functionality would be great.
Comment at: source/Interpreter/CommandInterpreter.cpp:638
@@ +637,3 @@
+
labath added a comment.
In http://reviews.llvm.org/D17088#350005, @zturner wrote:
> I think technically there are some platforms that cannot be both a host and a
> target. ios and anything involving a simulator comes to mind. But, if the
> only "gotcha" to having both of them be in the same e
labath added a comment.
I like this more, but I'd like to take it a bit further. I think we won't have
to parse the url string at all (see comments).
I believe the best way to avoid breaking (and being broken by) other changes is
to make sure this fits in nicely in the existing architecture. Pu
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
looks good.
http://reviews.llvm.org/D17088
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
labath accepted this revision.
This revision is now accepted and ready to land.
Comment at: scripts/Python/modules/readline/readline.cpp:55
@@ -39,1 +54,3 @@
static char*
+#if PY_VERSION_HEX >= 0x0300
+simple_readline(FILE *stdin, FILE *stdout, const char *prompt)
---
labath added a subscriber: labath.
labath accepted this revision.
labath added a reviewer: labath.
labath added a comment.
This revision is now accepted and ready to land.
We are not running these unittests on windows at the moment. You are the
windows maintainer, so if you say this is working fo
Author: labath
Date: Tue Feb 16 03:58:50 2016
New Revision: 260951
URL: http://llvm.org/viewvc/llvm-project?rev=260951&view=rev
Log:
Bump up timeout in TestChangeProcessGroup
The test fails very rarely. I suspect this is simply because the inferior does
not have enough
time to create the file un
Author: labath
Date: Tue Feb 16 03:58:47 2016
New Revision: 260950
URL: http://llvm.org/viewvc/llvm-project?rev=260950&view=rev
Log:
Mark TestLldbGdbServer.test_written_M_content_reads_back_correctly as flaky on
linux
I believe the root cause is the asynchronous arrival of inferior stdio
(pr256
labath accepted this revision.
labath added a comment.
So, linux actually manages to invoke the atexit handlers (through some deep
magic, no doubt) upon shared library unload, so we are ok here (plus linux
likes to nuke /tmp after every reboot). LGTM, with a small RAII request.
===
1901 - 2000 of 6833 matches
Mail list logo
