labath added a comment.
I like it. I noticed two small issues when running it though:
- TestFdLeak calls `@expectedFailure`, the expectation fn needs to be updated
to return a tuple
- TestInferiorAssert calls `matchAndroid`, which now returns a tuple. condition
needs updating.
LGTM after that.
================
Comment at:
packages/Python/lldbsuite/test/functionalities/jitloader_gdb/TestJITLoaderGDB.py:19
@@ -18,3 +18,3 @@
- @skipTestIfFn(lambda x: True, "llvm.org/pr24702", "Skipped because the
test crashes the test runner")
+ @skipTestIfFn(lambda x: (True, "Skipped because the test crashes the test
runner"), bugnumber="llvm.org/pr24702")
@unittest2.expectedFailure("llvm.org/pr24702")
----------------
I'm not sure why I wrote it this way originally, but now it seems this could be
written as `@skipIf(bugnumber="...") # Skip to avoid crash`
http://reviews.llvm.org/D16615
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
