labath added a subscriber: labath.
labath added a comment.
In http://reviews.llvm.org/D16049#326631, @bhushan wrote:
> Hi Zachary,
>
> If we use @skipIf then the list would require to contain all possible MIPS
> variations and the list will grow long.
> for ex: @skipIf(archs=not_in(['mips32','mips32r2', 'mips32r3',
> 'mips64','mips64r2', 'mips64r3', 'mips64r6' ......]))
>
> @skipUnlessMips covers all these possible values using regular expression
> matching.
I agree with Zachary that we have too many decorators and we shouldn't be
expanding their number, it's simply not sustainable. I see two options here:
- add a `getMipsArchitectures()` function and then write
`archs=not_in(getMipsArchitectures())`
- add a `not_regex()` function and write `archs=not_regex('mips.*')`
How does that sound?
Repository:
rL LLVM
http://reviews.llvm.org/D16049
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
