labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I am going to assume you know more about the exact details of the intel cpu's
than me, so I am not going comment on the technical details. The code seems
cleaner, so this looks like
labath added inline comments.
Comment at: cmake/modules/AddLLDB.cmake:75
@@ -74,1 +74,3 @@
if (PARAM_SHARED)
+set(out_dir lib${LLVM_LIBDIR_SUFFIX})
+if(${name} STREQUAL "liblldb" AND LLDB_BUILD_FRAMEWORK)
I am wondering whether this wouldn't
labath accepted this revision.
Comment at: source/Plugins/Process/Utility/RegisterInfos_x86_64.h:12
@@ -12,1 +11,3 @@
+#include
+#include
It's not a "C" include, if it's cstddef now. :) If you could you also move the
headers to the end of the include list as
labath added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:805
@@ -827,2 +804,3 @@
+ if (m_xstate_type == XStateType::Invalid) {
if (const_cast(this)->ReadFPR().Fail())
return false;
Then I think we s
labath added a comment.
So, the thing is that you already are changing the interface. The difference is
that you are using the const cast to hide that fact, which is why I dont
approve of it.
Also, since this is not an existing problem but rather something you are
introducing in this change, I
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Ok, lets leave that as-is then.. the issue seem s pretty contained for now.
https://reviews.llvm.org/D24603
___
lldb-commits mailing list
lldb-co
labath added a comment.
It definitely looks cleaner than the original version. I'm fine with this if
@clayborg is.
https://reviews.llvm.org/D24124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I'm sorry, I did not notice that. Go ahead with this patch in that case. It
looks great apart from this eexisting problem. If you're going to do further
cleanups here,, I would recommend look
labath added a comment.
In https://reviews.llvm.org/D24749#548778, @tfiala wrote:
> I'd say the install rpath change is probably worth doing on the first round.
> I think the top-level concept for frameworks is interesting but would be fine
> to come in as another change.
>
> I'd like to start
On 22 September 2016 at 01:00, Greg Clayton via lldb-commits
wrote:
> If you use a StringRef in printf, please use "%*s" and then put the count and
> data pointer into the printf, so the above line would become:
>
> + s->Printf("source regex = \"%*s\", exact_match = %d",
> +(int)m_re
labath accepted this revision.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp:513-521
@@ -513,1 +512,11 @@
+
+ // Find out how many bytes we need to watch after 4-byte alignment boundary.
+ uint8_t watch_size = (addr & 0x03) + size;
+
+ // We canno
Author: labath
Date: Thu Sep 22 10:26:43 2016
New Revision: 282167
URL: http://llvm.org/viewvc/llvm-project?rev=282167&view=rev
Log:
Fix TestBreakpointSerialization on windows
The test exposed a bug in the StructuredData Serialization code, which did not
escape the backslash properly. This manife
labath accepted this revision.
labath added a comment.
Sounds like a useful thing to have. I've found turning on logging very helpful
when looking for these issues, as it can tell you what was happening in the
past, in addition to the current state (also it allows you to compare the logs
from a
Author: labath
Date: Fri Sep 23 04:11:49 2016
New Revision: 282236
URL: http://llvm.org/viewvc/llvm-project?rev=282236&view=rev
Log:
[gdb-remote] Remove the const char * version of SendPacketAndWaitForResponse
Switch all callers to use the StringRef version.
Modified:
lldb/trunk/source/Plugi
labath resigned from this revision.
labath edited reviewers, added: beanz; removed: labath.
labath added a comment.
@beanz, could you look at the llvm side of this?
Repository:
rL LLVM
https://reviews.llvm.org/D24863
___
lldb-commits mailing list
labath added a comment.
In https://reviews.llvm.org/D24629#550841, @fjricci wrote:
> In https://reviews.llvm.org/D24629#550823, @tfiala wrote:
>
> > > > There is no reasonable thing we can base the expectation as the exact
> > > > same device with a different cpu revision could support watchpoin
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D24890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lld
Author: labath
Date: Mon Sep 26 08:50:06 2016
New Revision: 282406
URL: http://llvm.org/viewvc/llvm-project?rev=282406&view=rev
Log:
Remove an ancient XFAIL from TestBuiltinTrap
in refers to gcc-4.6. Hopefully noone is using that anymore, and I think there
is
a good chance it was fixed anyway.
Author: labath
Date: Mon Sep 26 09:34:02 2016
New Revision: 282408
URL: http://llvm.org/viewvc/llvm-project?rev=282408&view=rev
Log:
Remove ancient icc decorators
Nobody is running the test suite with icc, so we have no idea if they pass. But
the bug they link to has definitely been fixed.
Modif
labath added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpParser.h:42
@@ -41,1 +41,3 @@
+ const uint8_t *GetBaseAddr();
+
Replace these two functions with `llvm::ArrayRef GetData() const`
Comment at: source/Plugins/Proc
labath added a comment.
lgtm, after Zachary is happy.
https://reviews.llvm.org/D24919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
In https://reviews.llvm.org/D24610#553331, @omjavaid wrote:
> This is a new version of what seems to me fully implementing functionality we
> intend to have here.
>
> On a second tho
labath added a subscriber: labath.
Comment at: include/lldb/Interpreter/Args.h:150
@@ -147,19 +149,3 @@
///
/// @return
/// An array of NULL terminate C string argument pointers that
I think doxygen will complain about `@return` in a function returnin
labath added a comment.
In https://reviews.llvm.org/D24610#554587, @omjavaid wrote:
> Give this approach a rethink I dont see a lot of problems with this final
> implementation unless it fails on other architectures.
> We are already hacking our way to have these byte selection watchpoints
> w
labath added a comment.
Looks good as far as I am concerned. Just a couple of nits here and there.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1887
@@ -1885,1 +1886,3 @@
++num_keys_decoded;
+} else if (name.equals("eflags"
Note that the test fails when using gcc as a compiler (specifically gcc-4.9
in this case, but hopefully the exact version does not matter here).
Jason, will you be able to check this out today?
On 29 September 2016 at 05:45, Dimitar Vlahovski via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
[phabricator seems to be down, so I'll reply here]
Thank you for looking into this.
Hmm... I think we can consider this an improvement over the status quo, but
it's not going to solve the problem in all cases. E.g., on aarch64, a
single stp instruction with neon registers can access a block of me
Author: labath
Date: Fri Sep 30 06:47:54 2016
New Revision: 282848
URL: http://llvm.org/viewvc/llvm-project?rev=282848&view=rev
Log:
Fix PDB unittests on non-windows platforms
llvm r282788 changed how the presence of windows DIA SDK is signalled. Adjust to
that.
Modified:
lldb/trunk/unittest
Author: labath
Date: Fri Sep 30 07:12:15 2016
New Revision: 282849
URL: http://llvm.org/viewvc/llvm-project?rev=282849&view=rev
Log:
XFAIL TestSBData for gcc-4.9 i386
test broken in r282659.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/python_api/sbdata/TestSBData.py
Modified:
lldb/
I made a quick investigation today. The problem is indeed specific to
gcc-4.9. The main differences I could see is that gcc-4.9 generates a
different prologue for the function, and uses pushl for argument passing.
This confuses the emulator/augmenter and the unwind information at some
points ends u
labath added a comment.
random drive-by. Otherwise, I like it.
> Args.cpp:207
> +//--
> +Args::~Args() { Clear(); }
> +
I think we don't need to call Clear() here, as all memory owned by the object
will be correctly destroyed
Author: labath
Date: Sun Oct 2 10:56:33 2016
New Revision: 283069
URL: http://llvm.org/viewvc/llvm-project?rev=283069&view=rev
Log:
Revert "XFAIL TestSBData for gcc-4.9 i386"
Test fixed.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/python_api/sbdata/TestSBData.py
Modified:
lldb/tru
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I have a bunch of small comments. I'll have another look through this once they
are done.
The high-level change we need is to avoid choosing the plugin to use at
compile-time (your
The test fails on remote targets because it tries to set breakpoints based
on remote paths. We'll have that fixed shortly.
On 3 October 2016 at 11:13, Jim Ingham via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> These tests were failing for a bogus reason, so I fixed the bogus reason
> and
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm, thanks.
https://reviews.llvm.org/D25217
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: labath
Date: Mon Oct 3 19:32:20 2016
New Revision: 283171
URL: http://llvm.org/viewvc/llvm-project?rev=283171&view=rev
Log:
Fix test when using remote debugging.
Summary:
Use os.getcwd() instead of get_process_working_directory() as prefix for
souce file.
Reviewers: labath
Subscribers:
labath added inline comments.
> dvlahovski wrote in TestMiniDumpNew.py:19
> But, should `test_deeper_stack_in_mini_dump` and
> `test_local_variables_in_mini_dump` not have this decorator ?
They are not building any code, so the would behave the same way anyway. You
would be just running the te
labath added a comment.
@pablooliveira @sylvestre.ledru :
If you are fine with having lldb-server link against libLLVM in the
LLVM_LINK_LLVM_DYLIB case, I can make an lldb-only change that makes it work.
It won't affect our use case as we don't use that flag.
Repository:
rL LLVM
https://re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283171: Fix test when using remote debugging. (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D25217?vs=73381&id=73419#toc
Repository:
rL LLVM
https://reviews.llvm.org/D25217
labath added a comment.
In https://reviews.llvm.org/D25057#560325, @omjavaid wrote:
> @labath Referring to your email on the mailing list.
>
> Thanks for helping out with this work.
>
> I think we should push this fix, as you suggested this does not fix
> everything in a holistic way but it corr
labath added a comment.
Just a couple more details and I think we're ready.
> MinidumpParser.cpp:105
> +MinidumpParser::GetThreadContext(const MinidumpThread &td) {
> + return td.GetContext(GetData().data());
> +}
I think you have made it over-encapsulated now. :)
Either a Parser function whi
labath added a comment.
I wouldn't be opposed to completely disabling (a particular chosen set of
warnings) for that file, regardless of whether we do -Werror or not.
https://reviews.llvm.org/D25246
___
lldb-commits mailing list
lldb-commits@lists.
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Seems reasonable. For testing we'll yell at you if the buildbots break.
I take it we can now freely use the %z printf modifier.
https://reviews.llvm.org/D25247
labath added a comment.
Thanks for fixing all the comments. Unfortunately, on my last pass, I found one
more case of unverified input (I think).
> MinidumpParser.cpp:252
> +if (range_start <= addr && addr < range_start + range_size) {
> + return Range(range_start, GetData().slice(loc_
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lld
Author: labath
Date: Mon Dec 14 05:05:44 2015
New Revision: 255490
URL: http://llvm.org/viewvc/llvm-project?rev=255490&view=rev
Log:
XFAIL TestNamespaceLookup for linux
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/namespace/TestNamespaceLookup.py
Modified:
lldb/trunk/packag
labath added a subscriber: labath.
labath added a comment.
Hi,
all of the new tests in TestNamespaceLookup were failing on linux, against all
tested compilers
(http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/9405),
so I have XFAILed them. I don't know if this is somethi
Author: labath
Date: Mon Dec 14 06:09:28 2015
New Revision: 255492
URL: http://llvm.org/viewvc/llvm-project?rev=255492&view=rev
Log:
Extend XFAIL on TestNamespaceLookup on linux
one of the tests seems to (occasionally) fail with clang as well.
Modified:
lldb/trunk/packages/Python/lldbsuite/
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:518
@@ +517,3 @@
+if hasattr(func, "categories"):
+cat.extend(func.categories)
+func.categories = cat
tberghammer wrote:
> tfiala wrote:
> > This code
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255493: Make test categories composable (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D15451?vs=42522&id=42704#toc
Repository:
rL LLVM
http://reviews.llvm.org/D15451
Files:
Author: labath
Date: Mon Dec 14 07:17:18 2015
New Revision: 255493
URL: http://llvm.org/viewvc/llvm-project?rev=255493&view=rev
Log:
Make test categories composable
Summary:
Previously the add_test_categories would simply overwrite the current set of
categories for a
method. This change makes th
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D15428#308401, @zturner wrote:
> In hindsight I wonder if I even needed to manually mark the test with a debug
> info. Maybe we can say that tests should *never* be
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks like a nice simplification.
http://reviews.llvm.org/D15498
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/
labath created this revision.
labath added a reviewer: tfiala.
labath added a subscriber: lldb-commits.
This adds ability to mark test that do not complete due to hangs, crashes,
etc., as "expected",
to avoid flagging the build red for a known problem. Functionally, this extends
the scope of the
labath added a subscriber: labath.
labath added a comment.
No worries. I wanted to rename that function anyway, but then I
forgot, so it's good that you have reminded me. :)
http://reviews.llvm.org/D15530
___
lldb-commits mailing list
lldb-commits@l
No worries. I wanted to rename that function anyway, but then I
forgot, so it's good that you have reminded me. :)
On 15 December 2015 at 22:18, Todd Fiala wrote:
> tfiala added a comment.
>
> Hey Pavel,
>
> Change r255676 changed a few things that will require this patch to get
> updated. I th
Author: labath
Date: Wed Dec 16 06:09:45 2015
New Revision: 255763
URL: http://llvm.org/viewvc/llvm-project?rev=255763&view=rev
Log:
[test] Add ability to expect timeouts
Summary:
This adds ability to mark test that do not complete due to hangs, crashes,
etc., as "expected",
to avoid flagging th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255763: [test] Add ability to expect timeouts (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D15530?vs=42858&id=42985#toc
Repository:
rL LLVM
http://reviews.llvm.org/D15530
labath created this revision.
labath added reviewers: zturner, tfiala.
labath added a subscriber: lldb-commits.
As we override the indent option of the LLVM style, we need to override the
access modifier
offset as well. Otherwise, classes will be formatted like such
class A
{
public:
int fo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255882: Add AccessModifierOffset to clang-format style
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D15562?vs=42988&id=43106#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: labath
Date: Thu Dec 17 03:19:36 2015
New Revision: 255882
URL: http://llvm.org/viewvc/llvm-project?rev=255882&view=rev
Log:
Add AccessModifierOffset to clang-format style
Summary:
As we override the indent option of the LLVM style, we need to override the
access modifier
offset as well.
labath added a subscriber: labath.
labath added a comment.
Linux tests the same functionality in TestBuiltinTrap.py. Would it make sense
to merge these two tests, given that the only difference is which compiler
intrinsic is used to generate the int3 trap?
http://reviews.llvm.org/D15834
___
Author: labath
Date: Mon Jan 4 04:09:06 2016
New Revision: 256741
URL: http://llvm.org/viewvc/llvm-project?rev=256741&view=rev
Log:
Remove TestConnectRemote from XTIMEOUTs
The test in question was removed in r249613.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dosep.py
Modified: ll
Author: labath
Date: Mon Jan 4 04:52:17 2016
New Revision: 256744
URL: http://llvm.org/viewvc/llvm-project?rev=256744&view=rev
Log:
Remove XTIMEOUT from TestCreateAfterAttach on linux
I believe the cause for this was the attach lockup fixed in r246756. I will
enable this tests and
observe the b
labath created this revision.
labath added a reviewer: tfiala.
labath added a subscriber: lldb-commits.
This removes the old logic for rerunning flaky tests. The new test runners will
take care of
rerunning failing tests.
http://reviews.llvm.org/D15855
Files:
packages/Python/lldbsuite/test/ll
Author: labath
Date: Mon Jan 4 05:34:24 2016
New Revision: 256746
URL: http://llvm.org/viewvc/llvm-project?rev=256746&view=rev
Log:
Remove XTIMEOUT from TestExitDuringStep on linux
The test has passed last 200 buildbot runs, so it's hopefully working now. I'll
watch buildbots
for signs of troub
Author: labath
Date: Mon Jan 4 06:14:25 2016
New Revision: 256748
URL: http://llvm.org/viewvc/llvm-project?rev=256748&view=rev
Log:
Remove XTIMEOUT from TestHelloWorld on linux
I think it was timing out because of the attach deadlocks, which are now fixed.
In any case, it
has passed last 200 bu
Author: labath
Date: Mon Jan 4 07:07:22 2016
New Revision: 256752
URL: http://llvm.org/viewvc/llvm-project?rev=256752&view=rev
Log:
Remove XTIMEOUT from TestThreadStepOut on linux
The whole test is skipped already, so it's not running anyway.
Modified:
lldb/trunk/packages/Python/lldbsuite/t
Author: labath
Date: Mon Jan 4 07:51:14 2016
New Revision: 256755
URL: http://llvm.org/viewvc/llvm-project?rev=256755&view=rev
Log:
Remove XTIMEOUT from TestRegisters on linux
I suspect the test was hanging due to the attach deadlock. This was fixed and
the test has passed
last 200 buildbot run
labath added a comment.
I agree that the new test is better than the existing linux one, which can
therefore be removed. If you wish, I can do it after you get this in.
http://reviews.llvm.org/D15834
___
lldb-commits mailing list
lldb-commits@lists
Author: labath
Date: Tue Jan 5 04:44:36 2016
New Revision: 256824
URL: http://llvm.org/viewvc/llvm-project?rev=256824&view=rev
Log:
Remove old flaky test rerun logic
Summary:
This removes the old logic for rerunning flaky tests. The new test runners will
take care of
rerunning failing tests.
R
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256824: Remove old flaky test rerun logic (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D15855?vs=43871&id=43974#toc
Repository:
rL LLVM
http://reviews.llvm.org/D15855
File
Author: labath
Date: Tue Jan 5 06:51:26 2016
New Revision: 256827
URL: http://llvm.org/viewvc/llvm-project?rev=256827&view=rev
Log:
Remove XTIMEOUT from TestEvents on linux
I'm getting rid of the expected timeouts. I'll XFAIL/skip any tests that show
up as failing after
this (I haven't seen any
Author: labath
Date: Tue Jan 5 08:21:15 2016
New Revision: 256835
URL: http://llvm.org/viewvc/llvm-project?rev=256835&view=rev
Log:
Mark a test_lldbmi_gdb_set_target_async_on as flaky on linux
Test fails in about 1% of buildbot runs. Marking as flaky to avoid the noise.
Modified:
lldb/trunk
Author: labath
Date: Tue Jan 5 11:55:32 2016
New Revision: 256852
URL: http://llvm.org/viewvc/llvm-project?rev=256852&view=rev
Log:
Fix a typo in Process.cpp
Modified:
lldb/trunk/source/Target/Process.cpp
Modified: lldb/trunk/source/Target/Process.cpp
URL:
http://llvm.org/viewvc/llvm-proje
Author: labath
Date: Tue Jan 5 11:55:35 2016
New Revision: 256853
URL: http://llvm.org/viewvc/llvm-project?rev=256853&view=rev
Log:
Add logging to SBProcess::GetRestartedFromEvent
Modified:
lldb/trunk/source/API/SBProcess.cpp
Modified: lldb/trunk/source/API/SBProcess.cpp
URL:
http://llvm.o
Author: labath
Date: Tue Jan 5 11:55:29 2016
New Revision: 256851
URL: http://llvm.org/viewvc/llvm-project?rev=256851&view=rev
Log:
Fix a typo in lldbutil.py
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py
Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py
URL:
labath added a subscriber: labath.
labath added a comment.
Yes, please don't insert new decorators, we have enough as it is. You can
achieve the behavior you want with the correct arguments to expectedFailureAll
decorator.
http://reviews.llvm.org/D15893
_
Author: labath
Date: Wed Jan 6 03:48:54 2016
New Revision: 256925
URL: http://llvm.org/viewvc/llvm-project?rev=256925&view=rev
Log:
XFAIL TestMiSymbol on linux
new test introduced in r256863 fails on linux.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/symbol/TestMiSymb
labath added a subscriber: labath.
labath added a comment.
Hi, this introduces loads of new compiler warnings like:
lldb/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp:1434:14:
warning: variable 'target' is used uninitialized whenever 'if' condition is
false [-Wsometimes-uninitial
labath added a subscriber: labath.
labath added a comment.
Hi, the new check you have added to TestMiSymbol fails on linux: all the source
lines are listed twice for some reason. I don't know if this is expected
behavior (and the test needs to be fixed) or it's an bug (and the code needs to
be
Author: labath
Date: Wed Jan 6 05:40:06 2016
New Revision: 256928
URL: http://llvm.org/viewvc/llvm-project?rev=256928&view=rev
Log:
Fix a bug in lldbutil.expect_state_changes
The logic for skipping over the stop-and-restart events was incorrect as it was
also skipping the
expectations. Implemen
Author: labath
Date: Wed Jan 6 08:15:32 2016
New Revision: 256935
URL: http://llvm.org/viewvc/llvm-project?rev=256935&view=rev
Log:
Remove XTIMEOUT from TestMultithreaded on linux
instead, mark the test as expected flaky, which will trigger a rerun in case
the test hangs.
Modified:
lldb/t
labath added a comment.
It's looking good now, thanks.
Repository:
rL LLVM
http://reviews.llvm.org/D15886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Thu Jan 7 05:16:30 2016
New Revision: 257052
URL: http://llvm.org/viewvc/llvm-project?rev=257052&view=rev
Log:
Remove some Windows->Android XTIMEOUTs
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dosep.py
Modified: lldb/trunk/packages/Python/lldbsuite/test/dosep.p
Author: labath
Date: Thu Jan 7 09:24:51 2016
New Revision: 257068
URL: http://llvm.org/viewvc/llvm-project?rev=257068&view=rev
Log:
XFAIL TestMultithreaded on linux
Test sometimes fails even during the reruns, upgrading to xflaky to xfail.
Modified:
lldb/trunk/packages/Python/lldbsuite/tes
Author: labath
Date: Fri Jan 8 04:38:20 2016
New Revision: 257160
URL: http://llvm.org/viewvc/llvm-project?rev=257160&view=rev
Log:
Fix TestBatchMode on linux
New test introduced in r257120 was failing on linux. The reason for that the
regex for setting
the breakpoint was being applied to the "
Author: labath
Date: Fri Jan 8 05:16:45 2016
New Revision: 257165
URL: http://llvm.org/viewvc/llvm-project?rev=257165&view=rev
Log:
Another fix for TestBatchMode on linux
On locked down systems (such as our buildbot) one needs to do a special dance
to allow attaching
to processes. This commit a
Author: labath
Date: Fri Jan 8 05:23:21 2016
New Revision: 257166
URL: http://llvm.org/viewvc/llvm-project?rev=257166&view=rev
Log:
Fix TestBatchMode for gcc
gcc by default does not accept for loop declarations in C files (one must
choose C99 mode first,
which we don't). Place the declaration o
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
On linux we need the process to give us special permissions before we can
attach to it.
Previously, the code for this was copied into every file that needed it. This
moves the code to a
cent
labath accepted this revision.
labath added a reviewer: labath.
labath added a comment.
`__builtin_debugtrap()` indeed works (thanks Jim), but only on clang (no gcc).
Since that is architecture-independent, I think we should use that and just
make the test @skipIfGcc. Apart from that, the test w
labath added a comment.
Good idea. I'll do that.
http://reviews.llvm.org/D15992
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257319: Centralize the handling of attach permissions on
linux in tests (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D15992?vs=44316&id=44453#toc
Repository:
rL LLVM
http:/
Author: labath
Date: Mon Jan 11 04:24:50 2016
New Revision: 257319
URL: http://llvm.org/viewvc/llvm-project?rev=257319&view=rev
Log:
Centralize the handling of attach permissions on linux in tests
Summary:
On linux we need the process to give us special permissions before we can
attach to it.
Pr
Author: labath
Date: Mon Jan 11 04:27:31 2016
New Revision: 257321
URL: http://llvm.org/viewvc/llvm-project?rev=257321&view=rev
Log:
Remove CRLF line endings from test_common.h
Modified:
lldb/trunk/packages/Python/lldbsuite/test/make/test_common.h
Modified: lldb/trunk/packages/Python/lldbsui
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
Clang recently added support for an OpenCL pipe type. Adding the new type to
relevant switches to
avoid warnings.
http://reviews.llvm.org/D16055
Files:
source/Symbol/ClangASTContext.cpp
Author: labath
Date: Mon Jan 11 04:55:57 2016
New Revision: 257323
URL: http://llvm.org/viewvc/llvm-project?rev=257323&view=rev
Log:
Skip TestEvents on linux completely
The test hangs/crashes/fails because it does not use the listener API in a way
that LLDB expects.
I don't really know if this i
Author: labath
Date: Mon Jan 11 05:59:38 2016
New Revision: 257329
URL: http://llvm.org/viewvc/llvm-project?rev=257329&view=rev
Log:
Mark TestChangeValueAPI as flaky on linux (pr25652)
Modified:
lldb/trunk/packages/Python/lldbsuite/test/python_api/value/change_values/TestChangeValueAPI.py
M
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257460: Add clang::Type::Pipe to ClangASTContext (authored
by labath).
Changed prior to commit:
http://reviews.llvm.org/D16055?vs=44456&id=44607#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1605
Author: labath
Date: Tue Jan 12 02:51:28 2016
New Revision: 257460
URL: http://llvm.org/viewvc/llvm-project?rev=257460&view=rev
Log:
Add clang::Type::Pipe to ClangASTContext
Summary:
Clang recently added support for an OpenCL pipe type. Adding the new type to
relevant switches to
avoid warnings.
1801 - 1900 of 6833 matches
Mail list logo
