No worries. I wanted to rename that function anyway, but then I forgot, so it's good that you have reminded me. :)
On 15 December 2015 at 22:18, Todd Fiala <todd.fi...@gmail.com> wrote: > tfiala added a comment. > > Hey Pavel, > > Change r255676 changed a few things that will require this patch to get > updated. I think the main code change will be that > ResultsFormatter._make_rerun_eligibility_key(self) has been renamed to > ResultsFormatter._make_key(self). I folded the BasicResultsFormatter class > into ResultsFormatter since any specialized results formatters still likely > want to display the results summary output at the end. That key is now used > in several places and they're not at all specific to rerun eligibility. > > The rest of the differences are likely just line number changes as the new > code here will just need to slide into different final spots in the now > top-of-tree version of result_formatter.py. > > Thanks, and sorry for the collision! > > > http://reviews.llvm.org/D15530 > > > _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
