labath added a comment.
Thanks for fixing all the comments. Unfortunately, on my last pass, I found one
more case of unverified input (I think).
> MinidumpParser.cpp:252
> + if (range_start <= addr && addr < range_start + range_size) {
> + return Range(range_start, GetData().slice(loc_desc.rva, range_size));
> + }
Is anything verifying that loc_desc points into the file ?
> ProcessMinidump.cpp:187
> + // Don't allow the caching that lldb_private::Process::ReadMemory does
> + // since we have it all cached our our dump file anyway.
> + return DoReadMemory(addr, buf, size, error);
typo: "in our"
https://reviews.llvm.org/D25196
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
