labath added a comment.
@krytarowski: I thought I'd switch netbsd as well, as all the other platforms
are doing it already. However, if you want to stick with the system demangler
by default, I can easily change it to OFF ...
https://reviews.llvm.org/D23830
_
Author: labath
Date: Wed Aug 24 09:03:10 2016
New Revision: 279627
URL: http://llvm.org/viewvc/llvm-project?rev=279627&view=rev
Log:
Fix mismatched new/free in Process:RunPrivateStateThread
NFC
Modified:
lldb/trunk/source/Target/Process.cpp
Modified: lldb/trunk/source/Target/Process.cpp
URL
Author: labath
Date: Thu Aug 25 03:22:14 2016
New Revision: 279724
URL: http://llvm.org/viewvc/llvm-project?rev=279724&view=rev
Log:
Fix warnings preventing copy elision.
Summary:
Moving a temporary object prevents copy elision, which is exactly
what clang points out by warning about this pattern
labath added a subscriber: labath.
labath closed this revision.
labath added a comment.
committed in r279724.
https://reviews.llvm.org/D23825
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279725: gdb-remote: Make the sequence mutex non-recursive
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D23802?vs=69088&id=69208#toc
Repository:
rL LLVM
https://reviews.llv
Author: labath
Date: Thu Aug 25 03:34:57 2016
New Revision: 279725
URL: http://llvm.org/viewvc/llvm-project?rev=279725&view=rev
Log:
gdb-remote: Make the sequence mutex non-recursive
Summary:
This is a preparatory commit for D22914, where I'd like to replace this mutex
by an R/W lock
(which is a
labath created this revision.
labath added reviewers: ovyalov, clayborg.
labath added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Oleksiy is no longer active in LLDB, I'd like to formally assume ownership of
the linux and
android parts.
https://reviews.llvm.org/
labath added a comment.
Thank you for writing the tests. I have two stylistic comments, but otherwise
looks great.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:113
@@ -105,4 +112,3 @@
case 'J':
-// Asynchronous JSON packet,
labath added a subscriber: labath.
labath added reviewers: ki.stfu, abidh.
labath added a comment.
Woohoo. I am glad that this is finally getting fixed.
https://reviews.llvm.org/D23882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:/
Author: labath
Date: Fri Aug 26 04:47:58 2016
New Revision: 279808
URL: http://llvm.org/viewvc/llvm-project?rev=279808&view=rev
Log:
Add cmake option to choose whether to use the builtin demangler
Summary:
Previously the builting demangler was on for platforms that explicitly set a
flag by modif
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279808: Add cmake option to choose whether to use the
builtin demangler (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D23830?vs=69093&id=69333#toc
Repository:
rL LLVM
https
Author: labath
Date: Fri Aug 26 05:06:13 2016
New Revision: 279812
URL: http://llvm.org/viewvc/llvm-project?rev=279812&view=rev
Log:
Switch linux and android CODE_OWNERS
Summary:
Oleksiy is no longer active in LLDB, I'd like to formally assume ownership of
the linux and
android parts.
Reviewers
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279812: Switch linux and android CODE_OWNERS (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D23877?vs=69249&id=69335#toc
Repository:
rL LLVM
https://reviews.llvm.org/D23877
labath added a comment.
Looks fine to me. Adrian, Zachary, any more thoughts here?
Comment at: source/Plugins/Process/minidump/MinidumpParser.h:42
@@ +41,3 @@
+public:
+explicit MinidumpParser(const lldb::DataBufferSP &data_buf_sp, const
MinidumpHeader *header,
+
Author: labath
Date: Tue Aug 30 06:17:00 2016
New Revision: 280074
URL: http://llvm.org/viewvc/llvm-project?rev=280074&view=rev
Log:
Fix fallout from the GetNameColonValue() refactor (r28)
This fixes the linux test suite.
Modified:
lldb/trunk/source/Interpreter/Args.cpp
lldb/trunk/s
labath added a comment.
Which revision is this patch against? It does not seem to apply cleanly to
trunk for me. Could you try running the test suite on linux or mac as well, as
the last StringRef change left things in a pretty broken state there (you are
changing code which is pretty-much unus
Author: labath
Date: Tue Aug 30 08:18:46 2016
New Revision: 280087
URL: http://llvm.org/viewvc/llvm-project?rev=280087&view=rev
Log:
Fix darwin cmake build for r279997
Modified:
lldb/trunk/tools/debugserver/source/CMakeLists.txt
Modified: lldb/trunk/tools/debugserver/source/CMakeLists.txt
UR
I think we should move the new file away from source/Utility. If it's
supposed to be used by debugserver only, we probably should move it to
tools/debugserver/source ? Right now, debugservers cmake file contains
a hack to be able to include these, so by doing that we will remove
that as well.
Thou
I've seen that one. What kind of changes do you have in mind? I am not
sure how these things are related, as the StdString version is already
being used only by debugserver (*), and you don't plan to make changes
to it (afaik).
(*)
$ git grep -l -w StdStringExtractor
include/lldb/Utility/StdString
Author: labath
Date: Tue Aug 30 08:56:11 2016
New Revision: 280088
URL: http://llvm.org/viewvc/llvm-project?rev=280088&view=rev
Log:
Revert "gdb-remote: Make the sequence mutex non-recursive"
This reverts commit r279725 as it breaks "dynamic register size" feature of
mips.
Modified:
lldb/tr
labath added a comment.
Thanks for the heads up. I'll need to give this some thought. I've pulled the
change out until I can figure out what to do.
BTW, have you guys considered putting up a mips buildbot to detect these kinds
of things?
Repository:
rL LLVM
https://reviews.llvm.org/D23802
Author: labath
Date: Wed Aug 31 02:42:38 2016
New Revision: 280202
URL: http://llvm.org/viewvc/llvm-project?rev=280202&view=rev
Log:
Fix lldb build on Mac.
Summary:
https://github.com/llvm-mirror/lldb/commit/e80f43fd78fa0fbc04d2d59b5713acb5d06c8308
greatly improved an API, but missed one more occ
Author: labath
Date: Wed Aug 31 02:49:37 2016
New Revision: 280204
URL: http://llvm.org/viewvc/llvm-project?rev=280204&view=rev
Log:
Revert r280200 and put it a proper fix
PeekChar returns a character, we want the whole string there.
Modified:
lldb/trunk/source/Plugins/Process/Linux/NativePr
Author: labath
Date: Wed Aug 31 03:43:40 2016
New Revision: 280208
URL: http://llvm.org/viewvc/llvm-project?rev=280208&view=rev
Log:
XFail new TestPyObjSynthProvider.py on linux until I can investigate the cause
of the problem
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalit
Author: labath
Date: Wed Aug 31 03:43:37 2016
New Revision: 280207
URL: http://llvm.org/viewvc/llvm-project?rev=280207&view=rev
Log:
Revert r280137 and 280139 and subsequent build fixes
The rewrite of StringExtractor::GetHexMaxU32 changes functionality in a way
which makes
lldb-server crash. The
labath created this revision.
labath added a reviewer: granata.enrico.
labath added a subscriber: lldb-commits.
- copies the new file in the cmake build
- adds an additional import statement
- marks the test as no-debug-info specific, as it seems to be testing a python
feature
https://reviews.ll
n Wed, Aug 31, 2016 at 12:57 AM Pavel Labath via lldb-commits
> wrote:
>>
>> Author: labath
>> Date: Wed Aug 31 02:49:37 2016
>> New Revision: 280204
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=280204&view=rev
>> Log:
>> Revert r2802
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
It is hung because one of your previous changes broke a very fundamental piece
of functionality, which makes all tests fail. It is fixed now
http://lab.llvm.org:8011/builders/lldb-x8
016 at 1:51 AM Pavel Labath via lldb-commits
> wrote:
>>
>> Author: labath
>> Date: Wed Aug 31 03:43:37 2016
>> New Revision: 280207
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=280207&view=rev
>> Log:
>> Revert r280137 and 280139 and
0)); // instead it crashes
>>
>>
>>
>> On 31 August 2016 at 14:22, Zachary Turner wrote:
>> > Can you post the exact contents of the string causing the crash? I'll
>> > add a
>> > unittest for it
>> >
>> > On Wed, Aug 31
labath created this revision.
labath added reviewers: gkistanova, chying.
labath added subscribers: lldb-commits, zturner.
Herald added subscribers: srhines, danalbert, tberghammer.
The buildbot has been stable for the past few months and having it send
breakage emails will make it much easier to
labath created this revision.
labath added a reviewer: tberghammer.
labath added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
The vdso is full of hand-written assembly which the instruction emulator has a
hard time
understanding. Luckily, the kernel already provid
Author: labath
Date: Wed Aug 31 12:38:17 2016
New Revision: 280261
URL: http://llvm.org/viewvc/llvm-project?rev=280261&view=rev
Log:
Fixup TestPyObjSynthProvider.py and enable it again
Summary:
- copies the new file in the cmake build
- adds an additional import statement
- marks the test as no-d
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280261: Fixup TestPyObjSynthProvider.py and enable it again
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D24074?vs=69836&id=69881#toc
Repository:
rL LLVM
https://reviews.l
labath added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py:19
@@ -18,2 +18,3 @@
mydir = TestBase.compute_mydir(__file__)
+NO_DEBUG_INFO_TESTCASE = True
granata.en
Author: labath
Date: Wed Aug 31 12:43:49 2016
New Revision: 280264
URL: http://llvm.org/viewvc/llvm-project?rev=280264&view=rev
Log:
Always rely on CFI unwind info for linux vdso
Summary:
The vdso is full of hand-written assembly which the instruction emulator has a
hard time
understanding. Luck
labath added inline comments.
Comment at:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:13-14
@@ +12,4 @@
+
+// Project includes
+#include "AuxVector.h"
+
tberghammer wrote:
> Why do we need this?
I'm not adding anything. I just took the oppo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280264: Always rely on CFI unwind info for linux vdso
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D24079?vs=69857&id=69883#toc
Repository:
rL LLVM
https://reviews.llvm.or
Author: labath
Date: Thu Sep 1 04:17:37 2016
New Revision: 280344
URL: http://llvm.org/viewvc/llvm-project?rev=280344&view=rev
Log:
XFail TestMemoryFind on 32-bit architectures
the test fails for a very prosaic reason: `(const char *)0x1000` returns "4096"
on x86_64 and
"1000" (without the "0x"
labath created this revision.
labath added reviewers: clayborg, granata.enrico.
labath added a subscriber: lldb-commits.
It seems the original intention of the function was printing signed values in
decimal format, and
unsigned values in hex (without the leading "0x"). However, signed and unsigne
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks great. Thanks.
https://reviews.llvm.org/D24122
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I don't think the patch can go in in this form. Also, you seem to be putting
multiple unrelated changes in one patch. It would be much easier to review if
you split that up into mult
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280362: [zorg] Move lldb-x86_64-ubuntu-14.04-cmake buildbot
to the stable category (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D24078?vs=69853&id=69996#toc
Repository:
rL
.
Or I am misunderstanding the question..
pl
On 1 September 2016 at 15:15, Zachary Turner wrote:
> What about a case in the unit test where the value overflows the type? Would
> that be useful?
> On Thu, Sep 1, 2016 at 3:50 AM Pavel Labath via lldb-commits
> wrote:
>>
>
labath added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1844
@@ +1843,3 @@
+
+uint64_t value;
+value = reg_size == 4 ? *(uint32_t *)reg_bytes : *(uint64_t *)reg_bytes;
nitesh.jain wrote:
> labat
:
> I am probably being a little dense right now, but I can't seem to find
> (const char*)0x1000 anywhere in the test case code...
>
> On Sep 1, 2016, at 2:17 AM, Pavel Labath via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
> Author: labath
> Date:
Author: labath
Date: Fri Sep 2 04:25:42 2016
New Revision: 280477
URL: http://llvm.org/viewvc/llvm-project?rev=280477&view=rev
Log:
Bump up TestCallWithTimeout timeout
Still a bit flaky on remote targets. Trying a larger bump this time. :/
Modified:
lldb/trunk/packages/Python/lldbsuite/tes
Author: labath
Date: Fri Sep 2 04:25:36 2016
New Revision: 280476
URL: http://llvm.org/viewvc/llvm-project?rev=280476&view=rev
Log:
Make Scalar::GetValue more consistent
Summary:
It seems the original intention of the function was printing signed values in
decimal format, and
unsigned values in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280476: Make Scalar::GetValue more consistent (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D24126?vs=69979&id=70140#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24126
labath added inline comments.
Comment at: lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.cpp:146
@@ +145,3 @@
+break;
+}
+
You have a "enumeration not handled in a switch" warning here. Could you do
something about that?
Repository:
Author: labath
Date: Fri Sep 2 04:52:18 2016
New Revision: 280478
URL: http://llvm.org/viewvc/llvm-project?rev=280478&view=rev
Log:
Revert "Make Scalar::GetValue more consistent"
This reverts commit r280476 as it breaks several tests on i386. I was fixing an
32-bit
breakage, and I did not run t
Author: labath
Date: Fri Sep 2 05:58:52 2016
New Revision: 280480
URL: http://llvm.org/viewvc/llvm-project?rev=280480&view=rev
Log:
Reapply "Make Scalar::GetValue more consistent"
this is a resubmission of r280476. The problem with the original commit was
that it was printing
out all numbers as
Author: labath
Date: Mon Sep 5 03:34:56 2016
New Revision: 280652
URL: http://llvm.org/viewvc/llvm-project?rev=280652&view=rev
Log:
Add default_packet_timeout key to the new TestGdbRemoteHostInfo test
android targets use this key, so the test should recognize it.
Modified:
lldb/trunk/packa
labath added a comment.
Thanks for the patch. The changes seem pretty straight-forward. I'd just like
to sort out some issues in the new test first.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/TestMPXRegisters.py:27
@@ +26,3 @@
+
labath added a subscriber: labath.
labath added a comment.
Comment at: include/lldb/Host/FileSpec.h:712
@@ +711,3 @@
+ PathSyntax syntax = ePathSyntaxHostNative,
+ llvm::Triple *triple = nullptr);
+
I don't think the default-null paramet
labath added a comment.
Tests run clean when I apply this locally. Do you want me to put that in for
you?
https://reviews.llvm.org/D23882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
This adds the jModulesInfo packet, which is the equivalent of qModulesInfo, but
it enables us to
query multiple modules at once. This makes a
labath abandoned this revision.
labath added a comment.
I am abandoning this for the time being in favour of
https://reviews.llvm.org/D24236. The actual implementation of it turned out to
be more hackish then I anticipated.
https://reviews.llvm.org/D22914
___
labath added a comment.
There has been no activity here for 6 months. Shall we close it?
https://reviews.llvm.org/D16128
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Mon Sep 5 10:15:12 2016
New Revision: 280662
URL: http://llvm.org/viewvc/llvm-project?rev=280662&view=rev
Log:
Replace uses of MIUtilParse::CRegexParser with llvm::Regex
Summary:
Replace uses of the local MIUtilParse::CRegexParser class with the LLVM support
class llvm::Reg
labath closed this revision.
labath added a comment.
r280662
https://reviews.llvm.org/D23882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
BTW, what tests are failing for you now? I bet they failures are
caused by one of two things:
- unexpected compiler, for which we don't have the correct @xfail
annotations: the annotations are correct for gcc-4.8, gcc-4.9,
clang-3.5, clang-3.6 and ToT clang. If you have a different compiler,
they c
Author: labath
Date: Tue Sep 6 05:04:22 2016
New Revision: 280697
URL: http://llvm.org/viewvc/llvm-project?rev=280697&view=rev
Log:
Fix build breakage in r280692
The commit introduced an array of const objects, which libstdc++ does not like.
Make the object
non-const.
Also fix a compiler warni
On 6 September 2016 at 05:48, Sean Callanan via lldb-commits
wrote:
> +
> +struct Operand
> +{
> +enum class Type {
> +Invalid = 0,
> +Register,
> +Immediate,
> +Dereference,
> +Sum,
> +Product
> +} m_t
Author: labath
Date: Tue Sep 6 06:08:02 2016
New Revision: 280704
URL: http://llvm.org/viewvc/llvm-project?rev=280704&view=rev
Log:
Second round of fixups for r280692
Android targets don't have std::to_string and std::stoul. Use llvm::to_string
and strtoul
instead.
Modified:
lldb/trunk/sou
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I have a couple of questions I'd like to be answered before this goes in. Apart
from the inline comments, all my questions from the previous version of this
commit still stand.
===
labath updated this revision to Diff 70409.
labath added a comment.
- fix a bug where we would mark all modules as invalid if communicating with a
stub which does not support this packet
- extend the packet documentation about what to do when modules are not found
and the server volunteering inf
labath added a reviewer: jasonmolenda.
labath added a comment.
Hm... I was not aware of that packet. It does not appear to be directly
applicable to this situation, because it queries the module information by load
address, whereas here I query by file path. Also my packet does not return the
s
Author: labath
Date: Wed Sep 7 03:46:50 2016
New Revision: 280793
URL: http://llvm.org/viewvc/llvm-project?rev=280793&view=rev
Log:
Fix unittest compilation on windows
After the reformat, the unittests do not compile due to missing due to
redefinition errors
between PosixApi.h and ucrt/direct.h
labath added a comment.
Thank you for addressing the comments. let's continue this in the other thread.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/TestMPXRegisters.py:27
@@ +26,3 @@
+
+@skipIfiOSSimulator
+@skipIf(compile
labath added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:5
@@ +4,3 @@
+
+ifeq "$(ARCH)" "i386"
+ CXXFLAGS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32
valentinagiusti wrote:
> la
labath added a comment.
Ok, after a bit more digging, this is what I have found:
> Error ProcessGDBRemote::GetLoadedModuleList (LoadedModuleInfoList & list);
>
This packet is not usable **in it's current form** as it does not include the
UUID of the module. As far as I can tell, it is inte
labath added a comment.
I think we're approaching the end now. If you could upload the new version
(you'll have to reformat the changes), I'll give it a final pass.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:6
@@ +5,3 @
Author: labath
Date: Thu Sep 8 05:07:04 2016
New Revision: 280919
URL: http://llvm.org/viewvc/llvm-project?rev=280919&view=rev
Log:
gdb-remote: Add jModulesInfo packet
Summary:
This adds the jModulesInfo packet, which is the equivalent of qModulesInfo, but
it enables us to
query multiple module
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280919: gdb-remote: Add jModulesInfo packet (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D24236?vs=70409&id=70671#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24236
Author: labath
Date: Thu Sep 8 06:09:14 2016
New Revision: 280922
URL: http://llvm.org/viewvc/llvm-project?rev=280922&view=rev
Log:
Fix test breakage in r280919
It turns out that self.dbg.GetSelectedPlatform().GetTriple() is not a good way
to get the triple of the process, as it returns the inco
labath added a comment.
The reformat is complete, and our main buildbot is (as I think you've already
found out) in the non-experimental mode. As far as I am concerned, we can
proceed with this. If you can't test on linux before hand, just look out for
the emails and be ready to respond. If the
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
https://reviews.llvm.org/D24255
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: labath
Date: Thu Sep 8 11:58:30 2016
New Revision: 280965
URL: http://llvm.org/viewvc/llvm-project?rev=280965&view=rev
Log:
Fix MSVC error from r280919
MSVC did not understand my brace-initializer syntax. :/
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
labath added subscribers: zturner, lldb-commits, clayborg.
labath added a comment.
I am cc'ing a bunch of people to make sure we don't do this behind anyone's
back. I don't know whether you discussed this with anyone on lldb side (it's
certainly new to me), but I think it deserves a wider audien
Author: labath
Date: Fri Sep 9 04:49:54 2016
New Revision: 281025
URL: http://llvm.org/viewvc/llvm-project?rev=281025&view=rev
Log:
Fix new gdb-remote client unit test for windows
The behaviour of FileSpec differed between host OS versions. Hardcode the path
syntax to posix, as we don't care abo
Author: labath
Date: Fri Sep 9 05:12:57 2016
New Revision: 281029
URL: http://llvm.org/viewvc/llvm-project?rev=281029&view=rev
Log:
NFC: Reformat ABISysV_i386 register context into something readable
add clang-format guards so it does not reformat it again.
Modified:
lldb/trunk/source/Plugi
labath added a comment.
A collection of small remarks, mostly to do with style. Mainly, I'd like to
make the tests more strict about what they accept as reasonable values.
A higher level question: Given that we are already in the `minidump` namespace,
do we want all (most) of these symbols to b
labath added a comment.
@mgorny: The change should be reviewed by an lldb-mi maintainer (i.e.,
@ki.stfu). It helps is you explicitly specify the reviewer, as otherwise the
person may not notice the patch.
In https://reviews.llvm.org/D23883#539471, @mgorny wrote:
> In https://reviews.llvm.org/D
Author: labath
Date: Mon Sep 12 11:13:05 2016
New Revision: 281226
URL: http://llvm.org/viewvc/llvm-project?rev=281226&view=rev
Log:
Move StdStringExtractor to tools/debugserver
The class is only used in the debugserver. The rest of lldb has the
StringExtractor class.
Xcode project will need to
labath added a comment.
Just a couple of tiny comments from me.
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:86
@@ +85,3 @@
+llvm::Optional MinidumpParser::GetMinidumpString(uint32_t rva) {
+ auto arr_ref = m_data_sp->GetData().drop_front(rva);
+ return parse
Author: labath
Date: Tue Sep 13 05:39:12 2016
New Revision: 281317
URL: http://llvm.org/viewvc/llvm-project?rev=281317&view=rev
Log:
Remove MIUtilParse (no longer used)
Summary: follow-up to https://reviews.llvm.org/D23882
Reviewers: dawn, krytarowski, labath, ki.stfu
Subscribers: beanz, mgorny
labath closed this revision.
labath added a comment.
I am going to assume you still want me to submit this. r281317.
https://reviews.llvm.org/D23883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
labath added a comment.
Looks good as far as I am concerned.
https://reviews.llvm.org/D24385
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
Looks straight-forward enough. However, it could use a test-case.
https://reviews.llvm.org/D24514
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm. In general, feel free to manage mips decorators as you see fit.
https://reviews.llvm.org/D24549
___
lldb-commits mailing list
lldb-commits@
labath added a comment.
Thanks for adding the test case. LGTM from my side.
https://reviews.llvm.org/D24514
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
I have to admit I have very little knowledge of this part of the code. Could
you provide a bit of a high-level overview of this change? Does this fix an
existing problem ? (If so, should it have a test?) Or is it just a refactor?
Comment at:
source/Plu
labath added a comment.
The biggest feature I see missing here is the ability to run tests remotely.
Remote debugging is the most important use case for our team, and now we have a
number of (experimental) bots running the remote test suite. We want to make
sure we can debug correctly when the
labath added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:1183
@@ +1182,3 @@
+ case dwarf_config5_mips64:
+return reg_info->byte_offset;
+ case dwarf_cause_mips:
Why do we need to do this remapping? Couldn'
labath added a comment.
Btw, I will be in the bay area from 3rd to 7th of October. Maybe we could sit
down and talk the design and requirements through in person? I've been hoping
to speak to some of you in person anyway, and this could be a good first topic
on the agenda...
https://reviews.l
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I have some doubts about the validity of this patch. We should make sure those
are cleared before putting this in.
Comment at:
packages/Python/lldbsuite/test/funct
labath added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:1161
@@ +1160,3 @@
+ // In case of MIPS, the PTRACE_PEEKUSER/PTRACE_POKEUSER
+ // take register number has an offset
+ // Apart from GPR registers , the offset for othe
labath added a comment.
I don't think this is a totally bad idea. In fact we already had something like
this (nobody used it though), before it was removed in
https://reviews.llvm.org/rL255040. If it goes in, we might start using it
actually -- e.g., currently we have watchpoint tests which fa
labath added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/watchpoint/multi_watchpoint_slots/main.c:23
@@ +22,3 @@
+{
+printf("About to write byteArray[%d] ...\n", i); // About to write
byteArray
+
zturner wrote:
> What'
1701 - 1800 of 6833 matches
Mail list logo
