labath added a comment. Looks fine to me. Adrian, Zachary, any more thoughts here?
================ Comment at: source/Plugins/Process/minidump/MinidumpParser.h:42 @@ +41,3 @@ +public: + explicit MinidumpParser(const lldb::DataBufferSP &data_buf_sp, const MinidumpHeader *header, + const llvm::DenseMap<uint32_t, MinidumpLocationDescriptor> &directory_map); ---------------- If you have a `Create` function, the constructor should probably be private (also, `explicit` is not necessary anymore). https://reviews.llvm.org/D23545 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
