ovyalov added inline comments.
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:341
@@ -347,1 +340,3 @@
+AdbClient adb(m_device_id);
+
StreamString command;
I tried this CL on my device and it's failing to download a symbol
Author: ovyalov
Date: Wed Sep 30 17:27:55 2015
New Revision: 248956
URL: http://llvm.org/viewvc/llvm-project?rev=248956&view=rev
Log:
Fix Linux build.
Modified:
lldb/trunk/include/lldb/Symbol/ClangASTContext.h
Modified: lldb/trunk/include/lldb/Symbol/ClangASTContext.h
URL:
http://llvm.org/
ovyalov added a comment.
I tried Nexus 5 and 6P with Android M. Thanks for the new patch - it's fixing
the problem.
Repository:
rL LLVM
http://reviews.llvm.org/D13162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.or
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
ovyalov created this revision.
ovyalov added reviewers: clayborg, tberghammer.
ovyalov added a subscriber: lldb-commits.
Use %HOME%/.lldb/module_cache as a default module cache directory.
http://reviews.llvm.org/D13323
Files:
source/Target/Platform.cpp
Index: source/Target/Platform.cpp
==
ovyalov closed this revision.
ovyalov added a comment.
Users:
ovyalov (Author)
http://reviews.llvm.org/rL249040
http://reviews.llvm.org/D13323
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Author: ovyalov
Date: Thu Oct 1 12:48:57 2015
New Revision: 249040
URL: http://llvm.org/viewvc/llvm-project?rev=249040&view=rev
Log:
Use %HOME%/.lldb/module_cache as a default module cache directory.
http://reviews.llvm.org/D13323
Modified:
lldb/trunk/source/Target/Platform.cpp
Modified:
Author: ovyalov
Date: Thu Oct 1 14:08:00 2015
New Revision: 249055
URL: http://llvm.org/viewvc/llvm-project?rev=249055&view=rev
Log:
Fix Android build after r249047.
Modified:
lldb/trunk/source/Plugins/Language/ObjC/ObjCLanguage.cpp
Modified: lldb/trunk/source/Plugins/Language/ObjC/ObjCLan
Author: ovyalov
Date: Fri Oct 2 17:37:55 2015
New Revision: 249203
URL: http://llvm.org/viewvc/llvm-project?rev=249203&view=rev
Log:
Fix TestCompDirSymLink.py - remove existing symlink leftovers if previous test
run
was terminated (e.g., due timeout).
Modified:
lldb/trunk/test/functionalit
ovyalov created this revision.
ovyalov added reviewers: clayborg, zturner, labath.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
There are a few reasons for this change:
- Support generic logic flow for different socket types - a preparation
ovyalov updated this revision to Diff 37525.
ovyalov marked 3 inline comments as done.
ovyalov added a comment.
Addressed review suggestions.
Please take another look.
http://reviews.llvm.org/D13754
Files:
include/lldb/Host/Socket.h
include/lldb/Host/common/TCPSocket.h
include/lldb/Host/c
ovyalov added inline comments.
Comment at: source/Host/common/Socket.cpp:356
@@ -740,3 +355,3 @@
-uint16_t Socket::GetLocalPortNumber(const NativeSocket& socket)
+size_t Socket::Send(const void *buf, const size_t num_bytes)
{
Good point - done.
===
ovyalov closed this revision.
ovyalov added a comment.
Submitted as r234610
http://reviews.llvm.org/D8977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Thu Oct 15 18:54:09 2015
New Revision: 250474
URL: http://llvm.org/viewvc/llvm-project?rev=250474&view=rev
Log:
Split Socket class into Tcp/Udp/DomainSocket subclasses.
http://reviews.llvm.org/D13754
Added:
lldb/trunk/include/lldb/Host/common/TCPSocket.h
lldb/trunk
ovyalov added inline comments.
Comment at: source/Host/posix/DomainSocket.cpp:74
@@ +73,3 @@
+FileSystem::Unlink(FileSpec{name, true});
+
+Error error;
labath wrote:
> If we're going to use unique names, then this won't be necessary (and I would
> much ra
ovyalov created this revision.
ovyalov added reviewers: clayborg, labath, tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
This CL provides logic for running lldb-server on domain sockets and required
gdb-remote infrastructure chang
ovyalov updated this revision to Diff 37928.
ovyalov added a comment.
- Renamed LaunchGDBserverAndGetPort into LaunchGDBServer within
PlatformAndroidRemoteGDBServer/PlatformRemoteGDBServer/GDBRemoteCommunicationClient
- Fixed includes' order.
- Added Acceptor::LocalSocketId which returns either T
ovyalov added a comment.
In http://reviews.llvm.org/D13881#270878, @labath wrote:
> I *think* it looks good, but I find it quite hard to review a change of this
> size.
> A wise man once said "if your commit description contains bullet points, you
> are doing too much". I think it would be bet
Author: ovyalov
Date: Wed Oct 21 14:34:26 2015
New Revision: 250933
URL: http://llvm.org/viewvc/llvm-project?rev=250933&view=rev
Log:
Add domain socket support to gdb-remote protocol and lldb-server.
http://reviews.llvm.org/D13881
Added:
lldb/trunk/tools/lldb-server/Acceptor.cpp
lldb/tr
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/lldb.xcodeproj/project.pbxproj
/lldb/trunk/source/Host/posix/ConnectionFileDescriptorPosix.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
/lld
Author: ovyalov
Date: Wed Oct 21 16:58:22 2015
New Revision: 250953
URL: http://llvm.org/viewvc/llvm-project?rev=250953&view=rev
Log:
Fix lldb-server - write null terminating symbol along with port number.
Modified:
lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp
Modified: lldb/trunk/tools/
ovyalov created this revision.
ovyalov added reviewers: clayborg, labath.
ovyalov added a subscriber: lldb-commits.
Abstract domain sockets are supported only by Linux (at least, as documentation
says) so I'm putting new socket class into linux subfolder.
Since there is a possibility that abstrac
ovyalov added a comment.
In http://reviews.llvm.org/D13970#273217, @clayborg wrote:
> Looks good. At some point we should add these to the PluginMananger and have
> new instances found by having them register URL prefixes which match up with
> CreateInstance methods that are given the URL.
Th
Author: ovyalov
Date: Thu Oct 22 12:50:33 2015
New Revision: 251034
URL: http://llvm.org/viewvc/llvm-project?rev=251034&view=rev
Log:
Add support for abstract domain sockets.
http://reviews.llvm.org/D13970
Added:
lldb/trunk/include/lldb/Host/linux/AbstractSocket.h
lldb/trunk/source/Host
Author: ovyalov
Date: Thu Oct 22 14:17:32 2015
New Revision: 251044
URL: http://llvm.org/viewvc/llvm-project?rev=251044&view=rev
Log:
Set device_id to host value only in case of adb protocol.
Modified:
lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
lldb/trunk/source/Plugi
ovyalov created this revision.
ovyalov added a reviewer: clayborg.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Make Socket to support plugin interface - moved implementation classes into
source/Plugins/Socket folder and migrated most of use
ovyalov added a comment.
In http://reviews.llvm.org/D14085#275442, @zturner wrote:
> I'm not sure I agree with this change. The interface to programming with
> socket is by definition a property of the Host operating system. It seems to
> me like Host was already the correct place for this co
ovyalov added a comment.
In http://reviews.llvm.org/D14085#275507, @zturner wrote:
> I think most of the time they are used in a Connection class, but I don't
> think it's necessarily guaranteed they will always be that way.
>
> I can think of at least one use case in the future where we will ne
ovyalov retitled this revision from "Make Socket to support plugin interface"
to "Add Socket::Create factory method which uses socket scheme (tcp, unix,..)
to find an appropriate implementation class.".
ovyalov updated the summary for this revision.
ovyalov updated this revision to Diff 38484.
h
ovyalov retitled this revision from "Add Socket::Create factory method which
uses socket scheme (tcp, unix,..) to find an appropriate implementation class."
to "Add Socket::Create factory method which uses socket protocol to find an
appropriate implementation class.".
ovyalov updated the summary
ovyalov created this revision.
ovyalov added reviewers: tberghammer, labath.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
We can connect to a device using various protocols (tcp, unix domain, abstract).
Instead of adding new URL schemes (e.g., adb-uni
ovyalov accepted this revision.
ovyalov added a comment.
Looks good - minor comments.
Comment at:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:513
@@ +512,3 @@
+{
+FileSpec file_spec;
+file_spec.SetFile("[vdso]", false);
---
ovyalov added a comment.
In http://reviews.llvm.org/D14101#275946, @labath wrote:
> I like this. (I assume it will work with the tcp-connected devices which have
> an ID like `???:port`)
Yes - definitely.
http://reviews.llvm.org/D14101
___
lldb-
Author: ovyalov
Date: Tue Oct 27 12:32:01 2015
New Revision: 251417
URL: http://llvm.org/viewvc/llvm-project?rev=251417&view=rev
Log:
Add Socket::Create factory method which uses socket protocol to find an
appropriate implementation class.
http://reviews.llvm.org/D14085
Modified:
lldb/trun
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/include/lldb/Host/Socket.h
/lldb/trunk/include/lldb/Host/common/UDPSocket.h
/lldb/trunk/source/Host/common/Socket.cpp
/lldb/trunk/tools/lldb-server/Acceptor.cpp
/lldb/trunk/tools/lldb-server/Acceptor.h
Users:
Author: ovyalov
Date: Tue Oct 27 12:41:34 2015
New Revision: 251422
URL: http://llvm.org/viewvc/llvm-project?rev=251422&view=rev
Log:
Treat hostname in android URL as device id unless it matches "localhost".
http://reviews.llvm.org/D14101
Modified:
lldb/trunk/source/Plugins/Platform/Android
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL251422
http://reviews.llvm.org/D14101
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov created this revision.
ovyalov added a reviewer: clayborg.
ovyalov added a subscriber: lldb-commits.
Make lldb-gdbserver to take explicit socket scheme as command line argument -
so lldb gdb-server uses the same socket type as platform does.
http://reviews.llvm.org/D14126
Files:
sourc
ovyalov updated this revision to Diff 38588.
ovyalov added a comment.
Addressed review comments - please take another look.
http://reviews.llvm.org/D14126
Files:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
source/Plugins/Process/gdb-remote/GDBRemoteCommunicati
ovyalov added a comment.
Hi,
looks like TestHelloWorld and TestInferiorAssert began to fail after this
change -
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/7880
Could you mark these tests as XFAILs for now?
http://reviews.llvm.org/D14118
ovyalov added a comment.
You can get test logs from this link -
https://pantheon.corp.google.com/storage/browser/lldb_test_traces/lldb-x86_64-ubuntu-14.04-cmake/?project=android-devtools-lldb-build
I suspect that there are a few problems here:
1. TestHelloWorld - there is a race within the test
Author: ovyalov
Date: Wed Oct 28 13:36:11 2015
New Revision: 251542
URL: http://llvm.org/viewvc/llvm-project?rev=251542&view=rev
Log:
Mark TestHelloWorld and TestInferiorAssert.py as XFAIL due llvm.org/pr25338.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/inferior-ass
ovyalov added a comment.
Greg, is it ok to submit the CL?
http://reviews.llvm.org/D14126
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Wed Oct 28 14:49:50 2015
New Revision: 251547
URL: http://llvm.org/viewvc/llvm-project?rev=251547&view=rev
Log:
Make lldb-gdbserver to take explicit socket scheme as command line argument.
http://reviews.llvm.org/D14126
Modified:
lldb/trunk/source/Plugins/Process/gdb-
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.h
/lldb/trunk/tools/lldb-server/Acceptor.cpp
/lldb/trun
Author: ovyalov
Date: Wed Oct 28 17:21:02 2015
New Revision: 251563
URL: http://llvm.org/viewvc/llvm-project?rev=251563&view=rev
Log:
Remove unused SUN_LEN macro for Android.
Modified:
lldb/trunk/source/Host/posix/DomainSocket.cpp
Modified: lldb/trunk/source/Host/posix/DomainSocket.cpp
URL:
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D14166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
ovyalov added a comment.
In http://reviews.llvm.org/D14118#277675, @ravitheja wrote:
> Hi,
>
> This link for the traces needs a password, could u maybe provide me the
> login details or upload these somewhere else ? Also could u provide me the
> value of the AuxVectors during this test ?
Author: ovyalov
Date: Mon Nov 2 14:04:18 2015
New Revision: 251825
URL: http://llvm.org/viewvc/llvm-project?rev=251825&view=rev
Log:
Calculate size of sockaddr_un manually for abstract sockets:
- SUN_LEN doesn't work because strlen(sun_path) == 0
- sizeof(sockaddr_un) doesn't work on Android.
ovyalov created this revision.
ovyalov added reviewers: clayborg, tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Provide ADB port forwarding support for abstract sockets.
http://reviews.llvm.org/D14262
Files:
include/lldb/Host/posix/Con
ovyalov created this revision.
ovyalov added a reviewer: tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, aemerson.
Pass symbol file platform's file spec to ModuleCache::Put - i.e., to make sym
link path like this:
.lldb/module_cache/remot
Author: ovyalov
Date: Mon Nov 2 18:30:19 2015
New Revision: 251871
URL: http://llvm.org/viewvc/llvm-project?rev=251871&view=rev
Log:
Fix module cache sym links' creation for symbol files.
http://reviews.llvm.org/D14264
Modified:
lldb/trunk/source/Utility/ModuleCache.cpp
Modified: lldb/tru
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL251871
http://reviews.llvm.org/D14264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Mon Nov 2 19:37:01 2015
New Revision: 251879
URL: http://llvm.org/viewvc/llvm-project?rev=251879&view=rev
Log:
Provide ADB port forwarding support for abstract sockets.
http://reviews.llvm.org/D14262
Modified:
lldb/trunk/include/lldb/Host/posix/ConnectionFileDescripto
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/include/lldb/Host/posix/ConnectionFileDescriptorPosix.h
/lldb/trunk/source/Host/posix/ConnectionFileDescriptorPosix.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/A
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D14634
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
ovyalov added a comment.
Please see my comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:464
@@ -463,3 +463,3 @@
parsed_url = urlparse.urlparse(lldb.platform_url)
-if parsed_url.scheme == "adb":
+if parsed_url.scheme in ["adb", "unix-abstr
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: packages/Python/lldbsuite/test/lldbtest.py:464
@@ -463,3 +463,3 @@
parsed_url = urlparse.urlparse(lldb.platform_url)
-if parsed_url.scheme
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D14816
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov created this revision.
ovyalov added reviewers: clayborg, labath.
ovyalov added a subscriber: lldb-commits.
If remote platform is used and we're losing remote debug server connection in
between Process::ConnectRemote and Process::Attach (in context of
PlatformRemoteGDBServer::Attach) cur
ovyalov updated this revision to Diff 40948.
ovyalov added a comment.
Addressed review comments - renamed the method to EstablishConnectionIfNeeded.
http://reviews.llvm.org/D14895
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
source/Plugins/Process/gdb-remote/ProcessGDBRemot
Author: ovyalov
Date: Mon Nov 23 13:32:24 2015
New Revision: 253906
URL: http://llvm.org/viewvc/llvm-project?rev=253906&view=rev
Log:
Prevent ProcessGDBRemote from launching local debug server in case of remote
debug server connection failure.
http://reviews.llvm.org/D14895
Modified:
lldb/
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
Users:
ovyalov (Author)
http://reviews.llvm.org/rL253906
http://reviews.llvm.org/D14895
_
ovyalov closed this revision.
ovyalov added a comment.
Submitted as r250474
http://reviews.llvm.org/D13754
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov created this revision.
ovyalov added reviewers: clayborg, tberghammer.
ovyalov added a subscriber: lldb-commits.
Debug sections for JIT-ed code are stored in-memory and loaded as part of
module's image once __jit_debug_register_code is called -
if we cannot load a section by its base loa
Author: ovyalov
Date: Thu Dec 3 13:41:21 2015
New Revision: 254638
URL: http://llvm.org/viewvc/llvm-project?rev=254638&view=rev
Log:
Fix in-memory section loading for JIT-ed code.
http://reviews.llvm.org/D15172
Modified:
lldb/trunk/source/Symbol/ObjectFile.cpp
Modified: lldb/trunk/source/
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL254638
http://reviews.llvm.org/D15172
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
Comment at: cmake/platforms/Android.cmake:124
@@ -123,1 +123,3 @@
+# Use gold linker and enable safe ICF in case of x86, x86_64 and arm
+if ( ANDROID_ABI STREQUAL "x86"OR
Just out of curiosity -
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D15415
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D19557
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: source/Plugins/Language/Java/JavaLanguage.cpp:103
@@ +102,3 @@
+AddCXXSynthetic(g_category,
lldb_private::formatters::JavaArraySyntheticFrontEn
ovyalov added a comment.
LGTM
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:37
@@ -36,3 +36,3 @@
-const uint32_t kReadTimeout = 100; // 1 second
+const uint32_t kReadTimeout = 400; // 4 seconds
const char * kOKAY = "OKAY";
It might be usef
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D19916
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
ovyalov added a subscriber: ovyalov.
ovyalov added a comment.
Looks like this CL broke CMake build bot -
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/14634,
could you take a look?
Repository:
rL LLVM
http://reviews.llvm.org/D19124
__
ovyalov created this revision.
ovyalov added reviewers: labath, clayborg.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
ModuleCache hostname may contain symbols that are not allowed in filenames -
for example, in Android device_id is used as a hostna
ovyalov updated this revision to Diff 58180.
ovyalov added a comment.
Added asterisk symbol
http://reviews.llvm.org/D20548
Files:
source/Utility/ModuleCache.cpp
Index: source/Utility/ModuleCache.cpp
===
--- source/Utility/Module
ovyalov updated this revision to Diff 58258.
ovyalov added a comment.
Added the check for symbol in [1;31] range.
http://reviews.llvm.org/D20548
Files:
source/Utility/ModuleCache.cpp
Index: source/Utility/ModuleCache.cpp
===
---
ovyalov added a comment.
In http://reviews.llvm.org/D20548#437567, @labath wrote:
> According to
> https://msdn.microsoft.com/en-gb/library/windows/desktop/aa365247%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396,
> characters with codes 1..31 (basically `< ' '`), are illegal as well. We
> might
ovyalov added a comment.
In http://reviews.llvm.org/D20548#437862, @clayborg wrote:
> At some point we should probably make a host layer call like:
>
> const char *const char *Host::GetIllegalFilenameCharacters();" so that each
> host can determine the correct thing for the current host. Then Fi
ovyalov accepted this revision.
Comment at: unittests/Utility/ModuleCacheTest.cpp:74
@@ +73,3 @@
+{
+HostInfo::Initialize();
+ObjectFileELF::Initialize();
If it's one-off initialization can we use setUpTestCase for these purposes (for
HostInfo::Initialize
Author: ovyalov
Date: Tue May 24 13:09:05 2016
New Revision: 270590
URL: http://llvm.org/viewvc/llvm-project?rev=270590&view=rev
Log:
Replace file system forbidden symbols in the hostname which passed to the
ModuleCache.
http://reviews.llvm.org/D20548
Modified:
lldb/trunk/source/Utility/Mo
ovyalov closed this revision.
ovyalov added a comment.
Submitted as r270590
http://reviews.llvm.org/D20548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov added a comment.
In http://reviews.llvm.org/D16861#441964, @tfiala wrote:
> This change broke connection to debugserver on OS X - the constructed URL on
> debugserver does not take the tcp:// (URL-scheme) portion. This would
> manifest when 'lldb-server platform' was attempting to laun
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D21680
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov created this revision.
ovyalov added reviewers: labath, tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
- Extract sync commands like push/pull file and stat into SyncService so ADB
connection that's switched in sync mode can be reu
ovyalov added a comment.
In http://reviews.llvm.org/D21770#469876, @labath wrote:
> Is AdbClient getting big enough to deserve a couple of unit tests? All it
> would take is to add the ability to specify the address to connect to and
> make a small mock server that listens at that address?
It
ovyalov added a comment.
If you okay with that I'd like to submit this CL as-is and come up with unit
test with a separate change list.
http://reviews.llvm.org/D21770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
Author: ovyalov
Date: Thu Jun 30 13:10:27 2016
New Revision: 274256
URL: http://llvm.org/viewvc/llvm-project?rev=274256&view=rev
Log:
Improve ADB utilization within Android platform.
http://reviews.llvm.org/D21770
Modified:
lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
lldb/t
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
/lldb/trunk/source/Plugins/Platform/Android/Platf
ovyalov created this revision.
ovyalov added reviewers: labath, tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
- Disconnect SyncService in case of pull/push/stat request failure and make
Android platform to establish new ADB syn
Author: ovyalov
Date: Tue Jul 5 21:20:39 2016
New Revision: 274594
URL: http://llvm.org/viewvc/llvm-project?rev=274594&view=rev
Log:
Fix Linux build.
Modified:
lldb/trunk/source/Core/UserSettingsController.cpp
Modified: lldb/trunk/source/Core/UserSettingsController.cpp
URL:
http://llvm.or
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D22040
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
Author: ovyalov
Date: Wed Jul 6 12:02:42 2016
New Revision: 274638
URL: http://llvm.org/viewvc/llvm-project?rev=274638&view=rev
Log:
Fix ADB client disconnect issues.
http://reviews.llvm.org/D22029
Modified:
lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
lldb/trunk/source/Plu
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.h
/lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp
/lldb/trunk/source/Plugins/Platform/Android/Platf
ovyalov added inline comments.
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:71
@@ +70,3 @@
+{
+if (const char *android_serial = std::getenv("ANDROID_SERIAL"))
+adb.SetDeviceID(android_serial);
Could you check whethe
ovyalov created this revision.
ovyalov added reviewers: tberghammer, labath.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
adbd may fail to access a file due security constraints - in such case
sync:stat command returns file's mode as 0. If it's the c
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D22052
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
ovyalov updated this revision to Diff 63173.
ovyalov added a comment.
Addressed review comments:
- Check whether shell command output starts with /system/bin/sh: in order to
find out whether command failed
- Fail-fast download if filename contains single-quotes
- clang-format
http://reviews.ll
ovyalov added a comment.
In http://reviews.llvm.org/D22081#476766, @labath wrote:
> You raised good points here, Luke.
>
> I've thought about the quoting issue, but as you have already noticed there
> is no way to pass arguments containing quotes to adb correctly. Thinking
> about it more, what
ovyalov added a comment.
In http://reviews.llvm.org/D22081#477746, @labath wrote:
> Thanks for adding the additional checks. Looks good apart from the
> clang-format changes. This looks like the llvm style. I am not sure how
> you've run this but it does not seem to have picked up LLDB's `.clan
1 - 100 of 193 matches
Mail list logo
