[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

mib added a comment. In D148399#4284809 , @bulbazord wrote: > We'd go from: > > LLDB_LOGF(log, > "Process::SetPrivateState (plugin = %s, state = %s) state didn't " > "change. Ignoring...", > GetPluginName().data(), St

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

mib updated this revision to Diff 515473. mib edited the summary of this revision. mib added a comment. Address @JDevlieghere @bulbazord comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148399/new/ https://reviews.llvm.org/D148399 Files: lldb/source/Target/Process.cpp Index: l

[Lldb-commits] [PATCH] D148395: [lldb] Unify default/hijack listener between Process{Attach, Launch}Info (NFC)

mib added a comment. In D148395#4270508 , @bulbazord wrote: > Creating a ProcessAttachInfo from a ProcessLaunchInfo with this change means > they'll have different listeners. Is that ProcessLaunchInfo kept around for > any other reason? Or is it just ma

[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in passthrough mode to event listeners

mib marked 2 inline comments as done. mib added a comment. In D148397#4275792 , @JDevlieghere wrote: > I find "passthrough" somewhat confusing in this context. When using a > listener in this new mode, where does the event go after it has pass trough >

[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in passthrough mode to event listeners

mib updated this revision to Diff 515498. mib added a comment. Fix issue when returning a non-initialized passthrough listener from the SBAPI CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148397/new/ https://reviews.llvm.org/D148397 Files: lldb/include/lldb/API/SBAttachInfo.h lldb/

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

mib marked 23 inline comments as done. mib added inline comments. Comment at: lldb/test/API/functionalities/interactive_scripted_process/TestInteractiveScriptedProcess.py:102-103 +self.assertState(lldb.SBProcess.GetStateFromEvent(event), lldb.eStateRunning) +eve

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

mib updated this revision to Diff 515505. mib marked 2 inline comments as done. mib added a comment. Address @bulbazord comments: - f-string everything - remove logs - add type annotations CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145297/new/ https://reviews.llvm.org/D145297 Files

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

mib added a comment. ping @jingham @JDevlieghere CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145297/new/ https://reviews.llvm.org/D145297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

mib updated this revision to Diff 515523. mib added a comment. Fix typo in one of the type annotation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145297/new/ https://reviews.llvm.org/D145297 Files: lldb/test/API/functionalities/interactive_scripted_process/Makefile lldb/test/API

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

mib updated this revision to Diff 515529. mib added a comment. More f-string CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145297/new/ https://reviews.llvm.org/D145297 Files: lldb/test/API/functionalities/interactive_scripted_process/Makefile lldb/test/API/functionalities/interact

[Lldb-commits] [PATCH] D148395: [lldb] Unify default/hijack listener between Process{Attach, Launch}Info (NFC)

mib added a comment. In D148395#4287673 , @bulbazord wrote: > In D148395#4285017 , @mib wrote: > >> In D148395#4270508 , @bulbazord >> wrote: >> >>> Creating a ProcessAtt

[Lldb-commits] [PATCH] D148863: Make sure SelectMostRelevantFrame happens only when returning to the user

mib added a comment. It's unfortunate that we're not able to determine easily if the stop is public or not, so I guess this is the best we could do for now. We could however greatly reduce the amount of changes in the patch by having `select_most_relevant` default to `false` (or the `true` eith

[Lldb-commits] [PATCH] D148863: Make sure SelectMostRelevantFrame happens only when returning to the user

mib added inline comments. Comment at: lldb/include/lldb/Target/StackFrameList.h:56 + /// pass false here. + uint32_t GetSelectedFrameIndex(bool select_most_relevant_frame); I'd suggested making `select_most_relevant_frame = false` by default. Repository:

[Lldb-commits] [PATCH] D148863: Make sure SelectMostRelevantFrame happens only when returning to the user

mib added inline comments. Comment at: lldb/include/lldb/Target/Thread.h:433 + // call it internally. + uint32_t GetSelectedFrameIndex(bool select_most_relevant) { +return GetStackFrameList() ditto Comment at: lldb/include/lldb/Target/Thr

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

mib updated this revision to Diff 515899. mib marked 2 inline comments as done. mib added a comment. Re-format python code with `black` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145297/new/ https://reviews.llvm.org/D145297 Files: lldb/test/API/functionalities/interactive_scripted

[Lldb-commits] [PATCH] D148548: [lldb] Improve breakpoint management for interactive scripted process

mib updated this revision to Diff 515902. mib marked 2 inline comments as done. mib added a comment. Re-format python code with `black` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148548/new/ https://reviews.llvm.org/D148548 Files: lldb/bindings/interface/SBTargetExtensions.i lld

[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in shadow mode to event listeners

mib updated this revision to Diff 515956. mib marked an inline comment as done. mib retitled this revision from "[lldb/Utility] Add opt-in passthrough mode to event listeners" to "[lldb/Utility] Add opt-in shadow mode to event listeners". mib edited the summary of this revision. mib added a commen

[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in shadow mode to event listeners

mib updated this revision to Diff 515959. mib added a comment. More renaming and reformat CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148397/new/ https://reviews.llvm.org/D148397 Files: lldb/include/lldb/API/SBAttachInfo.h lldb/include/lldb/API/SBLaunchInfo.h lldb/include/lldb/

[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in shadow mode to event listeners

mib updated this revision to Diff 515960. mib added a comment. fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148397/new/ https://reviews.llvm.org/D148397 Files: lldb/include/lldb/API/SBAttachInfo.h lldb/include/lldb/API/SBLaunchInfo.h lldb/include/lldb/Target/Process.h

[Lldb-commits] [PATCH] D149175: [lldb/test] Update lldbutil.fetch_next_event to match broadcaster class

mib created this revision. mib added reviewers: bulbazord, jingham. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch updates the `lldbutil.fetch_next_event` he

[Lldb-commits] [PATCH] D149175: [lldb/test] Update lldbutil.fetch_next_event to match broadcaster class

mib updated this revision to Diff 516854. mib marked 2 inline comments as done. mib edited the summary of this revision. mib added a comment. Address @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149175/new/ https://reviews.llvm.org/D149175 Files: lldb/packages/P

[Lldb-commits] [PATCH] D149175: [lldb/test] Update lldbutil.fetch_next_event to match broadcaster class

mib added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1219-1220 +stream = lldb.SBStream() +event.GetDescription(stream) test.fail("received event '%s' from unexpected broadcaster '%s'." % bulbazord wrote

[Lldb-commits] [PATCH] D149179: [lldb/test] Consolidate interactive scripted process debugging test

mib created this revision. mib added reviewers: jingham, bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch improve the interactive scripted process debugging test by adding tes

[Lldb-commits] [PATCH] D149111: [lldb] Add support for specifying language when setting watchpoint by expression

mib requested changes to this revision. mib added a comment. This revision now requires changes to proceed. I think we should still be able to use this new flag with the previous ones (i.e. `watchpoint set -l c++ -w read -- &my_var`) Comment at: lldb/source/Interpreter/OptionG

[Lldb-commits] [PATCH] D149179: [lldb/test] Consolidate interactive scripted process debugging test

mib updated this revision to Diff 516929. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149179/new/ https://reviews.llvm.org/D149179 Files: lldb/test/API/functionalities/interactive_scripted_process/TestInteractiveScriptedProcess.py Index: lldb/test/API/functionalities/interactive_sc

[Lldb-commits] [PATCH] D145294: [lldb/API] Introduce SBProcess::ForceScriptedState method

This revision was automatically updated to reflect the committed changes. Closed by commit rG0d77e034749f: [lldb/API] Introduce SBProcess::ForceScriptedState method (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145294/new/ https:/

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c961ae1b507: [lldb] Move ScriptedProcess private state update to implementation (authored by mib). Changed prior to commit: https://reviews.llvm.org/D145295?vs=504877&id=516941#toc Repository: rG LL

[Lldb-commits] [PATCH] D148395: [lldb] Unify default/hijack listener between Process{Attach, Launch}Info (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG46e93c9df287: [lldb] Unify default/hijack listener between Process{Attach,Launch}Info (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in shadow mode to event listeners

This revision was automatically updated to reflect the committed changes. Closed by commit rG6382fcb16def: [lldb/Utility] Add opt-in shadow mode to event listeners (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148397/new/ https://

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG482a0ad5ba72: [lldb] Improve logging for process state change (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148399/new/ https://rev

[Lldb-commits] [PATCH] D145296: [lldb/Plugin] Add breakpoint setting support to ScriptedProcesses.

This revision was automatically updated to reflect the committed changes. Closed by commit rGad03aeadfb72: [lldb/Plugin] Add breakpoint setting support to ScriptedProcess (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145296/new/ h

[Lldb-commits] [PATCH] D148401: [lldb/API] Add convenience constructor for SBError (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf1fea818391: [lldb/API] Add convenience constructor for SBError (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148401/new/ https://

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cf668016efd: [lldb] Add an example of interactive scripted process debugging (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145297/new/ h

[Lldb-commits] [PATCH] D148548: [lldb] Improve breakpoint management for interactive scripted process

This revision was automatically updated to reflect the committed changes. Closed by commit rGe31d0c20e411: [lldb] Improve breakpoint management for interactive scripted process (authored by mib). Changed prior to commit: https://reviews.llvm.org/D148548?vs=515902&id=516948#toc Repository: rG

[Lldb-commits] [PATCH] D149175: [lldb/test] Update lldbutil.fetch_next_event to match broadcaster class

This revision was automatically updated to reflect the committed changes. Closed by commit rG34bd15798ede: [lldb/test] Update lldbutil.fetch_next_event to match broadcaster class (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149175

[Lldb-commits] [PATCH] D149179: [lldb/test] Consolidate interactive scripted process debugging test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3a6b93135cd: [lldb/test] Consolidate interactive scripted process debugging test (authored by mib). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D149111: [lldb] Add support for specifying language when setting watchpoint by expression

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. In D149111#4296709 , @bulbazord wrote: > In D149111#4296670 , @mib wrote: > >> I think we should still be able to u

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

mib added a comment. In D145295#4297312 , @dyung wrote: > Hi @mib, your change is causing a build failure on two build bots, can you > take a look and revert if you need time to investigate? > > https://lab.llvm.org/buildbot/#/builders/217/builds/20430 >

[Lldb-commits] [PATCH] D149218: [lldb] Fix another GCC build failure in ScriptedPythonInterface.h

mib created this revision. mib added a reviewer: bulbazord. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. In 6c961ae

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

mib added a comment. In D145295#4297322 , @mib wrote: > In D145295#4297312 , @dyung wrote: > >> Hi @mib, your change is causing a build failure on two build bots, can you >> take a look and revert if you need tim

[Lldb-commits] [PATCH] D149218: [lldb] Fix another GCC build failure in ScriptedPythonInterface.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda0700829f16: [lldb] Fix another GCC build failure in ScriptedPythonInterface.h (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D149218: [lldb] Fix another GCC build failure in ScriptedPythonInterface.h

mib added a comment. Fixed the problem: https://lab.llvm.org/buildbot/#/builders/217/builds/20435 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149218/new/ https://reviews.llvm.org/D149218 ___ lldb-commi

[Lldb-commits] [PATCH] D149096: [lldb] Speed up looking for dSYM next to executable

mib added inline comments. Comment at: lldb/source/Symbol/LocateSymbolFile.cpp:89-91 + dsym_file.append(".dSYM"); + llvm::sys::path::append(dsym_file, path_style, "Contents", "Resources", + "DWARF", filename); Why do you need the first

[Lldb-commits] [PATCH] D149096: [lldb] Speed up looking for dSYM next to executable

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Thanks! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149096/new/ https://reviews.llvm.org/D149096

[Lldb-commits] [PATCH] D149472: [lldb] Refactor host::OpenFileInExternalEditor

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with some comments Comment at: lldb/source/Host/macosx/objcxx/Host.mm:335 + + const std::string file_path = file_spec.GetPath(); + I guess this doesn't need

[Lldb-commits] [PATCH] D149472: [lldb] Refactor host::OpenFileInExternalEditor

mib added inline comments. Comment at: lldb/source/Host/macosx/objcxx/Host.mm:343-344 + CFCString file_cfstr(file_path.c_str(), kCFStringEncodingUTF8); + CFCReleaser file_URL(::CFURLCreateWithFileSystemPath( + NULL, file_cfstr.get(), kCFURLPOSIXPathStyle, false)); + --

[Lldb-commits] [PATCH] D149472: [lldb] Refactor host::OpenFileInExternalEditor

mib added inline comments. Comment at: lldb/source/Host/macosx/objcxx/Host.mm:420 + error = ::LSOpenURLsWithRole( + /*inURLs=*/cf_array.get(), /*inRole=*/kLSRolesAll, + /*inAEParam=*/&file_and_line_desc, I guess we could narrow down the `inRole` argume

[Lldb-commits] [PATCH] D149477: [lldb/crashlog] Fix json module loading issue

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. In 27f27d15f6c9 , we added a

[Lldb-commits] [PATCH] D149477: [lldb/crashlog] Fix json module loading issue

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc275fd03254: [lldb/crashlog] Fix JSON ObjectFile module loading issue (authored by mib). Changed prior to commit: https://reviews.llvm.org/D14947

[Lldb-commits] [PATCH] D149565: [lldb] Add debugger.external-editor setting

mib added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:298 + llvm::StringRef GetExternalEditor() const; + bool SetExternalEditor(llvm::StringRef editor); newline Comment at: lldb/source/Host/macosx/objcxx/Host.mm:395-396

[Lldb-commits] [PATCH] D149567: [lldb] Group debugger properties (NFC)

mib added a comment. nit: Sometimes we have newlines between methods and sometimes we don't ... It would be nice to be consistent, otherwise LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149567/new/ https://reviews.llvm.org/D149567 ___

[Lldb-commits] [PATCH] D149565: [lldb] Add debugger.external-editor setting

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149565/new/ https://reviews.llvm.org/D149565 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

mib added a comment. @bulbazord What if the FileSpec is pointing to a directory instead of a file ? What would `GetFilename` return in that case compared to `GetLastPathComponent` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149663/new/ https:

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

mib added a comment. In D149663#4313123 , @bulbazord wrote: > In D149663#4313112 , @mib wrote: > >> @bulbazord What if the FileSpec is pointing to a directory instead of a file >> ? What would `GetFilename` retur

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

mib added a comment. This looks good to me, although I'm wondering whether instead of passing a string, we should pass a dictionary. This way the user could either fill the dictionary with a simple stop reason description or the MachException data What do you think Jim ? Com

[Lldb-commits] [PATCH] D149663: [lldb] Remove FileSpec::GetLastPathComponent

mib added a comment. Given the current behavior, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149663/new/ https://reviews.llvm.org/D149663 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Alright Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149692/new/ https://reviews.llvm.org/D149692 ___ ll

[Lldb-commits] [PATCH] D149900: [lldb] Expose a const iterator for SymbolContextList

mib added a comment. LGTM but I'd prefer if we kept the type in the for loop for (const SymbolContext &sym_ctx : sc_list) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149900/new/ https://reviews.llvm.org/D149900 ___

[Lldb-commits] [PATCH] D149774: [lldb] Use templates to simplify {Get, Set}PropertyAtIndex (NFC)

mib added a comment. Very cool stuff! Comment at: lldb/include/lldb/Interpreter/OptionValue.h:325-344 + template ::value, bool> = true> + std::optional GetValueAs() const { +if constexpr (std::is_same_v) + return GetUInt64Value(); +if constexpr (std::is_same_v) +

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

mib added inline comments. Comment at: lldb/source/Utility/Broadcaster.cpp:430 - while (true) { -auto events_predicate = -[&listener](const event_listener_key &input) -> bool { - return input.second.get() == listener; -}; -collection::iterator iter, en

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

mib added inline comments. Comment at: lldb/source/Utility/Broadcaster.cpp:430 - while (true) { -auto events_predicate = -[&listener](const event_listener_key &input) -> bool { - return input.second.get() == listener; -}; -collection::iterator iter, en

[Lldb-commits] [PATCH] D150219: [lldb][NFCI] Remove n^2 loops and simplify iterator usage

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150219/new/ https://reviews.llvm.org/D150219 ___ lldb

[Lldb-commits] [PATCH] D150157: [lldb] Mark most SBAPI methods involving private types as protected or private

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with some comments. Comment at: lldb/include/lldb/API/SBBreakpoint.h:18-19 class ScriptInterpreter; +namespace python { +class SWIGBridge; } We've talked ab

[Lldb-commits] [PATCH] D150236: Thread::GetStackFrameCount should forestall interruption

mib requested changes to this revision. mib added a comment. This revision now requires changes to proceed. I don't understand why the succeeding return value for `GetFramesUpTo` is `false`. It looks counter-intuitive to me. What's the motivation behind that ? Comment at: lldb

[Lldb-commits] [PATCH] D150315: Make sure the "Relevant Frame" gets selected before the initial stop printing

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150315/new/ https://reviews.llvm.org/D150315 ___ lldb

[Lldb-commits] [PATCH] D150236: Thread::GetStackFrameCount should forestall interruption

mib added inline comments. Comment at: lldb/include/lldb/Target/StackFrameList.h:106 + /// Returns true if the function was interrupted, false otherwise. + bool GetFramesUpTo(uint32_t end_idx, bool allow_interrupt = true); JDevlieghere wrote: > I personally w

[Lldb-commits] [PATCH] D150236: Thread::GetStackFrameCount should forestall interruption

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. I guess the `InterruptionControl` argument makes it clearer. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150236/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D150485: [lldb] Add support for negative integer to {SB, }StructuredData

mib created this revision. mib added reviewers: labath, bulbazord, JDevlieghere, jingham. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch refactors the `StructuredData::Integer` class to make it temp

[Lldb-commits] [PATCH] D150624: [lldb] Fix lua build after 27b6a4e63afe

mib requested changes to this revision. mib added a comment. This revision now requires changes to proceed. We've already discussed that offline but I really think there should be a ScriptInterpreter `SWIGBridge` plugin and that would have all the method the Python and Lua SWIGBridge have in com

[Lldb-commits] [PATCH] D150624: [lldb] Fix lua build after 27b6a4e63afe

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Let's fix the Lua build failures first Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150624/new/ https://reviews.llvm.org/D150624 ___

[Lldb-commits] [PATCH] D150804: [lldb] Guarantee the lifetimes of all strings returned from SBAPI

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with nit. Comment at: lldb/source/API/SBFunction.cpp:181 + + return variable_sp->GetName().GetCString(); } nit: This threw me off, I thought you forgot to c

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:669 + r'(0x[0-9a-fA-F]{4,}) +' # addr (4 chars or more) + r'((.*)(?:(?: +\+ +)([0-9]+))|[^\s]+)' #

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib updated this revision to Diff 523948. mib added a comment. Address feedbacks: - Simplify and Improve regex - Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146765/new/ https://reviews.llvm.org/D146765 Files: lldb/examples/python/crashlog.py lldb/test/Shell/ScriptInter

[Lldb-commits] [PATCH] D151002: [lldb] Fix process pid parsing issue

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should fix an issue when parsing the process pid and setting it in the scripte

[Lldb-commits] [PATCH] D151002: [lldb] Fix process pid parsing issue

mib added a comment. In D151002#4357886 , @bulbazord wrote: > You probably encountered this somewhere, is there a simple test we could add > here? The change looks fine to me nonetheless. This is specific to interactive scripted process and the only tes

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib marked 7 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:628-629 +description = "" +# Since images are parsed after threads, we need to build a +# map for every image with a list of all the s

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib updated this revision to Diff 523961. mib marked 4 inline comments as done. mib added a comment. Address @bulbazord comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146765/new/ https://reviews.llvm.org/D146765 Files: lldb/examples/python/crashlog.py lldb/test/Shell/Scrip

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib updated this revision to Diff 523980. mib marked 3 inline comments as done. mib added a comment. Address @kastiglione comments and reformat. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146765/new/ https://reviews.llvm.org/D146765 Files: lldb/examples/python/crashlog.py lldb/

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdfdd8988621b: [lldb/crashlog] Load inlined symbol into interactive crashlog (authored by mib). Changed prior to commit: https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D151002: [lldb] Fix process pid parsing issue

This revision was automatically updated to reflect the committed changes. Closed by commit rGaefa8f4460d1: [lldb] Fix process pid parsing issue (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151002/new/ https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D150485: [lldb] Add support for negative integer to {SB, }StructuredData

mib updated this revision to Diff 524083. mib marked 2 inline comments as done. mib edited the summary of this revision. mib added a comment. Many changes: - Change SBAPI templated specialization for 2 distinct methods `GetUnsignedIntegerValue` & `GetSignedIntegerValue` - Add new tests - Update

[Lldb-commits] [PATCH] D151043: [lldb] Add "Trace" stop reason in Scripted Thread

mib created this revision. mib added a reviewer: jingham. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds support to eStopReasonTrace to Scripted Threads

[Lldb-commits] [PATCH] D151043: [lldb] Add "Trace" stop reason in Scripted Thread

mib added inline comments. Comment at: lldb/test/API/functionalities/scripted_process/dummy_scripted_process.py:70-71 def get_stop_reason(self) -> Dict[str, Any]: -return { "type": lldb.eStopReasonSignal, "data": { -"signal": signal.SIGINT -} } -

[Lldb-commits] [PATCH] D151044: [lldb] Move PassthroughScriptedProcess to `lldb.scripted_process` module

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch moves the `PassthroughScriptedProcess` & `PassthroughScriptedThread` classes f

[Lldb-commits] [PATCH] D151045: [lldb/crashlog] Remove tempfile prefix from inlined symbol object file

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the way we generate the ObjectFileJSON files containing the inlined symbols from

[Lldb-commits] [PATCH] D151043: [lldb] Add "Trace" stop reason in Scripted Thread

mib added a comment. In D151043#4360968 , @JDevlieghere wrote: > LGTM. Are there other stop reasons that are currently not supported by > scripted threads that we should consider supporting? Scripted Threads still don't support `eStopReasonWatchpoint`

[Lldb-commits] [PATCH] D151044: [lldb] Move PassthroughScriptedProcess to `lldb.scripted_process` module

mib added a comment. In D151044#4362084 , @bulbazord wrote: > The bug that you're fixing is with thread handling in > `MultiplexerScriptedProcess` right? That looks fine to me too. Yep! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D150485: [lldb] Add support for negative integer to {SB, }StructuredData

mib updated this revision to Diff 524476. mib marked 2 inline comments as done. mib added a comment. Address @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150485/new/ https://reviews.llvm.org/D150485 Files: lldb/include/lldb/API/SBStructuredData.h lldb/include/

[Lldb-commits] [PATCH] D151045: [lldb/crashlog] Remove tempfile prefix from inlined symbol object file

mib updated this revision to Diff 524502. mib added a reviewer: bulbazord. mib added a comment. Address @JDevlieghere & @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151045/new/ https://reviews.llvm.org/D151045 Files: lldb/examples/python/crashlog.py lldb/examp

[Lldb-commits] [PATCH] D151045: [lldb/crashlog] Remove tempfile prefix from inlined symbol object file

mib updated this revision to Diff 524521. mib added a comment. More refactoring CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151045/new/ https://reviews.llvm.org/D151045 Files: lldb/examples/python/crashlog.py lldb/examples/python/scripted_process/crashlog_scripted_process.py ll

[Lldb-commits] [PATCH] D150485: [lldb] Add support for negative integer to {SB, }StructuredData

This revision was automatically updated to reflect the committed changes. Closed by commit rG1370a1cb5b97: [lldb] Add support for negative integer to {SB,}StructuredData (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150485/new/ ht

[Lldb-commits] [PATCH] D151043: [lldb] Add "Trace" stop reason in Scripted Thread

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f407b8e6329: [lldb] Add "Trace" stop reason in Scripted Thread (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151043/new/ https://reviews

[Lldb-commits] [PATCH] D151044: [lldb] Move PassthroughScriptedProcess to `lldb.scripted_process` module

This revision was automatically updated to reflect the committed changes. Closed by commit rG273a2d337f67: [lldb] Move PassthroughScriptedProcess to `lldb.scripted_process` module (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15104

[Lldb-commits] [PATCH] D151045: [lldb/crashlog] Remove tempfile prefix from inlined symbol object file

This revision was automatically updated to reflect the committed changes. Closed by commit rGabba5de72466: [lldb/crashlog] Remove tempfile prefix from inlined symbol object file (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151045/

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

mib created this revision. mib added reviewers: jingham, JDevlieghere, bulbazord, aprantl. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. If we use a variable watchpoint with a condition using a scope variable

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/source/Breakpoint/Watchpoint.cpp:103-104 + TargetSP target_sp = exe_ctx.GetTargetSP(); + if (!target_sp) +return false; + bulbazord wrote: > Is it even possible to have an `Ex

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

mib marked 5 inline comments as done. mib added inline comments. Comment at: lldb/source/Breakpoint/Watchpoint.cpp:140-141 + + LLDB_LOGF(log, "Watchpoint::%s called by breakpoint %" PRIu64 ".%" PRIu64, +__FUNCTION__, break_id, break_loc_id); + bulbaz

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

mib updated this revision to Diff 525367. mib marked 4 inline comments as done. mib added a comment. Address @bulbazord & @aprantl comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151366/new/ https://reviews.llvm.org/D151366 Files: lldb/include/lldb/Breakpoint/Watchpoint.h l

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

mib added a comment. In D151366#4370123 , @aprantl wrote: > Just so I understand the limitations: > This works for > > int main() { > int val = 0; > // Break here > val++; > val++; > return 0; > } > > but not for > > int main() {

[Lldb-commits] [PATCH] D151460: [NFC][Py Reformat] Reformat python files in lldb

mib added a comment. Can you add this commit hash to the `.git-blame-ignore-revs` file so it doesn't show up in the git history CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151460/new/ https://reviews.llvm.org/D151460 ___ lldb-commits maili

<    3   4   5   6   7   8   9   10   11   12   >