[Lldb-commits] [PATCH] D119499: [lldb/API] Add a way to check if the CommandInterpreter is interactive

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f3fc2eee8ff: [lldb/API] Add a way to check if the CommandInterpreter is interactive (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119499/

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c54ffdc6c2e: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode (authored by mib). Changed prior to commit: https://reviews.ll

[Lldb-commits] [PATCH] D119504: [lldb/crashlog] Fix exception signal parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rG21658b77a596: [lldb/crashlog] Fix exception signal parsing (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119504/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode

mib added a comment. In D119501#3327339 , @shafik wrote: > Looks like the `scripted_crashlog_json.test` is broken on green dragon: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/41454/testReport/junit/lldb-shell/ScriptInterpreter_Python_Cras

[Lldb-commits] [PATCH] D120100: [lldb] Expose eBroadcastBitProgress to the SWIG SBAPI (NFC)

mib created this revision. mib added reviewers: clayborg, JDevlieghere, jingham. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch removes the multiple definitions of the eBroadcastBitProgress enum in `Debugger` and `SBDebugger` h

[Lldb-commits] [PATCH] D120101: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand

mib added inline comments. Comment at: lldb/source/Commands/CommandObjectRegexCommand.cpp:38 +// Parse the number following '%'. +const size_t idx = std::atoi(str.c_str() + pos + 1); + Are we assuming that the number following `%` will always have a singl

[Lldb-commits] [PATCH] D120100: [lldb] Expose eBroadcastBitProgress to the SWIG SBAPI

mib added a comment. In D120100#3331141 , @JDevlieghere wrote: > Removing the enum from SBDebugger is an ABI breaking change. I think this has > been in tree for a while, so if we shipped this like this in the last > release, we cannot guarantee that t

[Lldb-commits] [PATCH] D120100: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface

mib updated this revision to Diff 410023. mib retitled this revision from "[lldb] Expose eBroadcastBitProgress to the SWIG SBAPI" to "[lldb/bindings] Expose the progress reporting machinery to the SWIG interface". mib edited the summary of this revision. mib added a comment. Instead of moving th

[Lldb-commits] [PATCH] D120100: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3b9bb5a1847: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D120100: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/bindings/interface/SBDebugger.i:126-129 +%apply uint64_t& INOUT { uint64_t& progress_id }; +%apply uint64_t& INOUT { uint64_t& completed }; +%apply uint64_t& INOUT { uint64_t& total }; +

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

mib created this revision. mib added a reviewer: labath. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch is a follow-up of D120100 to address some feed

[Lldb-commits] [PATCH] D120100: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface

mib marked 3 inline comments as done. mib added a comment. @labath I addressed your comments in D120284 :) Comment at: lldb/bindings/interface/SBDebugger.i:126-129 +%apply uint64_t& INOUT { uint64_t& progress_id }; +%apply uint64_t& I

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Could you add a little test to exercise the command ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120292/new/ https://reviews.llvm.org/D120292

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

mib updated this revision to Diff 410449. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120284/new/ https://reviews.llvm.org/D120284 Files: lldb/test/API/functionalities/progress_reporting/TestProgressReporting.py Index: lldb/test/API/functionalities/progress_reporting/TestProgressRe

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

mib added inline comments. Comment at: lldb/bindings/python/python-extensions.swig:528-533 +def find(pattern, flags=re.I): +""" +Find matching SB methods/properties. See also Python's builtin `help()`. +""" +import lldb +import re kastiglione

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

mib added inline comments. Comment at: lldb/bindings/python/python-extensions.swig:528-533 +def find(pattern, flags=re.I): +""" +Find matching SB methods/properties. See also Python's builtin `help()`. +""" +import lldb +import re kastiglione

[Lldb-commits] [PATCH] D120101: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120101/new/ https://reviews.llvm.org/D120101 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

mib updated this revision to Diff 410973. mib edited the summary of this revision. mib added a comment. Make the interface binding arguments `OUTPUT` only. Re-enable test on all platforms. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120284/new/ https://reviews.llvm.org/D120284 Files:

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e3e79a9e4c3: [lldb/test] Fix TestProgressReporting.py race issue with the event listener (authored by mib). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

mib added a comment. In D120284#3345994 , @JDevlieghere wrote: >> I'm not entirely sure what's the best fix here. @JDevlieghere, what do you >> think? Can we just remove the output arguments from the LLDB_INSTRUMENT_VA >> invocation (given how logging

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

mib added a comment. In D120292#3346030 , @JDevlieghere wrote: > I like Jim's suggestion Same same ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120292/new/ https://reviews.llvm.org/D120292 __

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

mib added a comment. Jim's suggestion made me think that if we make a subcommand for this, it would be nice to have some completion handling. I know it would probably require you to move away from the python function but this is just a suggestion for later improvements. Repository: rG LLVM

[Lldb-commits] [PATCH] D120598: [lldb/crashlog] Fix scripted_crashlog_json.test failure

mib created this revision. mib added reviewers: JDevlieghere, jingham. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should fix the test failure on scripted_crashlog_json.test. The failure is caused because crash reporter wil

[Lldb-commits] [PATCH] D120599: Reland "[lldb/test] Fix TestProgressReporting.py race issue with the event listener"

mib created this revision. mib added reviewers: labath, JDevlieghere, MForster. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch relands commit 3e3e79a9e4c378b59f5f393f556e6a84edcd8898

[Lldb-commits] [PATCH] D120598: [lldb/crashlog] Fix scripted_crashlog_json.test failure

This revision was automatically updated to reflect the committed changes. Closed by commit rGbadb6e2730a9: [lldb/crashlog] Fix scripted_crashlog_json.test failure (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120598/new/ https://r

[Lldb-commits] [PATCH] D120599: Reland "[lldb/test] Fix TestProgressReporting.py race issue with the event listener"

This revision was automatically updated to reflect the committed changes. Closed by commit rG425880ed35ee: Reland "[lldb/test] Fix TestProgressReporting.py race issue with the event… (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[Lldb-commits] [PATCH] D120607: [lldb/test] Re-enable TestEvents.py on Darwin and fix crashes

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch re-enables TestEvents.py on Darwin and fixes some crashes that were happening due to an undefined method. I ran it 1

[Lldb-commits] [PATCH] D120969: [lldb/Plugins] Add ability to load modules to Scripted Processes

mib created this revision. mib added reviewers: JDevlieghere, jasonmolenda. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new way to load modules programatically with Scripted Processe

[Lldb-commits] [PATCH] D120969: [lldb/Plugins] Add ability to load modules to Scripted Processes

mib updated this revision to Diff 412923. mib added a comment. Re-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120969/new/ https://reviews.llvm.org/D120969 Files: lldb/examples/python/scripted_process/scripted_process.py lldb/include/lldb/Interpreter/ScriptedProcessInterfac

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

mib added a comment. Awesome! I could see this getting improved in the future by stacking each progress event in the output with their completion amount and popping the ones that are completed. Comment at: lldb/source/Core/Debugger.cpp:1727 + + // Only report progress is nob

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

mib added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1727 + + // Only report progress is nobody else is listening for it. + if (GetBroadcaster().EventTypeHasListeners(Debugger::eBroadcastBitProgress)) mib wrote: > typo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D120969: [lldb/Plugins] Add ability to load modules to Scripted Processes

mib added inline comments. Comment at: lldb/test/API/functionalities/scripted_process/stack_core_scripted_process.py:45 + +lib_load_addr = 0x0001001e +self.loaded_images.append({"path": self.lib_path, JDevlieghere wrote: > What exactly is

[Lldb-commits] [PATCH] D120969: [lldb/Plugins] Add ability to load modules to Scripted Processes

mib updated this revision to Diff 413079. mib added a comment. Address @JDevlieghere comments: - Fix error message - Use corefile module load address for scripted process module CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120969/new/ https://reviews.llvm.org/D120969 Files: lldb/ex

[Lldb-commits] [PATCH] D120607: [lldb/test] Re-enable TestEvents.py on Darwin and fix crashes

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a29c3f72e8d: [lldb/test] Re-enable TestEvents.py on Darwin and fix crashes (authored by mib). Herald added a project: All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D120969: [lldb/Plugins] Add ability to load modules to Scripted Processes

This revision was automatically updated to reflect the committed changes. Closed by commit rG680ca7f21a77: [lldb/Plugins] Add ability to load modules to Scripted Processes (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120969/new/

[Lldb-commits] [PATCH] D121038: [lldb/crashlog] Make interactive mode display more user-friendly

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch makes the crashlog interactive mode show the scripted process status with the crashed sc

[Lldb-commits] [PATCH] D121038: [lldb/crashlog] Make interactive mode display more user-friendly

mib updated this revision to Diff 413941. mib added a comment. Change implementation to emulate lldb's driver Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121038/new/ https://reviews.llvm.org/D121038 Files: lldb/examples/python/crashlog.py ll

[Lldb-commits] [PATCH] D121038: [lldb/crashlog] Make interactive mode display more user-friendly

mib updated this revision to Diff 413943. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121038/new/ https://reviews.llvm.org/D121038 Files: lldb/examples/python/crashlog.py lldb/test/Shell/ScriptInterpreter/Python/Crashlog/scripted_crashlog_json.test Index: lldb/test/Shell/ScriptI

[Lldb-commits] [PATCH] D121038: [lldb/crashlog] Make interactive mode display more user-friendly

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:1023-1024 + +async_state = debugger.GetAsync() +debugger.SetAsync(False) + JDevlieghere wrote: > This is the perfect pattern for a context manag

[Lldb-commits] [PATCH] D121038: [lldb/crashlog] Make interactive mode display more user-friendly

mib updated this revision to Diff 413972. mib marked an inline comment as done. mib added a comment. Use context manager pattern CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121038/new/ https://reviews.llvm.org/D121038 Files: lldb/examples/python/crashlog.py lldb/test/Shell/Script

[Lldb-commits] [PATCH] D121316: [lldb/Plugin] Test that a scripted process blueprint can be loaded for the dSYM

mib created this revision. mib added reviewers: JDevlieghere, jingham. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch ensures that lldb can automatically load a scripted process blueprint from a dSY

[Lldb-commits] [PATCH] D121038: [lldb/crashlog] Make interactive mode display more user-friendly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d097a6b932c: [lldb/crashlog] Make interactive mode display more user-friendly (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D121316: [lldb/Plugin] Test that a scripted process blueprint can be loaded for the dSYM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6aa48034f9e6: [lldb/Plugin] Test that a scripted process blueprint can be loaded for the dSYM (authored by mib). Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

mib added inline comments. Comment at: lldb/source/Core/Module.cpp:1187 + +Debugger::ReportError(std::string(strm.GetString())); + } It's unrelated to this patch, but it looks like `Debugger::HandleDiagnosticEvent` dumps everything to the error stream witho

[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

mib added inline comments. Comment at: lldb/source/Core/Module.cpp:1187 + +Debugger::ReportError(std::string(strm.GetString())); + } mib wrote: > It's unrelated to this patch, but it looks like > `Debugger::HandleDiagnosticEvent` dumps everything to the err

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

mib added inline comments. Comment at: lldb/source/Commands/CommandObjectLog.cpp:167 buffer_size.Clear(); + handler = eLogHandlerStream; log_options = 0; labath wrote: > mib wrote: > > clayborg wrote: > > > Do we want to define a "eLogHandlerDe

[Lldb-commits] [PATCH] D128557: [lldb] Add a log dump command to dump the circular log buffer

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128557/new/ https://reviews.llvm.org/D128557 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

mib created this revision. mib added reviewers: aprantl, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the C++ `std::string` dataformatter to reflect internal layout changes f

[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

mib added subscribers: ldionne, labath. mib added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:637 if (location_sp->GetName() == g_size_name) - location_sp = short_sp->GetChildAtIndex(3, true); + location_sp = short_sp->GetChildAtI

[Lldb-commits] [PATCH] D126983: [lldb] [llgs] Support "t" vCont action

mib added a comment. Herald added a subscriber: JDevlieghere. Hey @mgorny, This patch is causing a test to fail on the macOS bot: https://green.lab.llvm.org/green/job/lldb-cmake/44921/consoleText Feel free to skip it or let me know if you need help reproducing the issue. FAIL: lldb-api :: to

[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

mib added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:637 if (location_sp->GetName() == g_size_name) - location_sp = short_sp->GetChildAtIndex(3, true); + location_sp = short_sp->GetChildAtIndex(2, true); if (using_bitmasks)

[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

mib updated this revision to Diff 440452. mib edited the summary of this revision. mib added a comment. Use field identifiers instead of indices and add long-mode support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128694/new/ https://reviews.llvm.org/D128694 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should fix event handling for finite progress reports. Previously, the event handler wo

[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

This revision was automatically updated to reflect the committed changes. Closed by commit rG44a114fec715: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285 (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128694/n

[Lldb-commits] [PATCH] D128638: [lldb] [llgs] Add base nonstop fork/vfork tests

mib added a comment. Herald added a subscriber: JDevlieghere. Hi @mgorny, There are some random test failures following this patch on `lldb-debian-x86_64`: https://lab.llvm.org/buildbot/#/builders/68/builds/34883 Unresolved Tests (1): lldb-api :: tools/lldb-server/T

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib added a comment. In D128768#3619349 , @JDevlieghere wrote: > The fix looks good but I'm torn about the added logging. On the one hand > it'll make finding issues like this easier in the future, but on the other > hand, while this code isn't "hot",

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib updated this revision to Diff 441110. mib added a comment. Log only when verbose mode is enabled CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128768/new/ https://reviews.llvm.org/D128768 Files: lldb/source/Core/Debugger.cpp Index: lldb/source/Core/Debugger.cpp

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1839-1855 +if (log && log->GetVerbose()) { + if (data->IsFinite()) +LLDB_LOGF(log, + "%p Debugger('%llu')::HandleProgressEvent " +

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib updated this revision to Diff 441195. mib marked an inline comment as done. mib added a comment. Refactor logging code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128768/new/ https://reviews.llvm.org/D128768 Files: lldb/source/Core/Debugger.cpp Index: lldb/source/Core/Debugge

[Lldb-commits] [PATCH] D128638: [lldb] [llgs] Add base nonstop fork/vfork tests

mib added a comment. Not sure if this is related to this patch but `TestGdbRemote_vContThreads.py` is still timing out on the macOS bot: https://green.lab.llvm.org/green/job/lldb-cmake/44958/console Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib updated this revision to Diff 442397. mib marked an inline comment as done. mib added a comment. Address @JDevlieghere comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128768/new/ https://reviews.llvm.org/D128768 Files: lldb/source/Core/Debugger.cpp Index: lldb/source/Core

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

This revision was automatically updated to reflect the committed changes. Closed by commit rGea8b811bf800: [lldb/Core] Fix finite progress event reporting (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128768/new/ https://reviews.l

[Lldb-commits] [PATCH] D129456: [lldb] Add image dump pcm-info command

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with a comment Comment at: lldb/test/API/commands/target/dump-pcm-info/TestDumpPCMInfo.py:37 + +breakpoint() +self.expect( Left over ? Repos

[Lldb-commits] [PATCH] D129490: [lldb/libc++] Simplify the libc++ string formatter

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. This is great! Thanks for taking care of this! LGTM! Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:609 } else { -ValueObjectSP size_mode(dataval_sp->GetChild

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mib added inline comments. Comment at: clang/cmake/modules/ProtobufMutator.cmake:4-5 + set (PBM_PREFIX clang_protobuf_mutator) +elseif(${CMAKE_CURRENT_SOURCE_DIR} MATCHES "lldb") + set (PBM_PREFIX lldb_protobuf_mutator) +endif() If feels wrong to me that the cl

[Lldb-commits] [PATCH] D129603: [lldb/crashlog] Fix interactive crashlog test

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should fix the interactive crashlog test by checking in the binary and debug info so tha

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new flag for the interactive crashlog mode, that allow the user to specify,

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch allows the crashlog script to surface its errors to lldb by using the provided SBCommand

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mib added a comment. In D129377#3673204 , @mstorsjo wrote: > This broke building of Clang, when it's set up by symlinking > `llvm-project/clang` into `llvm-project/llvm/tools`. In that case, cmake > configure errors out like this: > > -- Configuring d

[Lldb-commits] [PATCH] D130540: [lldb] Read from the Rosetta shared cache with Xcode 14

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with a comment. Comment at: lldb/test/API/macosx/rosetta/TestRosetta.py:7-10 +def apple_silicon(test): +return platform.system() == 'Darwin' and test.getArchitecture() in

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

mib marked 5 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/scripted_process/crashlog_scripted_process.py:47-48 +if not self.target.GetExecutable() or not self.target.IsValid(): +# Return error return -

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

mib updated this revision to Diff 448434. mib edited the summary of this revision. mib added a comment. Address @JDevlieghere feedbacks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129611/new/ https://reviews.llvm.org/D129611 Files: lldb/examples/python/crashlog.py lldb/examples/

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:1012-1015 +def error(message, sb_error=lldb.SBError()): +nonlocal result +result.SetError(sb_error, "error: %s" % message) +return ---

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

mib updated this revision to Diff 448465. mib marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129614/new/ https://reviews.llvm.org/D129614 Files: lldb/examples/python/crashlog.py Index: lldb/examples/python/crashlog.py ==

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

mib updated this revision to Diff 449472. mib added a comment. Address @JDevlieghere comments: - Use exception approach / Remove `error` helper function - Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129614/new/ https://reviews.llvm.org/D129614 Files: lldb/examples/python/

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch updates the regular expression matching stackframes in crashlog to allow addresses that

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Fix parsing issue with `procPath`

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch checks that the `procPath` key exists in the crashlog data before using it. In can happe

[Lldb-commits] [PATCH] D131036: [lldb/crashlog] Add `-s|--skip-status` option to interactive mode

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new option for the interactive crashlog mode, that will prevent it from dum

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

mib updated this revision to Diff 449495. mib added a comment. Make lit run command more readable CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129611/new/ https://reviews.llvm.org/D129611 Files: lldb/examples/python/crashlog.py lldb/examples/python/scripted_process/crashlog_script

[Lldb-commits] [PATCH] D131038: [lldb/crashlog] Skip null image dsym fetching on interactive mode

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. Sometimes, it can happen that a crash report has null images in its list of used binaries. This man

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib created this revision. mib added reviewers: JDevlieghere, kastiglione. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the CrashLogParser class to be both the base class and a Factory for

[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

mib created this revision. mib added reviewers: JDevlieghere, jingham, jasonmolenda. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch improve exception reporting when loading a crash report in a scrip

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib updated this revision to Diff 449725. mib added a comment. Add missing `import` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131085/new/ https://reviews.llvm.org/D131085 Files: lldb/examples/python/crashlog.py lldb/examples/python/scripted_process/crashlog_scripted_process.py

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:604 + r'(' +version+ r')?' # img_version + r'(0x[0-9a-fA-F]{7}[0-9a-fA-F]*)' # addr + r' +(.*)'

[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:269-272 +elif enum == lldb.eStopReasonInstrumentation: +return "instrumentation" +elif enum == lld

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:428 self.crashlog = CrashLog(debugger, self.path, self.verbose) +self.data = None + JDevlieghere wrote: > Can this stay in the JSONCrashLogParser? I need it to get the `excep

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:1025 +if not target: +result.PutCString("error: couldn't create target provided by the user ({option.target_path})") +return

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

mib updated this revision to Diff 449782. mib added a comment. Change `f-string` to `string.format` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129611/new/ https://reviews.llvm.org/D129611 Files: lldb/examples/python/crashlog.py lldb/examples/python/scripted_process/crashlog_scri

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

mib updated this revision to Diff 449784. mib added a comment. - Add custom `InteractiveCrashLogException` - Simplify the `except` block CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129614/new/ https://reviews.llvm.org/D129614 Files: lldb/examples/python/crashlog.py lldb/source/Pl

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

mib updated this revision to Diff 449785. mib edited the summary of this revision. mib added a comment. Implement @kastiglione's suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131032/new/ https://reviews.llvm.org/D131032 Files: lldb/examples/python/crashlog.py Index: lldb

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Fix parsing issue with `procPath`

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:473 +if 'procPath' in json_data: +self.crashlog.process_path = json_data['procPath'] aprantl wrote: > Is it now undefined if it doe

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Fix parsing issue with `procPath`

mib updated this revision to Diff 449809. mib marked an inline comment as done. mib added a comment. Remove `procPath` key from crash report for testing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131033/new/ https://reviews.llvm.org/D131033 Files: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Fix parsing issue with `procPath`

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:473 +if 'procPath' in json_data: +self.crashlog.process_path = json_data['procPath'] JDevlieghere wrote: > mib wrote: > > aprantl wrote: > > > Is it now undefined if it

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

mib added a comment. In D131032#3698108 , @JDevlieghere wrote: > Can we test this by modifying an address in the existing test case? Sure but we won't be able to symbolicate that frame anymore ... do we really want to do that ? CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Remove 'process_path' parsing logic

mib updated this revision to Diff 449830. mib retitled this revision from "[lldb/crashlog] Fix parsing issue with `procPath`" to "[lldb/crashlog] Remove 'process_path' parsing logic". mib edited the summary of this revision. mib added a comment. Remove the `process_path` parsing logic CHANGES S

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib marked 4 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:428 self.crashlog = CrashLog(debugger, self.path, self.verbose) +self.data = None + mib wrote: > JDevlieghere wrote: > > Can this stay i

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib updated this revision to Diff 449847. mib added a comment. Address @JDevlieghere comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131085/new/ https://reviews.llvm.org/D131085 Files: lldb/examples/python/crashlog.py lldb/examples/python/scripted_process/crashlog_scripted_p

[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:525-542 + case EXC_BAD_ACCESS: +return "EXC_BAD_ACCESS"; + case EXC_BAD_INSTRUCTION: +return "EXC_BAD_INSTRUCTION"; + case EXC_AR

[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

mib updated this revision to Diff 449848. mib added a comment. Use `llvm::StringSwitch` to get the exception code with the name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131086/new/ https://reviews.llvm.org/D131086 Files: lldb/examples/python/scripted_process/crashlog_scripted_pr

[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

mib updated this revision to Diff 449849. mib added a comment. Remove the comment from `MachException::ExceptionCode` since the function returns now an `llvm::Optional` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131086/new/ https://reviews.llvm.org/D131086 Files: lldb/examples/py

<    1   2   3   4   5   6   7   8   9   10   >