[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

kwk updated this revision to Diff 198987. kwk added a comment. - Fix https://reviews.llvm.org/D61737#inline-548136 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61737/new/ https://reviews.llvm.org/D61737 Files: lldb/tools/driver/Options.td Ind

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

kwk added a comment. In D61737#1497202 , @jingham wrote: > I would rather not clutter up the lldb command driver's options with gdb > command flags. That seems like it will make lldb harder to figure out and > reduce our freedom to choose reasonable sho

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

kwk added a comment. @teemperor Do you recommend me to work on support for GDB's `--args` parameter then and ditch this review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61737/new/ https://reviews.llvm.org/D61737 ___

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

kwk added a comment. I withdraw from my approach and thanks to @teemperor I have found something else to work on. Thank you for this fruitful discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61737/new/ https://reviews.llvm.org/D61737 _

[Lldb-commits] [PATCH] D62243: Added a dot at the end of comment

kwk created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. kwk added a reviewer: jankratochvil. to test SVN commit access with a simple change. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62243 Files: lldb/CMakeLists.txt Ind

[Lldb-commits] [PATCH] D62243: Added a dot at the end of comment

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361383: Added a dot at the end of comment (authored by kwk, committed by ). Herald added a subscriber: abidh. Change

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I've made this change because a windows build bot fails with this error: FAILED: tools/lldb/source/Core/CMakeFiles/lldbCore.dir/Debugger.cpp.obj C:\PROGRA~2\MICROS~1\2017\COMMUN~1\VC\Tools\MSVC\

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

kwk updated this revision to Diff 200951. kwk added a comment. Fixed second place where nullptr couldn't be converted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62305/new/ https://reviews.llvm.org/D62305 Files: lldb/source/Core/Communication.

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

kwk added a comment. In D62305#1513642 , @labath wrote: > returning `lldb::thread_result_t()` is probably the best thing to do here... @labath I've followed your advice. Running tests for linux now. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

kwk updated this revision to Diff 200953. kwk added a comment. Return lldb::thread_result_t() instead of NULL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62305/new/ https://reviews.llvm.org/D62305 Files: lldb/source/Core/Communication.cpp ll

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

kwk updated this revision to Diff 200969. kwk added a comment. - Return empty lldb::thread_result_t as {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62305/new/ https://reviews.llvm.org/D62305 Files: lldb/source/Core/Communication.cpp lldb/s

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361503: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t' (authored by kwk, committed by ). Herald added a subscriber: abidh. Changed prior to commit: https://reviews.llvm.org/D623

[Lldb-commits] [PATCH] D62337: [lldb] followup fix for https://reviews.llvm.org/D62305

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixing this error on windows build bot: E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(21): error C2440: 'initializing': cannot convert from 'nu

[Lldb-commits] [PATCH] D62337: [lldb] followup fix for https://reviews.llvm.org/D62305

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361565: [lldb] followup fix for https://reviews.llvm.org/D62305 (authored by kwk, committed by ). Changed prior to commit: https://reviews.llvm.org/D62337?vs=201032&id=201082#toc Repository: rLLDB

[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

kwk added a comment. > This patch fixes a couple of existing tests, @labath can you please tell which tests are fixed by this commit exactly? I try to reproduce an issue with a test that (potentially under load) used tp sometimes hang. Now it does no longer do that and I wonder if your change h

[Lldb-commits] [PATCH] D78109: Ran git clang-format

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Depends on D74136 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78109 Files: lldb/source/Core/SearchFilter.cpp Index: lldb/source/Core/Sear

[Lldb-commits] [PATCH] D78109: Ran git clang-format

kwk abandoned this revision. kwk added a comment. Sorry, wrong `arc diff` invocation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78109/new/ https://reviews.llvm.org/D78109 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 257313. kwk added a comment. Ran git clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp lldb/source/C

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 257682. kwk added a comment. - Modify SearchFilterByModuleListAndCU - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResol

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 257688. kwk added a comment. - Honor the module Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp lldb/source/Cor

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked an inline comment as done. kwk added a comment. In D74136#1889066 , @labath wrote: > Yes, I believe this matches the behavior we were talking about. > > I could make a bunch of comments on the implementation and the test, but I'm > not sure if

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 257691. kwk added a comment. - Revert "Honor the module" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp lldb/s

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 258004. kwk added a comment. - Remove not needed include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp lldb/s

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

kwk added a comment. This looks good overall. I would add a section describing which test suite to use when you're interested in a particular DWARF feature for example. I heard from my GDB colleagues that the don't use a compiler, because that might change and produce a different DWARF. Instead

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk added a comment. In D75750#1971446 , @labath wrote: > In D75750#1967019 , @fche2 wrote: > > > >> So it might be good to have the SymbolVendors use one or more > > >> SymbolServer plug-ins. > > > > > > I don't

[Lldb-commits] [PATCH] D78337: [lldb/Host] Remove TaskPool and replace its uses with llvm::ThreadPool

kwk resigned from this revision. kwk added a comment. This revision now requires review to proceed. I resign because I think @labath made some good points that I cannot argue about. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78337/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D78337: [lldb/Host] Remove TaskPool and replace its uses with llvm::ThreadPool

kwk accepted this revision. kwk added a comment. This revision is now accepted and ready to land. All tests pass. I first thought that the `lldb/test/Shell/Reproducer/TestGDBRemoteRepro.test` test didn't work but it seems to be flaky. Comment at: lldb/source/Plugins/SymbolFi

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk added a subscriber: fche. kwk added a comment. In D75750#1988330 , @labath wrote: > lldb-dev is indeed a better place for the architectural discussion. However, > moving the discussion there does not automatically unblock this patch. "get > something

[Lldb-commits] [PATCH] D72698: [lldb] Add method decls to a CXXRecordDecl only after all their properties are defined

kwk added a comment. > The only code that is currently after addDecl is changing whether the special > members are > defaulted/trivial. I'm not sure if this actually fixes anything but it's > more correct than what we > did before. But at least you return immediately after calling `addDecl`.

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

kwk added a comment. I've marked some mistakes that were not addressed yet but are marked as "Done". Comment at: lldb/docs/resources/test.rst:86 + +API tests are located under ``lldb/test/API``. Thy are run with the +``dotest.py``. Tests are written in Python and test binaries

[Lldb-commits] [PATCH] D80543: [lldb] Manual remove of DISALLOW_COPY_AND_ASSIGN def and one expansion

kwk abandoned this revision. kwk added a comment. Sorry, wrong revisions uploaded Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80543/new/ https://reviews.llvm.org/D80543 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 266463. kwk marked 3 inline comments as done. kwk added a comment. Herald added a subscriber: sstefan1. - rebase - Rename function in test from inlined_42 to function_in_header - Typo: compulation -> compilation Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 266465. kwk marked 3 inline comments as done. kwk added a comment. - use %t in files created in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/B

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked 2 inline comments as done. kwk added inline comments. Comment at: lldb/test/Shell/Breakpoint/Inputs/search-support-files.h:1 +int inlined_42() { return 42; } labath wrote: > Calling this `inlined` is misleading. The function won't get inlined anywhere

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 266472. kwk added a comment. - make test CHECKs less strict Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp lld

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 266493. kwk marked an inline comment as done. kwk added a comment. - don't hard-code --color and --dump-input on FileCheck invocation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked an inline comment as done. kwk added a comment. @labath please see my inline comment. Comment at: lldb/source/Breakpoint/BreakpointResolverName.cpp:315 + if (filter_by_cu && filter_by_function) { +// Keep this symbol context if it is a function call to

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 269781. kwk marked an inline comment as done. kwk added a comment. - Outsource parts into SearchFilterByModulesAndSupportFiles::FunctionPasses - Tests with alternating setting target.inline-breakpoint-strategy between "always" and "headers" - Respecting target.in

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 269784. kwk added a comment. - Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/include/lldb/Core/SearchFilter.h lldb/include/lldb/Target/Target.

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 269782. kwk added a comment. - remove commented out code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/include/lldb/Core/SearchFilter.h lldb/include/lldb/

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 269787. kwk marked an inline comment as done. kwk added a comment. - remove debug output from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/include/lld

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk added a comment. @labath I've applied all the ideas we ping-ponged yesterday and I decided to go with alternating the `target.inline-breakpoint-strategy` from `always` (the default) to `headers`. This way you can exactly see in the test file how things are behaving. So before going into the

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk planned changes to this revision. kwk added a comment. IMPORTANT: The behavior of `target.inline-breakpoint-strategy` when set to `headers` is still subject to change! I think the setting is not respected correctly... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked an inline comment as done. kwk added inline comments. Comment at: lldb/source/Core/SearchFilter.cpp:732 +FileSpec cu_spec; +if (sym_ctx.comp_unit) { + cu_spec = sym_ctx.comp_unit->GetPrimaryFile(); jankratochvil wrote: > This condition is

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 271583. kwk added a comment. - Align tests with reviewer expectations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/include/lldb/Core/SearchFilter.h lldb/

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk added a comment. @labath @jingham @jankratochvil The test change suggested by @labath is now in place and it works. @jankratochvil, I've removed the logic that checks seomthing with the CU from `AddressPasses`. That logic now lives in `FunctionPasses` where it logically makes more sense to

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked 6 inline comments as done. kwk added inline comments. Comment at: lldb/source/Core/SearchFilter.cpp:713 + if (!type) +return SearchFilterByModuleList::FunctionPasses(function); + jankratochvil wrote: > If we cannot determine which file the functio

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 271631. kwk added a comment. - Remove old logic that was no longer needed since my search filter now adaptively adds eSymbolContextCompUnit and not always returns it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked an inline comment as done. kwk added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py:124 -file_list.Append(lldb.SBFileSpec("noFileOfThisName.xxx")) -wrong.append(target.BreakpointCreateFromScr

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 273307. kwk added a comment. - bring back logic to keep a symbol context when a function passes and add a comment as Jan suggested - remove test from scripted resolver that calls SearchFilterByModulesAndSupportFiles::AddressPasses - before the test checked tha

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 273309. kwk added a comment. - Add newlines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/include/lldb/Core/SearchFilter.h lldb/include/lldb/Target/Target

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked 2 inline comments as done. kwk added inline comments. Comment at: lldb/source/Breakpoint/BreakpointResolverName.cpp:323 + // passing. + remove_it = false; + } jankratochvil wrote: > Now `if (filter_by_function) {}` always overrid

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 273637. kwk added a comment. - Simplify logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/include/lldb/Core/SearchFilter.h lldb/include/lldb/Target/Targ

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes an override issue by marking a function as const so that the signature maps to the signature of the function in the base class. This is the original error: In file included from /root/ll

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

kwk added a comment. In D83580#2144871 , @serge-sans-paille wrote: > Possible followup: shouldn't all the other `Get*` be flagged as `const` too? Thank you @serge-sans-paille . You're right but I'm unsure if all getters are actually const or not. And I

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

This revision was automatically updated to reflect the committed changes. Closed by commit rGecfa01e956a4: [lldb] on s390x fix override issue (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83580/new/ https://reviews.llvm.org/D83580

[Lldb-commits] [PATCH] D83180: Set generic error in SBError SetErrorToGenericError

kwk added a comment. LGTM but a test would indeed be nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83180/new/ https://reviews.llvm.org/D83180 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

kwk created this revision. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kwk planned changes to this revision. I found the above named method hard to read because it had a) many nested blocks and b) one return statement at the end with

[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

kwk added a comment. In D70774#1761444 , @teemperor wrote: > Let's just remove that return value. It's anyway only used in one place or so > where we can just call GetSize() manually. Then we also don't need the > lambda. Otherwise this LGTM, thanks! O

[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

kwk updated this revision to Diff 231201. kwk added a comment. Small changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70774/new/ https://reviews.llvm.org/D70774 Files: lldb/source/Symbol/CompileUnit.cpp Index: lldb/source/Symbol/CompileUni

[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

kwk updated this revision to Diff 231406. kwk added a comment. - Have ResolveSymbolContext not return anything Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70774/new/ https://reviews.llvm.org/D70774 Files: lldb/include/lldb/Symbol/CompileUnit.h

[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

This revision was automatically updated to reflect the committed changes. Closed by commit rG373e2a4f69d6: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70774/new/ https://rev

[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

kwk reopened this revision. kwk added a comment. This revision is now accepted and ready to land. Reopening because I did find the logic error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70774/new/ https://reviews.llvm.org/D70774

[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

kwk updated this revision to Diff 231440. kwk added a comment. - Fixed logic error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70774/new/ https://reviews.llvm.org/D70774 Files: lldb/include/lldb/Symbol/CompileUnit.h lldb/source/API/SBThread.

[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

kwk planned changes to this revision. kwk added a comment. Running tests locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70774/new/ https://reviews.llvm.org/D70774 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

This revision was automatically updated to reflect the committed changes. Closed by commit rGc671639af6a9: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70774/new/ https://rev

[Lldb-commits] [PATCH] D71022: [lldb] NFC: less nesting in SearchFilter.cpp

kwk created this revision. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kwk edited the summary of this revision. I was working on SearchFilter.cpp and felt it a bit too complex in some cases in terms of nesting and logic flow. Reposi

[Lldb-commits] [PATCH] D71022: [lldb] NFC: less nesting in SearchFilter.cpp

kwk requested review of this revision. kwk marked 2 inline comments as done. kwk added a comment. Addressed all review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71022/new/ https://reviews.llvm.org/D71022 ___

[Lldb-commits] [PATCH] D71022: [lldb] NFC: less nesting in SearchFilter.cpp

kwk updated this revision to Diff 232494. kwk added a comment. - Review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71022/new/ https://reviews.llvm.org/D71022 Files: lldb/source/Core/SearchFilter.cpp Index: lldb/source/Core/SearchFil

[Lldb-commits] [PATCH] D71022: [lldb] NFC: less nesting in SearchFilter.cpp

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG51ce067a442e: [lldb] NFC: less nesting in SearchFilter.cpp (authored by kwk). Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [PATCH] D67906: [lldb] Provide tab completion for target select/delete

kwk added a comment. Why don't we always print the target index? Wouldn't that be much simpler? Comment at: lldb/source/Commands/CommandObjectTarget.cpp:76 - strm.Printf("%starget #%u: %s", prefix_cstr ? prefix_cstr : "", target_idx, - exe_path); + if (prefix_c

[Lldb-commits] [PATCH] D72290: [lldb/CMake] Use LLDB's autodetection logic for libxml2

kwk added inline comments. Comment at: lldb/cmake/modules/FindLibXml28.cmake:14 +if (APPLE) + set(LIBXML2_LIBRARIES xml2) +endif() labath wrote: > Why is this under `if(APPLE)` ? To me this looks as if this module file `FileLibXml28.cmake` is only re

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk planned changes to this revision. kwk added a comment. I plan to refactor some of this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 ___ lldb-commi

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk created this revision. Herald added subscribers: lldb-commits, dexonsmith, aprantl, mehdi_amini, mgorny. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. kwk planned changes to this revision. kwk added a comment. I plan to refactor some of this patch. To set a breakpoint on

[Lldb-commits] [PATCH] D74160: [lldb] removed no longer needed CMakeDependentOption

kwk created this revision. kwk added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. kwk updated this revision to Diff 242991. kwk added a comment. kwk edited the summary of this revision. kwk edited the summary of this revision. Removed typo

[Lldb-commits] [PATCH] D74160: [lldb] removed no longer needed CMakeDependentOption

kwk updated this revision to Diff 242991. kwk added a comment. Removed typo in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74160/new/ https://reviews.llvm.org/D74160 Files: lldb/cmake/modules/LLDBConfig.cmake Index: lldb/cmake

[Lldb-commits] [PATCH] D74160: [lldb] removed no longer needed CMakeDependentOption

This revision was automatically updated to reflect the committed changes. Closed by commit rGb89131cdda58: [lldb] removed no longer needed CMakeDependentOption (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74160/new/ https://revie

<    1   2   3