This revision was not accepted when it landed; it landed in state "Needs
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB361383: Added a dot at the end of comment (authored by
kwk, committed by ).
Herald added a subscriber: abidh.
Changed prior to commit:
https://reviews.llvm.org/D62243?vs=200696&id=200720#toc
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62243/new/
https://reviews.llvm.org/D62243
Files:
CMakeLists.txt
Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -4,7 +4,7 @@
cmake_policy(SET CMP0075 NEW)
endif()
-# Add path for custom modules
+# Add path for custom modules.
set(CMAKE_MODULE_PATH
${CMAKE_MODULE_PATH}
"${CMAKE_CURRENT_SOURCE_DIR}/cmake"
@@ -15,7 +15,7 @@
include(LLDBConfig)
include(AddLLDB)
-# Define the LLDB_CONFIGURATION_xxx matching the build type
+# Define the LLDB_CONFIGURATION_xxx matching the build type.
if( uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG" )
add_definitions( -DLLDB_CONFIGURATION_DEBUG )
else()
@@ -172,7 +172,7 @@
get_target_property(liblldb_build_dir liblldb LIBRARY_OUTPUT_DIRECTORY)
# Add a Post-Build Event to copy over Python files and create the symlink
- # to liblldb.so for the Python API(hardlink on Windows)
+ # to liblldb.so for the Python API(hardlink on Windows).
add_custom_target(finish_swig ALL
COMMAND
${PYTHON_EXECUTABLE}
${LLDB_SOURCE_DIR}/scripts/finishSwigWrapperClasses.py
Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -4,7 +4,7 @@
cmake_policy(SET CMP0075 NEW)
endif()
-# Add path for custom modules
+# Add path for custom modules.
set(CMAKE_MODULE_PATH
${CMAKE_MODULE_PATH}
"${CMAKE_CURRENT_SOURCE_DIR}/cmake"
@@ -15,7 +15,7 @@
include(LLDBConfig)
include(AddLLDB)
-# Define the LLDB_CONFIGURATION_xxx matching the build type
+# Define the LLDB_CONFIGURATION_xxx matching the build type.
if( uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG" )
add_definitions( -DLLDB_CONFIGURATION_DEBUG )
else()
@@ -172,7 +172,7 @@
get_target_property(liblldb_build_dir liblldb LIBRARY_OUTPUT_DIRECTORY)
# Add a Post-Build Event to copy over Python files and create the symlink
- # to liblldb.so for the Python API(hardlink on Windows)
+ # to liblldb.so for the Python API(hardlink on Windows).
add_custom_target(finish_swig ALL
COMMAND
${PYTHON_EXECUTABLE} ${LLDB_SOURCE_DIR}/scripts/finishSwigWrapperClasses.py
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
