[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk added a subscriber: phosek. kwk added a comment. @iridinite please see these: - https://discourse.llvm.org/t/http-library-in-llvm/56317/10 - https://discourse.llvm.org/t/rfc-building-llvm-debuginfod/59011 - https://discourse.llvm.org/t/rfc-building-llvm-debuginfod/58994 - https://discourse.ll

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk added a comment. Looks like it is already there: https://github.com/llvm/llvm-project/tree/main/llvm/include/llvm/Debuginfod Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 ___

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk abandoned this revision. kwk added a comment. There already is a Debuginfod implementation in LLVM by now. Abandoning revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 _

[Lldb-commits] [PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

kwk accepted this revision. kwk added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149641/new/ https://reviews.llvm.org/D149641 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk added a comment. @labath @jingham to summarize from what I read here and what I chatted about with @labath , the following is a possible way to go for now, right? 1. We're not going to introduce my flag. 2. You're both not perfectly happy with the way things are documented at the moment an

[Lldb-commits] [PATCH] D74650: [lldb] WIP: idea for keeping filenames in raw form when coming from DWARF

kwk created this revision. kwk added a reviewer: labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. PLEASE DO NOT REVIEW YET. This is for brainstorming an idea with @labath Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74650 Files: lldb/include/l

[Lldb-commits] [PATCH] D74895: [lldb]: fix typo in lldb-gdb-remote.txt

kwk created this revision. kwk added a reviewer: labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The logic of the sentence made more sense when "with" is replaced with "without". Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74895 Files: lldb

[Lldb-commits] [PATCH] D74895: [lldb]: fix typo in lldb-gdb-remote.txt

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7b7f76ae6ae: [lldb]: fix typo in lldb-gdb-remote.txt (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74895/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 246160. kwk added a comment. Updated tests and code to remove the --search-source-files flag and make it the default behavior to also search source files. TODO: rename class SearchFilterByModuleListAndCU to something more meaningful when an agreement on the beh

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 246162. kwk added a comment. - Clear formatting - Make list private again - Remove open from CommandObjectBreakpoint.cpp - Remove change in unrelated file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ ht

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk added a comment. I figured it might be the easiest to re-use `SearchFilterByModuleListAndCU` but it needs to be renamed still. If you have a good suggestion, please let me know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk added a comment. @labath @jingham Can you please have a look at the `lldb/test/Shell/Breakpoint/search-support-files.test` to see if the test reflects the desired behavior? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://revi

[Lldb-commits] [PATCH] D74650: [lldb] WIP: idea for keeping filenames in raw form when coming from DWARF

kwk abandoned this revision. kwk added a comment. I abandon this revision because @labath mentioned that in the past we must have had something similar: two file specs where one was normalized and one doesn't and then the behavior was not very predictable. I hope this recaptures our conversatio

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. kwk planned changes to this revision. This first patch does the heavy lifting of bootstrapping debuginfod with CMake and integrating it to find a source file using debuginfod when using `(lldb)

[Lldb-commits] [PATCH] D75753: Simplified return type of getBuildIDFromModule

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kwk added a child revision: D75754: Fix typo. kwk abandoned this revision. kwk added a comment. I didn't intend to create a new revision. Depends on D75750 . Repos

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 248746. kwk added a comment. - Simplified return type of getBuildIDFromModule - fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files: lldb/cmake/modules/FindD

[Lldb-commits] [PATCH] D75754: Fix typo

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kwk abandoned this revision. kwk added a comment. I didn't intend to create a new revision. Depends on D75753 . Repository: rG LLVM Github Monorepo https://revi

[Lldb-commits] [PATCH] D75753: Simplified return type of getBuildIDFromModule

kwk abandoned this revision. kwk added a comment. I didn't intend to create a new revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75753/new/ https://reviews.llvm.org/D75753 ___ lldb-commits mai

[Lldb-commits] [PATCH] D75754: Fix typo

kwk abandoned this revision. kwk added a comment. I didn't intend to create a new revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75754/new/ https://reviews.llvm.org/D75754 ___ lldb-commits mai

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 249047. kwk marked 3 inline comments as done. kwk added a comment. Changes suggested by elfutils maintainers: - Silently ignore error when no DEBUGINFOD_URLS was given as an environment variable (ENOSYS). - Silently ignore error when the build ID could not be fo

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk marked an inline comment as done. kwk added a comment. @labath thank you for your early feedback. It was helpful even though this is still a work in progress. Comment at: lldb/source/Host/common/DebugInfoD.cpp:43-67 +UUID getBuildIDFromModule(const ModuleSP &module) { + U

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 249096. kwk added a comment. - Fix include ordering based on clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files: lldb/cmake/modules/FindDebuginfod.cmake

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 251086. kwk added a comment. Herald added a reviewer: jdoerfert. - Added debuginfod2.py - after running: autopep8 --in-place --aggressive --aggressive debuginfod2.py - exponential backoff implemented - Added http.py with doctests - autopep8 --in-place --aggressiv

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk added a comment. @labath I've updated my patch and would love to hear your opinion on it. So far I've only written the python `ServeDirectoryWithHTTP()` function with proper doctest and documentation but since you mentioned the `0` port thingy I've tried that on the command line when using

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk planned changes to this revision. kwk added a comment. In D75750#1929967 , @jankratochvil wrote: > On Fedora 31 x86_64 with LLDB using python3 I got: > > llvm-lit: .../llvm-monorepo2/llvm/utils/lit/lit/TestingConfig.py:102: > fatal: unable to parse

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 251297. kwk added a comment. - Fix NameError: name 'TRUE' is not defined Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files: lldb/cmake/modules/FindDebuginfod.cmake

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk added a comment. @labath I've improved my test file for readability. Comment at: lldb/include/lldb/Host/DebugInfoD.h:26 + +llvm::Error findSource(UUID buildID, const std::string &path, + std::string &result_path); labath wrote: > Expec

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 251376. kwk marked 6 inline comments as done. kwk added a comment. - Removed not needed forward decl - Format comments for better readability in my test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ http

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 251383. kwk added a comment. - Validate that the server received the request from debuginfod client Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files: lldb/cmake/modu

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 252026. kwk added a comment. - check for valid UUID - less verbose mkdir and rm output - More explicit test and documentation - fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk added a comment. @labath @fche2 @jankratochvil I've implemented the logic to ignore invalid UUIDs and the ones that are too short. Can you have another look please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 252054. kwk marked 2 inline comments as done. kwk added a comment. - Remove commented out code - Remove lldb/packages/Python/lldbsuite/test/httpserver.py in favor of lit test - Removed commented out left-over code Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 252059. kwk added a comment. - Adjust buildID verification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files: lldb/cmake/modules/FindDebuginfod.cmake lldb/cmake/mod

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 252353. kwk added a comment. - Add documentation for workaround on rejecting special build UUIDs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files: lldb/cmake/modules

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk marked 10 inline comments as done. kwk added a comment. @labath @jankratochvil @fche2 I've addressed all your comments and hope the patch is good to go now. Comment at: lldb/source/Host/common/DebugInfoD.cpp:43 + buildID.GetBytes().size() == + sizeof(llvm::su

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk added a comment. @jankratochvil thanks for this thorough review. I have to think about one comment more precisely but the rest was fixed. Comment at: lldb/source/Host/common/DebugInfoD.cpp:50 + "invalid build ID: %s", +

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk updated this revision to Diff 252510. kwk marked 10 inline comments as done. kwk added a comment. - Add newline to end of FindDebuginfod.cmake - Describe empty string returned from debuginfod::findSource() - Don't treat build IDs of len <= 8 as an error but simply as not found - move inexpensi

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

kwk added a comment. LGTM but I haven't tested it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76736/new/ https://reviews.llvm.org/D76736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [PATCH] D74187: [lldb] Add method Language::IsMangledName

kwk requested changes to this revision. kwk added a comment. This revision now requires changes to proceed. I agree with @friss that there is a change in behavior. I'm not sure it is fixable with what I wrote but I think so. Comment at: lldb/include/lldb/Target/Language.h:191

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk marked 3 inline comments as done. kwk added a comment. @labath I made a signficant simplification of starting and killing the server. I hope you like that better. Comment at: lldb/source/Core/SourceManager.cpp:408 + if ((!file_spec.GetDirectory() && file_spec.GetFilen

[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

kwk added a comment. Let's summarize this. 1. In the old and the new version, the program is aborted with an `assert()` if the configuration is `LLDB_CONFIGURATION_DEBUG`. 2. In the old version, nothing happens, when the configuration is non-Debug. 3. In the new version, the assert in non-Debug

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk updated this revision to Diff 253531. kwk added a comment. - Use file:// and require debuginfod 0.179 - simplify FindDebuginfod.cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files: lldb/cmake/

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

kwk added a comment. In D77108#1951879 , @labath wrote: > In D77108#1951610 , @aprantl wrote: > > > This is obviously good! Do you think that a similar error handling bug > > might exist in other cases that depend

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

kwk added a comment. In D77108#1952039 , @labath wrote: > In D77108#1951997 , @kwk wrote: > > > In D77108#1951879 , @labath wrote: > > > > > Most DW_OP cases check their stac

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

kwk added a comment. Overall looks good to me except for one larger logic change. Maybe a your comment can clarify this. The code was in a very bad shape before, given the countless amounts of shortcuts you could take. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAST

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

kwk accepted this revision. kwk added a comment. This revision is now accepted and ready to land. No need to split this into multiples revisions. It is just a rewrite of some odd nesting. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2943 +// Mak

[Lldb-commits] [PATCH] D77336: Findtypes -gmodules fix

kwk added a comment. Could you explain, why this was done please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77336/new/ https://reviews.llvm.org/D77336 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These three `SearchFilter` methods all return `true` by their default implementation: virtual bool ModulePasses(const FileSpec &spec); virtual bool ModulePasses(const lldb::ModuleSP &module_sp);

[Lldb-commits] [PATCH] D77377: [lldb][nfc] early exit/continue

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This commit just tries to invert some `if`'s logic to `return`/`continue` early. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77377 Files: lldb/source/Breakpoint/BreakpointRes

[Lldb-commits] [PATCH] D77377: [lldb][nfc] early exit/continue

This revision was automatically updated to reflect the committed changes. Closed by commit rG107200ae0a03: [lldb][nfc] early exit/continue (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77377/new/ https://reviews.llvm.org/D77377 F

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk updated this revision to Diff 255022. kwk added a comment. - fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 Files: lldb/include/lldb/Core/SearchFilter.h lldb/source/Core/SearchFilter.cp

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk updated this revision to Diff 255024. kwk marked 3 inline comments as done. kwk added a comment. Re-added `AddressPasses` with FIXME comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 Files: lldb/source/Core/SearchFilter.cpp Index:

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk added a subscriber: lattner. kwk added a comment. Had some problem with my `arc diff` reporting that another git was running which it wasn't so I had to update the diff by hand with a bit of trouble. Comment at: lldb/include/lldb/Core/SearchFilter.h:102 + /// + /// \note

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk updated this revision to Diff 255026. kwk edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 Files: lldb/include/lldb/Core/SearchFilter.h lldb/source/Core/SearchFilter.cpp Index: lldb/source/Core/SearchFi

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk added a comment. @jankratochvil for now I've re-added the `AddressPasses` functions and the `FIXME` comment. Can you approve? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 ___ lldb-commits mai

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk updated this revision to Diff 255300. kwk added a comment. - Simplify comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 Files: lldb/include/lldb/Core/SearchFilter.h lldb/source/Core/SearchFil

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk marked 2 inline comments as done. kwk added a comment. @jankratochvil thanks for the tip. @labath, addressed your comments and will now push it. Comment at: lldb/include/lldb/Core/SearchFilter.h:102 + /// + /// \note if not overriden, default implementation always \c true

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

This revision was automatically updated to reflect the committed changes. kwk marked an inline comment as done. Closed by commit rG9072df8ac143: [lldb][nfc] remove overriden funcs with default impl (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 255339. kwk added a comment. - rebased onto master to get rid of NFC change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolv

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 255648. kwk added a comment. - Simplified test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp lldb/source/Core

[Lldb-commits] [PATCH] D97721: [lldb] Support DWARF-5 DW_FORM_line_strp (used by GCC)

kwk added a comment. @jankratochvil out of curiosity. Can you give a pointer to what the C program looks like that produces the object code? I know GCC might change and no longer produce this code so it's better to have the obj code instead. But still I'm not nearly close to understanding Rep

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk marked 8 inline comments as done. kwk added a comment. In D67390#1685484 , @labath wrote: > This looks fairly ok to me, but it could use a more explicit test of the > symbol uniqueing code. Right, now I believe the two tests you added check > that th

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222387. kwk marked an inline comment as done. kwk added a comment. - typo: dynmic -> dynamic - Applied changes requested in review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. @labath I did prepare some YAML file but apparently `yaml2obj` isn't meant to deal with this properly. Instead I get an Error like this: `yaml2obj: error: repeated symbol name: 'main'`. It looks like symbols from the `Symbols:` part of the YAML file are just added by name t

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222427. kwk added a comment. - Added YAML test to merge symbols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/Inputs/load-from-dynsym-alone.

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222441. kwk added a comment. - include test code in .c test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/load-from-dynsym-alone.c ll

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222479. kwk added a comment. - Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/load-from-dynsym-alone.c lldb/lit/Modules/ELF/loa

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222569. kwk marked 8 inline comments as done. kwk added a comment. - Remove verbose output in test - Fix typo: smymtab -> symtab - Move compare and hash logic out of base class into derived class as requested Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk marked an inline comment as done. kwk added a comment. @labath can you please check this patch one last time (hopefully)? Comment at: lldb/source/Plugins/ObjectFile/ELF/ELFHeader.cpp:371-373 + r.st_name = st_name; + return elf::ELFSymbol::operator==(r) && + st_nam

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222576. kwk added a comment. - Correct comment of test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/load-from-dynsym-alone.c lldb/lit/Mod

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222577. kwk added a comment. - Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/load-from-dynsym-alone.c lldb/lit/Modules/ELF/loa

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222584. kwk added a comment. - Simplify NamedELFSymbol::hash() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 Files: lldb/lit/Modules/ELF/load-from-dynsym-alone.c lldb

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ELFHeader.cpp:383 + std::hash()(st_name_string.AsCString()), + std::hash()(st_section_name_string.AsCString())); +} jankratochvil wrote: > llvm::hash_combine already calls std::ha

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk updated this revision to Diff 222634. kwk marked 10 inline comments as done. kwk added a comment. - Check that no additional symbols follow after the expected ones - Use compiler-generated copy-ctor - Cleanup from experiment - Simplify NamedELFSymbol::hash() - Cleanup Repository: rG LLVM G

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk planned changes to this revision. kwk added a comment. LLVM reasoning for why to go with `std::vector`: http://llvm.org/docs/ProgrammersManual.html#set-like-containers-std-set-smallset-setvector-etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk abandoned this revision. kwk added a comment. Here's the relevant transcript from #lldb@otfc for why this change is abandoned. [10/02/19 15:22:25] labath: Is it acceptable for you? "BTW given how this unique-ness of symbols turns out to be non-trivial is it really needed? Because for r

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk planned changes to this revision. kwk added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2711-2731 Section *symtab = section_list->FindSectionByType(eSectionTypeELFSymbolTable, true).get(); -if (!symtab) { - // The

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 222845. kwk marked 12 inline comments as done. kwk added a comment. - Change logic and comment for when .dynsym is parsed - Use different pattern for error checking - use less auto - Remove required system-linux test feature from LZMA tests Repository: rG LLVM

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk requested review of this revision. kwk added a comment. This revision is now accepted and ready to land. Tests did pass so this change is ready for review @labath @jankratochvil . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https:/

[Lldb-commits] [PATCH] D61847: [lldb] NFC modernize codebase with modernize-use-nullptr

kwk added a comment. @JDevlieghere can you please commit this in my name? I don't have commit access yet. I've filed an email an hope to get it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61847/new/ https://reviews.llvm.org/D61847 _

[Lldb-commits] [PATCH] D61847: [lldb] modernize codebase with modernize-use-nullptr

kwk added a comment. @teemperor I've addressed all of your comments. Can you please have another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61847/new/ https://reviews.llvm.org/D61847 ___ lldb

[Lldb-commits] [PATCH] D61847: [lldb] modernize codebase with modernize-use-nullptr

kwk added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:76 static constexpr PropertyDefinition g_properties[] = { -{"load-kexts", OptionValue::eTypeBoolean, true, true, NULL, {}, +{"load-kexts", + OptionVa

[Lldb-commits] [PATCH] D61847: [lldb] NFC modernize codebase with modernize-use-nullptr

kwk added a comment. @JDevlieghere I have commit access now. I'm currently working on rebasing my changes and resolving conflicts in these files where my patch wasn't rebaseable. lldb/source/Core/ValueObject.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h lldb/source/Plugins/Symb

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218929. kwk added a comment. Herald added subscribers: openmp-commits, libcxx-commits, Sanitizers, cfe-commits, seiya, erik.pilkington, asbirlea, ormris, Petar.Avramovic, jsji, mstorsjo, jfb, kadircet, arphaman, jkorous, george.burgess.iv, christof, jakehehrlich

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218931. kwk added a comment. - Better names for minidebuginfo files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt lldb/cmake/modules/LLDBCo

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 219038. kwk added a comment. - Fix spelling error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt lldb/cmake/modules/LLDBConfig.cmake lldb/

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218930. kwk added a comment. Herald added subscribers: wuzish, rnkovacs. - Fixup - Test for minidebuginfo image dump symtab - Fixed test for corrupted xz blob - Fix test - Added test that runs when no LZMA is configured Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218932. kwk added a comment. - Better names for minidebuginfo files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt lldb/cmake/modules/LLDBCo

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. @labath ah, I've just seen that you did accept the revision already. Will merge it then after running tests once more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 ___

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 223381. kwk marked 10 inline comments as done. kwk added a comment. - Fix typo: s/a. /a ./ - Fix comment header - Remove redundant input buffer check - Remove another redundant input buffer check - Change variable initialization to assign - added comment about min

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. @labath I've addressed all you comments. Thank you for answering @jankratochvil's question as well. If this patch is good to go now, please give a thumbs up. Comment at: lldb/source/Host/common/LZMA.cpp:84 + lzma_ret xzerr = lzma_stream_footer_decode( +

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 223382. kwk added a comment. Rebased onto current master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/include/lldb/Ho

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. @labath as much as I would love to merge this patch I get errors from these tests that I didn't see before. They only appear after rebasing onto master: Failing Tests (4): lldb-Suite :: commands/process/attach/TestProcessAttach.py lldb-Suite :: python_api/hello

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 223482. kwk added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/include/lldb/Host/Config.h.cmake

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk closed this revision. kwk added a comment. Closed by 2c082b48274fcba62bf9b3acb63075aedcc7a976 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

kwk added a comment. I think I'm guilty for adding `llvm-strip` to `LLDB_TEST_DEPS` I wasn't aware that it might cause problems. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 ___

[Lldb-commits] [PATCH] D68638: [lldb] Avoid resource leak

kwk created this revision. kwk added a reviewer: jankratochvil. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before the pointer variable `args_dict` was assigned the result of an allocation with `new` and then `args_dict` is passed to `GetValueForKeyAsDictionary` which im

[Lldb-commits] [PATCH] D68647: Simplify LZMA decoding by using ArrayRef::take_back

kwk created this revision. kwk added a reviewer: labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Follow-up for D66791#inline-616303 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68647 Files: lld

[Lldb-commits] [PATCH] D68647: Simplify LZMA decoding by using ArrayRef::take_back

kwk updated this revision to Diff 223865. kwk marked an inline comment as done. kwk added a comment. Fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68647/new/ https://reviews.llvm.org/D68647 Files: lldb/source/Host/common/LZMA.cpp Index:

[Lldb-commits] [PATCH] D68647: Simplify LZMA decoding by using ArrayRef::take_back

kwk marked an inline comment as done. kwk added inline comments. Comment at: lldb/source/Host/common/LZMA.cpp:99 + &xzindex, &memlimit, nullptr, + InputBuffer.take_back(LZMA_STREAM_HEADER_SIZE - opts.backward_size) + .data(), labath wrote: > I

  1   2   3   >